Re: [Mesa-dev] RFC [PATCH 0/7] Fix transform feedback of builtin "varyings".

2012-01-04 Thread Kenneth Graunke
On 01/03/2012 06:42 PM, Paul Berry wrote: [snip] > Ok, sounds good. I'm going to consider this an "acked-by" if that's all > right with you. I haven't heard many comments on this patch series, but > given that it fixes the tests and there hasn't been any negative > feedback, I think I'm going to

Re: [Mesa-dev] RFC [PATCH 0/7] Fix transform feedback of builtin "varyings".

2012-01-03 Thread Paul Berry
On 3 January 2012 16:35, Ian Romanick wrote: > On 12/29/2011 09:16 AM, Paul Berry wrote: > >> This patch series allows transform feedback to work properly on the >> built-in vertex shader output variables gl_PointSize, gl_ClipVertex, >> and gl_ClipDistance. gl_PointSize and gl_ClipVertex were br

Re: [Mesa-dev] RFC [PATCH 0/7] Fix transform feedback of builtin "varyings".

2012-01-03 Thread Ian Romanick
On 12/29/2011 09:16 AM, Paul Berry wrote: This patch series allows transform feedback to work properly on the built-in vertex shader output variables gl_PointSize, gl_ClipVertex, and gl_ClipDistance. gl_PointSize and gl_ClipVertex were broken due to bugs in the i965 driver, and were trivial to f

Re: [Mesa-dev] RFC [PATCH 0/7] Fix transform feedback of builtin "varyings".

2011-12-29 Thread Paul Berry
On 29 December 2011 09:16, Paul Berry wrote: > Arguments in favor: (1) Because of transform feedback's intended use > and its position in the pipeline, the distinction between varyings and > other vertex shader outputs is irrelevant; in all likelihood the spec > writers intended for it to work on

[Mesa-dev] RFC [PATCH 0/7] Fix transform feedback of builtin "varyings".

2011-12-29 Thread Paul Berry
This patch series allows transform feedback to work properly on the built-in vertex shader output variables gl_PointSize, gl_ClipVertex, and gl_ClipDistance. gl_PointSize and gl_ClipVertex were broken due to bugs in the i965 driver, and were trivial to fix--those are fixed in patches 1 and 2. gl_