Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR)

2014-11-20 Thread Jose Fonseca
On 19/11/14 21:17, Ilia Mirkin wrote: On Wed, Nov 19, 2014 at 3:45 PM, Jose Fonseca jfons...@vmware.com wrote: On 19/11/14 19:45, Ilia Mirkin wrote: On Wed, Nov 19, 2014 at 2:32 PM, Eric Anholt e...@anholt.net wrote: Eric Anholt e...@anholt.net writes: This series removes a bunch of

Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR)

2014-11-19 Thread Eric Anholt
Eric Anholt e...@anholt.net writes: This series removes a bunch of unused opcodes, mostly from TGSI. It doesn't go as far as we could possibly go -- while I welcome discussion for future patch series deleting more, I hope that discussion doesn't derail the review process for these changes.

Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR)

2014-11-19 Thread Ilia Mirkin
On Wed, Nov 19, 2014 at 2:32 PM, Eric Anholt e...@anholt.net wrote: Eric Anholt e...@anholt.net writes: This series removes a bunch of unused opcodes, mostly from TGSI. It doesn't go as far as we could possibly go -- while I welcome discussion for future patch series deleting more, I hope

Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR)

2014-11-19 Thread Jose Fonseca
On 19/11/14 19:32, Eric Anholt wrote: Eric Anholt e...@anholt.net writes: This series removes a bunch of unused opcodes, mostly from TGSI. It doesn't go as far as we could possibly go -- while I welcome discussion for future patch series deleting more, I hope that discussion doesn't derail

Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR)

2014-11-19 Thread Jose Fonseca
On 19/11/14 19:45, Ilia Mirkin wrote: On Wed, Nov 19, 2014 at 2:32 PM, Eric Anholt e...@anholt.net wrote: Eric Anholt e...@anholt.net writes: This series removes a bunch of unused opcodes, mostly from TGSI. It doesn't go as far as we could possibly go -- while I welcome discussion for future

Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR)

2014-11-19 Thread Ilia Mirkin
On Wed, Nov 19, 2014 at 3:45 PM, Jose Fonseca jfons...@vmware.com wrote: On 19/11/14 19:45, Ilia Mirkin wrote: On Wed, Nov 19, 2014 at 2:32 PM, Eric Anholt e...@anholt.net wrote: Eric Anholt e...@anholt.net writes: This series removes a bunch of unused opcodes, mostly from TGSI. It

Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR)

2014-11-19 Thread David Heidelberg
The patch attached should do it. just small nitpick, please drop /* for radeons */ comment from DP2ADD, thanks Reviewed-by: David Heidelberg da...@ixit.cz ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR)

2014-11-19 Thread Jose Fonseca
...@lists.freedesktop.org on behalf of Brian Paul bri...@vmware.com Sent: 13 November 2014 16:27 To: Eric Anholt; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR) On 11/12/2014 06:18 PM, Eric Anholt wrote: This series removes a bunch of unused opcodes

Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR)

2014-11-13 Thread Jose Fonseca
@lists.freedesktop.org Subject: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR) This series removes a bunch of unused opcodes, mostly from TGSI. It doesn't go as far as we could possibly go -- while I welcome discussion for future patch series deleting more, I hope that discussion doesn't derail

Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR)

2014-11-13 Thread Jose Fonseca
From: mesa-dev mesa-dev-boun...@lists.freedesktop.org on behalf of Eric Anholt e...@anholt.net Sent: 13 November 2014 01:43 To: Ilia Mirkin Cc: mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR) Ilia Mirkin imir...@alum.mit.edu

Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR)

2014-11-13 Thread Brian Paul
On 11/12/2014 06:18 PM, Eric Anholt wrote: This series removes a bunch of unused opcodes, mostly from TGSI. It doesn't go as far as we could possibly go -- while I welcome discussion for future patch series deleting more, I hope that discussion doesn't derail the review process for these

Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR)

2014-11-13 Thread Marek Olšák
Cc: mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR) Ilia Mirkin imir...@alum.mit.edu writes: AFAIK at least some of these (NRM, ARR, probably others) were being used by the d3d9 state tracker. Not sure what its status is, but I believe the hope

Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR)

2014-11-13 Thread Marek Olšák
This looks good to me. Other candidates for removal: SUB (same as ADD with the Negate bit inverted) CLAMP (same as MIN+MAX), some drivers don't implement this ABS (same as MOV with the Abs bit set) Marek On Thu, Nov 13, 2014 at 2:18 AM, Eric Anholt e...@anholt.net wrote: This series removes

Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR)

2014-11-13 Thread Ilia Mirkin
on behalf of Eric Anholt e...@anholt.net Sent: 13 November 2014 01:43 To: Ilia Mirkin Cc: mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR) Ilia Mirkin imir...@alum.mit.edu writes: AFAIK at least some of these (NRM, ARR, probably others) were being

Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR)

2014-11-13 Thread Roland Scheidegger
November 2014 01:43 To: Ilia Mirkin Cc: mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR) Ilia Mirkin imir...@alum.mit.edu writes: AFAIK at least some of these (NRM, ARR, probably others) were being used by the d3d9 state tracker. Not sure what its

Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR)

2014-11-13 Thread Jose Fonseca
@lists.freedesktop.org Subject: Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR) As long as we have NAND, pretty much anything can be lowered to that... I am, of course, not advocating keeping around every insane instruction, but it does seem a bit arbitrary as to which ones we have and which

Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR)

2014-11-13 Thread Jose Fonseca
From: Jose Fonseca Sent: 13 November 2014 13:06 To: Eric Anholt; mesa-dev@lists.freedesktop.org Subject: RE: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR) Thanks for doing this. It's has been long overdue. Unfortunately we are relying on TGSI_OPCODE_CND/TGSI_OPCODE_ARR internally. I'm

Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR)

2014-11-13 Thread Roland Scheidegger
: 13 November 2014 01:18 To: mesa-dev@lists.freedesktop.org Subject: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR) This series removes a bunch of unused opcodes, mostly from TGSI. It doesn't go as far as we could possibly go -- while I welcome discussion for future patch series deleting

[Mesa-dev] Removing unused opcodes (TGSI, Mesa IR)

2014-11-12 Thread Eric Anholt
This series removes a bunch of unused opcodes, mostly from TGSI. It doesn't go as far as we could possibly go -- while I welcome discussion for future patch series deleting more, I hope that discussion doesn't derail the review process for these changes. I haven't messed with the subroutine

Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR)

2014-11-12 Thread Ilia Mirkin
AFAIK at least some of these (NRM, ARR, probably others) were being used by the d3d9 state tracker. Not sure what its status is, but I believe the hope was to eventually get it into the tree. On Wed, Nov 12, 2014 at 8:18 PM, Eric Anholt e...@anholt.net wrote: This series removes a bunch of

Re: [Mesa-dev] Removing unused opcodes (TGSI, Mesa IR)

2014-11-12 Thread Eric Anholt
Ilia Mirkin imir...@alum.mit.edu writes: AFAIK at least some of these (NRM, ARR, probably others) were being used by the d3d9 state tracker. Not sure what its status is, but I believe the hope was to eventually get it into the tree. They've got code for lowering NRM and CND to sanity, and no