Re: [Mesa-dev] glsl/glcpp: A bunch of pre-processor cleanups

2014-07-28 Thread Carl Worth
> 14/23 glsl: Add an internal-error catch-all rule > In your updated commit message (on git branch), you mention that > this fixes two Khronos negative tests. But, it looks like we will > now print an "Internal compiler error" error message. So, we'll fail > to compile the negative tests, y

Re: [Mesa-dev] glsl/glcpp: A bunch of pre-processor cleanups

2014-07-23 Thread Jordan Justen
On 2014-07-17 16:45:34, Jordan Justen wrote: > Made it ~25% through. :) I'll be busy for a bit, but I'll continue > looking at the rest later. > > 01/23 glsl/glcpp: Emit proper error for #define with a non-identifier > Reviewed-by: Jordan Justen > > 02/23 glsl/glcpp: Add support for comments b

Re: [Mesa-dev] glsl/glcpp: A bunch of pre-processor cleanups

2014-07-17 Thread Jordan Justen
Made it ~25% through. :) I'll be busy for a bit, but I'll continue looking at the rest later. 01/23 glsl/glcpp: Emit proper error for #define with a non-identifier Reviewed-by: Jordan Justen 02/23 glsl/glcpp: Add support for comments between #define and macro identifier Reviewed-by: Jordan J

[Mesa-dev] glsl/glcpp: A bunch of pre-processor cleanups

2014-06-26 Thread Carl Worth
Here's my latest series of patches to improve conformance of glcpp, (the glsl preprocessor in mesa). Most of these changes are fixes that only a test-suite author could love. Most fix nit-picky tests that do things that no sance application would actually do. They're all reasonable things to do, b