Re: [Mesa-dev] i965: Invalid memory accesses after resizing brw_codegen's store table

2015-10-29 Thread Kristian Høgsberg
On Thu, Oct 29, 2015 at 12:32 AM, Iago Toral wrote: > On Wed, 2015-10-28 at 10:58 -0700, Kristian Høgsberg wrote: >> On Wed, Oct 28, 2015 at 10:01:40AM +0100, Samuel Iglesias Gonsálvez wrote: >> > There is no opinions about this issue or reviews of the proposed patch >> > after

Re: [Mesa-dev] i965: Invalid memory accesses after resizing brw_codegen's store table

2015-10-29 Thread Iago Toral
On Wed, 2015-10-28 at 10:58 -0700, Kristian Høgsberg wrote: > On Wed, Oct 28, 2015 at 10:01:40AM +0100, Samuel Iglesias Gonsálvez wrote: > > There is no opinions about this issue or reviews of the proposed patch > > after one week. > > > > This is just a reminder in case you have missed it :-) >

Re: [Mesa-dev] i965: Invalid memory accesses after resizing brw_codegen's store table

2015-10-28 Thread Kristian Høgsberg
On Wed, Oct 28, 2015 at 10:01:40AM +0100, Samuel Iglesias Gonsálvez wrote: > There is no opinions about this issue or reviews of the proposed patch > after one week. > > This is just a reminder in case you have missed it :-) Thanks for the reminder! How about something like this instead? diff

Re: [Mesa-dev] i965: Invalid memory accesses after resizing brw_codegen's store table

2015-10-28 Thread Samuel Iglesias Gonsálvez
There is no opinions about this issue or reviews of the proposed patch after one week. This is just a reminder in case you have missed it :-) Sam On 21/10/15 12:23, Iago Toral wrote: > Hi, > > The problem is with code like this (see brw_send_indirect_message): > > setup = brw_OR(p, addr,

[Mesa-dev] i965: Invalid memory accesses after resizing brw_codegen's store table

2015-10-21 Thread Samuel Iglesias Gonsalvez
Hello, I have found several invalid memory accesses when running dEQP-GLES31.functional.ssbo.* tests on i965 driver (and gen7+). That invalid memory accesses were unluckily happening when generating the assembly instructions for SSBO stores for different compute shaders. However it looks like

Re: [Mesa-dev] i965: Invalid memory accesses after resizing brw_codegen's store table

2015-10-21 Thread Iago Toral
Hi, The problem is with code like this (see brw_send_indirect_message): setup = brw_OR(p, addr, desc, brw_imm_ud(0)); send = next_insn(p, BRW_OPCODE_SEND); ... return setup; If next_insn triggers a realloc of the instruction store, then the setup instruction pointer is no longer valid. Notice