Re: [Mesa-dev] i965: Turn UBOs as push constants

2015-10-09 Thread Ben Widawsky
On Fri, Oct 09, 2015 at 06:06:30PM +0300, Abdiel Janulgue wrote: > Ping! No thoughts/consensus if this approach is worth considering or > not? The patches are getting stale. Should I re-base or just discard > these optimisations? > I am not the right person to ask, but I think it's certainly wort

Re: [Mesa-dev] i965: Turn UBOs as push constants

2015-10-09 Thread Abdiel Janulgue
Ping! No thoughts/consensus if this approach is worth considering or not? The patches are getting stale. Should I re-base or just discard these optimisations? On 09/15/2015 08:59 PM, Ben Widawsky wrote: > On Tue, Sep 15, 2015 at 12:24:00PM +0300, Abdiel Janulgue wrote: >> Here's a more comprehensi

Re: [Mesa-dev] i965: Turn UBOs as push constants

2015-09-15 Thread Ben Widawsky
On Tue, Sep 15, 2015 at 12:24:00PM +0300, Abdiel Janulgue wrote: > Here's a more comprehensive shader-db run: > > total instructions in shared programs: 6394485 -> 6374865 (-0.31%) > instructions in affected programs: 261322 -> 241702 (-7.51%) > helped:3210 > HU

Re: [Mesa-dev] i965: Turn UBOs as push constants

2015-09-15 Thread Abdiel Janulgue
Here's a more comprehensive shader-db run: total instructions in shared programs: 6394485 -> 6374865 (-0.31%) instructions in affected programs: 261322 -> 241702 (-7.51%) helped:3210 HURT: 0 GAINED:

Re: [Mesa-dev] i965: Turn UBOs as push constants

2015-09-14 Thread Abdiel Janulgue
On 09/12/2015 01:42 AM, Ben Widawsky wrote: > On Fri, Sep 11, 2015 at 11:33:14AM +0300, Abdiel Janulgue wrote: >> Some updated figures first: >> >> Ue4 Reflections Subway demo >> x fs gather constants disabled >> + fs gather constants enabled >> >> HSW: >> N Min Max

Re: [Mesa-dev] i965: Turn UBOs as push constants

2015-09-11 Thread Ben Widawsky
On Fri, Sep 11, 2015 at 11:33:14AM +0300, Abdiel Janulgue wrote: > Some updated figures first: > > Ue4 Reflections Subway demo > x fs gather constants disabled > + fs gather constants enabled > > HSW: > N Min MaxMedian AvgStddev > x 10 5.

[Mesa-dev] i965: Turn UBOs as push constants

2015-09-11 Thread Abdiel Janulgue
Some updated figures first: Ue4 Reflections Subway demo x fs gather constants disabled + fs gather constants enabled HSW: N Min MaxMedian AvgStddev x 10 5.09739 6.48963 6.33357 6.1979850.40742969 + 10 6.56139