On Fri, Dec 30, 2011 at 1:13 PM, Dave Airlie wrote:
>>> The fbo-blending-formats test now only fails on I8 with DST_ALPHA,
>>> I'm
>>> guessing what happens is we have an I8 dst, but we never flush the
>>> tiles, so we end up using the alpha from the tile as the dst alpha
>>> value instead of the
>> The fbo-blending-formats test now only fails on I8 with DST_ALPHA,
>> I'm
>> guessing what happens is we have an I8 dst, but we never flush the
>> tiles, so we end up using the alpha from the tile as the dst alpha
>> value instead of the red value.
Okay I've taken your suggestion, and the attac
- Original Message -
> >>
> >> Okay this fixes it here, and even seems reasonable to me.
> >
> > Yes. Great catch Dave.
> >
> > This should also fix to L8 rendering. But I belive that in the
> > commit message, you mean "i8" and not "l8".
> >
> > Please add a comment about why order matter
>>
>> Okay this fixes it here, and even seems reasonable to me.
>
> Yes. Great catch Dave.
>
> This should also fix to L8 rendering. But I belive that in the commit
> message, you mean "i8" and not "l8".
>
> Please add a comment about why order matters in the inv_swizzle() function,
> for future
- Original Message -
> >
> > was doing some piglit comparisons between softpipe and llvmpipe and
> > noticed the fbo-alphatest-formats test fails on llvmpipe for all
> > the
> > I8 formats.
> >
> > Now I looked at the code generated for
> > lp_tile_soa.c:lp_tile_i8_unorm_unswizzle_4ub and i
>
> was doing some piglit comparisons between softpipe and llvmpipe and
> noticed the fbo-alphatest-formats test fails on llvmpipe for all the
> I8 formats.
>
> Now I looked at the code generated for
> lp_tile_soa.c:lp_tile_i8_unorm_unswizzle_4ub and it references a[i+0]
> and a[i+1], if I change i
Hi guys,
was doing some piglit comparisons between softpipe and llvmpipe and
noticed the fbo-alphatest-formats test fails on llvmpipe for all the
I8 formats.
Now I looked at the code generated for
lp_tile_soa.c:lp_tile_i8_unorm_unswizzle_4ub and it references a[i+0]
and a[i+1], if I change it to
