Eric, The commit d36b28402f542 ("vc4: Reuse QPU disasm's cond flags in QIR.") breaks on Android builds (using clang) with this error:
external/mesa3d/src/gallium/drivers/vc4/vc4_qpu_disasm.c:349:33: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] fprintf(stderr, DESC(qpu_add_opcodes, op_add)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ external/mesa3d/src/gallium/drivers/vc4/vc4_qpu_disasm.c:228:9: note: expanded from macro 'DESC' ((index >= ARRAY_SIZE(array) || !(array)[index]) ? \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ looks like it should be "fprintf(stderr, "%s", DESC(...))" as the version for qpu_mul_opcodes is fine. Rob _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev