Re: [Mesa-dev] vertex array regression

2011-12-25 Thread Marek Olšák
2011/12/20 Mathias Fröhlich mathias.froehl...@gmx.net: Ok, back to topic, so have I understood right? You have fixed torcs not to use the slow path anymore? Which old version is the one still having this issue? I did not fix Torcs. I think optimizing apps is useless if the same optimization can

Re: [Mesa-dev] vertex array regression

2011-12-25 Thread Mathias Fröhlich
Hi, On Sunday, December 25, 2011 10:03:34 Marek Olšák wrote: I did not fix Torcs. I think optimizing apps is useless if the same optimization can be done in Mesa too. Ok, so any torcs version should show a performance difference to check against. Do you have any test program that could be

Re: [Mesa-dev] vertex array regression

2011-12-20 Thread Brian Paul
On 12/19/2011 01:12 PM, Mathias Fröhlich wrote: Brian, On Monday, December 19, 2011 17:01:07 you wrote: I still don't get what the purpose of the special mapping of the last four/five elements is all about. Can you explain that? As far as I can see the last ones should not map to anything.

Re: [Mesa-dev] vertex array regression

2011-12-19 Thread Brian Paul
On 12/16/2011 11:28 AM, Mathias Fröhlich wrote: Brian, On Thursday, December 15, 2011 22:36:24 you wrote: I found the problem. It's this chunk in vbo_context.c: [...] For fixed function, the point is to simply place the per-vertex material attributes in the generic attribute arrays. There

Re: [Mesa-dev] vertex array regression

2011-12-19 Thread Mathias Fröhlich
Brian, On Monday, December 19, 2011 17:01:07 you wrote: I still don't get what the purpose of the special mapping of the last four/five elements is all about. Can you explain that? As far as I can see the last ones should not map to anything. The map is used only in fixed function mode. And

Re: [Mesa-dev] vertex array regression

2011-12-19 Thread Marek Olšák
2011/12/19 Mathias Fröhlich mathias.froehl...@gmx.net: Brian, On Monday, December 19, 2011 17:01:07 you wrote: I still don't get what the purpose of the special mapping of the last four/five elements is all about.  Can you explain that? As far as I can see the last ones should not map to

Re: [Mesa-dev] vertex array regression

2011-12-19 Thread Mathias Fröhlich
Marek, On Tuesday, December 20, 2011 01:40:46 Marek Olšák wrote: The problem back in March and earlier was that the vertex array state was completely recomputed for each draw call even if the user did not change any state at all! There was the validation in the vbo module and then in

Re: [Mesa-dev] vertex array regression

2011-12-16 Thread Mathias Fröhlich
Brian, On Thursday, December 15, 2011 22:36:24 you wrote: I found the problem. It's this chunk in vbo_context.c: [...] For fixed function, the point is to simply place the per-vertex material attributes in the generic attribute arrays. There are 12 such material attributes. So there's

[Mesa-dev] vertex array regression

2011-12-15 Thread Brian Paul
Mathias, There's a regression in vertex array drawing with this commit: commit ed42c2580717527b2005580940fc766d95bb6b0b Author: Mathias Fröhlich mathias.froehl...@web.de Date: Mon Oct 31 16:23:40 2011 +0100 vbo: Use The VERT_{ATTRIB,BIT} defines. Signed-off-by: Mathias Froehlich

Re: [Mesa-dev] vertex array regression

2011-12-15 Thread Mathias Fröhlich
Brian, On Thursday, December 15, 2011 17:08:57 Brian Paul wrote: There's a regression in vertex array drawing with this commit: commit ed42c2580717527b2005580940fc766d95bb6b0b Author: Mathias Fröhlich mathias.froehl...@web.de Date: Mon Oct 31 16:23:40 2011 +0100 vbo: Use The

Re: [Mesa-dev] vertex array regression

2011-12-15 Thread Brian Paul
2011/12/15 Mathias Fröhlich mathias.froehl...@web.de: Brian, On Thursday, December 15, 2011 17:08:57 Brian Paul wrote: There's a regression in vertex array drawing with this commit: commit ed42c2580717527b2005580940fc766d95bb6b0b Author: Mathias Fröhlich mathias.froehl...@web.de Date: