Re: [Mesa-dev] [PATCH] gallium/hud: prevent NULL pointer dereference with pipe_query functions

2015-06-25 Thread Marek Olšák
What's the point of drawing a HUD pane if a query cannot be created? Can we detect this during initialization? Marek On Wed, Jun 24, 2015 at 9:26 PM, Samuel Pitoiset wrote: > The HUD doesn't check if query_create() fails and it calls other > pipe_query functions with NULL pointer instead of a va

Re: [Mesa-dev] [PATCH] gallium/hud: prevent NULL pointer dereference with pipe_query functions

2015-06-25 Thread Samuel Pitoiset
On 06/25/2015 02:36 PM, Marek Olšák wrote: What's the point of drawing a HUD pane if a query cannot be created? With my series which adds support for global performance counters on NV50, query_create() may fail if we want to monitor *two* different query types with the HUD. This limitation

Re: [Mesa-dev] [PATCH] gallium/hud: prevent NULL pointer dereference with pipe_query functions

2015-06-26 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Jun 24, 2015 at 9:26 PM, Samuel Pitoiset wrote: > The HUD doesn't check if query_create() fails and it calls other > pipe_query functions with NULL pointer instead of a valid query object. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/auxiliary/