Re: [Mesa-dev] [PATCH] i965: handle stencil_bits parameter for MESA_FORMAT_B8G8R8X8_UNORM format.

2015-12-08 Thread Ilia Mirkin
On Mon, Dec 7, 2015 at 5:32 PM, Dawid Gan wrote: > This format has been added in commit: > 28090b30dd6b5977de085f48c620574214b6b4ba > But it was handled in the same way as MESA_FORMAT_B8G8R8A8_UNORM format. > It was causing the screen in Supertuxkart to be darker than expected, see: > https://bugs

Re: [Mesa-dev] [PATCH] i965: handle stencil_bits parameter for MESA_FORMAT_B8G8R8X8_UNORM format.

2015-12-09 Thread Deve
This patch indeed seems to not have a sense. I just added it to the bug report as a suggestion that it works for me after this modification. Emil Velikov said that I should send it to the mailing list. Here is how it works in Supertuxkart: We create rtt with following parameters: DepthStencilT

Re: [Mesa-dev] [PATCH] i965: handle stencil_bits parameter for MESA_FORMAT_B8G8R8X8_UNORM format.

2015-12-09 Thread Ilia Mirkin
On Wed, Dec 9, 2015 at 11:18 AM, Deve wrote: > This patch indeed seems to not have a sense. I just added it to the bug > report as a suggestion that it works for me after this modification. Emil > Velikov said that I should send it to the mailing list. > > Here is how it works in Supertuxkart: > W

Re: [Mesa-dev] [PATCH] i965: handle stencil_bits parameter for MESA_FORMAT_B8G8R8X8_UNORM format.

2015-12-09 Thread Ilia Mirkin
On Wed, Dec 9, 2015 at 11:23 AM, Ilia Mirkin wrote: > On Wed, Dec 9, 2015 at 11:18 AM, Deve wrote: >> This patch indeed seems to not have a sense. I just added it to the bug >> report as a suggestion that it works for me after this modification. Emil >> Velikov said that I should send it to the m

Re: [Mesa-dev] [PATCH] i965: handle stencil_bits parameter for MESA_FORMAT_B8G8R8X8_UNORM format.

2015-12-10 Thread Ilia Mirkin
On Wed, Dec 9, 2015 at 2:15 PM, Ilia Mirkin wrote: > On Wed, Dec 9, 2015 at 11:23 AM, Ilia Mirkin wrote: >> On Wed, Dec 9, 2015 at 11:18 AM, Deve wrote: >>> This patch indeed seems to not have a sense. I just added it to the bug >>> report as a suggestion that it works for me after this modifica

Re: [Mesa-dev] [PATCH] i965: handle stencil_bits parameter for MESA_FORMAT_B8G8R8X8_UNORM format.

2015-12-11 Thread Neil Roberts
Ilia Mirkin writes: > I suspect that something like this may be the right thing for the > intel driver... no reason not to expose sRGB-capable visuals when it > so happens that alpha == 0. Also probably the same treatment should be > done for BGR565... sRGB encoding will matter even more there, a