Re: [Mesa-dev] [PATCH] nir: no-op C99 _Pragma() with MSVC

2019-11-26 Thread Nathan Kidd
On 2019-11-23 12:38 p.m., Brian Paul wrote: > BTW, With gcc 5.4.0, there's a lot of warnings about the pragma not > being understood: > > ../src/compiler/nir/nir_range_analysis.c:268:0: warning: ignoring > #pragma GCC unroll [-Wunknown-pragmas] >     ASSERT_TABLE_IS_COMMUTATIVE(union_table); >  ^

Re: [Mesa-dev] [PATCH] nir: no-op C99 _Pragma() with MSVC

2019-11-23 Thread Brian Paul
On 11/22/2019 09:16 PM, Ian Romanick wrote: On 11/22/19 6:49 PM, Brian Paul wrote: This fixes a build failure on MSVC. BTW, it looks like clang supports _Pragma() but I don't know if it understands the "gcc unroll N" directive. It probably doesn't, but that should be okay. This just exists t

Re: [Mesa-dev] [PATCH] nir: no-op C99 _Pragma() with MSVC

2019-11-22 Thread Giuseppe Bilotta
On Sat, Nov 23, 2019 at 3:49 AM Brian Paul wrote: > + > +/* MSVC doesn't have C99's _Pragma() */ > +#ifdef _MSC_VER > +#define _Pragma(x) > +#endif FWIW, MSVC has its own __pragma() extension instead of _Pragma(), but IIRC the syntax is slightly different (the contents are tokens, not a string to

Re: [Mesa-dev] [PATCH] nir: no-op C99 _Pragma() with MSVC

2019-11-22 Thread Ian Romanick
On 11/22/19 6:49 PM, Brian Paul wrote: > This fixes a build failure on MSVC. > > BTW, it looks like clang supports _Pragma() but I don't know if it > understands the "gcc unroll N" directive. It probably doesn't, but that should be okay. This just exists to speed up the debug builds in the pre-m