Re: [Mesa-dev] [PATCH] nvc0/ir: Fix assert accessing null pointer

On Fri, 2019-07-26 at 10:41 -0400, Ilia Mirkin wrote: > On Wed, Jul 24, 2019 at 9:34 AM Juan A. Suarez Romero > wrote: > > On Wed, 2019-07-24 at 14:27 +0200, Karol Herbst wrote: > > > it's only fixing a crash in a build with asserts enabled, but if > > > somebody wants to apply those to stable, th

Re: [Mesa-dev] [PATCH] nvc0/ir: Fix assert accessing null pointer

On Wed, Jul 24, 2019 at 9:34 AM Juan A. Suarez Romero wrote: > > On Wed, 2019-07-24 at 14:27 +0200, Karol Herbst wrote: > > it's only fixing a crash in a build with asserts enabled, but if > > somebody wants to apply those to stable, then go ahead. > > > > OK; in that case I will keep it out. Loo

Re: [Mesa-dev] [PATCH] nvc0/ir: Fix assert accessing null pointer

On Wed, 2019-07-24 at 14:27 +0200, Karol Herbst wrote: > it's only fixing a crash in a build with asserts enabled, but if > somebody wants to apply those to stable, then go ahead. > OK; in that case I will keep it out. Thanks! J.A. > On Wed, Jul 24, 2019 at 12:48 PM Juan A. Suarez Rome

Re: [Mesa-dev] [PATCH] nvc0/ir: Fix assert accessing null pointer

it's only fixing a crash in a build with asserts enabled, but if somebody wants to apply those to stable, then go ahead. On Wed, Jul 24, 2019 at 12:48 PM Juan A. Suarez Romero wrote: > > On Fri, 2019-07-19 at 13:56 +0200, Mark Menzynski wrote: > > Fixes: https://bugs.freedesktop.org/show_bug.cgi?

Re: [Mesa-dev] [PATCH] nvc0/ir: Fix assert accessing null pointer

On Fri, 2019-07-19 at 13:56 +0200, Mark Menzynski wrote: > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=111007 > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=67 > Signed-off-by: Mark Menzynski > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 2 +- > 1 file

Re: [Mesa-dev] [PATCH] nvc0/ir: Fix assert accessing null pointer

On Friday, 2019-07-19 21:23:24 +0200, Tobias Klausmann wrote: > > Am 19.07.19 um 18:18 schrieb Ilia Mirkin: > > On Fri, Jul 19, 2019 at 12:07 PM Tobias Klausmann > > wrote: > > > On 19.07.19 15:39, Eric Engestrom wrote: > > > > On Friday, 2019-07-19 13:56:30 +0200, Mark Menzynski wrote: > > > > >

Re: [Mesa-dev] [PATCH] nvc0/ir: Fix assert accessing null pointer

Am 19.07.19 um 18:18 schrieb Ilia Mirkin: On Fri, Jul 19, 2019 at 12:07 PM Tobias Klausmann wrote: On 19.07.19 15:39, Eric Engestrom wrote: On Friday, 2019-07-19 13:56:30 +0200, Mark Menzynski wrote: Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=111007 Fixes: https://bugs.freedesktop.o

Re: [Mesa-dev] [PATCH] nvc0/ir: Fix assert accessing null pointer

On Fri, Jul 19, 2019 at 12:07 PM Tobias Klausmann wrote: > On 19.07.19 15:39, Eric Engestrom wrote: > > On Friday, 2019-07-19 13:56:30 +0200, Mark Menzynski wrote: > >> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=111007 > >> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=67 > > `F

Re: [Mesa-dev] [PATCH] nvc0/ir: Fix assert accessing null pointer

On 19.07.19 15:39, Eric Engestrom wrote: On Friday, 2019-07-19 13:56:30 +0200, Mark Menzynski wrote: Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=111007 Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=67 `Fixes:` is used to indicate the commit that introduced the code being fixe

Re: [Mesa-dev] [PATCH] nvc0/ir: Fix assert accessing null pointer

The patch is correct as-is. Reviewed-by: Ilia Mirkin On Fri, Jul 19, 2019 at 9:39 AM Eric Engestrom wrote: > > On Friday, 2019-07-19 13:56:30 +0200, Mark Menzynski wrote: > > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=111007 > > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=6

Re: [Mesa-dev] [PATCH] nvc0/ir: Fix assert accessing null pointer

On Friday, 2019-07-19 13:56:30 +0200, Mark Menzynski wrote: > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=111007 > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=67 `Fixes:` is used to indicate the commit that introduced the code being fixed, such as: Fixes: 1c4e6d7ca83578caf521