Re: [Mesa-dev] [PATCH 10/32] i965/fs: Remove logic to keep track of MRF metadata in lower_load_payload().

On Fri, Feb 20, 2015 at 2:43 PM, Francisco Jerez wrote: > Jason Ekstrand writes: > > > One more comment here... This particularly regards your plan of > separating > > it into "things that match the destination" and "other things" and not > copy > > prop uniforms or immediates into the "other t

Re: [Mesa-dev] [PATCH 10/32] i965/fs: Remove logic to keep track of MRF metadata in lower_load_payload().

Jason Ekstrand writes: > One more comment here... This particularly regards your plan of separating > it into "things that match the destination" and "other things" and not copy > prop uniforms or immediates into the "other things". There is another case > we need to handle. On older gens (SNB

Re: [Mesa-dev] [PATCH 10/32] i965/fs: Remove logic to keep track of MRF metadata in lower_load_payload().

Jason Ekstrand writes: > On Fri, Feb 20, 2015 at 1:09 PM, Francisco Jerez > wrote: > >> Jason Ekstrand writes: >> >> > On Fri, Feb 20, 2015 at 4:11 AM, Francisco Jerez >> > wrote: >> > >> >> Jason Ekstrand writes: >> >> >> >> > I'm still a little pensive. But >> >> > >> >> > Reviewed-by: Jas

Re: [Mesa-dev] [PATCH 10/32] i965/fs: Remove logic to keep track of MRF metadata in lower_load_payload().

One more comment here... This particularly regards your plan of separating it into "things that match the destination" and "other things" and not copy prop uniforms or immediates into the "other things". There is another case we need to handle. On older gens (SNB maybe?) the SIMD16 FB write mess

Re: [Mesa-dev] [PATCH 10/32] i965/fs: Remove logic to keep track of MRF metadata in lower_load_payload().

On Fri, Feb 20, 2015 at 1:09 PM, Francisco Jerez wrote: > Jason Ekstrand writes: > > > On Fri, Feb 20, 2015 at 4:11 AM, Francisco Jerez > > wrote: > > > >> Jason Ekstrand writes: > >> > >> > I'm still a little pensive. But > >> > > >> > Reviewed-by: Jason Ekstrand > >> > > >> Thanks. > >> >

Re: [Mesa-dev] [PATCH 10/32] i965/fs: Remove logic to keep track of MRF metadata in lower_load_payload().

Jason Ekstrand writes: > On Fri, Feb 20, 2015 at 4:11 AM, Francisco Jerez > wrote: > >> Jason Ekstrand writes: >> >> > I'm still a little pensive. But >> > >> > Reviewed-by: Jason Ekstrand >> > >> Thanks. >> >> > Now for a little aside. I have come to the conclusion that I made a >> grave >>

Re: [Mesa-dev] [PATCH 10/32] i965/fs: Remove logic to keep track of MRF metadata in lower_load_payload().

On Fri, Feb 20, 2015 at 4:11 AM, Francisco Jerez wrote: > Jason Ekstrand writes: > > > I'm still a little pensive. But > > > > Reviewed-by: Jason Ekstrand > > > Thanks. > > > Now for a little aside. I have come to the conclusion that I made a > grave > > mistake when I did the LOAD_PAYLOAD st

Re: [Mesa-dev] [PATCH 10/32] i965/fs: Remove logic to keep track of MRF metadata in lower_load_payload().

Jason Ekstrand writes: > I'm still a little pensive. But > > Reviewed-by: Jason Ekstrand > Thanks. > Now for a little aside. I have come to the conclusion that I made a grave > mistake when I did the LOAD_PAYLOAD stuff. In retrospect, I should have > just subclassed fs_inst for load_payload.

Re: [Mesa-dev] [PATCH 10/32] i965/fs: Remove logic to keep track of MRF metadata in lower_load_payload().

I'm still a little pensive. But Reviewed-by: Jason Ekstrand Now for a little aside. I have come to the conclusion that I made a grave mistake when I did the LOAD_PAYLOAD stuff. In retrospect, I should have just subclassed fs_inst for load_payload. The problem is that we need to snag a bunch

Re: [Mesa-dev] [PATCH 10/32] i965/fs: Remove logic to keep track of MRF metadata in lower_load_payload().

On Thu, Feb 19, 2015 at 1:25 PM, Francisco Jerez wrote: > Jason Ekstrand writes: > > > On Thu, Feb 19, 2015 at 12:13 PM, Francisco Jerez > > > wrote: > > > >> Jason Ekstrand writes: > >> > >> > On Fri, Feb 6, 2015 at 4:01 PM, Francisco Jerez < > curroje...@riseup.net> > >> > wrote: > >> > > >>

Re: [Mesa-dev] [PATCH 10/32] i965/fs: Remove logic to keep track of MRF metadata in lower_load_payload().

Jason Ekstrand writes: > On Thu, Feb 19, 2015 at 12:13 PM, Francisco Jerez > wrote: > >> Jason Ekstrand writes: >> >> > On Fri, Feb 6, 2015 at 4:01 PM, Francisco Jerez >> > wrote: >> > >> >> Hey Matt, >> >> >> >> Matt Turner writes: >> >> >> >> > On Fri, Feb 6, 2015 at 6:42 AM, Francisco Jere

Re: [Mesa-dev] [PATCH 10/32] i965/fs: Remove logic to keep track of MRF metadata in lower_load_payload().

On Thu, Feb 19, 2015 at 12:13 PM, Francisco Jerez wrote: > Jason Ekstrand writes: > > > On Fri, Feb 6, 2015 at 4:01 PM, Francisco Jerez > > wrote: > > > >> Hey Matt, > >> > >> Matt Turner writes: > >> > >> > On Fri, Feb 6, 2015 at 6:42 AM, Francisco Jerez < > curroje...@riseup.net> > >> wrote:

Re: [Mesa-dev] [PATCH 10/32] i965/fs: Remove logic to keep track of MRF metadata in lower_load_payload().

Jason Ekstrand writes: > On Fri, Feb 6, 2015 at 4:01 PM, Francisco Jerez > wrote: > >> Hey Matt, >> >> Matt Turner writes: >> >> > On Fri, Feb 6, 2015 at 6:42 AM, Francisco Jerez >> wrote: >> >> MRFs cannot be read from anyway so they cannot possibly be a valid >> >> source of LOAD_PAYLOAD. >>

Re: [Mesa-dev] [PATCH 10/32] i965/fs: Remove logic to keep track of MRF metadata in lower_load_payload().

On Fri, Feb 6, 2015 at 4:01 PM, Francisco Jerez wrote: > Hey Matt, > > Matt Turner writes: > > > On Fri, Feb 6, 2015 at 6:42 AM, Francisco Jerez > wrote: > >> MRFs cannot be read from anyway so they cannot possibly be a valid > >> source of LOAD_PAYLOAD. > >> --- > > > > The function only seems

Re: [Mesa-dev] [PATCH 10/32] i965/fs: Remove logic to keep track of MRF metadata in lower_load_payload().

Hey Matt, Matt Turner writes: > On Fri, Feb 6, 2015 at 6:42 AM, Francisco Jerez wrote: >> MRFs cannot be read from anyway so they cannot possibly be a valid >> source of LOAD_PAYLOAD. >> --- > > The function only seems to test inst->dst.file == MRF. I don't see any > code for handling MRF sourc

Re: [Mesa-dev] [PATCH 10/32] i965/fs: Remove logic to keep track of MRF metadata in lower_load_payload().

On Fri, Feb 6, 2015 at 6:42 AM, Francisco Jerez wrote: > MRFs cannot be read from anyway so they cannot possibly be a valid > source of LOAD_PAYLOAD. > --- The function only seems to test inst->dst.file == MRF. I don't see any code for handling MRF sources. What am I missing?