Re: [Mesa-dev] [PATCH 14/29] anv/cmd_buffer: Apply subpass flushes before set_subpass

2017-12-01 Thread Pohjolainen, Topi
On Mon, Nov 27, 2017 at 07:06:04PM -0800, Jason Ekstrand wrote: > This seems slightly more correct because it means that the flushes > happen before any clears or resolves implied by the subpass transition. After reading the next patch this patch seems incomplete both before and after. Next patch

Re: [Mesa-dev] [PATCH 14/29] anv/cmd_buffer: Apply subpass flushes before set_subpass

2017-12-01 Thread Jason Ekstrand
On Fri, Dec 1, 2017 at 5:47 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Mon, Nov 27, 2017 at 07:06:04PM -0800, Jason Ekstrand wrote: > > This seems slightly more correct because it means that the flushes > > happen before any clears or resolves implied by the subpass transition

Re: [Mesa-dev] [PATCH 14/29] anv/cmd_buffer: Apply subpass flushes before set_subpass

2018-01-09 Thread Nanley Chery
On Mon, Nov 27, 2017 at 07:06:04PM -0800, Jason Ekstrand wrote: > This seems slightly more correct because it means that the flushes > happen before any clears or resolves implied by the subpass transition. > --- > src/intel/vulkan/genX_cmd_buffer.c | 8 > 1 file changed, 4 insertions(+),