Re: [Mesa-dev] [PATCH 4/4] egl/dri2: add image extension to swrast_core_extensions

Thanks for the review, Emil. If we want to use swrast we'll probably need to implement a new swrast version of the image extension. We can't reuse the functions from dri2.c, even for version 1 of the extension (createImageFromName, createImageFromRenderbuffer etc), since they require definitions

Re: [Mesa-dev] [PATCH 4/4] egl/dri2: add image extension to swrast_core_extensions

On 9 June 2017 at 01:28, gurchetansi...@chromium.org wrote: > From: Gurchetan Singh > > Otherwise, this extension is not visible to the EGL user > --- > src/egl/drivers/dri2/egl_dri2.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [Mesa-dev] [PATCH 4/4] egl/dri2: add image extension to swrast_core_extensions

On 28 June 2017 at 11:17, Emil Velikov wrote: > Hi Gurchetan, > > Pardon for the delay. > > On 22 June 2017 at 00:40, Gurchetan Singh wrote: >> Emil, >> >> If I understand you correctly, you're proposing to add the ability to use >> the

Re: [Mesa-dev] [PATCH 4/4] egl/dri2: add image extension to swrast_core_extensions

Hi Gurchetan, Pardon for the delay. On 22 June 2017 at 00:40, Gurchetan Singh wrote: > Emil, > > If I understand you correctly, you're proposing to add the ability to use > the kms_swrast driver in platform_x11.c (the host is a standard Ubuntu box > for the emulator

Re: [Mesa-dev] [PATCH 4/4] egl/dri2: add image extension to swrast_core_extensions

Ping... On Wed, Jun 21, 2017 at 4:40 PM, Gurchetan Singh < gurchetansi...@chromium.org> wrote: > Emil, > > If I understand you correctly, you're proposing to add the ability to use > the kms_swrast driver in platform_x11.c (the host is a standard Ubuntu box > for the emulator use case, not CrOS)

Re: [Mesa-dev] [PATCH 4/4] egl/dri2: add image extension to swrast_core_extensions

Emil, If I understand you correctly, you're proposing to add the ability to use the kms_swrast driver in platform_x11.c (the host is a standard Ubuntu box for the emulator use case, not CrOS) alongside swrast. In that case, we would need to: 1) Have a dri2_initialize_x11_kms_swrast function

Re: [Mesa-dev] [PATCH 4/4] egl/dri2: add image extension to swrast_core_extensions

On 19 June 2017 at 20:46, Chad Versace wrote: > On Thu 15 Jun 2017, Gurchetan Singh wrote: >> Emil, would you be fine with leaving the image extension in dri2.c but still >> adding it as a drisw extension? That solution would look like: >> >>

Re: [Mesa-dev] [PATCH 4/4] egl/dri2: add image extension to swrast_core_extensions

On Thu 15 Jun 2017, Gurchetan Singh wrote: > Emil, would you be fine with leaving the image extension in dri2.c but still > adding it as a drisw extension?  That solution would look like: > > [1]https://patchwork.freedesktop.org/patch/154807/   Observations: -

Re: [Mesa-dev] [PATCH 4/4] egl/dri2: add image extension to swrast_core_extensions

On 9 June 2017 at 16:40, Gurchetan Singh wrote: > Actually, these are the only patches that are required. We're trying to run > the Android Studio emulator using the host's GLES implementation. The > emulator uses the image extension in that case: > >

Re: [Mesa-dev] [PATCH 4/4] egl/dri2: add image extension to swrast_core_extensions

Emil, would you be fine with leaving the image extension in dri2.c but still adding it as a drisw extension? That solution would look like: https://patchwork.freedesktop.org/patch/154807/ On Fri, Jun 9, 2017 at 8:40 AM, Gurchetan Singh wrote: > Actually, these

Re: [Mesa-dev] [PATCH 4/4] egl/dri2: add image extension to swrast_core_extensions

Actually, these are the only patches that are required. We're trying to run the Android Studio emulator using the host's GLES implementation. The emulator uses the image extension in that case: https://android.googlesource.com/platform/sdk/+/emu-2.4-

Re: [Mesa-dev] [PATCH 4/4] egl/dri2: add image extension to swrast_core_extensions

Hi Gurchetan, On 9 June 2017 at 01:28, gurchetansi...@chromium.org wrote: > From: Gurchetan Singh > > Otherwise, this extension is not visible to the EGL user > --- > src/egl/drivers/dri2/egl_dri2.c | 1 + > 1 file changed, 1 insertion(+)