Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-03-26 Thread Chih-Wei Huang
2018-03-22 16:23 GMT+08:00 Tomasz Figa : > Hi Chih-Wei, > > On Thu, Feb 22, 2018 at 2:53 PM, Chih-Wei Huang wrote: >> 2018-02-21 3:03 GMT+08:00 Rob Herring : >>> >>> Perhaps worth revisiting. Given we've failed to progress at all since >>> then may change opinions some. We already have to handle m

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-03-25 Thread Tapani Pälli
On 03/23/2018 03:20 PM, Tomasz Figa wrote: On Fri, Mar 23, 2018 at 10:15 PM, Stefan Schake wrote: On Fri, Mar 23, 2018 at 1:02 PM, Tomasz Figa wrote: On Fri, Mar 23, 2018 at 8:52 PM, Robert Foss wrote: Hey Chih-Wei, On 03/23/2018 03:43 AM, Chih-Wei Huang wrote: 2018-03-22 16:23 GMT+08

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-03-23 Thread Tomasz Figa
On Fri, Mar 23, 2018 at 10:15 PM, Stefan Schake wrote: > On Fri, Mar 23, 2018 at 1:02 PM, Tomasz Figa wrote: >> On Fri, Mar 23, 2018 at 8:52 PM, Robert Foss >> wrote: >>> Hey Chih-Wei, >>> >>> >>> On 03/23/2018 03:43 AM, Chih-Wei Huang wrote: 2018-03-22 16:23 GMT+08:00 Tomasz Figa : >

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-03-23 Thread Stefan Schake
On Fri, Mar 23, 2018 at 1:02 PM, Tomasz Figa wrote: > On Fri, Mar 23, 2018 at 8:52 PM, Robert Foss > wrote: >> Hey Chih-Wei, >> >> >> On 03/23/2018 03:43 AM, Chih-Wei Huang wrote: >>> >>> 2018-03-22 16:23 GMT+08:00 Tomasz Figa : Hi Chih-Wei, On Thu, Feb 22, 2018 at 2:53 PM, C

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-03-23 Thread Tomasz Figa
On Fri, Mar 23, 2018 at 8:52 PM, Robert Foss wrote: > Hey Chih-Wei, > > > On 03/23/2018 03:43 AM, Chih-Wei Huang wrote: >> >> 2018-03-22 16:23 GMT+08:00 Tomasz Figa : >>> >>> Hi Chih-Wei, >>> >>> On Thu, Feb 22, 2018 at 2:53 PM, Chih-Wei Huang >>> wrote: 2018-02-21 3:03 GMT+08:00 Rob He

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-03-23 Thread Robert Foss
Hey Chih-Wei, On 03/23/2018 03:43 AM, Chih-Wei Huang wrote: 2018-03-22 16:23 GMT+08:00 Tomasz Figa : Hi Chih-Wei, On Thu, Feb 22, 2018 at 2:53 PM, Chih-Wei Huang wrote: 2018-02-21 3:03 GMT+08:00 Rob Herring : Perhaps worth revisiting. Given we've failed to progress at all since then may ch

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-03-22 Thread Tomasz Figa
On Fri, Mar 23, 2018 at 11:43 AM, Chih-Wei Huang wrote: > 2018-03-22 16:23 GMT+08:00 Tomasz Figa : >> Hi Chih-Wei, >> >> On Thu, Feb 22, 2018 at 2:53 PM, Chih-Wei Huang wrote: >>> 2018-02-21 3:03 GMT+08:00 Rob Herring : Perhaps worth revisiting. Given we've failed to progress at all sin

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-03-22 Thread Jason Ekstrand
On March 22, 2018 06:07:01 Tapani Pälli wrote: On 03/22/2018 01:01 PM, Emil Velikov wrote: Hi guys, On 22 March 2018 at 08:23, Tomasz Figa wrote: Hi Chih-Wei, On Thu, Feb 22, 2018 at 2:53 PM, Chih-Wei Huang wrote: 2018-02-21 3:03 GMT+08:00 Rob Herring : Perhaps worth revisiting. Given we'

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-03-22 Thread Tapani Pälli
On 03/22/2018 01:01 PM, Emil Velikov wrote: Hi guys, On 22 March 2018 at 08:23, Tomasz Figa wrote: Hi Chih-Wei, On Thu, Feb 22, 2018 at 2:53 PM, Chih-Wei Huang wrote: 2018-02-21 3:03 GMT+08:00 Rob Herring : Perhaps worth revisiting. Given we've failed to progress at all since then may c

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-03-22 Thread Emil Velikov
Hi guys, On 22 March 2018 at 08:23, Tomasz Figa wrote: > Hi Chih-Wei, > > On Thu, Feb 22, 2018 at 2:53 PM, Chih-Wei Huang wrote: >> 2018-02-21 3:03 GMT+08:00 Rob Herring : >>> >>> Perhaps worth revisiting. Given we've failed to progress at all since >>> then may change opinions some. We already

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-03-22 Thread Tomasz Figa
Hi Chih-Wei, On Thu, Feb 22, 2018 at 2:53 PM, Chih-Wei Huang wrote: > 2018-02-21 3:03 GMT+08:00 Rob Herring : >> >> Perhaps worth revisiting. Given we've failed to progress at all since >> then may change opinions some. We already have to handle multiple >> opens share the same pipe_screen, so I

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-22 Thread Emil Velikov
On 22 February 2018 at 05:57, Tomasz Figa wrote: > On Thu, Feb 22, 2018 at 7:23 AM, Rob Herring wrote: >> >> On Wed, Feb 21, 2018 at 1:22 PM, Emil Velikov >> wrote: >> > On 21 February 2018 at 18:50, Rob Herring wrote: >> >> On Wed, Feb 21, 2018 at 10:01 AM, Emil Velikov >> >> wrote: >> >>>

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-22 Thread Chih-Wei Huang
2018-02-21 3:03 GMT+08:00 Rob Herring : > > Perhaps worth revisiting. Given we've failed to progress at all since > then may change opinions some. We already have to handle multiple > opens share the same pipe_screen, so I don't think reusing the fd buys > us anything. > > Maybe we're close to the

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-21 Thread Tomasz Figa
On Thu, Feb 22, 2018 at 7:23 AM, Rob Herring wrote: > > On Wed, Feb 21, 2018 at 1:22 PM, Emil Velikov > wrote: > > On 21 February 2018 at 18:50, Rob Herring wrote: > >> On Wed, Feb 21, 2018 at 10:01 AM, Emil Velikov > >> wrote: > >>> Hi all, > >>> > >>> Pardon for dropping in late. I think yo

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-21 Thread Rob Herring
On Wed, Feb 21, 2018 at 1:22 PM, Emil Velikov wrote: > On 21 February 2018 at 18:50, Rob Herring wrote: >> On Wed, Feb 21, 2018 at 10:01 AM, Emil Velikov >> wrote: >>> Hi all, >>> >>> Pardon for dropping in late. I think you've got nearly everything >>> settled down, just sharing a couple of id

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-21 Thread Emil Velikov
On 21 February 2018 at 18:50, Rob Herring wrote: > On Wed, Feb 21, 2018 at 10:01 AM, Emil Velikov > wrote: >> Hi all, >> >> Pardon for dropping in late. I think you've got nearly everything >> settled down, just sharing a couple of ideas. >> >> On 21 February 2018 at 04:19, Tomasz Figa wrote: >

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-21 Thread Rob Herring
On Wed, Feb 21, 2018 at 10:01 AM, Emil Velikov wrote: > Hi all, > > Pardon for dropping in late. I think you've got nearly everything > settled down, just sharing a couple of ideas. > > On 21 February 2018 at 04:19, Tomasz Figa wrote: >> On Wed, Feb 21, 2018 at 4:03 AM, Rob Herring wrote: >>> On

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-21 Thread Emil Velikov
Hi all, Pardon for dropping in late. I think you've got nearly everything settled down, just sharing a couple of ideas. On 21 February 2018 at 04:19, Tomasz Figa wrote: > On Wed, Feb 21, 2018 at 4:03 AM, Rob Herring wrote: >> On Tue, Feb 20, 2018 at 4:26 AM, Tomasz Figa wrote: > It is actuall

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-20 Thread Tomasz Figa
On Wed, Feb 21, 2018 at 4:03 AM, Rob Herring wrote: > On Tue, Feb 20, 2018 at 4:26 AM, Tomasz Figa wrote: >> On Tue, Feb 20, 2018 at 6:51 PM, Robert Foss >> wrote: >>> Hey Tomasz, >>> >>> On 02/20/2018 09:55 AM, Tomasz Figa wrote: Hi Rob, On Fri, Feb 16, 2018 at 11:48 PM, To

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-20 Thread Rob Herring
On Tue, Feb 20, 2018 at 4:26 AM, Tomasz Figa wrote: > On Tue, Feb 20, 2018 at 6:51 PM, Robert Foss > wrote: >> Hey Tomasz, >> >> On 02/20/2018 09:55 AM, Tomasz Figa wrote: >>> >>> Hi Rob, >>> >>> On Fri, Feb 16, 2018 at 11:48 PM, Tomasz Figa wrote: On Fri, Feb 16, 2018 at 11:33 PM, Ro

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-20 Thread Tomasz Figa
On Tue, Feb 20, 2018 at 6:51 PM, Robert Foss wrote: > Hey Tomasz, > > On 02/20/2018 09:55 AM, Tomasz Figa wrote: >> >> Hi Rob, >> >> On Fri, Feb 16, 2018 at 11:48 PM, Tomasz Figa wrote: >>> >>> On Fri, Feb 16, 2018 at 11:33 PM, Robert Foss >>> wrote: Hey Tomasz, On 02/16

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-20 Thread Robert Foss
Hey Tomasz, On 02/20/2018 09:55 AM, Tomasz Figa wrote: Hi Rob, On Fri, Feb 16, 2018 at 11:48 PM, Tomasz Figa wrote: On Fri, Feb 16, 2018 at 11:33 PM, Robert Foss wrote: Hey Tomasz, On 02/16/2018 05:10 AM, Tomaszzz Figa wrote: On Fri, Feb 9, 2018 at 11:06 PM, Rob Herring wrote: On Fri

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-20 Thread Tomasz Figa
Hi Rob, On Fri, Feb 16, 2018 at 11:48 PM, Tomasz Figa wrote: > On Fri, Feb 16, 2018 at 11:33 PM, Robert Foss > wrote: >> Hey Tomasz, >> >> >> On 02/16/2018 05:10 AM, Tomasz Figa wrote: >>> >>> On Fri, Feb 9, 2018 at 11:06 PM, Rob Herring wrote: On Fri, Feb 9, 2018 at 3:58 AM, Tomasz

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-16 Thread Tomasz Figa
On Fri, Feb 16, 2018 at 11:33 PM, Robert Foss wrote: > Hey Tomasz, > > > On 02/16/2018 05:10 AM, Tomasz Figa wrote: >> >> On Fri, Feb 9, 2018 at 11:06 PM, Rob Herring wrote: >>> >>> On Fri, Feb 9, 2018 at 3:58 AM, Tomasz Figa wrote: On Fri, Feb 2, 2018 at 11:51 PM, Tomasz Figa wrote:

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-16 Thread Robert Foss
Hey Tomasz, On 02/16/2018 05:10 AM, Tomasz Figa wrote: On Fri, Feb 9, 2018 at 11:06 PM, Rob Herring wrote: On Fri, Feb 9, 2018 at 3:58 AM, Tomasz Figa wrote: On Fri, Feb 2, 2018 at 11:51 PM, Tomasz Figa wrote: On Fri, Feb 2, 2018 at 11:00 PM, Rob Herring wrote: On Fri, Feb 2, 2018 at 2:0

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-15 Thread Tomasz Figa
On Fri, Feb 9, 2018 at 11:06 PM, Rob Herring wrote: > On Fri, Feb 9, 2018 at 3:58 AM, Tomasz Figa wrote: >> On Fri, Feb 2, 2018 at 11:51 PM, Tomasz Figa wrote: >>> On Fri, Feb 2, 2018 at 11:00 PM, Rob Herring wrote: On Fri, Feb 2, 2018 at 2:01 AM, Tomasz Figa wrote: > Hi Rob, > >>

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-09 Thread Rob Herring
On Fri, Feb 9, 2018 at 3:58 AM, Tomasz Figa wrote: > On Fri, Feb 2, 2018 at 11:51 PM, Tomasz Figa wrote: >> On Fri, Feb 2, 2018 at 11:00 PM, Rob Herring wrote: >>> On Fri, Feb 2, 2018 at 2:01 AM, Tomasz Figa wrote: Hi Rob, On Tue, Jan 30, 2018 at 9:36 PM, Robert Foss wrote

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-09 Thread Tomasz Figa
On Fri, Feb 2, 2018 at 11:51 PM, Tomasz Figa wrote: > On Fri, Feb 2, 2018 at 11:00 PM, Rob Herring wrote: >> On Fri, Feb 2, 2018 at 2:01 AM, Tomasz Figa wrote: >>> Hi Rob, >>> >>> On Tue, Jan 30, 2018 at 9:36 PM, Robert Foss >>> wrote: > uint32_t (*get_fd)(buffer_handle_t handle,

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-02 Thread Tomasz Figa
On Fri, Feb 2, 2018 at 11:00 PM, Rob Herring wrote: > On Fri, Feb 2, 2018 at 2:01 AM, Tomasz Figa wrote: >> Hi Rob, >> >> On Tue, Jan 30, 2018 at 9:36 PM, Robert Foss >> wrote: uint32_t (*get_fd)(buffer_handle_t handle, uint32_t plane); uint64_t (*get_modifier)(buf

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-02 Thread Rob Herring
On Fri, Feb 2, 2018 at 2:01 AM, Tomasz Figa wrote: > Hi Rob, > > On Tue, Jan 30, 2018 at 9:36 PM, Robert Foss > wrote: >>> uint32_t (*get_fd)(buffer_handle_t handle, uint32_t plane); >>> uint64_t (*get_modifier)(buffer_handle_t handle, uint32_t >>> plane); >>> u

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-02 Thread Tomasz Figa
Hi Rob, On Tue, Jan 30, 2018 at 9:36 PM, Robert Foss wrote: >> uint32_t (*get_fd)(buffer_handle_t handle, uint32_t plane); >> uint64_t (*get_modifier)(buffer_handle_t handle, uint32_t >> plane); >> uint32_t (*get_offsets)(buffer_handle_t handle, uint32_t plane);

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-01-30 Thread Robert Foss
On 01/30/2018 04:16 AM, Tomasz Figa wrote: Hi Rob, On Tue, Jan 30, 2018 at 1:17 AM, Robert Foss wrote: Hey Tomasz, I'm tempted to split this work into two parts. 1) Move gbm&drm gralloc struct Alright, if we look at this only as an attempt to converge gbm_ and drm_gralloc, it's out of my

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-01-29 Thread Tomasz Figa
Hi Rob, On Tue, Jan 30, 2018 at 1:17 AM, Robert Foss wrote: > Hey Tomasz, > > I'm tempted to split this work into two parts. > 1) Move gbm&drm gralloc struct Alright, if we look at this only as an attempt to converge gbm_ and drm_gralloc, it's out of my scope and no concern anymore. > 2) Access

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-01-29 Thread Robert Foss
Hey Tomasz, I'm tempted to split this work into two parts. 1) Move gbm&drm gralloc struct 2) Accessor functions I would like to get 1) out the door to support John Stultzs current HiKey 960 efforts. As for 2), it would seem that we have some more discussing to do. But I'll keep pushing that fo

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-01-29 Thread Robert Foss
On 01/25/2018 08:52 PM, Rob Herring wrote: On Thu, Jan 25, 2018 at 10:21 AM, Robert Foss wrote: Hey Tomasz, On 01/24/2018 11:04 AM, Tomasz Figa wrote: Hi Robert, On Wed, Jan 17, 2018 at 2:36 AM, Robert Foss wrote: This series moves {gbm,drm,cros}_gralloc_handle_t struct to libdrm, sinc

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-01-25 Thread Rob Herring
On Thu, Jan 25, 2018 at 10:21 AM, Robert Foss wrote: > Hey Tomasz, > > On 01/24/2018 11:04 AM, Tomasz Figa wrote: >> >> Hi Robert, >> >> On Wed, Jan 17, 2018 at 2:36 AM, Robert Foss >> wrote: >>> >>> This series moves {gbm,drm,cros}_gralloc_handle_t struct to libdrm, >>> since at least 4 implemen

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-01-25 Thread Robert Foss
Hey Tomasz, On 01/24/2018 11:04 AM, Tomasz Figa wrote: Hi Robert, On Wed, Jan 17, 2018 at 2:36 AM, Robert Foss wrote: This series moves {gbm,drm,cros}_gralloc_handle_t struct to libdrm, since at least 4 implementations exist, and share a lot of contents. The idea is to keep the common stuff d

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-01-24 Thread Rob Herring
On Wed, Jan 24, 2018 at 4:04 AM, Tomasz Figa wrote: > Hi Robert, > > On Wed, Jan 17, 2018 at 2:36 AM, Robert Foss > wrote: >> This series moves {gbm,drm,cros}_gralloc_handle_t struct to libdrm, >> since at least 4 implementations exist, and share a lot of contents. >> The idea is to keep the com

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-01-24 Thread Tomasz Figa
Hi Robert, On Wed, Jan 17, 2018 at 2:36 AM, Robert Foss wrote: > This series moves {gbm,drm,cros}_gralloc_handle_t struct to libdrm, > since at least 4 implementations exist, and share a lot of contents. > The idea is to keep the common stuff defined in one place, and libdrm > is the common codeb