Re: [Mesa-dev] [PATCH v3 23/48] intel/fs: Assign constant locations if they haven't been assigned

2017-10-31 Thread Iago Toral
On Mon, 2017-10-30 at 11:39 -0700, Jason Ekstrand wrote: > On Mon, Oct 30, 2017 at 12:43 AM, Iago Toral > wrote: > > On Fri, 2017-10-27 at 12:43 -0700, Jason Ekstrand wrote: > > > On Fri, Oct 27, 2017 at 12:35 AM, Iago Toral > > > wrote: > > > > This sounds good to me, but I guess it is not reall

Re: [Mesa-dev] [PATCH v3 23/48] intel/fs: Assign constant locations if they haven't been assigned

2017-10-30 Thread Jason Ekstrand
On Mon, Oct 30, 2017 at 12:43 AM, Iago Toral wrote: > On Fri, 2017-10-27 at 12:43 -0700, Jason Ekstrand wrote: > > On Fri, Oct 27, 2017 at 12:35 AM, Iago Toral wrote: > > This sounds good to me, but I guess it is not really fixing anything, > right? I ask because the subject claims that this pat

Re: [Mesa-dev] [PATCH v3 23/48] intel/fs: Assign constant locations if they haven't been assigned

2017-10-30 Thread Iago Toral
On Fri, 2017-10-27 at 12:43 -0700, Jason Ekstrand wrote: > On Fri, Oct 27, 2017 at 12:35 AM, Iago Toral > wrote: > > This sounds good to me, but I guess it is not really fixing > > anything, > > > > right? I ask because the subject claims that this patch does > > something > > > > that the origi

Re: [Mesa-dev] [PATCH v3 23/48] intel/fs: Assign constant locations if they haven't been assigned

2017-10-27 Thread Jason Ekstrand
On Fri, Oct 27, 2017 at 12:35 AM, Iago Toral wrote: > This sounds good to me, but I guess it is not really fixing anything, > right? I ask because the subject claims that this patch does something > that the original code was already supposed to be doing. > This patch is a bit of an artifact of

Re: [Mesa-dev] [PATCH v3 23/48] intel/fs: Assign constant locations if they haven't been assigned

2017-10-27 Thread Iago Toral
This sounds good to me, but I guess it is not really fixing anything, right? I ask because the subject claims that this patch does something that the original code was already supposed to be doing. On Wed, 2017-10-25 at 16:25 -0700, Jason Ekstrand wrote: > Before, we bailing in assign_constant_loc