Re: [Mesa-dev] [RFC] More ARB_arrays_of_arrays support

2015-03-26 Thread Timothy Arceri
On Sat, 2015-03-21 at 20:06 -0400, Ilia Mirkin wrote: > Patches 1, 2, 3, 4, 8, and 11 are Reviewed-by: Ilia Mirkin > Is anyone interested in taking a look at the remaining patches? > > The rest I sent comments on, although even if you address my feedback, > I'm not sufficiently familiar to r-b

Re: [Mesa-dev] [RFC] More ARB_arrays_of_arrays support

2015-03-24 Thread Timothy Arceri
On Sat, 2015-03-21 at 09:27 -0700, Jason Ekstrand wrote: > > On Mar 21, 2015 2:49 AM, "Timothy Arceri" > wrote: > > > > This series adds most of the remaining glsl arrays of arrays > support. Support for uniform blocks is still missing, I've played > around with this but don't have anything worki

Re: [Mesa-dev] [RFC] More ARB_arrays_of_arrays support

2015-03-22 Thread Timothy Arceri
On Sat, 2015-03-21 at 09:27 -0700, Jason Ekstrand wrote: > > On Mar 21, 2015 2:49 AM, "Timothy Arceri" > wrote: > > > > This series adds most of the remaining glsl arrays of arrays > support. Support for uniform blocks is still missing, I've played > around with this but don't have anything worki

Re: [Mesa-dev] [RFC] More ARB_arrays_of_arrays support

2015-03-21 Thread Timothy Arceri
On Sat, 2015-03-21 at 20:06 -0400, Ilia Mirkin wrote: > Patches 1, 2, 3, 4, 8, and 11 are Reviewed-by: Ilia Mirkin > > > The rest I sent comments on, although even if you address my feedback, > I'm not sufficiently familiar to r-b at least some of them. Thanks for the reviews. > > If you do de

Re: [Mesa-dev] [RFC] More ARB_arrays_of_arrays support

2015-03-21 Thread Ilia Mirkin
Patches 1, 2, 3, 4, 8, and 11 are Reviewed-by: Ilia Mirkin The rest I sent comments on, although even if you address my feedback, I'm not sufficiently familiar to r-b at least some of them. If you do decide to play with UBO's, you can use idr's excellent random_ubo script to stress-test the vari

Re: [Mesa-dev] [RFC] More ARB_arrays_of_arrays support

2015-03-21 Thread Jason Ekstrand
On Mar 21, 2015 2:49 AM, "Timothy Arceri" wrote: > > This series adds most of the remaining glsl arrays of arrays support. Support for uniform blocks is still missing, I've played around with this but don't have anything working yet. > > What do you guys think about adding these changes without th