[Mesa-dev] [PATCH v2 02/14] i965/gen7: Don't rely directly on the hiz miptree structure

2014-07-22 Thread Jordan Justen
We are still allocating a miptree for hiz, but we only use fields from intel_miptree_aux_buffer. This will allow us to switch over to not allocating a miptree. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com Reviewed-by: Topi Pohjolainen topi.pohjolai...@intel.com ---

[Mesa-dev] [PATCH v2 10/14] i965: Add function to indicate when sampling with hiz is supported

2014-07-22 Thread Jordan Justen
Currently it indicates that this is never supported, but soon it will be supported for gen8+. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com Reviewed-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 10 ++

[Mesa-dev] [PATCH v2 04/14] i965/gen7: Don't allocate hiz miptree structure

2014-07-22 Thread Jordan Justen
We now skip allocating a hiz miptree for gen7. Instead, we calculate the required hiz buffer parameters and allocate a bo directly. v2: * Update hz_height calculation as suggested by Topi Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c |

[Mesa-dev] [PATCH v2 01/14] i965/hiz: Start to separate miptree out from hiz buffers

2014-07-22 Thread Jordan Justen
Today we allocate a miptree's for the hiz buffer. We needed this in the past because we would point the hardware at offsets of the hiz buffer. Since the hiz format is not documented, this is not a good idea. Since moving to support layered rendering on Gen7+, we no longer point at an offset into

[Mesa-dev] [PATCH v2 11/14] i965: Support sampling with hiz during rendering

2014-07-22 Thread Jordan Justen
For gen8, we can sample from depth while using the hiz buffer. This allows us to sample depth without resolving from hiz to the depth texture. To do this we must resolve to hiz before drawing so we can use the hiz buffer to sample while rendering. Hopefully the hiz buffer will already be resolved

[Mesa-dev] [PATCH v2 03/14] i965/gen8: Don't rely directly on the hiz miptree structure

2014-07-22 Thread Jordan Justen
We are still allocating a miptree for hiz, but we only use fields from intel_miptree_aux_buffer. This will allow us to switch over to not allocating a miptree. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com Reviewed-by: Topi Pohjolainen topi.pohjolai...@intel.com ---

[Mesa-dev] [PATCH v2 12/14] i965/gen8: Initialize aux_mode to GEN8_SURFACE_AUX_MODE_NONE

2014-07-22 Thread Jordan Justen
GEN8_SURFACE_AUX_MODE_NONE is 0, so this is a no-op. Yet, this also makes it clear that we can compare aux_mode to the other GEN8_SURFACE_AUX_MODE_ values. We will want to compare to GEN8_SURFACE_AUX_MODE_HIZ. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com Reviewed-by: Topi Pohjolainen

[Mesa-dev] [PATCH v2 13/14] i965/gen8: Add HiZ auxiliary buffer support

2014-07-22 Thread Jordan Justen
From: Kenneth Graunke kenn...@whitecape.org Signed-off-by: Kenneth Graunke kenn...@whitecape.org [jordan.l.jus...@intel.com: convert from aux_mt to aux_buf] Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/drivers/dri/i965/gen8_surface_state.c | 5 - 1 file changed, 4

[Mesa-dev] [PATCH v2 14/14] i965/gen8: Allow sampling with hiz when supported

2014-07-22 Thread Jordan Justen
For gen8+ this will indicate when we should allow hiz based sampling during rendering. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH v2 07/14] i965: Wrap MCS miptree in intel_miptree_aux_buffer

2014-07-22 Thread Jordan Justen
This will allow us to treat HiZ and MCS the same when using as an auxiliary surface buffer. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com Reviewed-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 2 +-

[Mesa-dev] [PATCH v2 00/14] i965/gen7+ hiz cleanup + gen8 hiz improvements

2014-07-22 Thread Jordan Justen
1. No longer allocate a miptree structure for hiz on gen7+. 2. Always enable hiz for depth on gen8+. 3. Enable hiz Auxiliary Buffer support on gen8. This support allows Broadwell to sample from depth using the hiz buffer, and thereby removing the need to resolve depth to/from the hiz

[Mesa-dev] [PATCH v2 08/14] i965/gen8: Use intel_miptree_aux_buffer for auxiliary buffer

2014-07-22 Thread Jordan Justen
This will allow us to treat HiZ and MCS the same when using them as auxiliary surface buffers. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com Reviewed-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/mesa/drivers/dri/i965/gen8_surface_state.c | 28 +- 1

[Mesa-dev] [PATCH v2 09/14] i965/gen8: Use aux buf qpitch for Auxiliary Buffer (MCS)

2014-07-22 Thread Jordan Justen
For some auxiliary buffers the qpitch may be different than the main miptree. (for example, hiz) In i965: Wrap MCS miptree in intel_miptree_aux_buffer we set aux_buf-qpitch to mt-qpitch, so for MCS, this should be a no-op. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com Reviewed-by: Topi

[Mesa-dev] [PATCH v2 05/14] i965/gen8: Don't allocate hiz miptree structure

2014-07-22 Thread Jordan Justen
We now skip allocating a hiz miptree for gen8. Instead, we calculate the required hiz buffer parameters and allocate a bo directly. v2: * Update hz_height calculation as suggested by Topi Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c |

[Mesa-dev] [PATCH v2 06/14] i965/gen8: Enable hiz for all depth levels

2014-07-22 Thread Jordan Justen
After modifying the hiz buffer allocation and qpitch calculation, hiz appears to work in all cases on gen8. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH v2 00/14] i965/gen7+ hiz cleanup + gen8 hiz improvements

2014-07-22 Thread Pohjolainen, Topi
On Mon, Jul 21, 2014 at 11:00:49PM -0700, Jordan Justen wrote: 1. No longer allocate a miptree structure for hiz on gen7+. 2. Always enable hiz for depth on gen8+. 3. Enable hiz Auxiliary Buffer support on gen8. This support allows Broadwell to sample from depth using the hiz buffer,

[Mesa-dev] [PATCH] [demos] fix direct rendering context in glxinfo

2014-07-22 Thread Marc Dietrich
commit e769bc682b4a0d0f597286b067f54f923d159866 broke direct rendering context because it defaults to indirect rendering and there is no way to reverse it. Signed-of-by: Marc Dietrich marvi...@gmx.de --- src/xdemos/glinfo_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 02/17] i965/gen6: add support for layered renderbuffers

2014-07-22 Thread Pohjolainen, Topi
On Fri, Jul 18, 2014 at 02:16:37PM -0700, Jordan Justen wrote: Rather than pointing the surface_state directly at a single sub-image of the texture for rendering, we now point the surface_state at the top level of the texture, and configure the surface_state as needed based on this. v2: *

Re: [Mesa-dev] [PATCH 04/17] i965: Split gen6 depth hiz state out from brw

2014-07-22 Thread Pohjolainen, Topi
On Fri, Jul 18, 2014 at 02:16:39PM -0700, Jordan Justen wrote: We will program the gen6 hiz depth state differently to enable layered rendering on gen6. v2: * Remove unneeded gen6_emit_depthbuffer as suggested by Topi Signed-off-by: Jordan Justen jordan.l.jus...@intel.com Compared side

Re: [Mesa-dev] [PATCH 08/17] i965/gen6 depth surface: calculate minimum array element being rendered

2014-07-22 Thread Pohjolainen, Topi
On Fri, Jul 18, 2014 at 02:16:43PM -0700, Jordan Justen wrote: (a23cfb8 for gen6) In layered rendering this will be 0. Otherwise it will be the selected slice. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/drivers/dri/i965/gen6_blorp.cpp | 3 +++

Re: [Mesa-dev] [PATCH 05/17] i965/gen6 depth surface: calculate more specific surface type

2014-07-22 Thread Pohjolainen, Topi
On Fri, Jul 18, 2014 at 02:16:40PM -0700, Jordan Justen wrote: (171e633 for gen6) This will be used in 3DSTATE_DEPTH_BUFFER in a later patch. Note: Cube maps are treated as 2D arrays with 6 times as many array elements as the cube map array would have. Signed-off-by: Jordan Justen

Re: [Mesa-dev] [PATCH] util: Add util_memcpy_cpu_to_le32() v3

2014-07-22 Thread Michel Dänzer
On 19.07.2014 04:55, Tom Stellard wrote: v2: - Preserve word boundaries. v3: - Use const and restrict. - Fix indentation. --- src/gallium/auxiliary/util/u_math.h | 17 + 1 file changed, 17 insertions(+) diff --git a/src/gallium/auxiliary/util/u_math.h

Re: [Mesa-dev] [PATCH 0/7] Fix handling of 8-bits-per-channel SRGB and SNORM formats

2014-07-22 Thread Richard Sandiford
Marek Olšák mar...@gmail.com writes: Hi Richard, For anything that changes the shared core code in src/gallium, the commit message prefix should be gallium:. You can also use gallium/util: if you just change auxiliary/util. For anything that changes src/mesa/state_tracker, the prefix should

[Mesa-dev] [PATCH v2 1/5] swrast: Fix handling of MESA_FORMAT_L8A8_SRGB for big-endian

2014-07-22 Thread Richard Sandiford
Luminance is the least-significant byte of the uint16, rather than the lowest byte in memory. Other parts of mesa already handle this correctly for big-endian, and swrast already handles other MESA_FORMAT_x8y8 formats correctly. This case was just an odd-one-out. Signed-off-by: Richard

[Mesa-dev] [PATCH v2 4/5] mesa: Add MESA_FORMAT_A8L8_{SNORM,SRGB}

2014-07-22 Thread Richard Sandiford
The associated UNORM format already existed. This means that each LnAn format has a reversed counterpart, which is necessary for handling big-endian mesa-gallium mappings. Signed-off-by: Richard Sandiford rsand...@linux.vnet.ibm.com --- src/mesa/drivers/dri/i965/brw_surface_formats.c | 2 ++

[Mesa-dev] [PATCH v2 0/5] Fix handling of LnAn and RnGn formats for big-endian

2014-07-22 Thread Richard Sandiford
MESA_FORMAT_LnAn_* puts the luminance in the low part of the integer and the alpha in the high part. The same goes for MESA_FORMAT_RnGn with the red and green channels. This series fixes gallium to be consistent with that layout on big-endian. Following the convention established last year,

[Mesa-dev] [PATCH v2 2/5] util: Add PIPE_FORMAT_AnLn and PIPE_FORMAT_GnRn formats

2014-07-22 Thread Richard Sandiford
...i.e. formats in which the alpha or green channel is first in memory. This means that each LnAn and RnGn format has a reversed counterpart, which is necessary for handling big-endian mesa-gallium mappings. Signed-off-by: Richard Sandiford rsand...@linux.vnet.ibm.com ---

[Mesa-dev] [PATCH v2 5/5] st/mesa: Fix handling of LA and RG formats for big-endian

2014-07-22 Thread Richard Sandiford
MESA_FORMAT_LnAn puts the luminance in the least significant part of the containing integer, which is equivalent to PIPE_FORMAT_LAnn. PIPE_FORMAT_LnAn puts the luminance first in memory. This patch fixes up the mesa-gallium mapping accordingly. Signed-off-by: Richard Sandiford

[Mesa-dev] [PATCH v2 3/5] util: Define PIPE_FORMAT_{LA, AL, RG, GR}nn aliases

2014-07-22 Thread Richard Sandiford
...i.e. formats in which the first listed component is in the least significant half of the integer. Signed-off-by: Richard Sandiford rsand...@linux.vnet.ibm.com --- src/gallium/include/pipe/p_format.h | 32 1 file changed, 32 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 10/17] i965/gen6 fbo: make unmatched depth/stencil configs return unsupported

2014-07-22 Thread Pohjolainen, Topi
On Fri, Jul 18, 2014 at 02:16:45PM -0700, Jordan Justen wrote: (f3c886b for gen6) Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/drivers/dri/i965/intel_fbo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_fbo.c

[Mesa-dev] [Bug 79949] [DRI3] GTK+ Programs Not Updating Correctly

2014-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79949 drag...@gmail.com changed: What|Removed |Added Status|NEW |NEEDINFO CC|

[Mesa-dev] [PATCH v2 7/7] st/mesa: Fix handling of 8888 SNORM and SRGB formats for big-endian

2014-07-22 Thread Richard Sandiford
MESA_FORMAT_x8y8z8w8 puts the x channel in the least significant part of the containing 32-bit integer, which is equivalent to PIPE_FORMAT_xyzw. PIPE_FORMAT_x8y8z8w8 puts the x channel first in memory. This patch fixes up the mesa-gallium mapping accordingly. Signed-off-by: Richard Sandiford

[Mesa-dev] [PATCH v2 0/7] Fix handling of 8-bits-per-channel SRGB and SNORM formats

2014-07-22 Thread Richard Sandiford
Similar to the L/A and R/G series I just posted, this one fixes the SNORM and SRGB formats. The UNORM ones were done last year as part of the original big-endian work. v2, with subject lines fixed to include the component: bit. No code changes from v1. Richard Sandiford (7): util:

[Mesa-dev] [PATCH v2 3/7] mesa: Tweak unpack name for MESA_FORMAT_R8G8B8X8_SNORM

2014-07-22 Thread Richard Sandiford
MESA_FORMAT_R8G8B8X8_SNORM used a function called unpack_X8B8G8R8_SNORM while MESA_FORMAT_R8G8B8X8_SRGB used a function called unpack_R8G8B8X8_SRGB. This patch renames the SNORM function to have the same order as the MESA_FORMAT name, like the SRGB function does. Signed-off-by: Richard Sandiford

[Mesa-dev] [PATCH v2 6/7] mesa: Add MESA_FORMAT_{A8R8G8B8, X8R8G8B8, X8B8G8R8}_SRGB

2014-07-22 Thread Richard Sandiford
This means that each SRGB format has a reversed counterpart, which is necessary for handling big-endian mesa-gallium mappings. Signed-off-by: Richard Sandiford rsand...@linux.vnet.ibm.com --- src/mesa/drivers/dri/i965/brw_surface_formats.c | 1 + src/mesa/main/format_pack.c

[Mesa-dev] [PATCH v2 2/7] util: Define PIPE_FORMAT_xyzw8888_{SNORM, SRGB} aliases

2014-07-22 Thread Richard Sandiford
...i.e. formats in which the first listed component is in the least significant byte of the integer. The corresponding UNORM aliases already exist. Signed-off-by: Richard Sandiford rsand...@linux.vnet.ibm.com --- src/gallium/include/pipe/p_format.h | 24 1 file changed,

[Mesa-dev] [PATCH v2 1/7] util: Add PIPE_FORMAT_x8B8G8R8_SNORM formats

2014-07-22 Thread Richard Sandiford
This means that each RnGnBnxn format has a reversed counterpart, which is necessary for handling big-endian mesa-gallium mappings. The associated UNORM and SRGB formats already exist. Signed-off-by: Richard Sandiford rsand...@linux.vnet.ibm.com --- src/gallium/auxiliary/util/u_format.csv | 3 +++

[Mesa-dev] [PATCH v2 5/7] mesa: Fix _mesa_texstore_signed_rgb?8888 for big-endian.

2014-07-22 Thread Richard Sandiford
MESA_FORMAT_x8y8z8w8 means a format in which x is the least signficant byte and w is the most significant byte. Most functions get that right, but the signed ones access the bytes from an array rather than an integer, so they need to take endianness into account. This isn't too onerous since

[Mesa-dev] [PATCH v2 4/7] mesa: Fix alpha component in unpack_R8G8B8X8_SRGB.

2014-07-22 Thread Richard Sandiford
The function was using the X component as the alpha channel, rather than setting alpha to 1.0. Signed-off-by: Richard Sandiford rsand...@linux.vnet.ibm.com --- src/mesa/main/format_unpack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/format_unpack.c

Re: [Mesa-dev] [PATCH 11/17] i965/gen6 depth surface: program 3DSTATE_DEPTH_BUFFER to top of surface

2014-07-22 Thread Pohjolainen, Topi
On Fri, Jul 18, 2014 at 02:16:46PM -0700, Jordan Justen wrote: (bf25ee2 for gen6) Previously we would always find the 2D sub-surface of interest, and then program the surface to this location. Now we always program the 3DSTATE_DEPTH_BUFFER at the start of the surface. To select the

[Mesa-dev] [Bug 79949] [DRI3] GTK+ Programs Not Updating Correctly

2014-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79949 --- Comment #10 from Joseph Booker j...@neoturbine.net --- (In reply to comment #9) This is the same as bug 81551 ... can you test Chris's patch and confirm whether it works or not? This fixes it. No graphical problems scrolling in Firefox or

[Mesa-dev] [Bug 79949] [DRI3] GTK+ Programs Not Updating Correctly

2014-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79949 Alex Deucher ag...@yahoo.com changed: What|Removed |Added Status|NEEDINFO|RESOLVED

Re: [Mesa-dev] [PATCH] util: Fix fallback iround handling of integral inputs

2014-07-22 Thread Roland Scheidegger
Am 22.07.2014 12:26, schrieb Richard Sandiford: Roland Scheidegger srol...@vmware.com writes: Am 21.07.2014 17:53, schrieb Richard Sandiford: lp_build_iround has a fallback case that tries to emulate a round-to-nearest float-int conversion by adding 0.5 and using a truncating fptosi. For odd

[Mesa-dev] Doubt about Streamed Vertex Buffer Write message descriptor in SandyBridge

2014-07-22 Thread Samuel Iglesias Gonsálvez
Hello, I have a doubt related to Streamed Vertex Buffer Write message and its message descriptor in SandyBridge. Reading about Stream Output Primitives Written (snb_ihd_os_vol2_part1.pdf, pag 175), it says the following: Whenever a GS thread outputs a DataPort Streamed Vertex Buffer Write

Re: [Mesa-dev] Doubt about Streamed Vertex Buffer Write message descriptor in SandyBridge

2014-07-22 Thread Ilia Mirkin
On Tue, Jul 22, 2014 at 11:25 AM, Samuel Iglesias Gonsálvez sigles...@igalia.com wrote: Hello, I have a doubt related to Streamed Vertex Buffer Write message and its message descriptor in SandyBridge. Reading about Stream Output Primitives Written (snb_ihd_os_vol2_part1.pdf, pag 175), it

Re: [Mesa-dev] [PATCH v2 1/7] util: Add PIPE_FORMAT_x8B8G8R8_SNORM formats

2014-07-22 Thread Roland Scheidegger
Am 22.07.2014 12:02, schrieb Richard Sandiford: This means that each RnGnBnxn format has a reversed counterpart, which is necessary for handling big-endian mesa-gallium mappings. The associated UNORM and SRGB formats already exist. Signed-off-by: Richard Sandiford rsand...@linux.vnet.ibm.com

Re: [Mesa-dev] [PATCH 03/16] glsl: Use constant_expression_value instead of as_constant

2014-07-22 Thread Ian Romanick
On 07/21/2014 03:39 PM, Matt Turner wrote: On Mon, Jul 21, 2014 at 2:04 PM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com Just a few lines earlier we may have wrapped the index expression with ir_unop_i2u expression. Whenever that happens, as_constant

Re: [Mesa-dev] [PATCH 15/16] glsl: Correctly determine when the field of a UBO is row-major

2014-07-22 Thread Ian Romanick
On 07/21/2014 03:28 PM, Matt Turner wrote: On Mon, Jul 21, 2014 at 2:04 PM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com Previously if a field of an block with an instance name was marked row-major (but block itself was not), we would think the field

Re: [Mesa-dev] [PATCH 15/16] glsl: Correctly determine when the field of a UBO is row-major

2014-07-22 Thread Ian Romanick
On 07/21/2014 03:35 PM, Matt Turner wrote: On Mon, Jul 21, 2014 at 3:28 PM, Matt Turner matts...@gmail.com wrote: On Mon, Jul 21, 2014 at 2:04 PM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com Previously if a field of an block with an instance name was

Re: [Mesa-dev] [PATCH 14/17] i965: Support non_mip_arrays for multiple miplevels

2014-07-22 Thread Pohjolainen, Topi
On Fri, Jul 18, 2014 at 02:16:49PM -0700, Jordan Justen wrote: Previously array spacing lod0 was only used with a single mip level. It indicated that no mip level spacing should be used between array slices. gen6 separate stencil hiz only support LOD0, so we need to allocate the miptree

Re: [Mesa-dev] [PATCH 16/17] i965/gen6: Stencil/hiz needs an offset for LOD 0

2014-07-22 Thread Pohjolainen, Topi
On Fri, Jul 18, 2014 at 02:16:51PM -0700, Jordan Justen wrote: Since gen6 separate stencil hiz only supports LOD0, we need to program an offset to the LOD when emitting the separate stencil/hiz. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com ---

Re: [Mesa-dev] [PATCH 15/17] i965/gen6: Force tile alignment for each stencil/hiz LOD

2014-07-22 Thread Pohjolainen, Topi
On Fri, Jul 18, 2014 at 02:16:50PM -0700, Jordan Justen wrote: Gen6 doesn't support multiple miplevels for hiz and stencil. Therefore, we must point to the LOD directly during rendering. But, we also have removed the tile offsets from normal depth surfaces, so we need to align each LOD to

Re: [Mesa-dev] [PATCH 17/17] i965/gen6: Force non_mip_arrays for separate stencil/hiz

2014-07-22 Thread Pohjolainen, Topi
On Fri, Jul 18, 2014 at 02:16:52PM -0700, Jordan Justen wrote: For gen6 we will use non-mipmapped array spacing, but with multiple mip levels. This is needed because gen6 hiz and separate stencil only support a single mip-level. PRM Volume 1, Part 1, 7.18.3.7.2 For separate stencil buffer

Re: [Mesa-dev] [PATCH 12/17] i965: Rename array_spacing_lod0 to non_mip_arrays

2014-07-22 Thread Pohjolainen, Topi
On Fri, Jul 18, 2014 at 02:16:47PM -0700, Jordan Justen wrote: Generalize the name array_spacing_lod0 to non_mip_arrays. Previously it was only used in certain cases where only a single mip-level was used. For gen6 we will use non-mipmapped array spacing, but with multiple mip levels. This

Re: [Mesa-dev] [PATCH v4 0/3] Software rendering in EGL-DRM

2014-07-22 Thread Emil Velikov
On 22/07/14 18:41, Giovanni Campagna wrote: On Mon, Jul 21, 2014 at 9:54 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 21/07/14 17:02, Giovanni Campagna wrote: On Mon, Jul 21, 2014 at 12:47 PM, Emil Velikov emil.l.veli...@gmail.com wrote: Giovanni can you test the series that I've

[Mesa-dev] [PATCH v2] gbm: Replace GBM_DRIVERS_PATH with LIBGL_DRIVERS_PATH

2014-07-22 Thread Dylan Baker
GBM_DRIVERS_PATH is not documented, and only used to set the location of gbm drivers, while LIBGL_DRIVERS_PATH is used for everything else, and is documented. Generally this split leads to confusion as to why gbm doesn't work. This patch makes LIBGL_DRIVERS_PATH the main variable, but uses

[Mesa-dev] [PATCH 6/6] swrast: Enable GL_ARB_texture_compression_bptc

2014-07-22 Thread Neil Roberts
Enables BPTC texture compression on the software rasterizer. --- src/mesa/main/extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index 2db27f4..154c1cd 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa/main/extensions.c

[Mesa-dev] [PATCH 3/6] Add texel fetch functions for BPTC-compressed textures

2014-07-22 Thread Neil Roberts
Adds functions to fetch from any of the four BPTC-compressed formats. --- src/mesa/Makefile.sources| 1 + src/mesa/main/texcompress.c | 6 + src/mesa/main/texcompress_bptc.c | 958 +++ src/mesa/main/texcompress_bptc.h | 34 ++ 4 files changed,

[Mesa-dev] [PATCH 0/6] Add support for BPTC texture compression

2014-07-22 Thread Neil Roberts
Here's a first attempt at a patch series to implement BPTC texture compression in the i965 driver on Gen=7. Getting it to work on the hardware is pretty trivial as it's just a case of adding some new Mesa format enums and then plugging them together with the right Intel surface type. However GL

[Mesa-dev] [PATCH 5/6] i965: Enable the GL_ARB_texture_compression_bptc extension

2014-07-22 Thread Neil Roberts
Enables the BPTC extension on Gen=7 and adds the necessary format mappings to get the right surface type value. --- src/mesa/drivers/dri/i965/brw_surface_formats.c | 5 + src/mesa/drivers/dri/i965/intel_extensions.c| 2 ++ 2 files changed, 7 insertions(+) diff --git

[Mesa-dev] [PATCH 1/6] Add the GL_ARB_texture_compression_bptc extension

2014-07-22 Thread Neil Roberts
This adds a boolean in the gl_extensions struct for GL_ARB_texture_compression_bptc as well as an entry in extension_table. --- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/extensions.c

[Mesa-dev] [PATCH 2/6] Add the format enums for BPTC-compressed images

2014-07-22 Thread Neil Roberts
This adds the following four Mesa image format enums which correspond to the four BPTC compressed texture formats: MESA_FORMAT_BPTC_RGBA_UNORM MESA_FORMAT_BPTC_SRGB_ALPHA_UNORM MESA_FORMAT_BPTC_RGB_SIGNED_FLOAT MESA_FORMAT_BPTC_RGB_UNSIGNED_FLOAT It also updates the format information

[Mesa-dev] [PATCH 4/6] Add texstore functions for BPTC-compressed textures

2014-07-22 Thread Neil Roberts
This adds compressors for all four of the BPTC compressed-texture formats. For the RGB and SRGB normalized BPTC textures it works by first compressing each 4x4 block using the existing DXT3 compressor and then converting it to a BPTC block. The BPTC block loses one bit of information on the green

Re: [Mesa-dev] [PATCH 5/6] i965: Enable the GL_ARB_texture_compression_bptc extension

2014-07-22 Thread Ilia Mirkin
On Tue, Jul 22, 2014 at 3:10 PM, Neil Roberts n...@linux.intel.com wrote: Enables the BPTC extension on Gen=7 and adds the necessary format mappings to get the right surface type value. --- src/mesa/drivers/dri/i965/brw_surface_formats.c | 5 +

Re: [Mesa-dev] [PATCH v2] gbm: Replace GBM_DRIVERS_PATH with LIBGL_DRIVERS_PATH

2014-07-22 Thread Jordan Justen
Reviewed-by: Jordan Justen jordan.l.jus...@intel.com On Tue, Jul 22, 2014 at 11:43 AM, Dylan Baker baker.dyla...@gmail.com wrote: GBM_DRIVERS_PATH is not documented, and only used to set the location of gbm drivers, while LIBGL_DRIVERS_PATH is used for everything else, and is documented.

Re: [Mesa-dev] [PATCH v2] gbm: Replace GBM_DRIVERS_PATH with LIBGL_DRIVERS_PATH

2014-07-22 Thread Kristian Høgsberg
On Tue, Jul 22, 2014 at 11:43 AM, Dylan Baker baker.dyla...@gmail.com wrote: GBM_DRIVERS_PATH is not documented, and only used to set the location of gbm drivers, while LIBGL_DRIVERS_PATH is used for everything else, and is documented. Generally this split leads to confusion as to why gbm

[Mesa-dev] [PATCH 2/7] glsl/glsl_parser.yy: vs12 doesn't have strcasecmp, use _stricmp instead

2014-07-22 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- src/glsl/glsl_parser.yy | 4 1 file changed, 4 insertions(+) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy index faaf438..25370cd 100644 --- a/src/glsl/glsl_parser.yy +++ b/src/glsl/glsl_parser.yy @@ -26,6 +26,10 @@ #include

[Mesa-dev] [PATCH 4/7] u_math.h: fix 64 to 32 bit truncation warning

2014-07-22 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- This file is common so this warning comes up a lot. src/gallium/auxiliary/util/u_math.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_math.h b/src/gallium/auxiliary/util/u_math.h index

[Mesa-dev] [PATCH 3/7] gallium/u_debug_flush.c: fix build error for vs12

2014-07-22 Thread Alon Levy
use util_snprintf that is already defined in other systems by u_string.h to as snprintf, so to not change behavior in other systems. Signed-off-by: Alon Levy al...@redhat.com --- src/gallium/auxiliary/util/u_debug_flush.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 0/7] vs12 cleanup patches

2014-07-22 Thread Alon Levy
Hi, These patches include some actual fixes for building target libgl-gdi with scons, and some warning removal (there are a ton left I didn't pursue - mostly truncation warnings and sign warnings). Not related to the patchset, but important for anyone building libgl-gdi (i.e. opengl32.dll)

[Mesa-dev] [PATCH 1/7] gallium/u_math.h: don't redefine INFINITY and NAN in VS2013

2014-07-22 Thread Alon Levy
Under VS2013 compiler that is distinguished by _MSC_VER of 1800 those two are already defined, use the SDK definition. Another option would have been to undef and use the definitions here - I'm not sure which is better. --- This removes warnings, this patch is not actually required to build.

[Mesa-dev] [PATCH 6/7] glsl: fix inconsistent struct/class warning in vs12

2014-07-22 Thread Alon Levy
Remove incorrect struct prefix, ir_variable is a class Signed-off-by: Alon Levy al...@redhat.com --- src/glsl/opt_dead_builtin_varyings.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/opt_dead_builtin_varyings.cpp b/src/glsl/opt_dead_builtin_varyings.cpp index

[Mesa-dev] [PATCH 5/7] wgl: stw_pixelformat_get_info: correct type for index variable

2014-07-22 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- src/gallium/state_trackers/wgl/stw_pixelformat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/wgl/stw_pixelformat.c b/src/gallium/state_trackers/wgl/stw_pixelformat.c index 1ef302d..7e5561b 100644 ---

[Mesa-dev] [PATCH 7/7] mesa/shaderimage.c: fix inconsistent sign warning

2014-07-22 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- src/mesa/main/shaderimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/shaderimage.c b/src/mesa/main/shaderimage.c index d1e752d..298ede2 100644 --- a/src/mesa/main/shaderimage.c +++ b/src/mesa/main/shaderimage.c

Re: [Mesa-dev] [PATCH 12/17] i965: Rename array_spacing_lod0 to non_mip_arrays

2014-07-22 Thread Jordan Justen
On Tue, Jul 22, 2014 at 11:14 AM, Pohjolainen, Topi topi.pohjolai...@intel.com wrote: On Fri, Jul 18, 2014 at 02:16:47PM -0700, Jordan Justen wrote: Generalize the name array_spacing_lod0 to non_mip_arrays. Previously it was only used in certain cases where only a single mip-level was used.

[Mesa-dev] [PATCH] docs/GL3.txt: put ARB_compute_shader back to undone.

2014-07-22 Thread Dave Airlie
It appears Paul isn't working on this. Signed-off-by: Dave Airlie airl...@redhat.com --- docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 0f37da4..9a80fca 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -157,7 +157,7 @@ GL 4.3:

Re: [Mesa-dev] [PATCH 4/6] Add texstore functions for BPTC-compressed textures

2014-07-22 Thread Ilia Mirkin
On Tue, Jul 22, 2014 at 3:09 PM, Neil Roberts n...@linux.intel.com wrote: This adds compressors for all four of the BPTC compressed-texture formats. For the RGB and SRGB normalized BPTC textures it works by first compressing each 4x4 block using the existing DXT3 compressor and then converting

Re: [Mesa-dev] [PATCH] docs/GL3.txt: put ARB_compute_shader back to undone.

2014-07-22 Thread Chris Forbes
It's still started though -- there's a partial implementation in master. On Wed, Jul 23, 2014 at 10:30 AM, Dave Airlie airl...@gmail.com wrote: It appears Paul isn't working on this. Signed-off-by: Dave Airlie airl...@redhat.com --- docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Mesa-dev] [PATCH] Add an accelerated version of F_TO_I for x86_64

2014-07-22 Thread Jason Ekstrand
On Mon, Jul 21, 2014 at 5:29 PM, Matt Turner matts...@gmail.com wrote: On Mon, Jul 21, 2014 at 5:16 PM, Jason Ekstrand ja...@jlekstrand.net wrote: Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/imports.h | 4 1 file changed, 4 insertions(+) diff --git

[Mesa-dev] [PATCH 2/4] softpipe, llvmpipe: mark BPTC formats as unsupported

2014-07-22 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/llvmpipe/lp_screen.c | 5 + src/gallium/drivers/softpipe/sp_screen.c | 5 + 2 files changed, 10 insertions(+) diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c b/src/gallium/drivers/llvmpipe/lp_screen.c index

[Mesa-dev] [PATCH 3/4] mesa/st: add BPTC formats, expose ARB_texture_compression_bptc

2014-07-22 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- This trivially depends on Neil's patches which add the mesa/core bits. src/mesa/state_tracker/st_extensions.c | 6 ++ src/mesa/state_tracker/st_format.c | 36 ++ 2 files changed, 42 insertions(+) diff

[Mesa-dev] [PATCH 1/4] gallium: add basic support for BPTC formats

2014-07-22 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- So... the pack/unpack functions just assert. As far as I can tell, these are entirely unused until e.g. softpipe or llvmpipe try to make use of this format. Whoever adds bptc texturing support to those drivers can add the mesa/texstore

[Mesa-dev] [PATCH 4/4] nvc0: add BPTC format support

2014-07-22 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- Confusing, but nvc0_formats.c #includes nv50_formats.c. src/gallium/drivers/nouveau/nv50/nv50_formats.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_formats.c

Re: [Mesa-dev] [PATCH v4 0/3] Software rendering in EGL-DRM

2014-07-22 Thread Giovanni Campagna
On Mon, Jul 21, 2014 at 9:54 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 21/07/14 17:02, Giovanni Campagna wrote: On Mon, Jul 21, 2014 at 12:47 PM, Emil Velikov emil.l.veli...@gmail.com wrote: Giovanni can you test the series that I've not butchered anything else during the rebase

Re: [Mesa-dev] Doubt about Streamed Vertex Buffer Write message descriptor in SandyBridge

2014-07-22 Thread Kenneth Graunke
On Tuesday, July 22, 2014 11:38:05 AM Ilia Mirkin wrote: On Tue, Jul 22, 2014 at 11:25 AM, Samuel Iglesias Gonsálvez sigles...@igalia.com wrote: Hello, I have a doubt related to Streamed Vertex Buffer Write message and its message descriptor in SandyBridge. Reading about Stream

[Mesa-dev] [PATCH] Add an accelerated version of F_TO_I for x86_64

2014-07-22 Thread Jason Ekstrand
According to a quick micro-benchmark, this new version is 20% faster on my Haswell laptop. v2: Removed the XXX note about x86_64 from the comment Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/imports.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

Re: [Mesa-dev] [PATCH 0/5] radeon: Write-combined CPU mappings of BOs in GTT

2014-07-22 Thread Michel Dänzer
On 21.07.2014 17:07, Christian König wrote: Am 19.07.2014 03:15, schrieb Michel Dänzer: On 19.07.2014 00:47, Christian König wrote: Am 18.07.2014 05:07, schrieb Michel Dänzer: [PATCH 5/5] drm/radeon: Use VRAM for indirect buffers on = SI I'm still not very keen with this change since I still