Reviewed-by: Bas Nieuwenhuizen
On Tue, Feb 14, 2017, at 07:25, Dave Airlie wrote:
> From: Dave Airlie
>
> Just one bonaire fix.
>
> Signed-off-by: Dave Airlie
> ---
> src/amd/vulkan/si_cmd_buffer.c | 11 +--
> 1 file changed, 9 insertions(+), 2 deletions(-)
&
s(struct radv_cmd_buffer
> *cmd_buffer,
> }
>
> static void
> -radv_cmd_buffer_flush_state(struct radv_cmd_buffer *cmd_buffer)
> +radv_cmd_buffer_flush_state(struct radv_cmd_buffer *cmd_buffer, bool
> instanced_or_indirect_draw, uint32_t count)
> {
Rename count to vertex_count or
r-b for now.
On Wed, Feb 15, 2017, at 01:16, Dave Airlie wrote:
> From: Dave Airlie
>
> This is possibly a bad idea, I might have to consider a better one.
>
> Signed-off-by: Dave Airlie
> ---
> src/amd/vulkan/radv_cmd_buffer.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/amd
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_device.c | 2 +-
src/amd/vulkan/radv_pipeline.c | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 1132eeb52d7..9185ef16dc0 100644
--- a/src/amd
Signed-off-by: Bas Nieuwenhuizen
---
src/compiler/spirv/nir_spirv.h| 1 +
src/compiler/spirv/spirv_to_nir.c | 5 -
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/compiler/spirv/nir_spirv.h b/src/compiler/spirv/nir_spirv.h
index e43e9b53825..8864a8f73d7 100644
--- a/src
No regressions on CTS 1.0.2 mustpass, though I don't think there are
tests for these extensions. I checked there were no references to the
format in the nir->LLVM conversion though.
Bas Nieuwenhuizen (3):
radv: Add support for shaderStorageImageWriteWithoutFormat.
spirv: Add sup
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_device.c | 2 +-
src/amd/vulkan/radv_pipeline.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 9185ef16dc0..be0d9d933fc 100644
--- a/src/amd/vulkan
Reviewed-by: Bas Nieuwenhuizen
On Wed, Feb 15, 2017, at 03:28, Dave Airlie wrote:
> From: Dave Airlie
>
> This is used in DOOM, so provide the fast clear path for it.
>
> Signed-off-by: Dave Airlie
> ---
> src/amd/vulkan/radv_formats.c | 5 +
> 1 file changed, 5
On Wed, Feb 15, 2017, at 09:43, Dave Airlie wrote:
> From: Dave Airlie
>
> zero extend ->u64 and sign extend ->i64.
>
> Signed-off-by: Dave Airlie
> ---
> src/amd/common/ac_nir_to_llvm.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/src/amd/common/ac_nir_to_llvm.c
> b/src/
This one only keeps allocated memory in the list, and list nodes
in the descriptor sets. Thsi doesn't need messing around with
max_sets, and we get automatic merging of free regions.
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_descriptor_set.c
We only use the freed ones after all free space has been used. If
the app only allocates small descriptor sets, we might go over
max_sets before the memory is full.
Signed-off-by: Bas Nieuwenhuizen
CC:
Fixes: f4e499ec79147f4172f3669ae9dafd941aaeeb65
---
src/amd/vulkan/radv_descriptor_set.c | 7
Even though the preferred stance is not to fix incorrect applications
via the driver, this prevents some nasty GPU hangs.
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_device.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/src/amd/vulkan
I assume this wants to check if all pipelines use the same SGPR for
the rings.
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_cmd_buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index
Reviewed-by: Bas Nieuwenhuizen
On Sun, Feb 19, 2017 at 7:38 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> This fixes:
> dEQP-VK.renderpass.formats.a2b10g10r10_unorm_pack32*
> regressions.
>
> Signed-off-by: Dave Airlie
> ---
> src/amd/vulkan/radv_formats.c
Series is
Reviewed-by: Bas Nieuwenhuizen
On Sun, Feb 19, 2017 at 7:33 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> This iterates the fast clear flush across the layers in the
> specified range.
>
> It also moves the compute resolve flush into the function
> and buil
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_meta_fast_clear.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/amd/vulkan/radv_meta_fast_clear.c
b/src/amd/vulkan/radv_meta_fast_clear.c
index 0902c455037..ffaa9a3d5e8 100644
--- a/src/amd/vulkan
On Sun, Feb 19, 2017 at 9:56 PM, Dave Airlie wrote:
> From: Dave Airlie
>
> physical devices can be enumerated multiple time per instance,
> this was causing the realloc to be hit for no reason, and
> the CTS allocation verification would get angry.
We only do the radv_physical_device_init on th
Reviewed-by: Bas Nieuwenhuizen
On Sun, Feb 19, 2017 at 11:48 PM, Dave Airlie wrote:
> From: Dave Airlie
>
> This just keeps popping up minor problems and regressions we should
> revisit in a more sustainable manner later.
>
> This also reverts:
> Revert "radv: qu
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_device.c | 224 +
src/amd/vulkan/radv_private.h | 12 ++-
src/amd/vulkan/si_cmd_buffer.c | 2 +-
3 files changed, 148 insertions(+), 90 deletions(-)
diff --git a/src/amd/vulkan/radv_device.c b
The preamble flushes now and the rest is the responsibility of the app.
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_cmd_buffer.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 5aea0e9de4b
So that we can use it without a cmd_buffer.
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/si_cmd_buffer.c | 141 ++---
1 file changed, 77 insertions(+), 64 deletions(-)
diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_buffer.c
index
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_device.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 7900ece9c89..4ec62a73585 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
For flushing we don't want to flush every third IB.
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_device.c | 6 +++---
src/amd/vulkan/radv_radeon_winsys.h | 3 ++-
src/amd/vulkan/radv_wsi.c | 2 +-
src/amd/vulkan/winsys/a
On Wed, Feb 22, 2017 at 5:31 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> This follows the txf_ms code, I can't figure out why amdgpu-pro
> doesn't do this in their shaders, they must know someone we don't.
>
> This fixes:
> dEQP-VK.pipeline.multisample_shader_builtin.sample_id.*
>
> Signed-off
Series is:
Reviewed-by: Bas Nieuwenhuizen
On Tue, Feb 21, 2017 at 5:14 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> This fixes up the clip distance passing between the geometry
> shader and the copy shader. It packs the clip and cull distances
> into one or two consecutive sl
For the series:
Reviewed-by: Bas Nieuwenhuizen
On Thu, Feb 23, 2017 at 7:09 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> This adds support to write to sample mask from the fragment shader.
>
> We can optimise this later like radeonsi.
>
> Signed-off-by: Dave Airlie
&g
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/common/ac_nir_to_llvm.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index 9778581a1ef..4f3d689db7e 100644
--- a/src/amd/common/ac_nir_to_llvm.c
+++ b/src/amd
Otherwise if the new compute pipeline is the same as the last used
pipeline before the call, we don't emit it again.
Signed-off-by: Bas Nieuwenhuizen
Cc: 13.0 17.0
---
src/amd/vulkan/radv_cmd_buffer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/amd/vulkan/radv_cmd_buffer.c
Per spec, VK_QUERY_RESULT_64_BIT specifies the integer size and the
availability flag is an integer. We apparently handled this correctly
already for the copy to buffer case.
Signed-off-by: Bas Nieuwenhuizen
Cc: 13.0 17.0
---
src/amd/vulkan/radv_query.c | 7 +--
1 file changed, 5
unitialized value is
better than a hang.
Signed-off-by: Bas Nieuwenhuizen
Cc: 13.0 17.0
---
src/amd/vulkan/radv_query.c | 65 +++--
1 file changed, 45 insertions(+), 20 deletions(-)
diff --git a/src/amd/vulkan/radv_query.c b/src/amd/vulkan/radv_query.c
Reviewed-by: Bas Nieuwenhuizen
On Mon, Feb 27, 2017 at 8:00 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> For blitting we need to use the depth or stencil format, never
> the combined.
>
> This fixes:
> dEQP-VK.texture.shadow.2d.nearest.less_or_equal_d32_sfloat_s8_ui
Reviewed-by: Bas Nieuwenhuizen
On Mon, Feb 27, 2017 at 3:15 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> These formats are used by some CTS tests, may as well fill them in.
>
> Signed-off-by: Dave Airlie
> ---
> src/amd/vulkan/radv_formats.c | 16
We can then use constants for indexed loads.
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_descriptor_set.c | 5 +
src/amd/vulkan/radv_descriptor_set.h | 1 +
2 files changed, 6 insertions(+)
diff --git a/src/amd/vulkan/radv_descriptor_set.c
b/src/amd/vulkan
So we don't need to know about radv_sampler in ac_nir_to_llvm.
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_descriptor_set.c | 14 +-
src/amd/vulkan/radv_descriptor_set.h | 2 +-
2 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/src/amd/v
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_descriptor_set.c | 23 ++-
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/src/amd/vulkan/radv_descriptor_set.c
b/src/amd/vulkan/radv_descriptor_set.c
index d8399574f2a..ca5b28090b9 100644
--- a/src/amd
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/common/ac_nir_to_llvm.c | 16
1 file changed, 16 insertions(+)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index 4f3d689db7e..db7194c3086 100644
--- a/src/amd/common/ac_nir_to_llvm.c
+++ b/src/amd
I don't think the "gallium:" commit message prefix is correct here.
Looking at the logs it should be "r600g/sb:".
With that change:
Reviewed-by: Bas Nieuwenhuizen
Do you need someone to push it for you?
- Bas
On Fri, Sep 16, 2016 at 4:58 PM, Martina Kollarova
wro
On Fri, Sep 16, 2016 at 3:57 PM, Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> These functions extract the pipe state structure from the current
> descriptors, for state saving.
> ---
> src/gallium/drivers/radeonsi/si_descriptors.c | 46
> +++
> src/gallium/drivers/ra
On Wed, Sep 28, 2016 at 6:27 PM, Nicolai Hähnle wrote:
> On 28.09.2016 16:20, Ilia Mirkin wrote:
>>
>> On Wed, Sep 28, 2016 at 6:25 AM, Nicolai Hähnle
>> wrote:
>>>
>>> From: Nicolai Hähnle
>>>
>>> The difference to the virtually identical ARB_robustness (which is
>>> already
>>> enabled uncondi
On Thu, Sep 29, 2016 at 10:20 AM, Nicolai Hähnle wrote:
> On 29.09.2016 00:00, Bas Nieuwenhuizen wrote:
>>
>> On Wed, Sep 28, 2016 at 6:27 PM, Nicolai Hähnle
>> wrote:
>>>
>>> On 28.09.2016 16:20, Ilia Mirkin wrote:
>>>>
>>>>
&
On Fri, Sep 30, 2016 at 2:13 PM, Marek Olšák wrote:
> intptr_t reads and writes aren't atomic. p_atomic_set and
> p_atomic_read functions don't do anything for atomicity. See:
>
> #define p_atomic_set(_v, _i) (*(_v) = (_i))
> #define p_atomic_read(_v) (*(_v))
That implementation seems bogus to me
On Fri, Sep 30, 2016 at 3:31 AM, Dave Airlie wrote:
> On 30 September 2016 at 01:07, Jason Ekstrand wrote:
>> On Sep 29, 2016 7:56 AM, "Emil Velikov" wrote:
>>>
>>> On 28 September 2016 at 19:53, Marek Olšák wrote:
>>> > Hi,
>>> >
>>> > It's been almost 4 months since the 12.0 branch was create
The issue Gustaw referred to is probably the cause of configure not
giving an error about it. If you want to be sure this is handled
right, also enable radeonsi to be build.
Yours sincerely,
Bas Nieuwenhuizen
On Sat, Oct 1, 2016 at 2:23 PM, Limeth wrote:
> Hello,
> I decided to try out the work
On Thu, Oct 6, 2016 at 1:09 AM, Gustaw Smolarczyk wrote:
> It's supposed to be how much at least we want to grow the cs, not the
> minimum size of the cs after growth.
> ---
> src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/
continue;
>
> + if (!fence->submitted)
> + return VK_TIMEOUT;
> +
Reviewed-by: Bas Nieuwenhuizen
> expired = device->ws->fence_wait(device->ws, fence->fence,
> tr
Hi Gustaw,
The patch is
reviewed-by: Bas Nieuwenhuizen
What needs to be done too, is checking if the resulting IB becomes too
large in the SI case, and handling that gracefully. I don't care if
that happens with this patch, or if someone writes a follow up patch
though
Yours sincerely
On Tue, Oct 11, 2016 at 2:42 AM, Dave Airlie wrote:
> On 11 October 2016 at 05:50, Dave Airlie wrote:
>> On 10 October 2016 at 21:45, Arsenault, Matthew
>> wrote:
>>> I don't like adding explicit IR arguments for ABI arguments, especially this
>>> one. Adding a special case for the first index f
On Tue, Oct 11, 2016 at 11:14 PM, Bas Nieuwenhuizen
wrote:
> On Tue, Oct 11, 2016 at 2:42 AM, Dave Airlie wrote:
>> On 11 October 2016 at 05:50, Dave Airlie wrote:
>>> On 10 October 2016 at 21:45, Arsenault, Matthew
>>> wrote:
>>>> I don't like ad
with
single negative. With that, patch 2-5 are
Acked-by: Bas Nieuwenhuizen
>
> Signed-off-by: Emil Velikov
> ---
> src/amd/Makefile.addrlib.am | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/amd/Makefile.addrlib.am b/src/amd/Makefile.addrlib.am
> index 434
On Mon, Oct 10, 2016 at 9:19 PM, Gustaw Smolarczyk wrote:
> 2016-10-10 22:04 GMT+02:00 Bas Nieuwenhuizen :
>> Hi Gustaw,
>>
>> The patch is
>> reviewed-by: Bas Nieuwenhuizen
>
> Thanks, please push it since I don't have commit access.
>
>>
&
Pushed, thanks.
- Bas
On Thu, Oct 13, 2016 at 10:54 PM, Gustaw Smolarczyk
wrote:
> When !use_ib_bos, we can't easily chain ibs one to another. If the
> required cs size grows over 1Mi - 8 dwords just fail the cs so that we
> won't assert-fail in radv_amdgpu_winsys_cs_submit later on.
> ---
> Ple
For patch 1-7:
Reviewed-by: Bas Nieuwenhuizen
For patch 8, you probably also want to add the extensions to the
release notes. With that added, it looks good to me too.
- Bas
On Mon, Aug 8, 2016 at 5:55 PM, Nicolai Hähnle wrote:
> Hi,
>
> this series adds some bug fixes and small e
This patch is
Reviewed-by: Bas Nieuwenhuizen
Tested-by: Bas Nieuwenhuizen
Thanks.
On Tue, Aug 23, 2016 at 3:11 AM, Jason Ekstrand wrote:
> The only reason we should throw INITIALIZATION_FAILED is if we have found
> useable intel hardware but have failed to bring it up for some
Patch 3, 4 are
Reviewed-by: Bas Nieuwenhuizen
For patch 1 and 2 I'm not familiar with the difference between the SI
and CIK+ tiling modes to be sure they are good, but the other parts of
the patch look good to me.
btw, I'm not sure what you tried wrt the CE hang, but it may be wo
I would prefer it if the function could be split in two functions
instead of using the initialized flag. I think we know whether it is
an initialization or a reinitialization per call site.
- Bas
On Thu, Aug 18, 2016 at 9:46 PM, Marek Olšák wrote:
> From: Marek Olšák
>
> Invalidated buffers don
Patch 1-7 of this series are
Reviewed-by: Bas Nieuwenhuizen
- Bas
(Adding mesa-dev ML this time)
On Thu, Aug 18, 2016 at 9:46 PM, Marek Olšák wrote:
> From: Marek Olšák
>
> If the kernel driver doesn't support it, it returns 0.
> ---
> src/gallium/drivers/radeon/r600_q
Hi Marek,
I don't think this accounts for the fast clear bits? unorm->uint and
snorm<->sint should have compatible clear values, but otherwise we may
need to eliminate the fast clears.
Yours sincerely,
Bas Nieuwenhuizen
On Mon, Aug 29, 2016 at 5:28 PM, Marek Olšák wrote:
>
PORT_ZMIN_0 0x000282D0
> -#define R_0282D4_PA_SC_VPORT_ZMAX_0 0x000282D4
> +#define R_0282D0_PA_SC_VPORT_ZMIN_0
> 0x0282D0
> +#define R_0282D4_PA_SC_VPORT_ZMAX_0
> 0x0282D4
Co
On Tue, Aug 30, 2016 at 9:06 AM, Marek Olšák wrote:
> On Mon, Aug 29, 2016 at 10:33 PM, Bas Nieuwenhuizen
> wrote:
>> On Mon, Aug 29, 2016 at 5:28 PM, Marek Olšák wrote:
>>> From: Marek Olšák
>>>
>>> Calculate depth ranges from viewport states an
On Wed, Sep 7, 2016 at 1:46 PM, Marek Olšák wrote:
> From: Marek Olšák
>
> ---
> src/gallium/drivers/radeon/r600_texture.c | 45
> ++-
> 1 file changed, 32 insertions(+), 13 deletions(-)
>
> diff --git a/src/gallium/drivers/radeon/r600_texture.c
> b/src/gallium/driv
On Wed, Sep 7, 2016 at 3:42 PM, Marek Olšák wrote:
> On Wed, Sep 7, 2016 at 2:11 PM, Bas Nieuwenhuizen
> wrote:
>> On Wed, Sep 7, 2016 at 1:46 PM, Marek Olšák wrote:
>>> From: Marek Olšák
>>>
>>> ---
>>>
On Wed, Sep 7, 2016 at 6:23 PM, Christian König wrote:
> Am 07.09.2016 um 18:06 schrieb Marek Olšák:
>>
>> On Wed, Sep 7, 2016 at 5:36 PM, Ilia Mirkin wrote:
>>>
>>> On Wed, Sep 7, 2016 at 4:08 AM, Michel Dänzer wrote:
On 07/09/16 04:19 AM, Christian König wrote:
>
> Am 06.09.2
Reviewed-by: Bas Nieuwenhuizen
On Sat, Sep 10, 2016 at 12:40 AM, Marek Olšák wrote:
> From: Marek Olšák
>
> LLVM can CSE the loads, thus we can always re-load constants before each
> use. The decrease in SGPR spilling is huge.
>
> The best improvements are the dumbest ones.
Reviewed-by: Bas Nieuwenhuizen
On Wed, Oct 19, 2016 at 8:38 PM, Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> Fixes spec/arb_tessellation_shader/execution/dvec[23]-vs-tcs-tes, among
> others.
>
> Cc: mesa-sta...@lists.freedesktop.org
> ---
> src/gallium/drivers/
On Thu, Oct 20, 2016 at 4:07 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> This fixes
> dEQP-VK.pipeline.multisample.sampled_image*
>
> These all render to multisampled image, and then
> sample from it, so we must transition it correctly.
>
> Cc: "13.0"
> Signed-off-by: Dave Airlie
> ---
> sr
Reviewed-by: Bas Nieuwenhuizen
On Fri, Oct 21, 2016 at 1:36 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> This fixes
> dEQP-VK.pipeline.multisample.sampled_image*
>
> These all render to multisampled image, and then
> sample from it, so we must transition it correctly,
&g
Reviewed-by: Bas Nieuwenhuizen
On Mon, Oct 24, 2016 at 9:39 PM, Marek Olšák wrote:
> From: Marek Olšák
>
> This should fix random GPU hangs on Hawaii and Fiji.
> It's already been fixed in 13.0 and later.
>
> Cc: 11.2 12.0
> ---
> src/gallium/drive
Reviewed-by: Bas Nieuwenhuizen
On Wed, Oct 26, 2016 at 3:04 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> The intrinsic engine asserts in llvm due to this,
> as we put a vec4 into a vec1, and the next instruction
> isn't expecting it.
>
> So trim the vector at t
For the series:
Reviewed-by: Bas Nieuwenhuizen
On Tue, Oct 25, 2016 at 12:23 AM, Marek Olšák wrote:
> Patch 1: SI fix for MSAA for Mesa 13.0. I don't know the impact of that bug.
> Patch 2: Possible GPU hang fix for Hawaii and Fiji when using separate CMASK.
> Patch 3: Addrlib i
Reviewed-by: Bas Nieuwenhuizen
On Wed, Oct 26, 2016 at 4:32 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> For 0 timeout, just poll for an event, and if none, return
> For UINT64_MAX timeout, just wait for special event blocked
> For other timeouts get the xcb fd and block on
Reviewed-by: Bas Nieuwenhuizen
On Wed, Nov 2, 2016 at 12:53 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> I missed this when I added the xlib code, this allows
> dolphin emu to start and crash later.
>
> Cc: "13.0"
> Signed-off-by: Dave Airlie
> ---
&
Reviewed-by: Bas Nieuwenhuizen
On Thu, Nov 3, 2016 at 7:22 PM, Marek Olšák wrote:
> From: Marek Olšák
>
> This fixes a crash in Deus Ex: Mankind Divided. Release builds were
> unaffected, so it's not too serious.
>
> Cc: 11.2 12.0 13.0
> ---
> src/gallium/d
Reviewed-by: Bas Nieuwenhuizen
On Tue, Nov 8, 2016 at 7:24 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> I was getting a random GPU hang in the renderpass simple tests,
> it turns out sometimes radv emitted the wrong thing "last".
>
> This fixes the logic to emit
Reviewed-by: Bas Nieuwenhuizen
On Wed, Nov 9, 2016 at 2:22 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> if a fence is created pre-signaled we should return that
> in GetFenceStatus even if it hasn't been submitted.
>
> Signed-off-by: Dave Airlie
> ---
> src
Reviewed-by: Bas Nieuwenhuizen
On Thu, Nov 10, 2016 at 1:33 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> We can only read the valid samples if this is an MSAA
> texture, which means the type field must be 0x14 or 0x15.
>
> This fixes:
> dEQP-VK.glsl.texture_functions
Maybe also add an assert in ac_add_function_attr that the attr is a
single flag? Something like
assert(attr && util_is_power_of_two(attr));
Either way, this patch is
Reviewed-by: Bas Nieuwenhuizen
On Fri, Nov 11, 2016 at 9:36 PM, Daniel Scharrer wrote:
> This fixes a NULL pointer
On Fri, Nov 11, 2016 at 10:35 PM, Daniel Scharrer wrote:
> On 2016-11-11 22:24, Bas Nieuwenhuizen wrote:
>> Maybe also add an assert in ac_add_function_attr that the attr is a
>> single flag? Something like
>>
>> assert(attr && util_is_power_of_two(attr));
>
r-b
On 15 Nov 2016 9:12 PM, "Dave Airlie" wrote:
> From: Dave Airlie
>
> Just return if the passed in swapchain is NULL.
>
> Fixes: dEQP-VK.wsi.xlib.swapchain.destroy.null_handle
>
> Signed-off-by: Dave Airlie
> ---
> src/amd/vulkan/radv_wsi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> di
Hi,
One possible reason is that the radv driver can't find any hardware.
This can happen for example if you use the radeon kernel driver, as
only the amdgpu kernel driver is currently supported.
I'm not sure what the error will be if the loader doesn't see radv at all.
Yours
No sense in repeatedly determining it. Also, it might be dependent
on the device as shaders get compiled differently for SI/CIK/VI etc.
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_device.c | 18 ++
src/amd/vulkan/radv_pipeline_cache.c | 8
src/amd
Invalidates the cache when someone switches cards.
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_device.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 04c0bdc..8595973 100644
--- a/src
symbol is
actually the LLVM DSO.
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_device.c | 36
1 file changed, 32 insertions(+), 4 deletions(-)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index b731171..04c0bdc 100644
--- a
Reviewed-by: Bas Nieuwenhuizen
On Tue, Nov 22, 2016 at 5:44 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> I've started working on a shader-db alike for Vulkan,
> it's based on vktrace and it records pipelines, this
> adds support to dump the shader stats exactly like
For the series:
Reviewed-by: Bas Nieuwenhuizen
On Tue, Nov 22, 2016 at 7:34 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> For the hw resolve there is no need to emit any sort
> of texture coordinates, so drop them all in the meta path.
>
> Signed-off-by: Dave Airlie
>
Tue, 22 Nov 2016 at 01:20 Bas Nieuwenhuizen
> wrote:
>>
>> Invalidates the cache when someone switches cards.
>>
>> Signed-off-by: Bas Nieuwenhuizen
>> ---
>> src/amd/vulkan/radv_device.c | 8 +---
>> 1 file changed, 5 insertions(+), 3 deletion
On Tue, Nov 22, 2016 at 2:31 PM, Emil Velikov wrote:
> On 22 November 2016 at 01:19, Bas Nieuwenhuizen
> wrote:
>> We want to also invalidate the cache when LLVM gets changed. As the
>> specific LLVM revision is not fixed at build time, we will need to
>> check at runti
Not needed anymore.
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/Makefile.am | 6 +-
src/amd/vulkan/Makefile.sources | 3 +--
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/src/amd/vulkan/Makefile.am b/src/amd/vulkan/Makefile.am
index c559a95..3f9b53e 100644
Remove vs exports if the ps doesn't use them.
Longer term we will probably want to do the optimizations between
stages in nir, but this seems simple enough for the short term.
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/common/ac_nir_to_llvm.c | 3 ++-
src/amd/common/ac_nir_to_llvm.h
For the series:
Reviewed-by: Bas Nieuwenhuizen
On Thu, Nov 24, 2016 at 12:40 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> This is just a cleanup before I rework this code to fix mirrored
> blits.
>
> Signed-off-by: Dave Airlie
> ---
> src/amd/vulk
Reviewed-by: Bas Nieuwenhuizen
On Thu, Nov 24, 2016 at 4:12 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> The code didn't limit the offsets to the number supplied, so
> if we expected 3 but only got 2 we were accessing undefined memory.
>
> This fixes ran
Reviewed-by: Bas Nieuwenhuizen
On Thu, Nov 24, 2016 at 7:14 PM, Emil Velikov wrote:
> From: Emil Velikov
>
> Cap up-to the number of properties available while copying the data.
> Otherwise we might crash and/or leak data.
>
> Cc: Dave Airlie
> Cc: "13.0"
You might want to rename the title of this patch.
- Bas
On Thu, Nov 24, 2016 at 7:18 PM, Emil Velikov wrote:
> From: Emil Velikov
>
> Signed-off-by: Emil Velikov
> ---
> src/intel/isl/isl_priv.h | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/src/intel/isl/isl_
Making this thread safe is probably overkill I guess?
Reviewed-by: Bas Nieuwenhuizen
On Thu, Nov 24, 2016 at 7:18 PM, Emil Velikov wrote:
> From: Emil Velikov
>
> Signed-off-by: Emil Velikov
> ---
> src/amd/vulkan/radv_private.h | 8 +++-
> 1 file changed, 7 inserti
Seems like libdrm_amdgpu does a dup indeed. Patches 7-8 are
Reviewed-by: Bas Nieuwenhuizen
On Thu, Nov 24, 2016 at 9:30 PM, Emil Velikov wrote:
> From: Emil Velikov
>
> radv_amdgpu_winsys_create() does not take ownership of the fd, thus we
> end up leaking it as we return wit
Reviewed-by: Bas Nieuwenhuizen
On Mon, Nov 28, 2016 at 8:04 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> This fixes:
> dEQP-VK.api.image_clearing.clear_color_image.3d*
>
> These were hitting an assert as the code wasn't taking the
> baseMipLevel into account w
On Mon, Nov 28, 2016 at 5:19 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> This just moves some common code into a utility function
> to avoid having to change multiple places later.
>
> Signed-off-by: Dave Airlie
> ---
> src/amd/vulkan/radv_cmd_buffer.c | 25 +
> 1 fil
Meta was using it before it was set. I suspect we typically don't
want to dump meta shaders, so just set it to false in the beginning.
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_device.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/amd/vulkan/radv_device.c b/sr
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/common/ac_nir_to_llvm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index c9b0106..d9eef57 100644
--- a/src/amd/common/ac_nir_to_llvm.c
+++ b/src/amd/common
With nir_intrinsic_ssbo_atomic_comp_swap we run out of params.
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/common/ac_nir_to_llvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index ee98f5f..df121d8 100644
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/common/ac_nir_to_llvm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index df121d8..87bb19a 100644
--- a/src/amd/common/ac_nir_to_llvm.c
+++ b/src/amd/common
101 - 200 of 2362 matches
Mail list logo
