/mesa/commit/f408fc40a028fa00e87900e6fd4cce65ee6640c2.patch
IMO it is a simpler implementation as I do not need two variants of
macros (base and extended) and there is no need for
translate_texture_format_ext(..).
What is your opinion about it?
greets
--
Christian Gmeiner, MSc
https
2017-11-14 10:21 GMT+01:00 Wladimir J. van der Laan :
> Resources only need a resolve-to-itself if their TS is valid for any
> level, not just if it happens to be allocated.
>
> Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
> ---
> src/galli
2017-11-14 10:21 GMT+01:00 Wladimir J. van der Laan :
> Sampler TS introduces yet another format enumeration for
> renderable+textureable formats. Introduce it into the etnaviv_format
> table as another column.
>
> Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Ch
2017-11-14 10:21 GMT+01:00 Wladimir J. van der Laan :
> This is to make sure that the TS is properly flushed to memory before
> rendering to a new surface starts.
>
> Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
> ---
> src/gallium/drivers/etnaviv/
2017-11-18 10:44 GMT+01:00 Wladimir J. van der Laan :
> When the BLT is involved as source or target, add an extra BLT
> enable/disable sequence around the sync sequence.
>
> Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
> ---
> src/galli
2017-11-18 10:44 GMT+01:00 Wladimir J. van der Laan :
> Prepare for BLT-based blitting path by moving RS-based
> blitting to the RS implementation file, making this
> self-contained.
>
> Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
> ---
> src/ga
h to work for them.
>
> Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
> ---
> src/gallium/drivers/etnaviv/Makefile.sources | 3 +
> src/gallium/drivers/etnaviv/etnaviv_blt.c| 562
> +++
> src/gallium/drivers/etnaviv/etnaviv
ion as well, on all
> vivantes.
>
> This needs to go in before "etnaviv: Use only DRAW_INSTANCED on GC3000+"
> (and thus before the GC7000 patch series).
Reviewed-by: Christian Gmeiner
> ---
> src/gallium/drivers/etnaviv/etnaviv_emit.c | 8
> 1 file changed,
I pushed this patch - looks we are fine to land the GC7000 patch series. I have
planed to this tomorrow.
2017-11-23 22:21 GMT+01:00 Christian Gmeiner :
> 2017-11-23 10:08 GMT+01:00 Wladimir J. van der Laan :
>> Vertex buffer legacy state is no longer picked up with new drawing
>> c
2017-11-18 10:44 GMT+01:00 Wladimir J. van der Laan :
> Update state objects to add new state, and emit function to emit new
> state.
>
> Signed-off-by: Wladimir J. van der Laan
> Reviewed-by: Christian Gmeiner
> ---
> src/gallium/drivers/etnaviv/etn
2017-11-27 7:32 GMT+01:00 Wladimir J. van der Laan :
> Hello Christian,
>
> On Sat, Nov 25, 2017 at 05:10:36PM +0100, Christian Gmeiner wrote:
>> 2017-11-18 10:44 GMT+01:00 Wladimir J. van der Laan :
>> > Update state objects to add new state, and emit functio
Guess the compiler isn't smart enough, since we're using int:2 while
> in reality we're storing an enum and using enum:2 might not always
> work.
>
> Alternative solutions is s/assert/unreachable/. The call will be up-to
> the etna devs, but including something like the
open patches on the ml).
greets
--
Christian Gmeiner, MSc
https://www.youtube.com/user/AloryOFFICIAL
https://soundcloud.com/christian-gmeiner
> Am Montag, den 05.06.2017, 21:11 +0200 schrieb Lucas Stach:
>> Same as with the colormasks, the blend color needs to be swizzled according
>> to
2017-06-20 15:28 GMT+02:00 Lucas Stach :
> Am Dienstag, den 20.06.2017, 13:21 +0200 schrieb Christian Gmeiner:
>> Hi Lucas,
>>
>> > this one is a logical follow-up to my piglit fixes series. Since the
>> > other patches have landed, it would be nice if
2017-06-05 21:11 GMT+02:00 Lucas Stach :
> Same as with the colormasks, the blend color needs to be swizzled according
> to the rendertarget format.
>
> Signed-off-by: Lucas Stach
Reviewed-by: Christian Gmeiner
greets
--
Christian Gmeiner, MSc
https://www.youtube.com/user/AloryOF
Based on a patch from Wladimir J. van der Laan and untested due
to lack of hardware. Binary blob emits those formats if GPU supports
HALTI1 (faked with ibvivhook).
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_format.c | 7 ---
src/gallium/drivers/etnaviv
Passes texwrap GL_ARB_texture_rg piglit (with faked full texture rg support).
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_format.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/etnaviv/etnaviv_format.c
b/src/gallium/drivers
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_format.c | 2 +-
src/gallium/drivers/etnaviv/etnaviv_format.h | 1 +
src/gallium/drivers/etnaviv/etnaviv_screen.c | 3 +++
src/gallium/drivers/etnaviv/etnaviv_texture.c | 8 +---
4 files changed, 10 insertions(+), 4
Passes all ext_texture_swizzle piglits.
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_format.c | 91 ++-
src/gallium/drivers/etnaviv/etnaviv_format.h | 4 ++
src/gallium/drivers/etnaviv/etnaviv_screen.c | 2 +-
src/gallium/drivers/etnaviv
Hi
2017-06-22 14:39 GMT+02:00 Wladimir J. van der Laan :
> On Wed, Jun 21, 2017 at 10:36:46PM +0200, Christian Gmeiner wrote:
>> Passes all ext_texture_swizzle piglits.
>
> You seem to have dropped the check in etnaviv_screen.c for HALTI0 when texture
> formats have implicit no
t;seqno;
Maybe I am running out of coffee but I do not see the logical change here that
should fix a performance regression.
before:
if (x && y) {
do_stuff
} else if (...) {
..
}
after:
if (x) {
if (y) {
do stuff
}
} else if (..) {
..
}
greets
--
Christian Gmeiner, MSc
https://www.
2017-06-23 17:50 GMT+02:00 Lucas Stach :
> The resource struct is already allocated at this point and should be
> free properly.
>
> Signed-off-by: Lucas Stach
Reviewed-by: Christian Gmeiner
> ---
> src/gallium/drivers/etnaviv/etnaviv_resource.c | 6 +-
> 1 file
nforms to our padding size.
> * The stride of the BO must be greater or equal to our padded
> --
> 2.11.0
>
greets
--
Christian Gmeiner, MSc
https://www.youtube.com/user/AloryOFFICIAL
https://soundcloud.com/christian-gmeiner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
2017-06-23 17:50 GMT+02:00 Lucas Stach :
> This fixes failures to import the scanout buffer with screen resolutions
> that don't satisfy teh RS alignment restrictions, like 1680x1050.
>
> Signed-off-by: Lucas Stach
Reviewed-by: Christian Gmeiner
> ---
> src/
2017-06-26 13:30 GMT+02:00 Lucas Stach :
> Am Montag, den 26.06.2017, 13:09 +0200 schrieb Christian Gmeiner:
>> 2017-06-26 12:25 GMT+02:00 Lucas Stach :
>> > Currently a resource flush may trigger a self resolve, even if a
>> > scanout buffer
>> > exists, bu
2017-06-23 17:50 GMT+02:00 Lucas Stach :
> There is no point in keeping this indirection. Makes the code easier to
> follow.
>
> Signed-off-by: Lucas Stach
Reviewed-by: Christian Gmeiner
> ---
> src/gallium/drivers/etnaviv/etnaviv_resource.c | 14 --
> src/ga
eas, leading to GPU hangs.
>
> Signed-off-by: Lucas Stach
Reviewed-by: Christian Gmeiner
> ---
> src/gallium/drivers/etnaviv/etnaviv_compiler.c | 57
> ++
> 1 file changed, 30 insertions(+), 27 deletions(-)
>
> diff --git a/src/gallium/drivers/etna
ass */
>> - label_mark_use(c, f->lbl_loop_end);
>> + label_mark_use(c, f->lbl_loop_end_idx);
>>
>> /* create branch to loop_end label */
>> emit_inst(c, &(struct etna_inst) {
>> @@ -1227,7 +1227,7 @@ trans_cont(const struct instr_trans
find out what is broken with the non
11 bit formats on GC2000 and if everything works on your platform. I
am not
sure if we should advertise the broken formats (on gpus with HALTI0).
greets
--
Christian Gmeiner, MSc
https://www.youtube.com/user/AloryOFFICIAL
https://soundcloud.com/christian-gmeiner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
ok.
>
Great - could you try piglit's oes_compressed_etc2_texture-miptree_gles3?
greets
--
Christian Gmeiner, MSc
https://www.youtube.com/user/AloryOFFICIAL
https://soundcloud.com/christian-gmeiner
___
mesa-dev mailing list
mesa-de
s that we consistently use
> enum_swizzle instead of unsigned throughout the codebase. And finally
> default cases like the one in the patch are dropped.
>
> Pretty much none of this is required for the patches to land. Just
> some janitorial tasks which came up in earlier thread.
>
2017-07-06 11:35 GMT+02:00 Aleksander Morgado :
> The check for the pointer being non-NULL was being done too late.
>
> Signed-off-by: Aleksander Morgado
Reviewed-by: Christian Gmeiner
> ---
> src/gallium/drivers/etnaviv/etnaviv_resource.c | 10 +++---
> 1 file changed,
it a try during the next 1-2
days and will provide you
the captured cmd stream.
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
ved from the table and destroyed.
>
> Fix the logic by initializing the refcnt to 1 when screen created.
> This initialization is done in etna_screen_create(), to follow the
> same logic as in freedreno and virgl.
>
> Signed-off-by: Aleksander Morgado
Reviewed-by: Christian Gmeine
2017-07-08 14:42 GMT+02:00 Andres Gomez :
> It looks like we could want this into -stable (?)
Forgot to add CC during push but I have nominated it for stable now.
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info
___
mesa-dev mail
2017-07-04 17:45 GMT+02:00 Lucas Stach :
> The minimum RS alignment calculation is needed in various places.
> Extract a helper to avoid open-coding the calcuation at every site.
>
> Signed-off-by: Lucas Stach
Reviewed-by: Christian Gmeiner
> ---
> src/galli
qno, instead of the base resource seqno.
>
> Signed-off-by: Lucas Stach
> Reviewed-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
> ---
> src/gallium/drivers/etnaviv/etnaviv_resource.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff
ff-by: Lucas Stach
> Reviewed-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
> ---
> src/gallium/drivers/etnaviv/etnaviv_texture.c | 24
> 1 file changed, 16 insertions(+), 8 deletions(-)
>
> diff --git a/src/gallium/drivers/etnaviv/etnavi
cated
> buffers, as the linear modifier is enough to trigger correct handling
> of those buffers.
>
> Signed-off-by: Lucas Stach
> Reviewed-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
> ---
> src/gallium/drivers/etnaviv/etnaviv_resource.c | 109
>
2017-07-04 17:45 GMT+02:00 Lucas Stach :
> There is no point in keeping this indirection. Makes the code easier to
> follow.
>
> Signed-off-by: Lucas Stach
> Reviewed-by: Wladimir J. van der Laan (v1)
Reviewed-by: Christian Gmeiner
> ---
> src/gallium/drivers/etnaviv/et
2017-12-19 17:35 GMT+01:00 Lucas Stach :
> The in-place resolve probably has some additional restrictions when not
> operating on a super tiled surface. Disable it on non-supertiled surfaces
> for now to work around a GPU hang.
>
> Signed-off-by: Lucas Stach
Reviewed-by: Ch
This change makes etna_get_driver_query_info(..) more generic
and puts the knowledge of supported queries directly besides
the implementation.
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_query.c| 15 +++
src/gallium/drivers/etnaviv/etnaviv_query_sw.c
Also add new define ETNA_SW_QUERY_BASE.
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_query.h| 3 +--
src/gallium/drivers/etnaviv/etnaviv_query_sw.h | 3 +++
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/etnaviv/etnaviv_query.h
>
> I've only observed the issue with R5G6B5_UNORM surfaces, other 16bpp
> formats seem to work fine.
>
> Fixes: d6aa2ba2b2 (etnaviv: replace translate_clear_color with
> util_pack_color)
> Cc: mesa-sta...@lists.freedesktop.org
> Signed-off-by: Lucas Stach
Reviewed-b
iv_translate.h"
> +#include "hw/common.xml.h"
> #include "pipe/p_defines.h"
> #include "util/u_memory.h"
>
> --
> 2.7.4
>
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
_UNK03838, 0x);
> + etna_set_state(stream, VIVS_GL_UNK03854, 0x);
> + etna_set_state(stream, VIVS_PS_CONTROL_EXT, 0x);
>
> /* Enable SINGLE_BUFFER for resolve, if supported */
> etna_set_state(stream, VIVS_RS_SINGLE_BUFFER,
> COND(ctx->s
2017-10-01 13:38 GMT+02:00 Lucas Stach :
> Am Sonntag, den 01.10.2017, 12:46 +0200 schrieb Christian Gmeiner:
>> 2017-09-26 12:29 GMT+02:00 Wladimir J. van der Laan :
>> > Set up new states that the blob started setting for GC3000 consistently.
>> >
>> > This
2017-10-01 11:21 GMT+02:00 Wladimir J. van der Laan :
> Support opcodes with bit 6 set in assembler, and assert that only ops
> 0x00..0x7f are used.
>
> Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
> ---
> src/gallium/drivers/etnaviv/etnaviv_asm.c |
2017-10-01 11:21 GMT+02:00 Wladimir J. van der Laan :
> A two-component dot product instruction is supported with HALTI2, use it
> on hardware that supports it.
>
> Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
> ---
> src/gallium/drivers/etnaviv/
the same as the blob does and potentially saves significant
> bandwidth when doing i.MX6qp scanout using PRE, and when rendering to
> textures (though here using sampler TS would be even better).
>
> Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
> ---
2017-10-01 16:23 GMT+02:00 Wladimir J. van der Laan :
> Setting PA_VIEWPORT_UNK state correctly is necessary to make point sprite
> rendering on GC3000 work.
>
> Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
> ---
> src/gallium/drivers/etnaviv/etn
t;
> Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
> ---
> src/gallium/drivers/etnaviv/etnaviv_context.c | 11 +++
> 1 file changed, 11 insertions(+)
>
> diff --git a/src/gallium/drivers/etnaviv/etnaviv_context.c
> b/src/gallium/drivers/et
d-off-by: Lucas Stach
Reviewed-by: Christian Gmeiner
> ---
> src/gallium/drivers/etnaviv/etnaviv_rasterizer.c | 3 +-
> src/gallium/drivers/etnaviv/hw/cmdstream.xml.h | 8 +--
> src/gallium/drivers/etnaviv/hw/common.xml.h | 18 +++---
> src/gallium/drivers/etnaviv/hw/is
2017-09-22 11:31 GMT+02:00 Lucas Stach :
> This is useful if we only need to copy part of a larger resource, mostly
> when using the RS engine to de-/tile on pipe transfers.
>
> Signed-off-by: Lucas Stach
> Reviewed-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
exSubImage2D).
>
> Optimize this by only blitting the tile aligned subregion of the
> resource, which the transfer is going to change.
>
> Signed-off-by: Lucas Stach
Reviewed-by: Christian Gmeiner
> ---
> src/gallium/drivers/etnaviv/etnaviv_transfer.c | 29
>
Saves us from calling util_query_clear_result(..) in every query
type implementation.
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_query.c| 3 +++
src/gallium/drivers/etnaviv/etnaviv_query_sw.c | 2 --
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git
We want the same active handling for every query type. So lets
handle it in the generic layer.
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_query.c| 17 -
src/gallium/drivers/etnaviv/etnaviv_query_sw.c | 5 -
2 files changed, 16 insertions
want to land occlusion query and half-float texture support for
etnaviv. Will send out patches during the weekend.
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
valid inputs otherwise.
>
> Fixes piglit drawpixels and a bunch of other tests using the st_draw path.
>
> Signed-off-by: Lucas Stach
Reviewed-by: Christian Gmeiner
> ---
> src/gallium/drivers/etnaviv/etnaviv_compiler.c | 4
> 1 file changed, 4 insertions(+)
>
> d
-by: Lucas Stach
Reviewed-by: Christian Gmeiner
> ---
> src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 5 +--
> src/gallium/drivers/etnaviv/etnaviv_context.h| 1 +
> src/gallium/drivers/etnaviv/etnaviv_state.c | 42
> ++--
> 3 files changed,
Gentle ping for RB for the whole series.
--
Christian Gmeiner, MSc
https://www.youtube.com/user/AloryOFFICIAL
https://soundcloud.com/christian-gmeiner
2016-12-23 23:04 GMT+01:00 Christian Gmeiner :
> As the original patchstack is now about 300 patches, I have choosen to
> squash the p
Hi Emil,
thanks for your review!
2017-01-09 21:00 GMT+01:00 Emil Velikov :
> Hi Christian,
>
> There's a few nitpicks. Note that neither is a blocker so feel free to
> send patches in the week(s) to come.
>
> On 23 December 2016 at 22:04, Christian Gmeiner
> wrot
Hi Emil,
thanks for your review!
2017-01-10 14:22 GMT+01:00 Emil Velikov :
> Hi Christian,
>
> Similar to 2/3 there's a few trivial nitpicks which can be addressed
> at a later stage.
>
I fixed them and will squash them.
> On 23 December 2016 at 22:04, Christian Gmein
Hi Emil,
2017-01-10 14:28 GMT+01:00 Emil Velikov :
> Hi Christian,
>
> On 23 December 2016 at 22:04, Christian Gmeiner
> wrote:
>> As the original patchstack is now about 300 patches, I have choosen to
>> squash the patches together into three different parts.
>>
with-gallium-drivers=svga,swrast,vc4,virgl,r300,r600,etnaviv,imx
> --disable-llvm-shared-libs
> ;
>make && make check;
> --
> 2.9.3
>
Reviewed-by: Christian Gmeiner
greets
--
Christian Gmeiner, MSc
https://www.youtube.com/use
gt; src/mesa/state_tracker/st_atom_texture.c | 4
> 9 files changed, 89 insertions(+), 2 deletions(-)
>
> --
> 2.10.2
>
greets
--
Christian Gmeiner, MSc
https://www.youtube.com/user/AloryOFFICIAL
https://soundcloud.com/christian-gmeiner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Christian Gmeiner
2016-12-06 17:17 GMT+01:00 Philipp Zabel :
> Imported resources already have contents that we want to be copied to
> texture resources derived from them. Set initial seqno of imported
> resources to 1, just as if it had already been rendered to.
>
>
Reviewed-by: Christian Gmeiner
2016-12-06 17:17 GMT+01:00 Philipp Zabel :
> Implement the resource_changed pipe callback to invalidate internal
> resources derived from imported buffers. This is needed to update the
> texture for re-imported renderables.
>
> Signed-off-by
autological-compare]
for (unsigned sp = c->frame_sp; sp >= 0; sp--)
~~ ^ ~
v2: Simply use the same datatype as c->frame_sp is using.
Reported-by: Rhys Kidd
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_compiler.c | 2
- offset < to_write)
~~ ^ ~
Signed-off-by: Christian Gmeiner
---
src/compiler/glsl/blob.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/compiler/glsl/blob.c b/src/compiler/glsl/blob.c
index dd4341b..ef17255 100644
--- a/src/compiler/glsl/blob.c
+++ b/src/compiler
There is no need to cache spec values directly as library
users will cache them anyway.
Signed-off-by: Christian Gmeiner
---
etnaviv/etnaviv_gpu.c | 72 --
etnaviv/etnaviv_priv.h | 22 ++-
2 files changed, 30 insertions(+), 64
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 4 ++--
src/gallium/drivers/etnaviv/etnaviv_context.h| 9 +
src/gallium/drivers/etnaviv/etnaviv_emit.c | 16
src/gallium/drivers/etnaviv/etnaviv_shader.c | 16
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_shader.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/etnaviv/etnaviv_shader.h
b/src/gallium/drivers/etnaviv/etnaviv_shader.h
index c613c17..9f26bef 100644
--- a/src/gallium
This commit adds some basic infrastructure to handle shader
variants. We are still creating exactly one shader variant
for each shader.
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_compiler.h | 3 ++
src/gallium/drivers/etnaviv/etnaviv_shader.c | 49
Happy reviewing.
Christian Gmeiner (11):
etnaviv: remove not needed forward declarations
etnaviv: s/etna_shader/etna_shader_variant
etnaviv: add basic shader variant support
etnaviv: add struct etna_shader_state
etnaviv: make specs const
etnaviv: pass a preallocated variant to compiler
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_shader.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/gallium/drivers/etnaviv/etnaviv_shader.h
b/src/gallium/drivers/etnaviv/etnaviv_shader.h
index b309370..1dbd200 100644
--- a/src/gallium/drivers/etnaviv
Prep work to add shader variant support.
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_compiler.c | 26 +++---
src/gallium/drivers/etnaviv/etnaviv_compiler.h | 10 -
.../drivers/etnaviv/etnaviv_compiler_cmdline.c | 2 +-
src
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 4 +-
src/gallium/drivers/etnaviv/etnaviv_compiler.c | 4 +-
src/gallium/drivers/etnaviv/etnaviv_compiler.h | 2 +
.../drivers/etnaviv/etnaviv_compiler_cmdline.c | 2 +
src/gallium/drivers
This reverts commit 658568941d5e232d690e1ffbcddbd6ea9685693a.
With the help of shader variants we can render to rb-swapped
formats now. Fixes about 60 piglits.
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_screen.c | 7 ++-
1 file changed, 2 insertions(+), 5
If we render to rb swapped format we will create a shader variant doing
the involved swizzing in the pixel shader.
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_compiler.c | 17 +
src/gallium/drivers/etnaviv/etnaviv_compiler_cmdline.c | 8
ned-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_compiler.c | 53 +++---
src/gallium/drivers/etnaviv/etnaviv_compiler.h | 7 ++-
.../drivers/etnaviv/etnaviv_compiler_cmdline.c | 22 +++--
src/gallium/drivers/etnaviv/etnaviv_shader.c | 18 +
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_shader.c | 30 ++--
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/src/gallium/drivers/etnaviv/etnaviv_shader.c
b/src/gallium/drivers/etnaviv/etnaviv_shader.c
index b1cac02..4a0b74b
If shader-db run, create a standard variant immediately
(as otherwise nothing will trigger the shader to be
actually compiled).
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_shader.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/gallium/drivers
Hi Lucas,
2017-03-27 10:56 GMT+02:00 Lucas Stach :
> Am Sonntag, den 26.03.2017, 16:13 +0200 schrieb Christian Gmeiner:
>> This commit adds some basic infrastructure to handle shader
>> variants. We are still creating exactly one shader variant
>> for each shader.
>>
*a, struct etna_shader_key *b)
{
+ STATIC_ASSERT(sizeof(struct etna_shader_key) <= sizeof(a->global));
+
return a->global == b->global;
}
greets
--
Christian Gmeiner, MSc
https://www.youtube.com/user/AloryOFFICIAL
https://soundcloud.com/christian-gmeiner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Hi Lucas
2017-03-27 10:43 GMT+02:00 Lucas Stach :
> Am Sonntag, den 26.03.2017, 16:13 +0200 schrieb Christian Gmeiner:
>> Signed-off-by: Christian Gmeiner
>
> s/adopt/adapt in the subject
>
Fixed locally.
> Reviewed-by: Lucas Stach
>
greets
--
Christian Gmeiner, MSc
Hi Lucas
2017-03-27 10:40 GMT+02:00 Lucas Stach :
> Am Sonntag, den 26.03.2017, 16:13 +0200 schrieb Christian Gmeiner:
>> If we render to rb swapped format we will create a shader variant doing
>> the involved swizzing in the pixel shader.
>>
>> Signed-off-by: Christ
At the moment travis ci failes with the following error:
checking for RADEON... yes
checking for RADEON... yes
configure: error: LLVM 3.8.0 or newer is required for r600
make: *** No targets specified and no makefile found. Stop.
Signed-off-by: Christian Gmeiner
---
.travis.yml | 2 +-
1 file
Hi,
2017-04-02 22:44 GMT+02:00 Rhys Kidd :
> On 2 April 2017 at 08:42, Christian Gmeiner
> wrote:
>>
>> At the moment travis ci failes with the following error:
>>
>> checking for RADEON... yes
>> checking for RADEON... yes
>> configure: error: LLVM 3
struct etna_screen *screen = CALLOC_STRUCT(etna_screen);
> struct pipe_screen *pscreen;
> + drmVersionPtr version;
> uint64_t val;
>
> if (!screen)
> @@ -749,6 +752,11 @@ etna_screen_create(struct etna_device *dev, struct
> etna_gpu *gpu,
>go
Can we do that without the extra if and just call
etna_cmd_stream_flush_explicit(..) in every
case? (Just like in freedreno?)
> if (fence)
> - *fence = etna_fence_create(pctx);
> + *fence = etna_fence_create(pctx, out_fence_fd);
> }
greets
--
Christian Gmeiner, MSc
https://www.youtube.com/user/AloryOFFICIAL
https://soundcloud.com/christian-gmeiner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
2017-04-12 14:33 GMT+02:00 Emil Velikov :
> On 26 March 2017 at 15:13, Christian Gmeiner
> wrote:
>> This reverts commit 658568941d5e232d690e1ffbcddbd6ea9685693a.
>>
>> With the help of shader variants we can render to rb-swapped
>> formats now. Fixes about 60
texture.
>
> - i.MX6qp includes a PRE which can scan-out directly from tiled formats,
> avoiding untiling overhead.
Just some small nitpicks else
Series is:
Reviewed-by: Christian Gmeiner
Btw.. we could land this for 17.0.1 if this lands before 00:00 GMT tomorrow.
> ---
> src
And you forgot your Signed-off-by line!
greets
--
Christian Gmeiner, MSc
https://www.youtube.com/user/AloryOFFICIAL
https://soundcloud.com/christian-gmeiner
2017-04-13 16:25 GMT+02:00 Christian Gmeiner :
> Hi
>
> 2017-04-13 16:05 GMT+02:00 Wladimir J. van der Laan :
>> This pat
ure.
>
> - i.MX6qp includes a PRE which can scan-out directly from tiled formats,
> avoiding untiling overhead.
>
> Signed-off-by: Wladimir J. van der Laan
Series is:
Reviewed-by: Christian Gmeiner
greets
--
Christian Gmeiner, MSc
https://www.youtube.com/user/AloryO
> +#define INST_OPCODE_IMADLOSAT0 0x004e
> +#define INST_OPCODE_IMADLOSAT0 0x004f
INST_OPCODE_IMADLOSAT0 got redefined...
greets
--
Christian Gmeiner, MSc
https://www.youtube.com/user/AloryOFFICIAL
https://soundclo
p Zabel
Reviewed-by: Christian Gmeiner
--
Christian Gmeiner, MSc
https://www.youtube.com/user/AloryOFFICIAL
https://soundcloud.com/christian-gmeiner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Signed-off-by: Lucas Stach
Reviewed-by: Christian Gmeiner
--
Christian Gmeiner, MSc
https://www.youtube.com/user/AloryOFFICIAL
https://soundcloud.com/christian-gmeiner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
. van der Laan
Reviewed-by: Christian Gmeiner
--
Christian Gmeiner, MSc
https://www.youtube.com/user/AloryOFFICIAL
https://soundcloud.com/christian-gmeiner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
ontext *ctx)
> assert((~vao_enabled & vao->_Enabled) == 0);
>
> /* Bind the buffer object */
> - const GLuint stride = exec->vtx.vertex_size*sizeof(GLfloat);
> _mesa_bind_vertex_buffer(ctx, vao, 0, exec->vtx.bufferobj, buffer_offset,
>
201 - 300 of 470 matches
Mail list logo
