Re: [Mesa-dev] [PATCH/RFC] glsl: allow redeclaring variables as 'precise invariant'

2018-10-30 Thread Erik Faye-Lund
Ping? (Added Timothy the the CC-list, as he's the most recent person to modify the parser, it seems) On Wed, 2018-08-29 at 13:59 +0200, Erik Faye-Lund wrote: > Ping? > > On on., aug. 22, 2018 at 7:34 PM, Erik Faye-Lund < > erik.faye-l...@collabora.com> wrote: > > The

[Mesa-dev] [PATCH] mesa: expose EXT_texture_compression_s3tc on GLES

2018-10-25 Thread Erik Faye-Lund
From: Marek Olšák The spec was modified to support GLES. Tested-by: Erik Faye-Lund --- This replaces this patch: https://patchwork.freedesktop.org/patch/257423/ docs/relnotes/18.3.0.html| 1 + src/mesa/main/extensions_table.h | 2 +- src/mesa/main/glformats.c| 11

Re: [Mesa-dev] [PATCH 0/5] add support for EXT_shader_implicit_conversions

2018-11-02 Thread Erik Faye-Lund
On Fri, 2018-11-02 at 15:40 +, Emil Velikov wrote: > On Tue, 30 Oct 2018 at 17:11, Erik Faye-Lund > wrote: > > EXT_shader_implicit_conversions is a useful extension that adds > > implicit > > conversions to OpenGL ES 3.1. Since it's tested excensively in > >

Re: [Mesa-dev] [PATCH] docs: mention EXT_shader_implicit_conversions

2018-11-02 Thread Erik Faye-Lund
On Fri, 2018-11-02 at 15:57 +, Emil Velikov wrote: > From: Emil Velikov > > Cc: Erik Faye-Lund > Signed-off-by: Emil Velikov > --- > Ff| 2 ++ > docs/relnotes/19.0.0.html | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > crea

Re: [Mesa-dev] [PATCH] mesa: expose EXT_texture_compression_s3tc on GLES

2018-10-26 Thread Erik Faye-Lund
d a porting-bug, where I tried to use glGetTexLevelParameteriv on gles2, which isn't supported. I'll send out and updated version of the piglit patches for that also. > On Thu, Oct 25, 2018 at 6:59 AM Erik Faye-Lund > wrote: > > > > From: Marek Olšák > > &g

[Mesa-dev] [PATCH] mesa: expose NV_conditional_render on GLES

2018-11-05 Thread Erik Faye-Lund
The extension spec has been updated to include GLES 3 support, so let's enable it there. Signed-off-by: Erik Faye-Lund --- This patch can be tested with this piglit-series: https://patchwork.freedesktop.org/series/52039/ src/mapi/glapi/gen/NV_conditional_render.xml | 4 ++-- src/mesa/main

Re: [Mesa-dev] [PATCH] mesa: expose NV_conditional_render on GLES

2018-11-05 Thread Erik Faye-Lund
> render but not ARB_occlusion_query? (I don't think that's really > possible given that the feature is basically designed for occlusion > queries...) I don't think so, no. > On Mon, Nov 5, 2018 at 12:26 PM Erik Faye-Lund > wrote: > > The extension spec has been updated

Re: [Mesa-dev] [PATCH 1/3] freedreno: implements get_sample_position

2018-11-06 Thread Erik Faye-Lund
On Tue, 2018-11-06 at 19:27 +0900, Hyunjun Ko wrote: > Since 1285f71d3e landed, it needs to provide apps with proper sample > position for MSAA. > > Currently no way to query this to hw, these are taken from blob > driver. > > Fixes: dEQP- >

[Mesa-dev] [PATCH v2] mesa: expose NV_conditional_render on GLES

2018-11-07 Thread Erik Faye-Lund
The extension spec has been updated to include GLES 2 support, so let's enable it there. Signed-off-by: Erik Faye-Lund --- Here's a V2 of this patch. The only difference is that this also expose the extension on ES2. The piglit patches has also been updated: https://patchwork.freedesktop.org

Re: [Mesa-dev] [PATCH 00/13] query validation fixes

2018-11-08 Thread Erik Faye-Lund
On Thu, 2018-11-08 at 13:43 +0200, Tapani Pälli wrote: > > On 11/8/18 1:02 PM, Tapani Pälli wrote: > > > > On 11/8/18 11:53 AM, Erik Faye-Lund wrote: > > > On Thu, 2018-11-08 at 10:47 +0200, Tapani Pälli wrote: > > > > On 11/8/18 10:44 AM, Erik Faye-Lund wr

[Mesa-dev] [PATCH v2 07/13] mesa/main: fix validation of GL_ANY_SAMPLES_PASSED_CONSERVATIVE

2018-11-08 Thread Erik Faye-Lund
low this behavior. This shouldn't cause any functional change, as all drivers that support ES3_compatibility should in practice enable either ES3_compatibility or EXT_occlusion_query_boolean under all APIs that export this symbol. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 4 ++--

[Mesa-dev] [PATCH v2 13/13] mesa/main: remove overly strict query-validation

2018-11-08 Thread Erik Faye-Lund
The rules encoded in this code also applies to OpenGL ES 3.0 and up, but the per-enum validation has already been taught about these rules. So let's get rid of this duplicate, narrow version of the validation. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 14 -- 1

[Mesa-dev] [PATCH v2 04/13] mesa/main: simplify pipeline-statistics query validation

2018-11-08 Thread Erik Faye-Lund
The _mesa_has_ARB_pipeline_statistics_query(ctx)-helper will already check the GLES-version according to the extension-table, so if this extension would ever be back-ported to ES, we only need to update the table to support this. This shouln't have any functional effect. Signed-off-by: Erik Faye

[Mesa-dev] [PATCH v2 12/13] mesa/main: fix validation of GL_TIMESTAMP

2018-11-08 Thread Erik Faye-Lund
ort. This shouln't have any functional effect, as this entry-point is only valid on desktop GL, or on GLES with EXT_disjoint_timer_query in the first place. But if this gets added to the core of a future version of ES, this should be a step in the right direction. Signed-off-by: Erik Faye-Lund --- src/m

[Mesa-dev] [PATCH v2 01/13] mesa/main: correct requirement for EXT_occlusion_query_boolean

2018-11-08 Thread Erik Faye-Lund
by either ARB_occlusion_query nor ARB_occlusion_query2. But it should be trivial to implement for any driver supporting ARB_occlusion_query2, as it can simply be implemented as GL_ANY_SAMPLES_PASSED. Signed-off-by: Erik Faye-Lund --- src/mesa/main/extensions_table.h | 2 +- 1 file changed, 1 insertion

[Mesa-dev] [PATCH v2 10/13] mesa/main: fix validation of transform-feedback overflow queries

2018-11-08 Thread Erik Faye-Lund
age of GL_TRANSFORM_FEEDBACK_STREAM_OVERFLOW and GL_TRANSFORM_FEEDBACK_OVERFLOW into errors on ES 3, as required by the spec. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c in

[Mesa-dev] [PATCH v2 00/13] query validation fixes

2018-11-08 Thread Erik Faye-Lund
system :) Erik Faye-Lund (13): mesa/main: correct requirement for EXT_occlusion_query_boolean mesa/main: correct year for EXT_occlusion_query_boolean mesa/main: use non-prefixed enums for consistency mesa/main: simplify pipeline-statistics query validation mesa/main: fix validation

[Mesa-dev] [PATCH v2 05/13] mesa/main: fix validation of GL_SAMPLES_PASSED

2018-11-08 Thread Erik Faye-Lund
ry2, as ARB_occlusion_query isn't available in core contexts. This turns usage of GL_SAMPLES_PASSED into an error on ES 3, as is required by the spec. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/queryobj.c b/src/mesa/m

[Mesa-dev] [PATCH v2 11/13] mesa/main: fix validation of ARB_query_buffer_object

2018-11-08 Thread Erik Faye-Lund
cts on ES 3 into errors, as required by the spec. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c index 45db43139a4..c86b9ec065b 100644 --- a/src/mesa/main/queryob

[Mesa-dev] [PATCH v2 09/13] mesa/main: fix validation of transform-feedback queries

2018-11-08 Thread Erik Faye-Lund
rns usage of GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN into an error on ES 2, as well as usage of GL_PRIMITIVES_GENERATED on ES 3, both as required by the spec. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/m

[Mesa-dev] [PATCH v2 02/13] mesa/main: correct year for EXT_occlusion_query_boolean

2018-11-08 Thread Erik Faye-Lund
According to the extension spec, this was initially released in 2011, so let's set this to the correct value. The value of 2001 could be a copy-paste mistake, as ARB_occlusion_query which this is based on was released then. Signed-off-by: Erik Faye-Lund --- src/mesa/main/extensions_table.h | 2

[Mesa-dev] [PATCH v2 06/13] mesa/main: fix validation of GL_ANY_SAMPLES_PASSED

2018-11-08 Thread Erik Faye-Lund
low this behavior. This shouldn't cause any functional change, as all drivers that support ARB_occlusion_query2 should in practice enable either ARB_occlusion_query2 or EXT_occlusion_query_boolean under all APIs that export this symbol. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 3 ++-

[Mesa-dev] [PATCH v2 03/13] mesa/main: use non-prefixed enums for consistency

2018-11-08 Thread Erik Faye-Lund
These enums all have the same values as their non-prefixed versions, and there's several aliases for some of them. So let's switch to the non-prefixed versions for simplicity. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 66 1 file

[Mesa-dev] [PATCH v2 08/13] mesa/main: fix validation of GL_TIME_ELAPSED

2018-11-08 Thread Erik Faye-Lund
ame functionality for ES. This turns usage of GL_TIME_ELAPSED into an error on ES 3, as is required by the spec. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c in

Re: [Mesa-dev] [PATCH 00/13] query validation fixes

2018-11-08 Thread Erik Faye-Lund
On Thu, 2018-11-08 at 10:47 +0200, Tapani Pälli wrote: > On 11/8/18 10:44 AM, Erik Faye-Lund wrote: > > On Thu, 2018-11-08 at 08:47 +0200, Tapani Pälli wrote: > > > FYI there's a whole lot of tests that start to fail when this > > > series > > > running on

Re: [Mesa-dev] [PATCH 00/13] query validation fixes

2018-11-08 Thread Erik Faye-Lund
On Thu, 2018-11-08 at 09:54 +0100, Erik Faye-Lund wrote: > On Thu, 2018-11-08 at 10:47 +0200, Tapani Pälli wrote: > > On 11/8/18 10:44 AM, Erik Faye-Lund wrote: > > > On Thu, 2018-11-08 at 08:47 +0200, Tapani Pälli wrote: > > > > FYI there's a whole lot of

Re: [Mesa-dev] [PATCH 08/13] mesa/main: fix validation of GL_TIME_ELAPSED

2018-11-08 Thread Erik Faye-Lund
On Thu, 2018-11-08 at 11:40 +0200, Tapani Pälli wrote: > > On 11/7/18 5:58 PM, Erik Faye-Lund wrote: > > ctx->Extensions.EXT_timer_query is set based on the driver- > > capabilities, not based on the context type. We need to check > > against > > _mesa_has_EXT_t

Re: [Mesa-dev] [PATCH 00/13] query validation fixes

2018-11-08 Thread Erik Faye-Lund
On Thu, 2018-11-08 at 10:47 +0200, Tapani Pälli wrote: > On 11/8/18 10:44 AM, Erik Faye-Lund wrote: > > On Thu, 2018-11-08 at 08:47 +0200, Tapani Pälli wrote: > > > FYI there's a whole lot of tests that start to fail when this > > > series > > > running on

Re: [Mesa-dev] [PATCH 00/13] query validation fixes

2018-11-08 Thread Erik Faye-Lund
On Thu, 2018-11-08 at 08:47 +0200, Tapani Pälli wrote: > FYI there's a whole lot of tests that start to fail when this series > running on Intel CI. It includes dEQP but also Piglit tests, can you > do > Intel CI run or do you want me to send you results? If you mean mesa-ci.01.org, then I have

Re: [Mesa-dev] [PATCH v3] virgl: Add command and flags to initiate debugging on the host (v2)

2018-11-13 Thread Erik Faye-Lund
> v3: Only request host logging if the host actually understands the > command > > Signed-off-by: Gert Wollny Looks good to me! Reviewed-by: Erik Faye-Lund > --- > The corresponding virglrenderer patches can be found in this MR: > https://gitlab.freedesktop.org/virg

Re: [Mesa-dev] [PATCH 16/28] Replace IROUND_POS with _mesa_roundevenf

2018-11-12 Thread Erik Faye-Lund
On Fri, 2018-11-09 at 10:40 -0800, Dylan Baker wrote: > Which has the same behavior. Does it? I'm not so sure... IROUND_POS seems to round to nearest integer depending on the FPU rounding mode, _mesa_roundevenf rounds to the nearest *even* value regardless of the FPU rounding mode, no? I'm not

Re: [Mesa-dev] [PATCH 16/28] Replace IROUND_POS with _mesa_roundevenf

2018-11-13 Thread Erik Faye-Lund
On Mon, 2018-11-12 at 09:22 -0800, Dylan Baker wrote: > Quoting Erik Faye-Lund (2018-11-12 04:51:47) > > On Fri, 2018-11-09 at 10:40 -0800, Dylan Baker wrote: > > > Which has the same behavior. > > > > Does it? I'm not so sure... IROUND_POS seems to round to

Re: [Mesa-dev] [Mesa-stable] [PATCH 0/5] add support for EXT_shader_implicit_conversions

2018-11-06 Thread Erik Faye-Lund
On Nov 6, 2018 13:51, "Juan A. Suarez Romero" wrote:On Tue, 2018-11-06 at 10:32 +, Emil Velikov wrote: > On Fri, 2 Nov 2018 at 16:06, Erik Faye-Lund > wrote: > > On Fri, 2018-11-02 at 15:40 +, Emil Velikov wrote: > > > On Tue, 30 Oct 2018 at 17:1

Re: [Mesa-dev] [PATCH] mesa/st: swap order of clear() and clear_with_quad()

2018-11-14 Thread Erik Faye-Lund
On Tue, 2018-11-13 at 21:53 -0500, Marek Olšák wrote: > > > On Tue, Nov 13, 2018, 6:00 PM Rob Clark > On Tue, Nov 13, 2018 at 5:25 PM Eric Anholt > > wrote: > > > > > > Rob Clark writes: > > > > > > > If we can't clear all the buffers with pctx->clear() (say, for > > example, > > > > because

Re: [Mesa-dev] [PATCH] mesa/st: swap order of clear() and clear_with_quad()

2018-11-14 Thread Erik Faye-Lund
On Tue, 2018-11-13 at 19:07 -0500, Ilia Mirkin wrote: > On Tue, Nov 13, 2018 at 6:50 PM Rob Clark > wrote: > > On Tue, Nov 13, 2018 at 6:19 PM Eric Anholt > > wrote: > > > Rob Clark writes: > > > > > > > On Tue, Nov 13, 2018 at 5:25 PM Eric Anholt > > > > wrote: > > > > > Rob Clark writes: >

Re: [Mesa-dev] [PATCH 16/28] Replace IROUND_POS with _mesa_roundevenf

2018-11-14 Thread Erik Faye-Lund
On Tue, 2018-11-13 at 22:13 +, Roland Scheidegger wrote: > Am 13.11.18 um 18:00 schrieb Dylan Baker: > > Quoting Erik Faye-Lund (2018-11-13 01:34:53) > > > On Mon, 2018-11-12 at 09:22 -0800, Dylan Baker wrote: > > > > Quoting Erik Faye-Lund (2018-11-12 04:51:47

Re: [Mesa-dev] [PATCH 11/22] nir: simplify get_io_offset() parameters

2018-11-14 Thread Erik Faye-Lund
t Reviewed-by: Erik Faye-Lund > --- > src/compiler/nir/nir_lower_io.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/src/compiler/nir/nir_lower_io.c > b/src/compiler/nir/nir_lower_io.c > index b3595bb19d5..2a6c284de2b 100644 > ---

Re: [Mesa-dev] [PATCH 16/28] Replace IROUND_POS with _mesa_roundevenf

2018-11-14 Thread Erik Faye-Lund
On Tue, 2018-11-13 at 09:00 -0800, Dylan Baker wrote: > Quoting Erik Faye-Lund (2018-11-13 01:34:53) > > On Mon, 2018-11-12 at 09:22 -0800, Dylan Baker wrote: > > > Quoting Erik Faye-Lund (2018-11-12 04:51:47) > > > > On Fri, 2018-11-09 at 10:40 -0800, Dylan Ba

[Mesa-dev] [PATCH] mesa/main: fixup make check after NV_conditional_render for gles

2018-11-09 Thread Erik Faye-Lund
It seems I missed some details when exposing NV_conditional_render on GLES; this fixes up "make check". Fixes: 5213be9fab7 ("mesa: expose NV_conditional_render on GLES") Signed-off-by: Erik Faye-Lund --- Caught by the Intel CI system. Sorry about this! src/m

Re: [Mesa-dev] [PATCH] mesa/main: fixup make check after NV_conditional_render for gles

2018-11-09 Thread Erik Faye-Lund
t really know what makes this appear in the ABI, though. If someone can explain, I'd be happy to fix things up. Anyway, I pushed the test-fixes for now; the ABI change seems to already have happened. > On Fri, Nov 9, 2018 at 10:20 AM Erik Faye-Lund > wrote: > > It seems I mis

Re: [Mesa-dev] [PATCH] mesa/main: fixup make check after NV_conditional_render for gles

2018-11-09 Thread Erik Faye-Lund
On Fri, 2018-11-09 at 11:17 -0500, Ilia Mirkin wrote: > On Fri, Nov 9, 2018 at 10:51 AM Erik Faye-Lund > wrote: > > On Fri, 2018-11-09 at 10:44 -0500, Ilia Mirkin wrote: > > > Errr ... why are these being added to the ABI now? Extensions are > > > generally not ad

[Mesa-dev] [PATCH 04/13] mesa/main: simplify pipeline-statistics query validation

2018-11-07 Thread Erik Faye-Lund
The _mesa_has_ARB_pipeline_statistics_query(ctx)-helper will already check the GLES-version according to the extension-table, so if this extension would ever be back-ported to ES, we only need to update the table to support this. This shouln't have any functional effect. Signed-off-by: Erik Faye

[Mesa-dev] [PATCH 01/13] mesa/main: correct requirement for EXT_occlusion_query_boolean

2018-11-07 Thread Erik Faye-Lund
by either ARB_occlusion_query nor ARB_occlusion_query2. But it should be trivial to implement for any driver supporting ARB_occlusion_query2, as it can simply be implemented as GL_ANY_SAMPLES_PASSED. Signed-off-by: Erik Faye-Lund --- src/mesa/main/extensions_table.h | 2 +- 1 file changed, 1 insertion

[Mesa-dev] [PATCH 03/13] mesa/main: use non-prefixed enums for consistency

2018-11-07 Thread Erik Faye-Lund
These enums all have the same values as their non-prefixed versions, and there's several aliases for some of them. So let's switch to the non-prefixed versions for simplicity. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 66 1 file

[Mesa-dev] [PATCH 02/13] mesa/main: correct year for EXT_occlusion_query_boolean

2018-11-07 Thread Erik Faye-Lund
According to the extension spec, this was initially released in 2011, so let's set this to the correct value. The value of 2001 could be a copy-paste mistake, as ARB_occlusion_query which this is based on was released then. Signed-off-by: Erik Faye-Lund --- src/mesa/main/extensions_table.h | 2

[Mesa-dev] [PATCH 00/13] query validation fixes

2018-11-07 Thread Erik Faye-Lund
fixing this are also included. Erik Faye-Lund (13): mesa/main: correct requirement for EXT_occlusion_query_boolean mesa/main: correct year for EXT_occlusion_query_boolean mesa/main: use non-prefixed enums for consistency mesa/main: simplify pipeline-statistics query validation mesa/mai

[Mesa-dev] [PATCH 06/13] mesa/main: fix validation of GL_ANY_SAMPLES_PASSED

2018-11-07 Thread Erik Faye-Lund
low this behavior. This shouldn't cause any functional change, as all drivers that support ARB_occlusion_query2 should in practice enable either ARB_occlusion_query2 or EXT_occlusion_query_boolean under all APIs that export this symbol. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 3 ++-

[Mesa-dev] [PATCH 10/13] mesa/main: fix validation of transform-feedback overflow queries

2018-11-07 Thread Erik Faye-Lund
age of GL_TRANSFORM_FEEDBACK_STREAM_OVERFLOW and GL_TRANSFORM_FEEDBACK_OVERFLOW into errors on ES 3, as required by the spec. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c in

[Mesa-dev] [PATCH 07/13] mesa/main: fix validation of GL_ANY_SAMPLES_PASSED_CONSERVATIVE

2018-11-07 Thread Erik Faye-Lund
low this behavior. This shouldn't cause any functional change, as all drivers that support ES3_compatibility should in practice enable either ES3_compatibility or EXT_occlusion_query_boolean under all APIs that export this symbol. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 4 ++--

[Mesa-dev] [PATCH 05/13] mesa/main: fix validation of GL_SAMPLES_PASSED

2018-11-07 Thread Erik Faye-Lund
S 3, as is required by the spec. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c index 96b1c6bb30a..74977210f2d 100644 --- a/src/mesa/main/queryobj.c +++ b/src/mesa/m

[Mesa-dev] [PATCH 12/13] mesa/main: fix validation of GL_TIMESTAMP

2018-11-07 Thread Erik Faye-Lund
lid on desktop GL in the first place. But if this gets added to a future version of ES, this should be a step in the right direction. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/queryobj.c b/src/mesa/m

[Mesa-dev] [PATCH 08/13] mesa/main: fix validation of GL_TIME_ELAPSED

2018-11-07 Thread Erik Faye-Lund
red by the spec. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c index 2f178bbf483..e4185073e3b 100644 --- a/src/mesa/main/queryobj.c +++ b/src/mesa/main/queryob

[Mesa-dev] [PATCH 13/13] mesa/main: remove overly strict query-validation

2018-11-07 Thread Erik Faye-Lund
The rules encoded in this code also applies to OpenGL ES 3.0 and up, but the per-enum validation has already been taught about these rules. So let's get rid of this duplicate, narrow version of the validation. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 14 -- 1

[Mesa-dev] [PATCH 11/13] mesa/main: fix validation of ARB_query_buffer_object

2018-11-07 Thread Erik Faye-Lund
cts on ES 3 into errors, as required by the spec. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c index d22432930d0..01a5504575d 100644 --- a/src/mesa/main/queryob

[Mesa-dev] [PATCH 09/13] mesa/main: fix validation of transform-feedback queries

2018-11-07 Thread Erik Faye-Lund
TEN into an error on ES 2, as well as usage of GL_PRIMITIVES_GENERATED on ES 3, both as required by the spec. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c in

[Mesa-dev] [PATCH 3/7] st/mesa: simplify MaxAtomicBufferSize-logic

2018-08-30 Thread Erik Faye-Lund
MaxAtomicCounters has already been assigned in the loop above in the ssbo_atomic = true case, so this will calculate the same value as the default. While we're at it, fixup indentation on the MaxAtomicBufferBindings assign. Signed-off-by: Erik Faye-Lund --- src/mesa/state_tracker

[Mesa-dev] [PATCH 0/7] gallium/virgl: use hw-atomic buffers

2018-08-30 Thread Erik Faye-Lund
currently needed to pass dEQP GLES-3.1 (as well as GLES-3.2) using virgl/virglrenderer on i965 hardware. Erik Faye-Lund (6): st/mesa: use real bool for can_ubo st/mesa: clean up atomic vs ssbo code st/mesa: simplify MaxAtomicBufferSize-logic gallium: add PIPE_CAP_MAX_COMBINED_SHADER_BUFFERS

[Mesa-dev] [PATCH 4/7] gallium: add PIPE_CAP_MAX_COMBINED_SHADER_BUFFERS

2018-08-30 Thread Erik Faye-Lund
This gets rid of a r600 specific hack in the state-tracker, and prepares for other drivers to be able to use hw-atomics. While we're at it, clean up some indentation in the various drivers. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 3 +++ src/gallium

[Mesa-dev] [PATCH 2/7] st/mesa: clean up atomic vs ssbo code

2018-08-30 Thread Erik Faye-Lund
without incorrectly dropping the last SSBO. This has the nice result that the SSBOs and atomic buffers are dealt with almost completely orthogonally, easing some upcoming patches. Signed-off-by: Erik Faye-Lund --- src/mesa/state_tracker/st_extensions.c | 27 -- 1 file

[Mesa-dev] [PATCH 5/7] gallium: add PIPE_CAP_MAX_COMBINED_HW_ATOMIC_COUNTER{S, _BUFFERS}

2018-08-30 Thread Erik Faye-Lund
This moves the evergreen-specific max-sizes out as a driver-cap, so other drivers with less strict requirements also can use hw-atomics. Remove ssbo_atomic as it's no longer needed. We should now be able to use hw-atomics for some stages and not for other, if needed. Signed-off-by: Erik Faye

[Mesa-dev] [PATCH 1/7] st/mesa: use real bool for can_ubo

2018-08-30 Thread Erik Faye-Lund
We're doing full c99 now, so there's no point in using the old boolean type. Signed-off-by: Erik Faye-Lund --- This is not technically nessecary for the series, but IMO a nice cleanup nevertheless. src/mesa/state_tracker/st_extensions.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[Mesa-dev] [PATCH 6/7] virgl: update minor differences to upstream header

2018-08-30 Thread Erik Faye-Lund
virgl_protocol.h is considered to have it's upstream in the virglrenderer repository, and somehow these minor differences has crept in. Let's sync with the upstream to avoid this. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/virgl/virgl_protocol.h | 2 +- 1 file changed, 1 insertion

[Mesa-dev] [PATCH 7/7] virgl: use hw-atomics instead of in-ssbo ones

2018-08-30 Thread Erik Faye-Lund
From: Tomeu Vizoso Emulating atomics on top of ssbos can lead to too small max SSBO count, so let's use the hw-atomics mechanism to expose atomic buffers instead. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/virgl/virgl_context.c | 37 ++ src/gallium/drivers

Re: [Mesa-dev] [PATCH 7/7] virgl: use hw-atomics instead of in-ssbo ones

2018-09-03 Thread Erik Faye-Lund
2018 at 6:41 AM Erik Faye-Lund wrote: > > From: Tomeu Vizoso > > Emulating atomics on top of ssbos can lead to too small max SSBO count, > so let's use the hw-atomics mechanism to expose atomic buffers instead. > > Signed-off-by: Erik Faye-Lund > --- > src/g

Re: [Mesa-dev] [PATCH 5/7] gallium: addPIPE_CAP_MAX_COMBINED_HW_ATOMIC_COUNTER{S, _BUFFERS}

2018-09-03 Thread Erik Faye-Lund
On fr., aug. 31, 2018 at 7:44 PM, Gurchetan Singh wrote: On Thu, Aug 30, 2018 at 6:41 AM Erik Faye-Lund wrote: This moves the evergreen-specific max-sizes out as a driver-cap, so other drivers with less strict requirements also can use hw-atomics. Remove ssbo_atomic as it's no longer

Re: [Mesa-dev] [PATCH 7/7] virgl: use hw-atomics instead of in-ssbo ones

2018-09-03 Thread Erik Faye-Lund
On fr., aug. 31, 2018 at 7:35 PM, Gurchetan Singh wrote: On Thu, Aug 30, 2018 at 6:41 AM Erik Faye-Lund wrote: From: Tomeu Vizoso Emulating atomics on top of ssbos can lead to too small max SSBO count, so let's use the hw-atomics mechanism to expose atomic buffers instead

[Mesa-dev] [PATCH v2 0/7] gallium/virgl: use hw-atomic buffers

2018-09-04 Thread Erik Faye-Lund
-tracker requirement. - [Marek] Added documentation of the new caps Erik Faye-Lund (6): st/mesa: use real bool for can_ubo st/mesa: clean up atomic vs ssbo code st/mesa: simplify MaxAtomicBufferSize-logic gallium: add PIPE_CAP_MAX_COMBINED_SHADER_BUFFERS gallium: add

[Mesa-dev] [PATCH v2 3/7] st/mesa: simplify MaxAtomicBufferSize-logic

2018-09-04 Thread Erik Faye-Lund
MaxAtomicCounters has already been assigned in the loop above in the ssbo_atomic = true case, so this will calculate the same value as the default. While we're at it, fixup indentation on the MaxAtomicBufferBindings assign. Signed-off-by: Erik Faye-Lund Reviewed-by: Marek Olšák --- src/mesa

[Mesa-dev] [PATCH v2 2/7] st/mesa: clean up atomic vs ssbo code

2018-09-04 Thread Erik Faye-Lund
without incorrectly dropping the last SSBO. This has the nice result that the SSBOs and atomic buffers are dealt with almost completely orthogonally, easing some upcoming patches. Signed-off-by: Erik Faye-Lund Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_extensions.c | 27

[Mesa-dev] [PATCH v2 5/7] gallium: add PIPE_CAP_MAX_COMBINED_HW_ATOMIC_COUNTER{S, _BUFFERS}

2018-09-04 Thread Erik Faye-Lund
This moves the evergreen-specific max-sizes out as a driver-cap, so other drivers with less strict requirements also can use hw-atomics. Remove ssbo_atomic as it's no longer needed. We should now be able to use hw-atomics for some stages and not for other, if needed. Signed-off-by: Erik Faye

[Mesa-dev] [PATCH v2 4/7] gallium: add PIPE_CAP_MAX_COMBINED_SHADER_BUFFERS

2018-09-04 Thread Erik Faye-Lund
This gets rid of a r600 specific hack in the state-tracker, and prepares for other drivers to be able to use hw-atomics. While we're at it, clean up some indentation in the various drivers. Signed-off-by: Erik Faye-Lund Reviewed-by: Marek Olšák Reviewed-by: Wladimir J. van der Laan --- src

[Mesa-dev] [PATCH v2 1/7] st/mesa: use real bool for can_ubo

2018-09-04 Thread Erik Faye-Lund
We're doing full c99 now, so there's no point in using the old boolean type. Signed-off-by: Erik Faye-Lund Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_extensions.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src

[Mesa-dev] [PATCH v2 6/7] virgl: update minor differences to upstream header

2018-09-04 Thread Erik Faye-Lund
virgl_protocol.h is considered to have it's upstream in the virglrenderer repository, and somehow these minor differences has crept in. Let's sync with the upstream to avoid this. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/virgl/virgl_protocol.h | 2 +- 1 file changed, 1 insertion

[Mesa-dev] [PATCH v2 7/7] virgl: use hw-atomics instead of in-ssbo ones

2018-09-04 Thread Erik Faye-Lund
From: Tomeu Vizoso Emulating atomics on top of ssbos can lead to too small max SSBO count, so let's use the hw-atomics mechanism to expose atomic buffers instead. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/virgl/virgl_context.c | 37 ++ src/gallium/drivers

[Mesa-dev] [PATCH] st/mesa: do not call update_framebuffer_size with NULL pointer

2018-09-20 Thread Erik Faye-Lund
a crash while running Piglit's glx/glx-visuals-stencil test, both on virgl and r600g. Signed-off-by: Erik Faye-Lund --- src/mesa/state_tracker/st_atom_framebuffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_atom_framebuffer.c b/src/mesa

Re: [Mesa-dev] NIR constant problem for GPU which doesn't have native integer support

2019-01-03 Thread Erik Faye-Lund
On Wed, 2019-01-02 at 10:16 -0600, Jason Ekstrand wrote: > On Wed, Jan 2, 2019 at 9:43 AM Ilia Mirkin > wrote: > > Have a look at the first 4 patches in the series from Jonathan > > Marek > > to address some of these issues: > > > > https://patchwork.freedesktop.org/series/54295/ > > > > Not

Re: [Mesa-dev] Thoughts after hitting 100 merge requests?

2019-01-16 Thread Erik Faye-Lund
On Fri, 2019-01-11 at 10:57 -0600, Jason Ekstrand wrote: > All, > > The mesa project has now hit 100 merge requests (36 are still open). > I (and I'm sure others) would be curious to hear people's initial > thoughts on the process. What's working well? What's not working? > Is it total fail

Re: [Mesa-dev] [PATCH v3 05/24] mapi: add all _glapi_table entrypoints to static_data.py

2019-01-18 Thread Erik Faye-Lund
Currently this is done via MAX_OFFSETS constant, although a better > solution is in the works. > > v2: add FramebufferTexture2DMultisampleEXT > v3: add MAX_OFFSETS guard > > Signed-off-by: Emil Velikov > Reviewed-by: Erik Faye-Lund (v1) Consider this version also: Reviewed-

Re: [Mesa-dev] [PATCH] docs: add note about sending merge-requests from forks

2019-01-23 Thread Erik Faye-Lund
On Wed, 2019-01-23 at 17:03 +, Emil Velikov wrote: > Hi all, > > In case the patch is still outstanding, feel free to add > Reviewed-by: Emil Velikov > Thanks, pushed. > On Wed, 23 Jan 2019 at 11:20, Erik Faye-Lund > wrote: > > On Wed, 2019-01-23 at 10:42

Re: [Mesa-dev] Thoughts after hitting 100 merge requests?

2019-01-17 Thread Erik Faye-Lund
On Thu, 2019-01-17 at 10:00 +0100, Michel Dänzer wrote: > On 2019-01-17 8:38 a.m., Erik Faye-Lund wrote: > > 3. There's some browsing-pain with the commit list. For instance, I > > always second-guess if the latest commit is at the top or bottom. > > At the top, same as in

Re: [Mesa-dev] Thoughts after hitting 100 merge requests?

2019-01-17 Thread Erik Faye-Lund
On Thu, 2019-01-17 at 14:37 +, Daniel Stone wrote: > Hi, > > On Thu, 17 Jan 2019 at 07:38, Erik Faye-Lund > wrote: > > 1. New MRs should probably get their cover-letter automatically > > sent to > > the mailing list for incrased visibility. > >

Re: [Mesa-dev] [PATCH] docs: add note about sending merge-requests from forks

2019-01-23 Thread Erik Faye-Lund
On Wed, 2019-01-23 at 10:08 +, Eric Engestrom wrote: > On Wednesday, 2019-01-23 10:36:15 +0100, Erik Faye-Lund wrote: > > Sending MRs from the main Mesa repository increase clutter in the > > repository, and decrease visibility of project-wide branches. So > > it's >

Re: [Mesa-dev] [PATCH] st/mesa: fix PRIMITIVES_GENERATED query after the "pipeline stat single" changes

2019-01-23 Thread Erik Faye-Lund
for drivers that support transform feedback." I also think this should have a Fixes tag: Fixes: d644698b443 ("gallium: Add the ability to query a single pipeline statistics counter") With those things changed: Reviewed-by: Erik Faye-Lund Also, I added Kenneth Grauke who wr

[Mesa-dev] [PATCH] docs: add note about sending merge-requests from forks

2019-01-23 Thread Erik Faye-Lund
Sending MRs from the main Mesa repository increase clutter in the repository, and decrease visibility of project-wide branches. So it's better if MRs are sent from forks instead. Let's add a note about this, in case its not obvious to everyone. Signed-off-by: Erik Faye-Lund --- docs

Re: [Mesa-dev] Thoughts after hitting 100 merge requests?

2019-01-23 Thread Erik Faye-Lund
On Thu, 2019-01-17 at 08:38 +0100, Erik Faye-Lund wrote: > On Fri, 2019-01-11 at 10:57 -0600, Jason Ekstrand wrote: > > All, > > > > The mesa project has now hit 100 merge requests (36 are still > > open). > > I (and I'm sure others) would be curious to h

Re: [Mesa-dev] [PATCH] docs: add note about sending merge-requests from forks

2019-01-23 Thread Erik Faye-Lund
On Wed, 2019-01-23 at 10:14 +, Daniel Stone wrote: > Hi, > > On Wed, 23 Jan 2019 at 10:09, Eric Engestrom < > eric.engest...@intel.com> wrote: > > On Wednesday, 2019-01-23 10:36:15 +0100, Erik Faye-Lund wrote: > > > Sending MRs from the main

Re: [Mesa-dev] [PATCH] docs: add note about sending merge-requests from forks

2019-01-23 Thread Erik Faye-Lund
On Wed, 2019-01-23 at 10:42 +, Eric Engestrom wrote: > On Wednesday, 2019-01-23 11:21:27 +0100, Erik Faye-Lund wrote: > > On Wed, 2019-01-23 at 10:14 +, Daniel Stone wrote: > > > Hi, > > > > > > On Wed, 23 Jan 2019 at 10:09, Eric Engestrom <

Re: [Mesa-dev] [PATCH] anv,radv: Disable VK_EXT_pci_bus_info

2018-12-10 Thread Erik Faye-Lund
On Mon, 2018-12-10 at 11:04 -0600, Jason Ekstrand wrote: > The Vulkan working group recently discovered that we made a mistake > in > assuming that PCI domains are 16-bit even though they can potentially > be > 32-bit values. To fix this, the next spec update will chang the chang -> change >

Re: [Mesa-dev] [PATCH v3] mesa: Fix GLES2 OES float texture framebuffer rendering.

2018-12-12 Thread Erik Faye-Lund
On Wed, 2018-12-12 at 09:27 +0200, Tapani Pälli wrote: > > On 12/12/18 8:42 AM, Tapani Pälli wrote: > > > > On 12/12/18 5:05 AM, Nick Kreeger wrote: > > > This change enables GLES2 to render float/half-float textures to > > > a > > > framebuffer when the appropriate OES extensions are available.

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-12 Thread Erik Faye-Lund
tring this out! With or without any bots or anything :) Acked-by: Erik Faye-Lund > I know some people are somewhat skeptical as to how well it will work > but they won't be able to see until we actually start experimenting > with it which we can't do until we allow MRs. Personally, I s

Re: [Mesa-dev] [PATCH v6 5/8] mesa/st: rework support for sRGB framebuffer attachements

2018-12-13 Thread Erik Faye-Lund
On Thu, 2018-11-15 at 13:45 +0100, Gert Wollny wrote: > @@ -457,14 +458,15 @@ st_framebuffer_create(struct st_context *st, > * format such that util_format_srgb(visual->color_format) can be > supported > * by the pipe driver. We still need to advertise the capability > here. > * >

Re: [Mesa-dev] [PATCH v6 0/8] Add and enable extension EXT_sRGB_write_control

2018-12-13 Thread Erik Faye-Lund
On Thu, 2018-11-15 at 13:45 +0100, Gert Wollny wrote: > From: Gert Wollny > > Dear all, > > after the RFC and Ilias comments I reworked the series another > time. > Changes with respect to the RFC are > - renaming the new CAP > - reordering of the patches that no double checking of >

Re: [Mesa-dev] PSA: Please send MRs to the mailing list

2018-12-18 Thread Erik Faye-Lund
On Mon, 2018-12-17 at 16:13 -0600, Jason Ekstrand wrote: > On Mon, Dec 17, 2018 at 2:13 PM Jason Ekstrand > wrote: > > On Mon, Dec 17, 2018 at 1:53 PM Eric Anholt > > wrote: > > > Jason Ekstrand writes: > > > > > > > I don't know if it was actually in the doc that Jordan wrote up > > > but

Re: [Mesa-dev] [PATCH] mesa: GLES2 fix for OES float/half-float textures.

2018-12-11 Thread Erik Faye-Lund
n. Reviewed-by: Erik Faye-Lund > --- > src/mesa/main/glformats.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c > index 3a91600..785d720 100644 > --- a/src/mesa/main/glformats.c

Re: [Mesa-dev] [PATCH] svga: Enable rendering of float/half-float

2018-12-11 Thread Erik Faye-Lund
On Mon, 2018-12-10 at 16:36 -0500, Nick Kreeger wrote: > In GLES2 - if extensions are present, float and half-float textures > can > be used for rendering. This change enables the svga driver to handle > rendering these types. > --- > src/gallium/drivers/svga/svga_screen.c | 6 -- > 1 file

Re: [Mesa-dev] [PATCH] mesa: Fix GLES2 OES float texture framebuffer rendering.

2018-12-11 Thread Erik Faye-Lund
On Mon, 2018-12-10 at 16:31 -0500, Ilia Mirkin wrote: > On Mon, Dec 10, 2018 at 4:28 PM Nick Kreeger > wrote: > > This change enables GLES2 chagnes to render > > > > This change enables GLES2 to render float/half-float textures to a > > framebuffer when the appropriate OES extensions are

Re: [Mesa-dev] [PATCH 04/11] st/mesa: Use Array._DrawVAO in st_atom_array.c.

2018-12-11 Thread Erik Faye-Lund
On Tue, 2018-12-11 at 10:37 +0100, Mathias Fröhlich wrote: > Hey, > > On Tuesday, 11 December 2018 10:19:47 CET Erik Faye-Lund wrote: > > On Mon, 2018-12-10 at 18:23 +0100, Mathias Fröhlich wrote: > > > Hi Erik, > > > > > > Not sure if this is our

Re: [Mesa-dev] [PATCH 04/11] st/mesa: Use Array._DrawVAO in st_atom_array.c.

2018-12-11 Thread Erik Faye-Lund
On Mon, 2018-12-10 at 18:23 +0100, Mathias Fröhlich wrote: > Hi Erik, > > Not sure if this is our problem as I think that I only saw simple > bindings with a zero instance divisor while debugging supertux kart. > > But at least I think that this is a problem in virglrenderer. The >

Re: [Mesa-dev] [PATCH 4/4] virgl: work around bad assumptions in virglrenderer

2018-12-12 Thread Erik Faye-Lund
On Wed, 2018-12-12 at 06:18 +0100, Mathias Fröhlich wrote: > Erik, > > On Tuesday, 11 December 2018 15:29:49 CET Erik Faye-Lund wrote: > > On Tue, 2018-12-11 at 15:26 +0100, Erik Faye-Lund wrote: > > > Virglrenderer does the wrong thing when given an instance > > &g

Re: [Mesa-dev] [PATCH 04/11] st/mesa: Use Array._DrawVAO in st_atom_array.c.

2018-12-11 Thread Erik Faye-Lund
On Tue, 2018-12-11 at 11:42 +0100, Mathias Fröhlich wrote: > Erik, > > > Yeah, in both D3D11 and D3D12, InstanceDataStepRate is per element, > > not > > per input slot. So I guess this is the most flexible way of > > describing > > this, and we'll have to duplicate the bindings in cases like

<    1   2   3   4   5   6   7   8   >