Re: [Mesa-dev] [PATCH] mesa/st: swap order of clear() and clear_with_quad()

2018-11-14 Thread Erik Faye-Lund
On Tue, 2018-11-13 at 21:53 -0500, Marek Olšák wrote: > > > On Tue, Nov 13, 2018, 6:00 PM Rob Clark > On Tue, Nov 13, 2018 at 5:25 PM Eric Anholt > > wrote: > > > > > > Rob Clark writes: > > > > > > > If we can't clear all the buffers with pctx->clear() (say, for > > example, > > > > because o

[Mesa-dev] [PATCH 15/30] mesa/main: do not allow ARB_depth_buffer_float enums before gles3

2018-11-19 Thread Erik Faye-Lund
, let's make a helper for it. Signed-off-by: Erik Faye-Lund --- src/mesa/main/context.h | 6 ++ src/mesa/main/glformats.c | 6 +++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h index c51b3c17c0d..14f9a6b8987 100644

[Mesa-dev] [PATCH 10/30] mesa/main: do not allow astc enums on gles1

2018-11-19 Thread Erik Faye-Lund
ums there. Signed-off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c index 2e2ef9a05bb..b715af1a468 100644 --- a/src/mesa/main/glformats.c +++ b/src/mesa/main/glfo

[Mesa-dev] [PATCH 05/30] mesa/main: clean up ES2_compatibility check

2018-11-19 Thread Erik Faye-Lund
This makes the logic a little bit easier to follow; this is *either* about ES2 compatibility *or* about gles. GL_RGB565 was added already in OpenGL ES 1.0. Signed-off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa

[Mesa-dev] [PATCH 06/30] mesa/main: clean up integer texture check

2018-11-19 Thread Erik Faye-Lund
This makes the logic a little bit easier to follow, and reduce a bit of repetition. Signed-off-by: Erik Faye-Lund --- src/mesa/main/context.h | 6 ++ src/mesa/main/glformats.c | 27 +++ 2 files changed, 17 insertions(+), 16 deletions(-) diff --git a/src/mesa/main

[Mesa-dev] [PATCH 13/30] mesa/main: do not allow ARB_texture_rgb10_a2ui enums before gles3

2018-11-19 Thread Erik Faye-Lund
ARB_texture_rgb10_a2ui isn't supported on OpenGL ES, we shouldn't expose it there even if the driver supports it. Signed-off-by: Erik Faye-Lund --- src/mesa/main/context.h | 6 ++ src/mesa/main/glformats.c | 12 ++-- 2 files changed, 12 insertions(+), 6 deletions(-) di

[Mesa-dev] [PATCH 07/30] mesa/main: use _mesa_has_FOO_bar for compressed format checks

2018-11-19 Thread Erik Faye-Lund
_mesa_has_FOO_bar() knows about the APIs these extensions should be supported under, so let's use that to simplify these checks a bit. Signed-off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 04/30] mesa/main: clean up OES_texture_float_linear check

2018-11-19 Thread Erik Faye-Lund
alled for OpenGL ES 3.x right now. But if this was to change in the future, this makes the function behave a lot more predictable. Signed-off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/glformats.c b/src/mesa

[Mesa-dev] [PATCH 01/30] mesa/main: make _mesa_has_tessellation return bool

2018-11-19 Thread Erik Faye-Lund
All other _mesa_has_foo functions return bool rather than GLboolean, so let's follow that style here as well. Signed-off-by: Erik Faye-Lund --- src/mesa/main/context.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h

[Mesa-dev] [PATCH 08/30] mesa/main: do not allow s3tc enums on gles1

2018-11-19 Thread Erik Faye-Lund
lso need to use _mesa_has_EXT_texture_compression_s3tc() instead of checking the driver cap directly, otherwise we end up enabling this on OpenGL ES 1.x, as the API isn't checked. Signed-off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) d

[Mesa-dev] [PATCH 02/30] mesa/main: rename format-check function

2018-11-19 Thread Erik Faye-Lund
cing-prefix from the name. Signed-off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 12 ++-- src/mesa/main/glformats.h | 6 +++--- src/mesa/main/teximage.c | 4 ++-- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/glformats.c b/src/mesa/ma

[Mesa-dev] [PATCH 00/30] do not allow invalid texture-format enums

2018-11-19 Thread Erik Faye-Lund
test was fixed, namely oes_packed_depth_stencil-depth-stencil-texture_gles1. I don't think this is worth back-porting to old releases, as this only prevents broken code from incorrectly working, not the other way around. Erik Faye-Lund (30): mesa/main: make _mesa_has_tessellation return bool mesa/main:

[Mesa-dev] [PATCH 03/30] mesa/main: clean up S3_s3tc check

2018-11-19 Thread Erik Faye-Lund
S3_s3tc is the extension that enables this functionality on desktop, so let's check for that one. The _mesa_has_S3_s3tc() helper already verifies the API according to the extension-table. Signed-off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 8 +++- 1 file changed, 3 inser

[Mesa-dev] [PATCH 17/30] mesa/main: do not allow rg-textures enums before gles3

2018-11-19 Thread Erik Faye-Lund
EXT_packed_float isn't supported on OpenGL ES, we shouldn't allow these enums there, before OpenGL ES 3.0 which also introduce support for these enums. Since this check is repeated a lot, let's make a helper for this. Signed-off-by: Erik Faye-Lund --- src/mesa/main/context.h |

[Mesa-dev] [PATCH 11/30] mesa/main: do not allow depth-texture enums on gles1

2018-11-19 Thread Erik Faye-Lund
epth textures on OpenGL and OpenGL ES 2.0+. There's no extension enabling depth-textures for OpenGL ES 1.x, so we shouldn't allow those enums there. This fixes oes_packed_depth_stencil-depth-stencil-texture_gles1 on i965 Signed-off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 3

[Mesa-dev] [PATCH 12/30] mesa/main: do not allow stencil-texture enums on gles1

2018-11-19 Thread Erik Faye-Lund
support depth textures on OpenGL and OpenGL ES 2.0+. There's no extension enabling stencil-textures for OpenGL ES 1.x, so we shouldn't allow those enums there. Signed-off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) dif

[Mesa-dev] [PATCH 14/30] mesa/main: do not allow integer-texture enums before gles3

2018-11-19 Thread Erik Faye-Lund
Integer textures shouldn't be implicitly exposed on OpenGL ES 1.x and 2.x, but because the code checked against a driver-capability rather than using an extension-check helper, we ended up accidentally allowing these enums on older versions when the driver supports it. Signed-off-by: Erik

[Mesa-dev] [PATCH 28/30] mesa/st: do not probe for the same texture-formats twice

2018-11-19 Thread Erik Faye-Lund
This should be equalent of what we did before. Signed-off-by: Erik Faye-Lund --- src/mesa/state_tracker/st_extensions.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 16889074f66

[Mesa-dev] [PATCH 19/30] mesa/main: do not allow MESA_ycbcr_texture enums on gles

2018-11-19 Thread Erik Faye-Lund
This extension requies OpenGL, and shouldn't be available on OpenGL ES. So let's not allow the enums from it either. Signed-off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/glformats.c b/src

[Mesa-dev] [PATCH 25/30] mesa/main: split float-texture support checking in two

2018-11-19 Thread Erik Faye-Lund
irst place. Signed-off-by: Erik Faye-Lund --- src/mesa/main/context.h | 14 ++ src/mesa/main/glformats.c | 39 +-- 2 files changed, 43 insertions(+), 10 deletions(-) diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h index 071bd5b0818..b

[Mesa-dev] [PATCH 24/30] mesa/main: do not allow EXT_texture_sRGB_R8 enums before gles3

2018-11-19 Thread Erik Faye-Lund
#x27;s tighten the check. Signed-off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c index 6c9d8b88d79..d79bcedffd9 100644 --- a/src/mesa/main/glformats.c +++ b/src/mes

[Mesa-dev] [PATCH 23/30] mesa/main: do not allow sRGB texture enums before gles3

2018-11-19 Thread Erik Faye-Lund
tighten the check. Signed-off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c index 0a42d3dd9a0..6c9d8b88d79 100644 --- a/src/mesa/main/glformats.c +++ b/src/mesa/main/glfo

[Mesa-dev] [PATCH 22/30] mesa/main: do not allow snorm-texture enums before gles3

2018-11-19 Thread Erik Faye-Lund
#x27;s tighten the check. Signed-off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c index 453465fb1c8..0a42d3dd9a0 100644 --- a/src/mesa/main/glformats.c +++ b/src/mesa/main/glfo

[Mesa-dev] [PATCH 30/30] mesa/st: require linear interpolation for ARB_texture_float

2018-11-19 Thread Erik Faye-Lund
There's nothing in the ARB_texture_float specification that limits filterability for floating-point textures, so we need to ensure that this is required to enable this extension. Luckily, we have just the right bits ready. Signed-off-by: Erik Faye-Lund --- src/mesa/state_tracker/st_extensi

[Mesa-dev] [PATCH 26/30] mesa/main: require EXT_texture_type_2_10_10_10_REV for gles3

2018-11-19 Thread Erik Faye-Lund
OpenGL ES 3.0 require this functionality, so we should also test for it to avoid incorrectly exposing a too high GLES version. On desktop, this has been required since all the way back in OpenGL 1.2 anyway. Signed-off-by: Erik Faye-Lund --- src/mesa/main/version.c | 3 ++- 1 file changed, 2

[Mesa-dev] [PATCH 29/30] mesa/main: do not require float-texture filtering for es3

2018-11-19 Thread Erik Faye-Lund
The OpenGL ES 3.0 specification, table 3.13 lists half-float textures as filterable, but not float textures. So we shouldn't depend on ARB_float_texture, which requires full filtering support for both. Signed-off-by: Erik Faye-Lund --- src/mesa/main/version.c | 4 +++- 1 file chang

[Mesa-dev] [PATCH 18/30] mesa/main: do not allow EXT_texture_shared_exponent enums before gles3

2018-11-19 Thread Erik Faye-Lund
repeated, let's introduce a helper. Signed-off-by: Erik Faye-Lund --- src/mesa/main/context.h | 6 ++ src/mesa/main/glformats.c | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h index af81717d9bd..7db3b94e0b6 100644 -

[Mesa-dev] [PATCH 27/30] mesa/main: require EXT_texture_sRGB for gles3

2018-11-19 Thread Erik Faye-Lund
sRGB textures is a requirement for OpenGL ES 3.0, so let's make sure we don't incorrectly enable a too high version. Signed-off-by: Erik Faye-Lund --- src/mesa/main/version.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c index b

[Mesa-dev] [PATCH 20/30] mesa/main: do not allow type_2_10_10_10_REV enums before gles3

2018-11-19 Thread Erik Faye-Lund
ums there. Signed-off-by: Erik Faye-Lund --- src/mesa/main/context.h | 7 +++ src/mesa/main/glformats.c | 6 +++--- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h index 7db3b94e0b6..071bd5b0818 100644 --- a/src/mesa/main/c

[Mesa-dev] [PATCH 21/30] mesa/main: do not allow floating-point texture enums on gles1

2018-11-19 Thread Erik Faye-Lund
#x27;t allow those enums there. Signed-off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c index 2ac3110187f..453465fb1c8 100644 --- a/src/mesa/main/glf

[Mesa-dev] [PATCH 09/30] mesa/main: do not allow etc2 enums on gles1

2018-11-19 Thread Erik Faye-Lund
re. Signed-off-by: Erik Faye-Lund --- src/mesa/main/glformats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c index 964235bb72f..2e2ef9a05bb 100644 --- a/src/mesa/main/glformats.c +++ b/src/mesa/main/glformats.c

[Mesa-dev] [PATCH 16/30] mesa/main: do not allow EXT_packed_float enums before gles3

2018-11-19 Thread Erik Faye-Lund
EXT_packed_float isn't supported on OpenGL ES, we shouldn't allow these enums there, before OpenGL ES 3.0 which also introduce support for these enums. Signed-off-by: Erik Faye-Lund --- src/mesa/main/context.h | 6 ++ src/mesa/main/glformats.c | 6 +++--- 2 files changed, 9

Re: [Mesa-dev] [PATCH 30/30] mesa/st: require linear interpolation for ARB_texture_float

2018-11-19 Thread Erik Faye-Lund
h the lack of FP32-interpolation... > On Mon, Nov 19, 2018 at 7:16 AM Erik Faye-Lund > wrote: > > There's nothing in the ARB_texture_float specification that limits > > filterability for floating-point textures, so we need to ensure > > that > > this is requi

Re: [Mesa-dev] [PATCH 30/30] mesa/st: require linear interpolation for ARB_texture_float

2018-11-19 Thread Erik Faye-Lund
On Mon, 2018-11-19 at 11:13 -0500, Ilia Mirkin wrote: > On Mon, Nov 19, 2018 at 10:40 AM Erik Faye-Lund > wrote: > > On Mon, 2018-11-19 at 10:02 -0500, Ilia Mirkin wrote: > > > Unfortunately this will drop GL 3.0 from Adreno A3xx. I think > > > we'd > > &g

Re: [Mesa-dev] [PATCH 30/30] mesa/st: require linear interpolation for ARB_texture_float

2018-11-19 Thread Erik Faye-Lund
On Mon, 2018-11-19 at 11:37 -0500, Ilia Mirkin wrote: > On Mon, Nov 19, 2018 at 11:30 AM Erik Faye-Lund > wrote: > > On Mon, 2018-11-19 at 11:13 -0500, Ilia Mirkin wrote: > > > On Mon, Nov 19, 2018 at 10:40 AM Erik Faye-Lund > > > wrote: > > > > On M

Re: [Mesa-dev] [PATCH 25/30] mesa/main: split float-texture support checking in two

2018-11-19 Thread Erik Faye-Lund
On Mon, 2018-11-19 at 18:43 +0100, Francesco Ansanelli wrote: > Hi Eric, > > While checking this patch I noticed an extra semicolon in this > function: > +static inline bool > +_mesa_has_half_float_textures(const struct gl_context *ctx) > +{ > + return _mesa_has_ARB_texture_float(ctx) || > +

Re: [Mesa-dev] [PATCH 30/30] mesa/st: require linear interpolation for ARB_texture_float

2018-11-20 Thread Erik Faye-Lund
cting this would be the right thing to do in theory, but I have no practical use-case for it, so I'm happy to drop the patch for now. > > From: mesa-dev on behalf of > Ilia Mirkin > Sent: Monday, November 19, 2018 5:37:58 PM > To: Erik

Re: [Mesa-dev] [PATCH 30/30] mesa/st: require linear interpolation for ARB_texture_float

2018-11-20 Thread Erik Faye-Lund
now. I'd still like to know what you're referring to, though. > On Mon, Nov 19, 2018 at 7:15 AM Erik Faye-Lund < > erik.faye-l...@collabora.com> wrote: > > There's nothing in the ARB_texture_float specification that limits > > filterability for floating-po

Re: [Mesa-dev] [PATCH 30/30] mesa/st: require linear interpolation for ARB_texture_float

2018-11-20 Thread Erik Faye-Lund
On Tue, 2018-11-20 at 10:08 +0100, Erik Faye-Lund wrote: > On Tue, 2018-11-20 at 01:21 -0500, Marek Olšák wrote: > > I'd like to keep ARB_texture_float enabled on drivers that don't > > support linear interpolation. ARB_texture_float is required by DX9, > &g

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

2019-05-21 Thread Erik Faye-Lund
41 AM, GitLab Mirror wrote: > Module: Mesa > Branch: master > Commit: eb85124a9f6e9cb94d0d4a99f91bbae374777e3a > URL:    https://nam04.safelinks.protection.outlook.com/?url="" > > Author: Erik Faye-Lund > Date:   Mon May 20 13:29:05 2019 +0200 > >

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

2019-05-21 Thread Erik Faye-Lund
lder versions or live with pre- processing. We can cross that bridge when we get there. Perhaps by then the world looks a bit differently? On Tue, 2019-05-21 at 15:51 +0200, Erik Faye-Lund wrote: > Right. I guess with an old enough bison version, this can happen. > I'll see if I can come

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

2019-05-22 Thread Erik Faye-Lund
On Wed, 2019-05-22 at 15:21 +0200, Hans Åberg wrote: > > On 22 May 2019, at 08:54, Erik Faye-Lund < > > erik.faye-l...@collabora.com> wrote: > > > > The problem is that Bison doesn't seem to have any mechanism for > > doing > > statements like the

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

2019-05-23 Thread Erik Faye-Lund
On Wed, 2019-05-22 at 20:41 +0200, Akim Demaille wrote: > > Le 22 mai 2019 à 18:06, Akim Demaille a écrit > > : > > > > Hi Erik, > > > > > Le 22 mai 2019 à 08:54, Erik Faye-Lund < > > > erik.faye-l...@collabora.com> a écrit : > >

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

2019-05-23 Thread Erik Faye-Lund
On Wed, 2019-05-22 at 18:06 +0200, Akim Demaille wrote: > Hi Erik, > > > Le 22 mai 2019 à 08:54, Erik Faye-Lund < > > erik.faye-l...@collabora.com> a écrit : > > > > I ended up reverting the change [from-%error-verbose to %define > > parse.error ver

Re: [Mesa-dev] [PATCH] list: add some iterator debug

2019-05-27 Thread Erik Faye-Lund
On Sat, 2019-05-25 at 15:44 -0700, Rob Clark wrote: > This ends up embedded in a for loop expression, ie. the C part in an > for (A;B;C) > > iirc, that means it needs to be a C expr rather than statement.. or > something roughly like that, I'm too lazy to dig out my C grammar > Can't you just ca

Re: [Mesa-dev] [PATCH] list: add some iterator debug

2019-05-27 Thread Erik Faye-Lund
On Mon, 2019-05-27 at 04:23 -0700, Rob Clark wrote: > On Mon, May 27, 2019 at 2:50 AM Erik Faye-Lund > wrote: > > On Sat, 2019-05-25 at 15:44 -0700, Rob Clark wrote: > > > This ends up embedded in a for loop expression, ie. the C part in > > > an > > > for (

Re: [Mesa-dev] [PATCH] list: add some iterator debug

2019-05-27 Thread Erik Faye-Lund
On Mon, 2019-05-27 at 13:37 +0200, Erik Faye-Lund wrote: > On Mon, 2019-05-27 at 04:23 -0700, Rob Clark wrote: > > On Mon, May 27, 2019 at 2:50 AM Erik Faye-Lund > > wrote: > > > On Sat, 2019-05-25 at 15:44 -0700, Rob Clark wrote: > > > > This ends up embedded

[Mesa-dev] mirroring ogl-sample source code in gitlab?

2019-06-11 Thread Erik Faye-Lund
While looking into dead-links on our website, I noticed that the OpenGL Sample Implementation that SGI open sourced lacks a proper public mirror. So I'm looking to fix this. The tarballs are currently available from here: http://www.servu.org/mirror/old/mirrors.bufferoverflow.xyz/oss.sgi.com/proje

Re: [Mesa-dev] mirroring ogl-sample source code in gitlab?

2019-06-12 Thread Erik Faye-Lund
On Tue, 2019-06-11 at 12:41 -0400, Adam Jackson wrote: > On Tue, 2019-06-11 at 11:13 +0200, Erik Faye-Lund wrote: > > > So here's the question: How does people feel about hosting this > > under > > https://gitlab.freedesktop.org/mesa/ogl-sample/? If people are OK &

Re: [Mesa-dev] mirroring ogl-sample source code in gitlab?

2019-06-12 Thread Erik Faye-Lund
On Wed, 2019-06-12 at 10:25 +0200, Erik Faye-Lund wrote: > On Tue, 2019-06-11 at 12:41 -0400, Adam Jackson wrote: > > On Tue, 2019-06-11 at 11:13 +0200, Erik Faye-Lund wrote: > > > > > So here's the question: How does people feel about hosting

Re: [Mesa-dev] mirroring ogl-sample source code in gitlab?

2019-06-13 Thread Erik Faye-Lund
On Wed, 2019-06-12 at 14:03 -0400, Adam Jackson wrote: > On Wed, 2019-06-12 at 10:29 +0200, Erik Faye-Lund wrote: > > On Wed, 2019-06-12 at 10:25 +0200, Erik Faye-Lund wrote: > > > On Tue, 2019-06-11 at 12:41 -0400, Adam Jackson wrote: > > > > On Tue, 2019-06-11

[Mesa-dev] Proposal for the future of www.mesa3d.org

2019-06-21 Thread Erik Faye-Lund
A while back, Laura and Jean was working on a Sphinx-conversion of the mesa-documentation. Sadly this work stranded due to it also trying to move to using GitLab Pages for hosting www.mesa3d.org, and because the documentation and the websit eis the same thing, this lead to problems with hosting the

Re: [Mesa-dev] [PATCH] panfrost: Rewrite u-interleaving code

2019-07-03 Thread Erik Faye-Lund
On Tue, 2019-06-25 at 12:36 -0700, Vasily Khoruzhick wrote: > On Tue, Jun 25, 2019 at 11:54 AM Alyssa Rosenzweig > wrote: > > Hi Alyssa, > > > Rather than using a magic lookup table with no explanations, let's > > add > > liberal comments to the code to explain what this tiling scheme is > > and

Re: [Mesa-dev] [PATCH v4 0/5] EGL_KHR_partial_update support

2019-07-03 Thread Erik Faye-Lund
On Tue, 2019-06-25 at 18:37 +0200, Boris Brezillon wrote: > This is an attempt at resurrecting Daniel's MR [1] which was already > resurrecting Harish's EGL_KHR_partial_update series [2]. This version > implements Marek's suggestion to pass the set_damage_region() > directly > to the gallium driver

Re: [Mesa-dev] [PATCH v4 4/5] st/dri2: Implement DRI2bufferDamageExtension

2019-07-03 Thread Erik Faye-Lund
On Wed, 2019-06-26 at 10:34 -0700, Alyssa Rosenzweig wrote: > Ah-ha, now we're into parts of the stack I can claim to understand! > >:) > > Reviewed-by: Alyssa Rosenzweig > > On Tue, Jun 25, 2019 at 06:37:48PM +0200, Boris Brezillon wrote: > > From: Daniel Stone > > > > Add a pipe_screen->set_

Re: [Mesa-dev] boolean usage in gallium

2019-07-03 Thread Erik Faye-Lund
On Sat, 2019-06-29 at 00:08 -0400, Ilia Mirkin wrote: > Ken pointed out on IRC today that there was still a lot of "boolean" > (vs bool/_Bool) usage in gallium. In fact, many interfaces are > specified with boolean. > > I had it in my mind that I had at some point removed most boolean > usage, but

Re: [Mesa-dev] [PATCH v4 4/5] st/dri2: Implement DRI2bufferDamageExtension

2019-07-03 Thread Erik Faye-Lund
On Wed, 2019-07-03 at 12:33 +0200, Boris Brezillon wrote: > On Wed, 03 Jul 2019 11:54:29 +0200 > Erik Faye-Lund wrote: > > > On Wed, 2019-06-26 at 10:34 -0700, Alyssa Rosenzweig wrote: > > > Ah-ha, now we're into parts of the stack I

Re: [Mesa-dev] [PATCH] panfrost: Take into account off-screen FBOs

2019-07-04 Thread Erik Faye-Lund
On Thu, 2019-07-04 at 10:02 +0200, Tomeu Vizoso wrote: > In that case, ctx->pipe_framebuffer.cbufs[0] can be NULL. > > Signed-off-by: Tomeu Vizoso > Cc: Boris Brezillon > Fixes: 5375d009be18 ("panfrost: Pass referenced BOs to the SUBMIT > ioctls") Nit: this isn't really about off-screen vs on-s

[Mesa-dev] [PATCH 0/5] gallium: kill PIPE_CAP_SM3

2019-07-05 Thread Erik Faye-Lund
nstance, some drivers might be able to enable PIPE_CAP_VERTEX_SHADER_SATURATE without enabling the rest. But for now, I leave that up to follow-up patches. I'm intentionally sending just the cover-letter here. You can see the merge request on gitlab here: https://gitlab.freedesktop.org/mesa/mesa/merge_requests/

Re: [Mesa-dev] [PATCH 03/11] panfrost/midgard: Flush undefineds to zero

2019-07-10 Thread Erik Faye-Lund
On Wed, 2019-07-10 at 06:24 -0700, Alyssa Rosenzweig wrote: > Fixes a buggy dEQP test. > > Signed-off-by: Alyssa Rosenzweig > --- > .../drivers/panfrost/ci/expected-failures.txt | 6 -- > src/gallium/drivers/panfrost/meson.build | 1 + > .../drivers/panfrost/midgard/compiler.h | 6

Re: [Mesa-dev] [PATCH 03/11] panfrost/midgard: Flush undefineds to zero

2019-07-10 Thread Erik Faye-Lund
On Wed, 2019-07-10 at 06:24 -0700, Alyssa Rosenzweig wrote: > Fixes a buggy dEQP test. > Maybe you could share which test this fixes, so someone can fix it? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman

Re: [Mesa-dev] [PATCH] virgl: Set meta data for textures from handle.

2019-07-17 Thread Erik Faye-Lund
1); > + virgl_resource_layout(&res->u.b, &res->metadata); > > res->hw_res = vs->vws->resource_create_from_handle(vs->vws, > whandle); > if (!res->hw_res) { Whoops! Good catch, sorry for the mess! Reviewed-by: Erik Faye-Lund

<    3   4   5   6   7   8