On Wed, 2015-06-10 at 17:03 -0700, Kenneth Graunke wrote:
> On Wednesday, June 10, 2015 09:07:32 AM Iago Toral Quiroga wrote:
> > In commit fe74fee8fa721a we rounded the line width to the nearest integer to
> > match the GLES3 spec requirements stated in section 13.4.2.1, but th
On Thu, 2015-06-11 at 00:18 -0700, Kenneth Graunke wrote:
> On Thursday, June 11, 2015 09:03:37 AM Iago Toral Quiroga wrote:
> > The same fix Marius implemented for gen6 (commit a9b04d8a) and
> > gen7 (commit 24ecf37a).
> > ---
> > src/mesa/drivers/dr
Reviewed-by: Iago Toral Quiroga
On Thu, 2015-06-11 at 01:59 -0700, Kenneth Graunke wrote:
> We already recognize min(max(a, 0.0), 1.0) as a saturate, but neglected
> this variant (which is also handled by the GLSL IR pass).
>
> shader-db results on Broadwell:
> total instruc
Thanks Ken, this does make debugging NIR code a bit easier :)
Reviewed-by: Iago Toral Quiroga
On Wed, 2015-06-10 at 02:39 -0700, Kenneth Graunke wrote:
> This makes the SSA definitions use sequential numbers (0, 1, 2, ...)
> instead of seemingly random ones. There's not much poi
Reviewed-by: Iago Toral Quiroga
On Thu, 2015-06-11 at 09:58 -0700, Anuj Phogat wrote:
> Signed-off-by: Anuj Phogat
> ---
> src/mesa/main/readpix.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix
Oh, I missed that we had that helper function available for this...
With the patch that adds the integer formats to the helper function this
is:
Reviewed-by: Iago Toral Quiroga
On Wed, 2015-06-10 at 16:54 -0700, Anuj Phogat wrote:
> Signed-off-by: Anuj Phogat
> ---
> src/mesa/main/
On Tue, 2015-06-16 at 23:52 -0700, Ben Widawsky wrote:
> On Tue, Feb 24, 2015 at 07:02:50PM +0100, Eduardo Lima Mitev wrote:
> > From: Iago Toral Quiroga
> >
> > We can't use sampler messages with gradient information (like
> > sample_g or sample_d) to deal with
On Tue, 2015-06-16 at 23:52 -0700, Ben Widawsky wrote:
> On Tue, Feb 24, 2015 at 07:02:50PM +0100, Eduardo Lima Mitev wrote:
> > From: Iago Toral Quiroga
> >
> > We can't use sampler messages with gradient information (like
> > sample_g or sample_d) to deal with
ead, so if nobody else has
objections this is:
Reviewed-by: Iago Toral Quiroga
> Signed-off-by: Rob Clark
> ---
> v2: Added similar helper for nir_src, and cleaned up a few places that
> open coded this. There are a couple left (such as validate_alu_src())
> but that handle is_pa
even if we have multiple invocations, keeping the relative order
of reads and writes within each one is necessary.
Iago
> -Jordan
>
> On 2015-06-03 00:01:13, Iago Toral Quiroga wrote:
> > SSBOs are read/write and this CSE pass only handles read-only variables.
> > ---
On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote:
> Without this patch, arb_color_buffer_float-readpixels test fails, when
> forced to use meta pbo path.
>
> Signed-off-by: Anuj Phogat
> Cc:
> ---
> src/mesa/drivers/common/meta_tex_subimage.c | 10 ++
> 1 file changed, 6 insertions(
On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote:
> Signed-off-by: Anuj Phogat
> Cc:
> ---
> src/mesa/main/readpix.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c
> index caa2648..a9416ef 100644
> --- a/src/mesa/main/readpix.c
>
On Thu, 2015-06-18 at 09:19 -0700, Anuj Phogat wrote:
> On Thu, Jun 18, 2015 at 7:09 AM, Iago Toral wrote:
> > On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote:
> >> Signed-off-by: Anuj Phogat
> >> Cc:
> >> ---
> >> src/mesa/main/readpi
Reviewed-by: Iago Toral Quiroga
On Thu, 2015-06-18 at 17:50 -0700, Jason Ekstrand wrote:
> This makes things a little simpler, more efficient, and quite a bit more
> readable.
> ---
> src/mesa/drivers/dri/i965/brw_fs.cpp | 45
> ++--
>
; explicitly be always one register.
Right, in fact we were incorrectly computing a size of 2 registers in
SIMD16 executions because of this.
Reviewed-by: Iago Toral Quiroga
> ---
> src/mesa/drivers/dri/i965/brw_fs.cpp | 6 ++
> 1 file changed, 6 insertions(+)
>
> d
Reviewed-by: Iago Toral Quiroga
On Thu, 2015-06-18 at 17:50 -0700, Jason Ekstrand wrote:
> ---
> src/mesa/drivers/dri/i965/brw_fs.cpp | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
> b/src/mesa/drivers/dri/i965/brw_fs.c
On Thu, 2015-06-18 at 17:50 -0700, Jason Ekstrand wrote:
> Soon we will start using the builder to explicitly set all the execution
> sizes. We could make a 32-wide builder, but the builder asserts that we
> never grow it which is usually a reasonable assumption. Sinc this one
> instruction is a
On Fri, 2015-06-19 at 07:01 -0700, Jason Ekstrand wrote:
>
> On Jun 19, 2015 5:09 AM, "Iago Toral" wrote:
> >
> > On Thu, 2015-06-18 at 17:50 -0700, Jason Ekstrand wrote:
> > > Soon we will start using the builder to explicitly set all the
> executi
On Fri, 2015-06-19 at 13:32 -0700, Anuj Phogat wrote:
> On Thu, Jun 18, 2015 at 11:41 PM, Iago Toral wrote:
> > On Thu, 2015-06-18 at 09:19 -0700, Anuj Phogat wrote:
> >> On Thu, Jun 18, 2015 at 7:09 AM, Iago Toral wrote:
> >> > On Tue, 2015-06-16 at
be we can check if we are using any memorybarriers in the
shader code and decide if we want to enable these optimizations for
ssbos based on that. I think we can try to do that in a later patch.
Iago
> -Jordan
>
> On 2015-06-03 00:01:16, Iago Toral Quiroga wrote:
> > Since the back
On Mon, 2015-06-22 at 12:35 -0700, Anuj Phogat wrote:
> On Sun, Jun 21, 2015 at 11:25 PM, Iago Toral wrote:
> > On Fri, 2015-06-19 at 13:32 -0700, Anuj Phogat wrote:
> >> On Thu, Jun 18, 2015 at 11:41 PM, Iago Toral wrote:
> >> > On Thu, 2015-06-18 at 09:19 -0700,
On Tue, 2015-06-23 at 08:54 +0200, Iago Toral wrote:
> On Mon, 2015-06-22 at 12:35 -0700, Anuj Phogat wrote:
> > On Sun, Jun 21, 2015 at 11:25 PM, Iago Toral wrote:
> > > On Fri, 2015-06-19 at 13:32 -0700, Anuj Phogat wrote:
> > >> On Thu, Jun 18, 2015 at 11:41 PM,
Reviewed-by: Iago Toral Quiroga
On Thu, 2015-06-18 at 17:51 -0700, Jason Ekstrand wrote:
> This doesn't affect instructions allocated using the builder.
> ---
> src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp | 9 +
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
Reviewed-by: Iago Toral Quiroga
On Thu, 2015-06-18 at 17:50 -0700, Jason Ekstrand wrote:
> ---
> src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
> b/src/mes
On Thu, 2015-06-18 at 17:51 -0700, Jason Ekstrand wrote:
> We want to move these into the builder so that they know the current
> builder's dispatch width. This will be needed by a later commit.
> ---
> src/mesa/drivers/dri/i965/brw_fs.cpp | 52 ++
> src/mesa/drivers/dri/i965/brw
On Tue, 2015-06-23 at 15:45 -0700, Jordan Justen wrote:
> On 2015-06-22 23:38:14, Iago Toral wrote:
> > On Mon, 2015-06-22 at 14:28 -0700, Jordan Justen wrote:
> > > 24-26 once again makes me wonder if these optimization *can* be used
> > > with SSBOs based on
On Wed, 2015-06-24 at 15:43 +0300, Francisco Jerez wrote:
> Iago Toral writes:
>
> > On Wed, 2015-06-17 at 17:20 -0700, Jordan Justen wrote:
> >> I wanted to question whether this was required, based on this text
> >> from the extension spec:
> >>
>
to use the meta pbo path.
>
> v2: Make need_rgb_to_luminance_conversion() a static function. (Iago)
I think you meant "need_signed_unsigned_int_conversion()" here
Other than that:
Reviewed-by: Iago Toral Quiroga
> Bump up the comment and the commit message.
; explicitly be always one register.
>
> Reviewed-by: Iago Toral Quiroga
>
> v2: Use mlen for determining the number of registers written
I think you meant read instead of written.
With that change my review stays, I had also missed that skylake
required a header.
Iago
Reviewed-by: Iago Toral Quiroga
On Thu, 2015-06-25 at 13:24 -0700, Jason Ekstrand wrote:
> Soon we will start using the builder to explicitly set all the execution
> sizes. We could make a 32-wide builder, but the builder asserts that we
> never grow it which is usually a reasonable a
Reviewed-by: Iago Toral Quiroga
On Thu, 2015-06-25 at 13:24 -0700, Jason Ekstrand wrote:
> Shortly, offset() will depend on the builder so we need it moved to some
> place where it has access to that.
> ---
> src/mesa/drivers/dri/i965/brw_fs.h| 21 +
> s
On Mon, 2015-06-29 at 15:21 +0900, Michel Dänzer wrote:
> On 25.06.2015 21:42, Marek Olšák wrote:
> > Gallium should be alright. We'll let you know if we find a regression,
> > but I don't think there will be any.
>
> Famous last words. :) This change broke the piglit test
> spec@ext_texture_integ
Reviewed-by: Iago Toral Quiroga
On Fri, 2015-06-26 at 13:15 -0700, Anuj Phogat wrote:
> Currently used ctx->_ImageTransferState check is not sufficient
> because it doesn't include the read color clamping enabled with
> GL_CLAMP_READ_COLOR. So, use th
On Mon, 2015-06-29 at 00:11 -0700, Jordan Justen wrote:
> On 2015-06-24 07:36:24, Iago Toral wrote:
> > On Wed, 2015-06-24 at 15:43 +0300, Francisco Jerez wrote:
> > > AFAICT the reason why this (and many of the other changes in GLSL
> > > optimization passes) is needed
Hi Jason,
On Mon, 2015-06-29 at 16:22 -0700, Jason Ekstrand wrote:
> On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev wrote:
> > From: Iago Toral Quiroga
> >
> > This is based on similar code existing in vec4_visitor. It builds the
> > uniform register file ite
efault which should be appropriate for the floats used.
>
> Fixes: 4b249d2ee (mesa: Handle transferOps in texstore_rgba)
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91173
> Signed-off-by: Ilia Mirkin
> Cc: "10.5 10.6"
Looks correct to me, thanks for fixin
On Tue, 2015-06-30 at 09:30 -0700, Jason Ekstrand wrote:
> On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev wrote:
> > From: Iago Toral Quiroga
> >
> > The same we do in the FS NIR backend, only that here we need to consider
> > the number of components in the condi
) function we need
to call then I'll look into having separate paths for scalar and vec4.
Iago
> On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev wrote:
> > From: Iago Toral Quiroga
> >
> > The current implementation operates in scalar mode only, so add a vec4
> &g
On Tue, 2015-06-30 at 11:53 -0700, Jason Ekstrand wrote:
> On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev wrote:
> > From: Iago Toral Quiroga
> >
> > For the indirect case we need to take the index delivered by
> > NIR and compute the parent uniform that we are
On Thu, 2015-07-02 at 09:33 +0200, Iago Toral wrote:
> On Tue, 2015-06-30 at 11:53 -0700, Jason Ekstrand wrote:
> > On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev
> > wrote:
> > > From: Iago Toral Quiroga
> > >
> > > For the indirect case we nee
On Thu, 2015-07-02 at 10:11 -0700, Jason Ekstrand wrote:
> On Wed, Jul 1, 2015 at 11:44 PM, Iago Toral wrote:
> > On Tue, 2015-06-30 at 09:30 -0700, Jason Ekstrand wrote:
> >> On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev
> >> wrote:
> >> > From: Iag
On Thu, 2015-07-02 at 09:31 +0200, Iago Toral wrote:
> On Tue, 2015-06-30 at 11:32 -0700, Jason Ekstrand wrote:
> > I'm not sure what I think about adding an is_scalar flag vs. having
> > _scalar and _vec4 versions of each function. My feeling is that once
> > we tweak
On Fri, 2015-07-03 at 13:23 +0300, Francisco Jerez wrote:
> Samuel Iglesias Gonsálvez writes:
>
> > On 29/06/15 09:11, Jordan Justen wrote:
> >> On 2015-06-24 07:36:24, Iago Toral wrote:
> >>> On Wed, 2015-06-24 at 15:43 +0300, Francisco Jerez wrote:
> >&
On Sun, 2015-07-05 at 19:14 -0700, Jason Ekstrand wrote:
> On Fri, Jul 3, 2015 at 12:32 AM, Iago Toral wrote:
> > On Thu, 2015-07-02 at 10:11 -0700, Jason Ekstrand wrote:
> >> On Wed, Jul 1, 2015 at 11:44 PM, Iago Toral wrote:
> >> > On Tue, 2015-06-30 at 09:
Even if your next patch needs more work this one alone still makes
sense:
Reviewed-by: Iago Toral Quiroga
Iago
On Wed, 2015-07-08 at 14:00 -0700, Matt Turner wrote:
> It's only used inside #ifdef DEBUG. Cuts ~1.7k of .text, and more
> importantly prevents a larger code size regres
Reviewed-by: Iago Toral Quiroga
On Thu, 2015-07-09 at 18:59 -0700, Chad Versace wrote:
> Don't assume that $(top_srcdir)/.git is a directory. It may be a
> gitlink file [1] if $(top_srcdir) is a submodule checkout or a linked
> worktree [2].
>
> [1] A "gitlink" is
it makes sense to claim the same for it.
Timothy: maybe it is a good idea to add some text like that to the
commit log for future reference. With that:
Reviewed-by: Iago Toral Quiroga
Iago
> On Fri, Jul 10, 2015 at 6:41 PM, Timothy Arceri wrote:
> > This implementation should be fast
On Fri, 2015-07-10 at 12:13 +0200, Iago Toral Quiroga wrote:
> As discussed with Jordan, this v3-part1 series contains a good part of the
> frontend stuff (most of which has already been reviewed). The idea is to get
> this landed ahead, since some of the remaining patches (specifically
I think Chris did not review this one:
Reviewed-by: Iago Toral Quiroga
Iago
On Fri, 2015-07-10 at 11:44 -0700, Matt Turner wrote:
> BEGIN_BATCH() and ADVANCE_BATCH() will contain "do {" and "} while (0)"
> respectively to allow declaring local variables used by inte
NULL;
> + }
I think it is probably best to put the destruction of interface_types in
a separate patch, it is a different issue after all. You can add my
Reviewed-by on that patch.
With that and a couple of other minor nitpicks I mention below fixed,
this is:
Reviewed-by: Iago Toral Quiro
BTW, notice that patches 1-3, 5-7 and 51 have already been reviewed by
Jordan.
Iago
On Tue, 2015-07-14 at 09:46 +0200, Iago Toral Quiroga wrote:
> This is the second part of the v3 series including remaining frontend bits
> like the optional unsized array at the bottom of SSBO defin
Reviewed-by: Iago Toral Quiroga
On Mon, 2015-07-13 at 16:22 -0700, Matt Turner wrote:
> Literals without an f/F suffix are of type double, and implicit
> conversion rules specify that the float in (float op double) be
> converted to a double before the operation is performed. I beli
Reviewed-by: Iago Toral Quiroga
On Mon, 2015-07-13 at 16:22 -0700, Matt Turner wrote:
> ---
> src/glsl/nir/nir_opcodes.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/glsl/nir/nir_opcodes.py b/src/glsl/nir/nir_opcodes.py
> index 56e96
his at some point and did not see any issues with enabling this
for GLES 3.1 at the time but then I forgot to enable it, but I need to
double check this though.
Iago
>
> Cheers
>
>
> Mike
>
> On Tue, 14 Jul 2015 at 08:48 Iago Toral Quiroga
> wrote:
>
>
On Tue, 2015-07-14 at 11:30 +0200, Iago Toral wrote:
> Reviewed-by: Iago Toral Quiroga
BTW, ldexpf and copysignf are c99 too, so I guess you'll need to wrap
these too.
Iago
> On Mon, 2015-07-13 at 16:22 -0700, Matt Turner wrote:
> > ---
> > src/glsl/nir/nir_opcodes.
This one will need wrapping for fabsf.
Reviewed-by: Iago Toral Quiroga
On Mon, 2015-07-13 at 16:22 -0700, Matt Turner wrote:
> ---
> src/gallium/auxiliary/util/u_format_rgb9e5.h | 2 +-
> src/gallium/auxiliary/util/u_math.h | 2 +-
> 2 files changed, 2 insertions(+),
Reviewed-by: Iago Toral Quiroga
On Mon, 2015-07-13 at 16:22 -0700, Matt Turner wrote:
> ---
> src/util/register_allocate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/util/register_allocate.c b/src/util/register_allocate.c
> index 2ad8c
Reviewed-by: Iago Toral Quiroga
On Mon, 2015-07-13 at 16:22 -0700, Matt Turner wrote:
> ---
> src/mesa/vbo/vbo_context.c| 6 +++---
> src/mesa/vbo/vbo_exec_array.c | 4 ++--
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/src/mesa/vbo/vbo_contex
On Mon, 2015-07-13 at 16:22 -0700, Matt Turner wrote:
> There are a couple of unrelated changes in t_vb_lighttmp.h that I hope
> you'll excuse -- there's a block of code that's duplicated modulo a few
> trivial differences that I took the liberty of fixing.
> ---
> src/mesa/tnl/t_draw.c
Reviewed-by: Iago Toral Quiroga
On Mon, 2015-07-13 at 16:22 -0700, Matt Turner wrote:
> ---
> src/mesa/swrast/s_aaline.c| 28 ++--
> src/mesa/swrast/s_aalinetemp.h| 4 ++--
> src/mesa/swrast/s_atifragshader.c | 4 ++--
> src/mesa/swr
Needs wrappers for sinf, cosf, powf, logf.
Reviewed-by: Iago Toral Quiroga
On Mon, 2015-07-13 at 16:22 -0700, Matt Turner wrote:
> ---
> src/mesa/program/prog_execute.c | 30 +++---
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/s
static GLboolean invert_matrix_3d( GLmatrix *mat )
> MAT(in,0,1) * MAT(in,0,1) +
> MAT(in,0,2) * MAT(in,0,2));
>
> - if (scale == 0.0)
> + if (scale == 0.0F)
> return GL_FALSE;
>
>scale = 1.0F / sc
On Tue, 2015-07-14 at 13:19 +0200, Iago Toral wrote:
> On Mon, 2015-07-13 at 16:22 -0700, Matt Turner wrote:
> > ---
> > src/mesa/math/m_clip_tmp.h | 20 ++---
> > src/mesa/math/m_matrix.c | 70
> > +++---
> >
case GL_SPOT_CUTOFF:
> - assert(params[0] == 180.0 || (params[0] >= 0.0 && params[0] <= 90.0));
> + assert(params[0] == 180.0F || (params[0] >= 0.0F && params[0] <=
> 90.0F));
>if (light->SpotCutoff == params[0])
>
Hi,
when we sent the patches for the new nir->vec4 backend we mentioned that
we had a few dEQP tests that would fail to link because of register
spilling. Now that we have added GS support we see a few instances of
this problem popping up in a few GS piglit tests too, for example this
one:
tests/
On Wed, 2015-07-15 at 11:02 -0700, Connor Abbott wrote:
> On Wed, Jul 15, 2015 at 7:49 AM, Iago Toral wrote:
> > Hi,
> >
> > when we sent the patches for the new nir->vec4 backend we mentioned that
> > we had a few dEQP tests that would fail to link because of regi
'll have a look at the patches.
Iag
> On Sun, Jun 28, 2015 at 11:29 PM, Iago Toral wrote:
> > Reviewed-by: Iago Toral Quiroga
> >
> > On Fri, 2015-06-26 at 13:15 -0700, Anuj Phogat wrote:
> >> Currently used ctx->_ImageTransferState check is not sufficient
re any transfer ops. */
> - return get_readpixels_transfer_ops(ctx, rb->Format, format, type,
> + return _mesa_get_readpixels_transfer_ops(ctx, rb->Format, format, type,
> uses_blit) != 0;
With the change, indentation for the second
> -type == GL_BYTE))) {
> + if (_mesa_need_signed_unsigned_int_conversion(rb->Format, format,
> + type))
> return GL_TRUE;
> - }
You need to rebase your patch, this code does
On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote:
> Signed-off-by: Anuj Phogat
> Cc:
> ---
> src/mesa/main/readpix.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c
> index caa2648..a9416ef 100644
> --- a/src/mesa/main/readpix.c
>
On Fri, 2015-06-19 at 13:40 -0700, Anuj Phogat wrote:
> On Tue, Jun 16, 2015 at 9:21 PM, Jason Ekstrand wrote:
> >
> > On Jun 16, 2015 11:15, "Anuj Phogat" wrote:
> >>
> >> Without this patch, piglit test fbo_integer_readpixels_sint_uint fails,
> >> when
> >> forced to use the meta pbo path.
> >>
Hi,
On Thu, 2015-07-16 at 08:15 -0700, Jason Ekstrand wrote:
>
> On Jul 15, 2015 11:20 PM, "Iago Toral" wrote:
> >
> > On Wed, 2015-07-15 at 11:02 -0700, Connor Abbott wrote:
> > > On Wed, Jul 15, 2015 at 7:49 AM, Iago Toral
> wrote:
> > > >
On Mon, 2015-07-20 at 10:56 -0700, Anuj Phogat wrote:
> On Mon, Jul 20, 2015 at 5:10 AM, Iago Toral wrote:
> > On Fri, 2015-06-19 at 13:40 -0700, Anuj Phogat wrote:
> >> On Tue, Jun 16, 2015 at 9:21 PM, Jason Ekstrand
> >> wrote:
> >> >
> >&g
On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote:
> Without this patch, piglit test arb_color_buffer_float-readpixels
> fails, when forced to use the meta pbo path.
>
> Signed-off-by: Anuj Phogat
> Cc:
> ---
> src/mesa/drivers/common/meta_tex_subimage.c | 5 +
> 1 file changed, 5 insert
On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote:
> Signed-off-by: Anuj Phogat
> ---
> src/mesa/drivers/common/meta.c | 13 ++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c
> index 214a68a..fceb2
BGRA_INTEGER:
> + return GL_BGRA;
> + case GL_ALPHA_INTEGER:
> + return GL_ALPHA;
I would probably move the GL_ALPHA_INTEGER case together with the other
single component formats, at first I thought you had missed it. Either
way:
Reviewed-by: Iago Toral Quiroga
>
On Tue, 2015-07-21 at 09:24 +0200, Iago Toral wrote:
> On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote:
> > Without this patch, piglit test arb_color_buffer_float-readpixels
> > fails, when forced to use the meta pbo path.
> >
> > Signed-off-by: Anuj Phogat
>
On Tue, 2015-07-21 at 08:13 +0200, Iago Toral wrote:
> On Mon, 2015-07-20 at 10:56 -0700, Anuj Phogat wrote:
> > On Mon, Jul 20, 2015 at 5:10 AM, Iago Toral wrote:
> > > On Fri, 2015-06-19 at 13:40 -0700, Anuj Phogat wrote:
> > >> On Tue, Jun 16, 2015 at 9:21 PM,
be fine because decompress_texture_image claims to
receive a destFormat that is "ala glReadPixels", so there is no need to
care for all those internal formats anyway, but I think you should
explain this in the commit log.
With that change,
Reviewed-by: Iago Toral Quiroga
>
On Tue, 2015-07-21 at 17:05 -0700, Anuj Phogat wrote:
> On Tue, Jul 21, 2015 at 1:36 AM, Iago Toral wrote:
> > On Tue, 2015-07-21 at 08:13 +0200, Iago Toral wrote:
> >> On Mon, 2015-07-20 at 10:56 -0700, Anuj Phogat wrote:
> >> > On Mon, Jul 20, 2015 at 5:10 AM, Iago
On Tue, 2015-07-21 at 11:13 -0700, Anuj Phogat wrote:
> On Tue, Jul 21, 2015 at 12:50 AM, Iago Toral wrote:
> > On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote:
> >> Signed-off-by: Anuj Phogat
> >> ---
> >> src/mesa/drivers/common/meta.c | 13 ++
The problem here is that the _mesa_meta_BlitFramebuffer is not setting
G/B channels to 0.0 when doing Luminance/Intensity to RGBA conversions,
so why not implement the fix in _mesa_meta_BlitFramebuffer directly? The
GL spec expects frambuffer blits to handle these conversions properly,
so it looks
Patches 10-11 are
Reviewed-by: Iago Toral Quiroga
On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote:
> Signed-off-by: Anuj Phogat
> ---
> src/mesa/drivers/common/meta.c | 12 ++--
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/src/mesa/drive
Looks good to me, if this did not introduce any regressions:
Reviewed-by: Iago Toral Quiroga
On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote:
> This allows us to handle cases when texImage->_BaseFormat doesn't match
> _mesa_format_get_base_format(texImage->Format). _Base
Reviewed-by: Iago Toral Quiroga
On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote:
> Signed-off-by: Anuj Phogat
> ---
> src/mesa/drivers/common/meta.c | 7 ++-
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/src/mesa/drivers/common/meta.c b/src/m
Reviewed-by: Iago Toral Quiroga
On Wed, 2015-07-22 at 11:54 -0700, Anuj Phogat wrote:
> _mesa_meta_pbo_GetTexSubImage() uses _mesa_meta_BlitFrameBuffer(),
> which will do fragment clamping if enabled. But fragment clamping
> doesn't affect ReadPixels and GetTexImage.
>
>
_function_create(nir_shader *shader, const char *name);
>
> diff --git a/src/mesa/program/prog_to_nir.c b/src/mesa/program/prog_to_nir.c
> index d9b1854..ea47f79 100644
> --- a/src/mesa/program/prog_to_nir.c
> +++ b/src/mesa/program/prog_to_nir.c
> @@ -958,11 +958,10 @@ set
Reviewed-by: Iago Toral Quiroga
On Fri, 2015-10-09 at 07:09 -0700, Jason Ekstrand wrote:
> ---
> src/mesa/program/prog_to_nir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/program/prog_to_nir.c b/src/mesa/program/prog_to_nir.c
> inde
On Mon, 2015-10-12 at 07:47 -0700, Jason Ekstrand wrote:
>
> On Oct 12, 2015 1:26 AM, "Iago Toral" wrote:
> >
> > On Fri, 2015-10-09 at 07:09 -0700, Jason Ekstrand wrote:
> > > ---
> > > src/glsl/nir/glsl_to_nir.cpp | 40 --
On Tue, 2015-10-13 at 15:17 +0300, Francisco Jerez wrote:
> Iago Toral Quiroga writes:
>
> > This fixes the following test:
> >
> > [require]
> > GL >= 3.3
> > GLSL >= 3.30
> > GL_ARB_shader_storage_buffer_object
> >
On Tue, 2015-10-13 at 09:44 -0700, Jordan Justen wrote:
> On 2015-10-13 05:17:37, Francisco Jerez wrote:
> > Iago Toral Quiroga writes:
> >
> > > This fixes the following test:
> > >
> > > [require]
> > > GL >= 3.3
> &
On Wed, 2015-10-14 at 11:08 -0700, Jordan Justen wrote:
> On 2015-10-13 22:49:08, Iago Toral wrote:
> > On Tue, 2015-10-13 at 09:44 -0700, Jordan Justen wrote:
> > > On 2015-10-13 05:17:37, Francisco Jerez wrote:
> > > > Iago Toral Quiroga writes:
> > > >
On Wed, 2015-10-14 at 16:18 +0300, Francisco Jerez wrote:
> "Lofstedt, Marta" writes:
>
> > I have found a couple of more places in linker.cpp where we loop up to
> > MESA_SHADER_FRAGMENT.
> > Should these now also be up to MESA_SHADER_COMPUTE instead?
> >
> Some might be oversights like this, b
On Thu, 2015-10-15 at 08:06 -0700, Jason Ekstrand wrote:
> On Thu, Oct 15, 2015 at 12:18 AM, Iago Toral Quiroga
> wrote:
> > Before d31f98a272e429d and 56e2bdbca36a20 we had a sigle index space for
> > UBOs
> > and SSBOs, so NumBufferInterfaceBlocks would contai
ES 3.1 context was in use.
>
> Fixes 48 dEQP-GLES31 tests:
>
> dEQP-GLES31.functional.ssbo.atomic.*
Reviewed-by: Iago Toral Quiroga
That said:
> Signed-off-by: Samuel Iglesias Gonsalvez
> ---
> src/glsl/builtin_functions.cpp | 2 +-
> 1 file changed, 1 insertion(
/* We need to include API in version string for OpenGL ES, otherwise
> + * application can not detect GLES via glGetString(GL_VERSION) query.
> + *
> + * From OpenGL ES 3.2 spec, Page 436:
> + *
> + * "The VERSION string is laid out as follows:
> + *
On Wed, 2015-10-14 at 21:40 +0300, Francisco Jerez wrote:
> Jordan Justen writes:
>
> > On 2015-10-13 22:49:08, Iago Toral wrote:
> >> On Tue, 2015-10-13 at 09:44 -0700, Jordan Justen wrote:
> >> > On 2015-10-13 05:17:37, Francisco Jerez wrote:
&g
On Sun, 2015-10-18 at 21:31 -0700, Kristian Høgsberg Kristensen wrote:
> An immdiate is already uniform so just return it up front. Without this,
> brw_fs_surface_builder ends up passing immediate surface indices through
> SHADER_OPCODE_BROADCAST. This writes to a stride 0 dst, which we can't
> con
t, bld, i), offset(read_result, bld, i));
>
>break;
> }
Thanks Kristian, this was silly, I wonder why I decided to do it like
this to begin with, specially since I do full vector reads for vec4...
Reviewed-by: Iago Toral Quiroga
Iago
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
r write). If
the header is not present, only the execution mask is used."
Similar text exists for SIMD8 and SIMD4x2 is not affected by Sample
mask.
Reviewed-by: Iago Toral Quiroga
> Signed-off-by: Kristian Høgsberg Kristensen
> ---
> src/mesa/drivers/dri/i965/brw_eu_emit.c | 3 +-
1 - 100 of 3167 matches
Mail list logo
