Re: [Mesa-dev] [PATCH] draw: handle edge flags in llvm path

Am 15.12.2015 um 17:25 schrieb Brian Paul: > On 12/14/2015 08:38 PM, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> We just ignored them altogether. While this feature is rather >> old-fashioned >> supporting it is actually rather trivial. >> Th

Re: [Mesa-dev] [PATCH 00/11] GL_ATI_fragment_shader support for Gallium

Am 16.12.2015 um 00:05 schrieb Miklós Máté: > Hi, > > This series aims to improve the looks of Star Wars: Knights of the > Old Republic (via Wine), but features some additional cleanup as > well. The main component of the series is the implementation of > GL_ATI_fragment_shader for all Gallium dri

[Mesa-dev] stencil texturing trouble

Hi, looking at some piglit failures, I was wondering what is actually the correct thing to do with stencil texturing. What do you put in the missing channels? The GL spec seems to say depth texture mode is only applicable to depth textures, so what it is then? It looks like nvidia is returning the

Re: [Mesa-dev] [PATCH] gallivm: add a horrible hack for stencil texturing with border

#x27;s no sampler, no border, no problem there...) Roland > Marek > > On Wed, Dec 16, 2015 at 5:37 AM, wrote: >> From: Roland Scheidegger >> >> mesa/st doesn't give us a useful swizzle when stencil texturing. Moreover, >> it's not even obvious what

Re: [Mesa-dev] [PATCH] gallivm: add a horrible hack for stencil texturing with border

Am 16.12.2015 um 17:39 schrieb Marek Olšák: > On Wed, Dec 16, 2015 at 5:18 PM, Roland Scheidegger > wrote: >> Am 16.12.2015 um 12:52 schrieb Marek Olšák: >>> This is not well defined in gallium, but r600g and radeonsi use these >>> default swizzles for depth

Re: [Mesa-dev] [PATCH 03/11] st/mesa: implement GL_ATI_fragment_shader

Am 16.12.2015 um 23:40 schrieb Ilia Mirkin: > On Tue, Dec 15, 2015 at 6:05 PM, Miklós Máté wrote: >> + } else if (desc->special == 3) { >> + src[0] = args[0]; >> + src[1] = args[1]; >> + src[2] = ureg_swizzle(args[2], >> +TGSI_SWIZZLE_Z, TGSI_SWIZZLE_Z, TGSI_SWIZZLE_Z,

Re: [Mesa-dev] [PATCH] draw: fix clip test with NaNs

Am 17.12.2015 um 19:13 schrieb Brian Paul: > On 12/17/2015 09:58 AM, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> NaNs mean it should be clipped, otherwise the NaNs might get passed to >> the >> next stages (if clipping didn't happen for a

Re: [Mesa-dev] [PATCH] draw: fix clip test with NaNs

Am 17.12.2015 um 20:22 schrieb Matt Turner: > On Thu, Dec 17, 2015 at 11:19 AM, Roland Scheidegger > wrote: >> Am 17.12.2015 um 19:13 schrieb Brian Paul: >>> On 12/17/2015 09:58 AM, srol...@vmware.com wrote: >>>> From: Roland Scheidegger >>>> >&

Re: [Mesa-dev] [PATCH] gallivm: add a horrible hack for stencil texturing with border

Am 21.12.2015 um 20:59 schrieb Jose Fonseca: > On 16/12/15 16:18, Roland Scheidegger wrote: >> Am 16.12.2015 um 12:52 schrieb Marek Olšák: >>> This is not well defined in gallium, but r600g and radeonsi use these >>> default swizzles for depth and stencil surfaces and

Re: [Mesa-dev] [PATCH] gallivm: add a horrible hack for stencil texturing with border

Am 22.12.2015 um 02:56 schrieb Marek Olšák: > On Tue, Dec 22, 2015 at 12:10 AM, Roland Scheidegger > wrote: >> Am 21.12.2015 um 20:59 schrieb Jose Fonseca: >>> On 16/12/15 16:18, Roland Scheidegger wrote: >>>> Am 16.12.2015 um 12:52 schrieb Marek Olšák: >>

Re: [Mesa-dev] [PATCH 8/8] draw: fix draw pipeline stages wrt changing vertex sizes

Am 22.12.2015 um 16:32 schrieb Jose Fonseca: > On 22/12/15 03:00, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> The vertex size can change in fetch_pipeline_prepare, if drivers use >> the draw_prepare_shader_outputs hook (similar to what the llvm path

Re: [Mesa-dev] [PATCH 0/5] OpenGL ES improvements

Am 03.08.2014 14:40, schrieb Marek Olšák: > Hi everyone, > > This series adds: > - Support for ETC2 texture formats to all gallium drivers. This is a > requirement for OpenGL ES 3.0, which can now be considered feature-complete > as far as I know. Textures of such formats are loaded as plain R/R

Re: [Mesa-dev] [PATCH 1/2] c11/threads: add missing brackets around _MTX_INITIALIZER_NP

Am 02.08.2014 03:51, schrieb Emil Velikov: > On 02/08/14 00:26, Ian Romanick wrote: >> On 08/01/2014 09:41 AM, Emil Velikov wrote: >>> ... for win32 builds. Spotted this warning when I've imported the >>> library into waffle, and gave mingw-w64-gcc a bash at compiling it. >>> >>> src/waffle/core/wc

Re: [Mesa-dev] [PATCH 0/5] OpenGL ES improvements

Fair enough. Whoever wants to see it supported for his hardware can add support for it natively later... Roland Am 04.08.2014 22:33, schrieb Marek Olšák: > Like Alex said. I don't plan to add gallium support if our hardware > cannot do it. > > Marek > > On Mon, Aug 4,

Re: [Mesa-dev] [PATCH 0/5] OpenGL ES improvements

t; cannot do it. >> >> Marek >> >> On Mon, Aug 4, 2014 at 5:54 PM, Roland Scheidegger >> wrote: >>> Am 03.08.2014 14:40, schrieb Marek Olšák: >>>> Hi everyone, >>>> >>>> This series adds: >>>> - Support for ETC2 te

Re: [Mesa-dev] [PATCH] targets/dri: link with mesautil

Am 05.08.2014 01:52, schrieb Emil Velikov: > On 05/08/14 00:36, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> Build system so I've no idea what I'm doing but this looks similar to other >> build fixes... >> --- >> src/gallium/ta

Re: [Mesa-dev] RFC: mesa/st dynamic sampler support in tgsi

Am 05.08.2014 06:54, schrieb Ilia Mirkin: > Hello, > > I'm in the process of working out the details of adding dynamic > sampler support to mesa/st as part of ARB_gpu_shader5. Unfortunately > I've run into a bit of a roadblock. > > One approach I've tried is to load the indirect sampler index int

Re: [Mesa-dev] [PATCH] st/mesa: adjust Z coordinates for quad clearing

] = 1.0f; > + vp.scale[2] = 0.5; 0.5f for consistency? Same below. >vp.scale[3] = 1.0f; >vp.translate[0] = 0.5f * fb_width; >vp.translate[1] = 0.5f * fb_height; > - vp.translate[2] = 0.0f; > + vp.translate[2] = 0.5; >vp.translate[3] = 0.0f;

Re: [Mesa-dev] [PATCH] mesa: make vertex array type error checking a little more efficient

. > */ > - if (sizeMax == BGRA_OR_4) > - sizeMax = 4; > - } else { > - legalTypesMask &= ~FIXED_ES_BIT; > - > - if (!ctx->Extensions.ARB_ES2_compatibility) > - legalTypesMask &= ~FIXED_GL_BIT; > - > - if (!ctx->Extensions.ARB_vertex_type_2_10_10_10_re

Re: [Mesa-dev] RFC: mesa/st dynamic sampler support in tgsi

From a gallium perspective, indirect temp regs are already working - so something like MOV TEMP[0], TEMP[TEMP[1].x] should work. Indirect registers are supported for inputs, outputs, temps, constants, and immediates even, but the indirect reg itself must come from a temp or address reg (I am not 10

[Mesa-dev] primitive id handling in mesa (and state tracker)

So, primitive id in llvmpipe doesn't really work, or rather it works but it can't do much useful with the way mesa/st sets this up at least for some tests. In particular all of piglit glsl-1.50-geometry-primitive-id-restart fail (result is always 0). We actually have both system value prim id and o

Re: [Mesa-dev] RFC: mesa/st dynamic sampler support in tgsi

Am 06.08.2014 04:02, schrieb Ilia Mirkin: > On Tue, Aug 5, 2014 at 5:25 PM, Roland Scheidegger wrote: >> From a gallium perspective, indirect temp regs are already working - so >> something like >> MOV TEMP[0], TEMP[TEMP[1].x] should work. >> Indirect registers are su

Re: [Mesa-dev] RFC: mesa/st dynamic sampler support in tgsi

Am 06.08.2014 13:00, schrieb Marek Olšák: > On Wed, Aug 6, 2014 at 4:02 AM, Ilia Mirkin wrote: >> On Tue, Aug 5, 2014 at 5:25 PM, Roland Scheidegger >> wrote: >>> From a gallium perspective, indirect temp regs are already working - so >>> something like >&g

Re: [Mesa-dev] RFC: mesa/st dynamic sampler support in tgsi

Am 06.08.2014 17:03, schrieb Ilia Mirkin: > On Wed, Aug 6, 2014 at 10:52 AM, Roland Scheidegger > wrote: >> Am 06.08.2014 13:00, schrieb Marek Olšák: >>> On Wed, Aug 6, 2014 at 4:02 AM, Ilia Mirkin wrote: >>>> On Tue, Aug 5, 2014 at 5:25 PM, Roland Scheidegger

Re: [Mesa-dev] RFC: mesa/st dynamic sampler support in tgsi

Am 06.08.2014 17:20, schrieb Ilia Mirkin: > On Wed, Aug 6, 2014 at 11:15 AM, Roland Scheidegger > wrote: >> Am 06.08.2014 17:03, schrieb Ilia Mirkin: >>> On Wed, Aug 6, 2014 at 10:52 AM, Roland Scheidegger >>> wrote: >>>> Am 06.08.2014 13:00, schrieb M

Re: [Mesa-dev] Merging VC4 driver

Am 06.08.2014 22:33, schrieb Eric Anholt: > I'd like to start merging the VC4 driver. I've got a lot of things > working under sim (piglit's at 5212/6726 for a slightly-trimmed > quick.py), and once I find where I put my serial cable I hope to get the > kernel fixed up and passing even more than t

Re: [Mesa-dev] [PATCH] gallium: remove PIPE_SHADER_CAP_MAX_ADDRS

There's extensions like NV_vertex_program2 which can make use of more than one address reg, I guess that's the reason why it was in gallium (this extension also comes with opcodes arr,ara for instance which are in gallium too). But I doubt anyone plans to implement that so this should be fine. Inte

Re: [Mesa-dev] [PATCH] gallium: remove PIPE_SHADER_CAP_MAX_ADDRS

Am 07.08.2014 00:32, schrieb Ilia Mirkin: > On Wed, Aug 6, 2014 at 6:06 PM, Marek Olšák wrote: >> From: Marek Olšák >> >> This limit is fixed in Mesa core and cannot be changed. >> It only affects ARB_vertex_program and ARB_fragment_program. >> >> The minimum value for ARB_vertex_program is 1 acc

Re: [Mesa-dev] Merging VC4 driver

Am 07.08.2014 00:10, schrieb Eric Anholt: > Roland Scheidegger writes: > >> Am 06.08.2014 22:33, schrieb Eric Anholt: > >>> + * When building using the simulator (on x86), we advertise ourselves as >>> the >>> + * i965 driver so that you

Re: [Mesa-dev] [PATCH 0/6] Add support for BPTC texture compression

Am 07.08.2014 14:30, schrieb Neil Roberts: > Kristian Høgsberg writes: > >> That's a great reference image. Do you have a version of the image >> compressed with nVidias online compressor? > > I finally got access to an NVidia card last night so I've added an image > from their online compresso

Re: [Mesa-dev] Mesa (master): mesa/formats: Add layout and swizzle information

Am 07.08.2014 20:25, schrieb Jason Ekstrand: > Michel, > > On Thu, Aug 7, 2014 at 12:04 AM, Michel Dänzer > wrote: > > On 07.08.2014 02:02, Jason Ekstrand wrote: > > Michael, > > Close, but no cigar. :) > > > I'm sorry about that. I must have read too q

Re: [Mesa-dev] [PATCH 11/11] glsl: Optimize X / X == 1

It also doesn't hold true for inf and nan inputs with ieee754 math (just like 0 should be all nan, and in particular making a 1.0 out of a nan that way sounds sort of broken). Earlier glsl versions though had pretty much undefined behavior for infs/nans. Newer versions have more clearly defined beh

Re: [Mesa-dev] [PATCH] st/mesa: fix blit-based partial TexSubImage for 1D arrays

Looks good to me too. I guess on llvmpipe we got lucky because row_stride and layer_stride were equal so the math worked out the same in the end :-). Reviewed-by: Roland Scheidegger Am 08.08.2014 01:18, schrieb Ilia Mirkin: > Reviewed-by: Ilia Mirkin > > Makes sense and also fixe

Re: [Mesa-dev] [PATCH] st/mesa: fix blit-based partial TexSubImage for 1D arrays

Ah right. That's why it didn't matter then :-) Roland Am 08.08.2014 02:30, schrieb Marek Olšák: > Hi Roland, > > This code isn't used by llvmpipe, because it returns > PIPE_CAP_PREFER_BLIT_BASED_TEXTURE_TRANSFER = 0. > > Marek > > On Fri, Aug 8, 201

Re: [Mesa-dev] [PATCH 03/13] mesa: Add SYSTEM_VALUE_BASE_VERTEX

Am 08.08.2014 09:37, schrieb Kenneth Graunke: > On Friday, August 08, 2014 12:31:07 AM Kenneth Graunke wrote: >> From: Ian Romanick >> >> This system value represents the basevertex value passed to >> glDrawElementsBaseVertex and related functions. >> >> Signed-off-by: Ian Romanick >> --- >> src

Re: [Mesa-dev] [PATCH 01/13] mesa: Document SYSTEM_VALUE_VERTEX_ID and SYSTEM_VALUE_INSTANCE_ID

The mesa parts of the series all look good to me. We definitely want something like that in gallium too (draw fails the vertex id tests sort of on purpose right now because we needed d3d10 behavior). Oh and sort of off-topic but since you're familiar with it do you know why the gl_PrimitiveIn of

Re: [Mesa-dev] [PATCH 03/13] mesa: Add SYSTEM_VALUE_BASE_VERTEX

Am 08.08.2014 20:06, schrieb Ian Romanick: > On 08/08/2014 12:37 AM, Kenneth Graunke wrote: >> On Friday, August 08, 2014 12:31:07 AM Kenneth Graunke wrote: >>> From: Ian Romanick >>> >>> This system value represents the basevertex value passed to >>> glDrawElementsBaseVertex and related functions

Re: [Mesa-dev] [PATCH] i965: Use memcpy instead of an assignment when storing uniforms

Am 08.08.2014 22:56, schrieb Neil Roberts: > The i965 driver uses a float pointer to point to the value of a uniform and > also as the destination within the batch buffer. However the same locations > can also be used to store values for integer uniforms. Previously the value > was being copied int

Re: [Mesa-dev] Mesa (master): mesa/formats: Add layout and swizzle information

Am 08.08.2014 09:46, schrieb Kenneth Graunke: > On Thursday, August 07, 2014 10:41:36 PM Roland Scheidegger wrote: >> Am 07.08.2014 20:25, schrieb Jason Ekstrand: >>> Michel, >>> >>> On Thu, Aug 7, 2014 at 12:04 AM, Michel Dänzer >> <mailto:mic...@daen

Re: [Mesa-dev] [PATCH 03/13] mesa: Add SYSTEM_VALUE_BASE_VERTEX

Am 08.08.2014 23:47, schrieb Ian Romanick: > On 08/08/2014 11:31 AM, Roland Scheidegger wrote: >> Am 08.08.2014 20:06, schrieb Ian Romanick: >>> On 08/08/2014 12:37 AM, Kenneth Graunke wrote: >>>> On Friday, August 08, 2014 12:31:07 AM Kenneth Graunke w

Re: [Mesa-dev] [PATCH 01/13] mesa: Document SYSTEM_VALUE_VERTEX_ID and SYSTEM_VALUE_INSTANCE_ID

Am 08.08.2014 23:38, schrieb Ian Romanick: > On 08/08/2014 07:55 AM, Roland Scheidegger wrote: >> The mesa parts of the series all look good to me. > > So.. can we put your R-b on patches 1 through 7? :) Actually I'm not really qualified for the glsl parts in 4,5 but 1-3,

Re: [Mesa-dev] [PATCH 2/8] mesa: define and use ALL_TYPE_BITS in varray.c code

mask(const struct gl_context *ctx) > { > - GLbitfield legalTypesMask = ~0u; /* all */ > + GLbitfield legalTypesMask = ALL_TYPE_BITS; > > if (_mesa_is_gles(ctx)) { >legalTypesMask &= ~(FIXED_GL_BIT | > 1/8, 2/8 are Reviewed-by: Roland Scheidegger ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/8] mesa: use PRIu64 for printing 64-bit uints

Am 08.08.2014 23:20, schrieb Brian Paul: > Silences MinGW warnings: > warning: unknown conversion type character ‘l’ in format [-Wformat] > warning: too many arguments for format [-Wformat-extra-args] > --- > src/mesa/main/bufferobj.c | 33 + > src/mesa/main/var

Re: [Mesa-dev] [PATCH 6/8] mesa: whitespace, 80-column wrapping in program.c

> gl_geometry_program *prog, > - GLenum target, GLuint id) > +_mesa_init_geometry_program(struct gl_context *ctx, > +struct gl_geometry_program *prog, > +GLenum target, GLuint id) > { >

Re: [Mesa-dev] [PATCH 3/8] mesa: use PRIu64 for printing 64-bit uints

Am 09.08.2014 02:24, schrieb Matt Turner: >> Other than that, is there some recommendation wrt whitespace around that >> ugly format specifier? Some places seem to use it, some don't. Either >> way it's ugly dunno which one is worse. Would be nice though if we'd be >> consistent imho. > > I've alw

Re: [Mesa-dev] [PATCH 8/8] mesa: simplify _mesa_update_draw_buffers()

- the code got moved around but the buffer copy part came in from cbfe29cdee5d338a25f13a191b80428d05c8. You dare touch my code :-). I guess though I did the copy because _mesa_drawbuffers will write the same ctx->Color.DrawBuffer bits that are passed in as buffers. Looks safe to me th

Re: [Mesa-dev] [PATCH 7/8] mesa: fix assertion in _mesa_drawbuffers()

Am 08.08.2014 23:20, schrieb Brian Paul: > Fixes failed assertion when _mesa_update_draw_buffers() was called > with GL_DRAW_BUFFER == GL_FRONT_AND_BACK. The piglit gl30basic hit > this. > > Cc: "10.2" > --- > src/mesa/main/buffers.c |5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(

Re: [Mesa-dev] [PATCH] mesa/st: add support for dynamic sampler offsets

On closer look, it looks to me like it wouldn't be all that difficult to make proper sampler array dcls (as you apparently get them quite easily from glsl) which is really my only problem with it but it's not really all that important so Reviewed-by: Roland Scheidegger Am 09.08.

Re: [Mesa-dev] [PATCH] mesa/st: add support for dynamic sampler offsets

Am 09.08.2014 16:33, schrieb Ilia Mirkin: > On Sat, Aug 9, 2014 at 10:14 AM, Roland Scheidegger > wrote: >> On closer look, it looks to me like it wouldn't be all that difficult to >> make proper sampler array dcls (as you apparently get them quite easily > > If yo

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

Am 09.08.2014 05:24, schrieb Connor Abbott: > On Wed, Aug 6, 2014 at 6:29 PM, Marek Olšák wrote: >> What IR? A flatland GLSL IR? A replacement for Mesa IR? Something else? > > It's a flatland IR, similar to TGSI/Direct3D style with enough GLSL > IR-like stuff to get existing things working now an

Re: [Mesa-dev] [PATCH] mesa/st: add support for dynamic sampler offsets

Am 09.08.2014 17:25, schrieb Ilia Mirkin: > On Sat, Aug 9, 2014 at 11:12 AM, Roland Scheidegger > wrote: >> Am 09.08.2014 16:33, schrieb Ilia Mirkin: >>> On Sat, Aug 9, 2014 at 10:14 AM, Roland Scheidegger >>> wrote: >>>> On closer look, it looks to me

Re: [Mesa-dev] [PATCH 3/8] mesa: use PRIu64 for printing 64-bit uints

Am 11.08.2014 15:29, schrieb Brian Paul: > On 08/08/2014 06:15 PM, Roland Scheidegger wrote: >> Am 08.08.2014 23:20, schrieb Brian Paul: >>> Silences MinGW warnings: >>> warning: unknown conversion type character ‘l’ in format [-Wformat] >>> warning: too

Re: [Mesa-dev] [PATCH 1/2] mesa: use PRId64 for printing 64-bit ints

Both patches Reviewed-by: Roland Scheidegger Am 11.08.2014 17:24, schrieb Brian Paul: > Silences MinGW warnings: > warning: unknown conversion type character ‘l’ in format [-Wformat] > warning: too many arguments for format [-Wformat-extra-args] > > v2: use signed types/format

Re: [Mesa-dev] [PATCH v2 1/4] gallium: add basic support for BPTC formats

#include "u_format_latc.h"' > print '#include "u_format_etc.h"' > +print '#include "u_format_bptc.h"' > print > > u_format_pack.generate(formats) > @@ -141,7 +142,7 @@ def write_format_table(formats): > if format.colorspace != ZS and not format.is_pure_color(): > print " &util_format_%s_unpack_rgba_8unorm," % > format.short_name() > print " &util_format_%s_pack_rgba_8unorm," % > format.short_name() > -if format.layout == 's3tc' or format.layout == 'rgtc': > +if format.layout == 's3tc' or format.layout == 'rgtc' or > format.layout == 'bptc': Not that this would be your bug but isn't that actually missing etc format? > print " &util_format_%s_fetch_rgba_8unorm," % > format.short_name() > else: > print " NULL, /* fetch_rgba_8unorm */" > diff --git a/src/gallium/include/pipe/p_format.h > b/src/gallium/include/pipe/p_format.h > index a7fdcd0..a29b9d6 100644 > --- a/src/gallium/include/pipe/p_format.h > +++ b/src/gallium/include/pipe/p_format.h > @@ -344,6 +344,11 @@ enum pipe_format { > > PIPE_FORMAT_B5G6R5_SRGB = 254, > > + PIPE_FORMAT_BPTC_RGBA_UNORM = 255, > + PIPE_FORMAT_BPTC_SRGBA_UNORM= 256, > + PIPE_FORMAT_BPTC_RGB_FLOAT = 257, > + PIPE_FORMAT_BPTC_RGB_UFLOAT = 258, > + > PIPE_FORMAT_COUNT > }; > > For the series: Reviewed-by: Roland Scheidegger ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa/st: emit sampler declarations as arrays when indirect accesses are done

Am 11.08.2014 17:18, schrieb Ilia Mirkin: > Signed-off-by: Ilia Mirkin > --- > > This applies on top of my previous patch to allow dynamic sampler offsets. > > Roland, I believe this should address your concerns. The generated code looks > like: > > FRAG > PROPERTY FS_COLOR0_WRITES_ALL_CBUFS 1

Re: [Mesa-dev] [PATCH] mesa/st: emit sampler declarations as arrays when indirect accesses are done

Am 11.08.2014 18:56, schrieb Ilia Mirkin: > On Mon, Aug 11, 2014 at 12:43 PM, Roland Scheidegger > wrote: >> Am 11.08.2014 17:18, schrieb Ilia Mirkin: >>> Signed-off-by: Ilia Mirkin >>> --- >>> >>> This applies on top of my previous patch to

Re: [Mesa-dev] [PATCH 7/8] mesa: fix assertion in _mesa_drawbuffers()

Am 11.08.2014 00:51, schrieb Brian Paul: > On 08/08/2014 07:43 PM, Roland Scheidegger wrote: >> Am 08.08.2014 23:20, schrieb Brian Paul: >>> Fixes failed assertion when _mesa_update_draw_buffers() was called >>> with GL_DRAW_BUFFER == GL_FRONT_AND_BACK. The pi

Re: [Mesa-dev] [PATCH 5/5] docs: add GL4.5 section, mark ARB_texture_barrier as done

Am 11.08.2014 21:07, schrieb Ilia Mirkin: > Signed-off-by: Ilia Mirkin > --- > > Not 100% sure about the KHR_robust_buffer_access_behavior -- is that part of > GL4.5? Well this is mostly the same as ARB_robust_buffer_access_behavior which is core in 4.3. Except ARB_robust_buffer_access_behavior i

Re: [Mesa-dev] [PATCH 5/5] docs: add GL4.5 section, mark ARB_texture_barrier as done

Am 11.08.2014 22:56, schrieb Ilia Mirkin: > On Mon, Aug 11, 2014 at 4:34 PM, Roland Scheidegger > wrote: >> Am 11.08.2014 21:07, schrieb Ilia Mirkin: >>> Signed-off-by: Ilia Mirkin >>> --- >>> >>> Not 100% sure about the KHR_robust_buffer_acces

Re: [Mesa-dev] [PATCH] i965: Store uniform constant values in a gl_constant_value instead of float

This looks good to me. However I'm wondering if it would be better to use a generic float/int union. I guess though these values actually really are gl_constant_value type (as they come as gl params) so this looks good. Roland Am 12.08.2014 20:04, schrieb Neil Roberts: > Hi, > > Here is a replac

Re: [Mesa-dev] Mesa (master): mesa/formats: Add layout and swizzle information

Am 06.08.2014 11:28, schrieb Michel Dänzer: > On 06.08.2014 03:08, Jason Ekstrand wrote: >> Module: Mesa >> Branch: master >> Commit: 850fb0d1dca616179d3239a7b7bd94fe1979604c >> URL: >> https://urldefense.proofpoint.com/v1/url?u=http://cgit.freedesktop.org/mesa/mesa/commit/?id%3D850fb0d1dca6161

Re: [Mesa-dev] [PATCH] mesa: fix texstore with GL_COLOR_INDEX data

rying. Roland Am 13.08.2014 19:35, schrieb Jason Ekstrand: > Roland, > I just sent the exact same patch. > > Reviewed-by: Jason Ekstrand <mailto:jason.ekstr...@intel.com>> > > > On Wed, Aug 13, 2014 at 10:33 AM, <mailto:srol...@vmware.com>> wrote: > &

Re: [Mesa-dev] [PATCH] mesa: fix texstore with GL_COLOR_INDEX data

14 19:46, schrieb Roland Scheidegger: > Ha one minute faster :-). > FWIW interestingly this one also fixes the other conform failures I was > seeing (with GL_BYTE/GL_RGB data) when unconditionally disabling > texstore_swizzle so I guess the results of the swizzle path aren't qu

Re: [Mesa-dev] [PATCH] mesa/texstore: Don't use the _mesa_swizzle_and_convert if we need transfer ops

Reviewed-by: Roland Scheidegger Not sure though why you moved the function, it's declared elsewhere anyway. (And I bet there's cases where transfer ops wouldn't actually be required which aren't caught by this check, like for instance RGB formats with only alpha pixel scale,

Re: [Mesa-dev] [PATCH 3/5] gallium: add opcodes/cap for fine derivative support

Reviewed-by: Roland Scheidegger llvmpipe also already does the fine version. A coarse version (which we indeed do when used implicitly for sampling though with some other changes) might be minimally simpler though not even sure (might save a shuffle instruction somewhere), but probably not worth

Re: [Mesa-dev] [PATCH 3/5] gallium: add opcodes/cap for fine derivative support

nce we do (in some cases at least with avx) do texture sampling for multiple quads at once this is something which needs to be handled in any case. I suspect hw being slower with different effective lods per pixel has similar reasons - there's just more work to be done. Roland > >

Re: [Mesa-dev] [PATCH 16/19] gallium/nouveau: handle query_renderer caps

Am 15.08.2014 00:33, schrieb Ilia Mirkin: > Hm, I wonder what GETPARAM_PCI_DEVICE returns for GK20A. Also, not > 100% sure what UMA means, but GK20A (NVEA) would defnitely qualify. > Not sure about the other IGP's that steal vram from the system. All > IGPs end in 0xa-0xf though, so they're easy to

Re: [Mesa-dev] [RFC] gallium/st/drivers: Extend render_condition() Add a new boolean flag: inverted Adopt all places where we make use of this This will be used to implement ARB_conditional_render_inv

NAK. This is unnecessary, the condition parameter can already handle that (and was added for that purpose, though for d3d10 only at that time - 793e8e3d7ed816cc9a066245dde798afdcf8b581). Can't speak for other drivers, but llvmpipe/softpipe already handle it in any case. Otherwise, I'd still have to

Re: [Mesa-dev] [PATCH 2/6] gallium/st: Add PIPE_CAP_CONDITIONAL_RENDER_INVERTED

Am 16.08.2014 01:59, schrieb Tobias Klausmann: > with this we determine if the driver wants to enable > GL_ARB_conditional_render_inverted > > Signed-off-by: Tobias Klausmann > --- > src/gallium/docs/source/screen.rst | 2 ++ > src/gallium/drivers/freedreno/freedreno_screen.c | 1 +

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

Am 16.08.2014 02:12, schrieb Connor Abbott: > I know what you might be thinking right now. "Wait, *another* IR? Don't > we already have like 5 of those, not counting all the driver-specific > ones? Isn't this stuff complicated enough already?" Well, there are some > pretty good reasons to start afr

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

Am 18.08.2014 19:05, schrieb Connor Abbott: > On Mon, Aug 18, 2014 at 12:38 PM, Ilia Mirkin wrote: >> On Mon, Aug 18, 2014 at 12:25 PM, Connor Abbott wrote: >>> On Mon, Aug 18, 2014 at 11:47 AM, Jose Fonseca wrote: On 18/08/14 14:21, Marek Olšák wrote: Once these are in place, all deve

Re: [Mesa-dev] [PATCH 5/6] rbug: fix a crash in sampler_view_destroy caused by incorrect context

gt;base; > The whole sampler_view_create / sampler_view_destroy functions here look also a bit asymmetric (especially wrt reference counts) compared to surface_create / surface_destroy which sounds fishy but in any case 1/6, 4/6, 5/6 are Reviewed-by: Roland Scheidegger

Re: [Mesa-dev] [PATCH 2/6] rbug: fix crash in set_vertex_buffers

Am 18.08.2014 23:24, schrieb Marek Olšák: > From: Marek Olšák > > --- > src/gallium/drivers/rbug/rbug_context.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/rbug/rbug_context.c > b/src/gallium/drivers/rbug/rbug_context.c > index ca94590..d6fca2e

Re: [Mesa-dev] [PATCH 3/6] rbug: implement streamout context functions

>base.create_stream_output_target = > rbug_create_stream_output_target; > + rb_pipe->base.stream_output_target_destroy = > rbug_stream_output_target_destroy; > + rb_pipe->base.set_stream_output_targets = rbug_set_stream_output_targets; > rb_pipe->

Re: [Mesa-dev] [PATCH 6/6] rbug: only add textures to the list

e value in trying to make them displayable? I guess though it would be pretty difficult without any means to figure out what kind of data it is. Reviewed-by: Roland Scheidegger ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/6] gallium/u_blitter: don't use an empty fragment shader if there's a colorbuffer

nd_fs_state(pipe, cbsurf ? ctx->fs_write_one_cbuf : ctx->fs_empty); > pipe->bind_vertex_elements_state(pipe, ctx->velem_state); > > /* set a framebuffer state */ > 1/6,2/6 are Reviewed-by: Roland Scheidegger ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v4 1/6] mesa: add ARB_conditional_render_inverted flags

Series looks good to me too, just one minor nitpick below, otherwise 1-4, and 6 are Reviewed-by: Roland Scheidegger Am 19.08.2014 00:06, schrieb Tobias Klausmann: > Also add an extension bit so we can safely enable > > Signed-off-by: Tobias Klausmann > --- > src/mesa/main/co

Re: [Mesa-dev] [PATCH 2/6] rbug: fix crash in set_vertex_buffers

Am 19.08.2014 01:35, schrieb Marek Olšák: > On Tue, Aug 19, 2014 at 1:10 AM, Roland Scheidegger > wrote: >> Am 18.08.2014 23:24, schrieb Marek Olšák: >>> From: Marek Olšák >>> >>> --- >>> src/gallium/drivers/rbug/rbug_context.c | 2 +-

Re: [Mesa-dev] [PATCH 3/6] rbug: implement streamout context functions

Am 19.08.2014 01:43, schrieb Marek Olšák: > On Tue, Aug 19, 2014 at 1:12 AM, Roland Scheidegger > wrote: >> Am 18.08.2014 23:24, schrieb Marek Olšák: >>> From: Marek Olšák >>> >>> --- >>> src/gallium/drivers/rbug/rbug_context.c | 46 >>&

Re: [Mesa-dev] [PATCH] mesa: fix NULL pointer deref bug in _mesa_drawbuffers()

nt = 0, destMask0 = destMask[0]; >while (destMask0) { > GLint bufIndex = ffs(destMask0) - 1; > Reviewed-by: Roland Scheidegger ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] cant build mesa against current llvm(3.6 git)

Am 19.08.2014 23:29, schrieb Enrico Horn: > Hi everyone, > tried to build mesa just now with llvm from git and get the following error: > > gallivm/lp_bld_misc.cpp: In function 'LLVMBool > lp_build_create_jit_compiler_for_module(LLVMOpaqueExecutionEngine**, > lp_generated_code**, LLVMModuleRef, un

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

Didn't look at it that closely, but I'm pretty surprised this really works. One things ARB_texture_view can do is cast cube maps (and cube map arrays) to 2d arrays and vice versa (also 1d/2d to the respective array type), and we cannot express that in sampler views (yet) (we can't express it in sur

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

ix it? Should the target be added to >> pipe_sampler_view? >> >> On Wed, Aug 20, 2014 at 11:25 AM, Roland Scheidegger >> wrote: >>> Didn't look at it that closely, but I'm pretty surprised this really >>> works. One things ARB_texture_view can do is cast cube

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

he pipe_resource's target. Any >>> suggestions on how to fix it? Should the target be added to >>> pipe_sampler_view? >>> >>> On Wed, Aug 20, 2014 at 11:25 AM, Roland Scheidegger >>> wrote: >>>> >>>> Didn't look at it

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

Am 20.08.2014 18:12, schrieb Jose Fonseca: > On 20/08/14 17:02, Roland Scheidegger wrote: >> Am 20.08.2014 17:47, schrieb Jose Fonseca: >>> On 20/08/14 16:31, Ilia Mirkin wrote: >>>> Hm, it's not tested. And you're right, that would (most likely) me

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

Am 20.08.2014 18:33, schrieb Ilia Mirkin: > On Wed, Aug 20, 2014 at 12:22 PM, Jose Fonseca wrote: >> On 20/08/14 17:14, Roland Scheidegger wrote: >>> >>> Am 20.08.2014 17:55, schrieb Ilia Mirkin: >>>> >>>> On Wed, Aug 20, 2014 at 11:47 AM, Jose

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

Am 20.08.2014 20:13, schrieb Kenneth Graunke: > On Wednesday, August 20, 2014 06:41:08 PM Michel Dänzer wrote: >> On 20.08.2014 00:04, Connor Abbott wrote: >>> On Mon, Aug 18, 2014 at 8:52 PM, Michel Dänzer >>> wrote: On 19.08.2014 01:28, Connor Abbott wrote: > On Mon, Aug 18, 2014 at 4:3

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

Am 20.08.2014 20:45, schrieb Matt Turner: > On Wed, Aug 20, 2014 at 11:28 AM, Roland Scheidegger > wrote: >> Am 20.08.2014 20:13, schrieb Kenneth Graunke: >>> For example, Debian was stuck on Mesa 9.2.2 for 4 months (2013-12-08 >>> to 2014-03-22), and I was

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

Am 20.08.2014 18:48, schrieb Roland Scheidegger: > Am 20.08.2014 18:33, schrieb Ilia Mirkin: >> On Wed, Aug 20, 2014 at 12:22 PM, Jose Fonseca wrote: >>> On 20/08/14 17:14, Roland Scheidegger wrote: >>>> >>>> Am 20.08.2014 17:55, schrieb Ilia Mirkin: &g

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

Am 20.08.2014 22:27, schrieb Ilia Mirkin: > On Wed, Aug 20, 2014 at 4:12 PM, Roland Scheidegger > wrote: >> Am 20.08.2014 18:48, schrieb Roland Scheidegger: >>> Am 20.08.2014 18:33, schrieb Ilia Mirkin: >>>> On Wed, Aug 20, 2014 at 12:22 PM, Jose Fonseca wrote

Re: [Mesa-dev] [RFC] gallium: add support for rectangle primitives

Am 21.08.2014 18:44, schrieb Marek Olšák: > From: Marek Olšák > > This is already supported by r600g and radeonsi. > Alex suggested this could be useful for video acceleration state trackers. > --- > src/gallium/auxiliary/tgsi/tgsi_strings.c | 3 ++- > src/gallium/auxiliary/util/u_prim.h

Re: [Mesa-dev] [PATCH v2 2/4] gallium: add a texture target to sampler view and a CAP to use it

-569,6 +569,7 @@ enum pipe_cap { > PIPE_CAP_VIDEO_MEMORY = 106, > PIPE_CAP_UMA = 107, > PIPE_CAP_CONDITIONAL_RENDER_INVERTED = 108, > + PIPE_CAP_SAMPLER_VIEW_TARGET = 109, > }; > > #define PIPE_QUIRK_TEXTURE_BORDER_COLOR_SWIZZLE_NV50 (1 << 0) > diff

Re: [Mesa-dev] [PATCH v2 3/4] mesa/st: add ARB_texture_view support

Am 21.08.2014 04:42, schrieb Ilia Mirkin: > Signed-off-by: Ilia Mirkin > --- > > v1 -> v2: > - make use of new PIPE_CAP to determine whether ARB_texture_view is available > - set the gl_texture_object's Target in the sampler view object > > src/mesa/state_tracker/st_atom_texture.c | 30 ++

Re: [Mesa-dev] [PATCH v2 2/4] gallium: add a texture target to sampler view and a CAP to use it

Am 21.08.2014 19:39, schrieb Ilia Mirkin: > On Thu, Aug 21, 2014 at 1:35 PM, Roland Scheidegger > wrote: >> Am 21.08.2014 04:42, schrieb Ilia Mirkin: >>> This allows a sampler view to have a different texture target than the >>> underlying resource. This will

Re: [Mesa-dev] The GL3.txt format

Am 25.08.2014 07:56, schrieb Kenneth Graunke: > On Monday, August 25, 2014 12:05:07 AM Romain Failliot wrote: >> Some folks helped me and a lot of detection bug have been fixed! >> >> I have a question though (for my own culture): what's with the swrast, the >> softpipe and the llvmpipe? Aren't the

Re: [Mesa-dev] [PATCH] glsl_to_tgsi: allocate and enlarge arrays for temporaries on demand

Am 24.08.2014 23:51, schrieb Marek Olšák: > On Sun, Aug 24, 2014 at 6:15 PM, Ilia Mirkin wrote: >> On Sun, Aug 24, 2014 at 7:44 AM, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> This fixes crashes if the number of temporaries is greater than 4096. >>> >>> Bugzilla: >>> https://urldefense.pro

Re: [Mesa-dev] The GL3.txt format

mainly because I might have bug reports saying that softpipe > is green but it's never mentioned in the original file) > > > 2014-08-25 10:28 GMT-04:00 Roland Scheidegger <mailto:srol...@vmware.com>>: > > > Am 25.08.2014 07 :56, schrieb Kenneth Graunke: &

Re: [Mesa-dev] [PATCH] glsl_to_tgsi: allocate and enlarge arrays for temporaries on demand

Am 26.08.2014 01:58, schrieb Ian Romanick: > On 08/24/2014 02:51 PM, Marek Olšák wrote: >> On Sun, Aug 24, 2014 at 6:15 PM, Ilia Mirkin wrote: >>> On Sun, Aug 24, 2014 at 7:44 AM, Marek Olšák wrote: From: Marek Olšák This fixes crashes if the number of temporaries is greater than

Re: [Mesa-dev] [PATCH] docs: fix up status of softpipe, llvmpipe

Am 27.08.2014 00:55, schrieb Dave Airlie: > On 26 August 2014 05:55, wrote: >> From: Roland Scheidegger >> >> The docs were never really up to date for them, missing just about >> everything. >> So mark them off as all done for GL 3.3 (though softpipe is in fa

Re: [Mesa-dev] [PATCH V4 2/3] gallium: add cap for MAX_VERTEX_ATTRIB_STRIDE

Reviewed-by: Roland Scheidegger Though I think most drivers can probably support a lot more (everything draw based should be able to support virtually unlimited strides I believe, up to max_int32 probably though this doesn't make much sense, and I suspect that's true for all d3d10-lev

<    9   10   11   12   13   14   15   16   17   18   >