Re: [Mesa-dev] [PATCH] GL3: remove radeonsi occurrences in GL 4.2, already specified as "all DONE"

Reviewed-by: Edward O'Callaghan On 2016-04-30 01:48, Fabio Pedretti wrote: --- docs/GL3.txt | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index bb2bb6e..5a6be41 100644 --- a/docs/GL3.txt +++

Re: [Mesa-dev] [PATCH 22/27] glsl: add helper for comparing arrays in varying packing pass

On 2016-03-31 21:57, Timothy Arceri wrote: --- src/compiler/glsl/lower_packed_varyings.cpp | 25 + 1 file changed, 25 insertions(+) diff --git a/src/compiler/glsl/lower_packed_varyings.cpp b/src/compiler/glsl/lower_packed_varyings.cpp index ad766bb..6e7a289 100644

Re: [Mesa-dev] [PATCH 19/27] glsl: skip location and component packing validation on patch out

Acked-by: Edward O'Callaghan On 2016-03-31 21:57, Timothy Arceri wrote: These outputs have a separate location domain from per-vertex outputs and need to be handled separately. For now just skip validation so we don't invalidate valid shaders. ---

Re: [Mesa-dev] [PATCH 27/27] docs: mark ARB_enhanced_layouts as DONE

Acked-by: Edward O'Callaghan On 2016-03-31 21:58, Timothy Arceri wrote: --- docs/GL3.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index f6248da..ede8cf5 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@

Re: [Mesa-dev] [PATCH 02/27] glsl: allow component qualifier on varying inputs

Reviewed-by: Edward O'Callaghan On 2016-03-31 21:57, Timothy Arceri wrote: --- src/compiler/glsl/ast_type.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/glsl/ast_type.cpp b/src/compiler/glsl/ast_type.cpp index 30c9eff..de3fdcc 100644 ---

Re: [Mesa-dev] [PATCH 4/4] radeonsi: Print a message when scratch allocation fails.

On 2016-04-20 11:46, Nicolai Hähnle wrote: On 19.04.2016 17:50, Bas Nieuwenhuizen wrote: Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_compute.c | 5 - src/gallium/drivers/radeonsi/si_state_shaders.c | 5 - 2 files changed, 8

Re: [Mesa-dev] [PATCH 1/4] radeonsi: use CE suballocator for CP DMA realignment.

On 2016-04-20 09:29, Bas Nieuwenhuizen wrote: I retract patch 1 and 2. Large scratch buffers are nice, but the hardware only supports a 32-bit offset into it. - Bas On Wed, Apr 20, 2016 at 12:50 AM, Bas Nieuwenhuizen wrote: Use the CE suballocator instead of the

Re: [Mesa-dev] [PATCH 2/2] radeonsi: Implement ddx/ddy on VI using ds_bpermute

On 2016-04-16 20:20, Marek Olšák wrote: On Sat, Apr 16, 2016 at 8:04 AM, Michel Dänzer wrote: On 16.04.2016 14:51, Michel Dänzer wrote: On 16.04.2016 11:39, Tom Stellard wrote: The ds_bpermute instruction allows threads to transfer data directly to or from the vgprs of

Re: [Mesa-dev] [PATCH 1/6] gallium: use enums in p_defines.h

Patches 1 & 2 are, Reviewed-by: Edward O'Callaghan i`ll have to spend some time looking at the others tomorrow.. On 2016-04-16 22:50, Marek Olšák wrote: From: Marek Olšák and remove number assignments which are consecutive ---

Re: [Mesa-dev] [PATCH 1/2] gallium/radeon: use enums in r600_query.h

This series is, Reviewed-by: Edward O'Callaghan On 2016-04-16 22:50, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/r600_query.h | 43 ++--- 1 file changed, 23 insertions(+), 20

Re: [Mesa-dev] [PATCH 0/4] Implement ARB_clear_texture for radeon drivers

Hi Jakob, Unfortunately ARB_clear_texture is not as straight forward and taking that from nouveau. You will notice I sent essentially a identical series last year to the ml as a rfc. You can find that work sitting around on my github here:

Re: [Mesa-dev] [PATCH v2 01/20] radeonsi: lower compute shader arguments

Patches - 2-4, 7-8, 12-14 & 17 - are all: Reviewed-by: Edward O'Callaghan The series was: Tested-by: Edward O'Callaghan On 2016-04-14 05:29, Bas Nieuwenhuizen wrote: Signed-off-by: Bas Nieuwenhuizen

Re: [Mesa-dev] [PATCH 1/3] glsl: removing double semi-colons

This series is, Reviewed-by: Edward O'Callaghan On 2016-04-14 02:43, Jakob Sinclair wrote: Trivial change. Removing unnecessary semi-colons from the code. I don't have push access so someone reviewing this can push it. Signed-off-by: Jakob Sinclair

Re: [Mesa-dev] ARB_framebuffer_no_attachments for llvm and soft pipes

On 2016-04-11 22:27, Roland Scheidegger wrote: Am 10.04.2016 um 09:41 schrieb Edward O'Callaghan: All the piglits pass for these two as-is. However, some of the piglits require SSBO support to run, although I can't see why anything would actually fail but I thought I would make note of it just

Re: [Mesa-dev] [PATCH 1/2] tgsi: fix buffer overflow

This series is, Reviewed-by: Edward O'Callaghan On 2016-04-13 11:06, Thomas Hindoe Paaboel Andersen wrote: Increase r to four channels as rgba is written to it --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Mesa-dev] [PATCH] util: Fix race condition on libgcrypt initialization

Reviewed-by: Edward O'Callaghan On 2016-04-13 08:10, Mark Janes wrote: Fixes intermittent Vulkan CTS failures within the test groups: dEQP-VK.api.object_management.multithreaded_per_thread_device dEQP-VK.api.object_management.multithreaded_per_thread_resources

Re: [Mesa-dev] [PATCH] radeonsi: enable GLSL 4.20 and therefore OpenGL 4.2

Reviewed-by: Edward O'Callaghan On 2016-04-13 07:42, Nicolai Hähnle wrote: From: Nicolai Hähnle This is the last necessary bit for OpenGL 4.2 support. All driver-specific functionality has already been implemented as part of

Re: [Mesa-dev] [PATCH 0/3] R600-GCN: Improving performance on APUs & IGPs

Reviewed-by: Edward O'Callaghan Thanks for working on this, Edward. On 2016-04-12 05:02, Marek Olšák wrote: Hi, This disables buffer moves between VRAM and GTT by setting both of them as preferred heaps for APUs and IGPs. Allocations go to VRAM if there is free

Re: [Mesa-dev] [PATCH 0/5] R600, GCN: Guard Band support

I didn't see anything obviously wrong so, Reviewed-by: Edward O'Callaghan But I have some general questions about guard band, not sure if this is the right place but I'll just ask any way: From my somewhat naive understanding guard band can lead to small gaps

Re: [Mesa-dev] [PATCH] r600g: fix typo in r600 register definitions

Acked-by: Edward O'Callaghan On 2016-04-09 09:12, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/r600/r600d.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600d.h

Re: [Mesa-dev] [PATCH 1/7] gallium/radeon: move pipeline stat context flags to common code

This series is, Reviewed-by: Edward O'Callaghan This definitely makes for a good cleanup, I was wondering about all the manual stuff myself.. On 2016-04-09 09:12, Marek Olšák wrote: From: Marek Olšák ---

Re: [Mesa-dev] [PATCH] radeonsi: implement and rely on set_active_query_state

Reviewed-by: Edward O'Callaghan On 2016-04-08 18:58, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_blit.c | 3 --- src/gallium/drivers/radeonsi/si_pipe.h | 4

Re: [Mesa-dev] [PATCH] radeonsi: fix mask checking when emitting scissors and viewports

On 2016-04-08 19:00, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index

Re: [Mesa-dev] [PATCH] gallium/radeon: unify checking streamout enable state

Reviewed-by: Edward O'Callaghan On 2016-04-08 19:00, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/r600/r600_state_common.c | 5 ++--- src/gallium/drivers/radeon/r600_pipe_common.h | 6 ++

Re: [Mesa-dev] [PATCH] svga: add some trivial null pointer checks

Reviewed-by: Edward O'Callaghan +1 for defensive programming. On 2016-04-07 06:00, Brian Paul wrote: These small mallocs will probably never fail, but static analysis tools may complain about the missing checks. --- src/gallium/drivers/svga/svga_pipe_blend.c

Re: [Mesa-dev] r600/compute: cleanup evergreen_compute.c

Nice cleanup. This series is, Reviewed-by: Edward O'Callaghan On 2016-04-07 07:40, Dave Airlie wrote: This probably should have been cleaned up before merging, but we were a bit lax with it. This is a bunch of cleanups and changes, that make adding

Re: [Mesa-dev] [PATCH 0/4] ARB_robust_buffer_access_behavior for radeonsi

I had a hacked up version of this last week which was very similar. This is much cleaner, hence this series is, Reviewed-by: Edward O'Callaghan On 2016-04-04 21:41, Bas Nieuwenhuizen wrote: This series implements ARb_robust_buffer_access_behavior for the radeonsi

Re: [Mesa-dev] report ARB_cull_distance

Patches 1-5, 8 & 10 are, Reviewed-by: Edward O'Callaghan On 2016-04-04 12:15, Dave Airlie wrote: Okay I've taken Tobias' last work in progress, cleaned it up a bit, move the rename out into a separate patch, reordered things slightly. I've dropped the separate

Re: [Mesa-dev] [PATCH 00/20] GL compute shaders for radeonsi

This series is, Tested-By: Edward O'Callaghan I didn`t pick up anything major wrong with it, but with others minor suggestions this series is also, Reviewed-By: Edward O'Callaghan Kind Regards, On 2016-04-03 00:10, Bas

Re: [Mesa-dev] Split buffer block array into UBO and SSBO arrays

This series is, Acked-by: Edward O'Callaghan On 2016-04-03 21:16, Timothy Arceri wrote: This is the final clean-up of the buffer block structures. With this series we just create two arrays to begin with and drop the combined array. Note to avoid code churn and

Re: [Mesa-dev] radeonsi, r600g ARB_framebuffer_no_attachments rebased

On 2016-04-03 14:55, Ilia Mirkin wrote: On Sat, Apr 2, 2016 at 10:54 PM, Edward O'Callaghan wrote: This series implements ARB_framebuffer_no_attachments for radeonsi & r600g. It is a rebase of the last previous patch series with the respective Rb's added. I have

Re: [Mesa-dev] [PATCH 05/30] r600: refactor binding code for attach buffer to CB.

Reviewed-by: Edward O'Callaghan On 2016-03-31 18:03, Dave Airlie wrote: From: Dave Airlie This refactors out the code and fixes it up to be used for images later. It uses the code in the current RAT binding for compute. Signed-off-by: Dave

Re: [Mesa-dev] [PATCH 04/30] r600: refactor out CB setup.

Reviewed-by: Edward O'Callaghan On 2016-03-31 18:03, Dave Airlie wrote: From: Dave Airlie This moves the code to create CB info out into a separate function so it can be reused in images code to create RATs. Signed-off-by: Dave Airlie

Re: [Mesa-dev] [PATCH 02/30] r600: factor out the code to initialise a buffer resource.

Reviewed-by: Edward O'Callaghan On 2016-03-31 18:03, Dave Airlie wrote: From: Dave Airlie This takes the code required to initialise a buffer resource out of the texture buffer code, into it's own function. This is going to be used for the

Re: [Mesa-dev] [PATCH 03/30] r600: refactor texture resource words setup code.

Reviewed-by: Edward O'Callaghan On 2016-03-31 18:03, Dave Airlie wrote: From: Dave Airlie This refactors out the code to setup a texture resource so we can reuse it later from the images code. Signed-off-by: Dave Airlie

Re: [Mesa-dev] [PATCH] mesa/st: Avoid a NULL-ptr dereference on possible missing callback

Determinism is always better regardless of how you get there. A null pointer deference `on purpose` is a really poor idea in C. I am somewhat surprised you are asking if its really better to rely on undefined behavior vs. an assert. I thought about using a if branch and just returning but I

Re: [Mesa-dev] [PATCH] mesa: remove initialized field from uniform storage

Reviewed-by: Edward O'Callaghan On 2016-03-27 14:51, Timothy Arceri wrote: The only place this was used was in a gallium debug function that had to be manually enabled. --- src/compiler/glsl/ir_uniform.h | 5

Re: [Mesa-dev] [PATCH 03/17] mesa/st: Set _NumSamples in update_framebuffer_state()

On 2016-03-25 22:20, Ilia Mirkin wrote: On Mar 25, 2016 4:43 AM, wrote: On 2016-03-25 14:02, Ilia Mirkin wrote: On Thu, Mar 24, 2016 at 8:11 PM, Edward O'Callaghan wrote: Using PIPE_FORMAT_NONE to indicate what MSAA modes are

Re: [Mesa-dev] [PATCH 15/17] nvc0: handle the case where there are no framebuffer attachments

On 2016-03-25 14:29, Ilia Mirkin wrote: Please leave this and the next patch out of your series. I'm going to need to retest everything carefully once the core support is in (and I get a bit of time). Done. Be sure to remove my Rb if you made changes and i`ll review it again. Thanks,

Re: [Mesa-dev] [PATCH 10/17] gallium/util: Ensure util_framebuffer_get_num_samples() is valid

On 2016-03-25 14:20, Ilia Mirkin wrote: Instead of introducing buggy code in patch 6/17 and then fixing it up here, you need to fold this with patch 6 so that it's all done at the same time. Yea, can do. Cheers, On Thu, Mar 24, 2016 at 8:11 PM, Edward O'Callaghan

Re: [Mesa-dev] [PATCH 03/17] mesa/st: Set _NumSamples in update_framebuffer_state()

On 2016-03-25 14:02, Ilia Mirkin wrote: On Thu, Mar 24, 2016 at 8:11 PM, Edward O'Callaghan wrote: Using PIPE_FORMAT_NONE to indicate what MSAA modes are supported with a framebuffer using no attachment. Signed-off-by: Edward O'Callaghan

Re: [Mesa-dev] [PATCH] radeonsi: fix 2D array MSAA failures since image support landed

Reviewed-by: Edward O'Callaghan On 2016-03-23 04:27, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 11/17] gallium/aux: Fix u_blitter.c for layers/samples

Ah you are correct, this is no longer needed in the push branch. We can drop this one from the series as its a nop, please ignore thanks for spotting it. On 2016-03-22 02:43, Marek Olšák wrote: Does this fix anything even? The blitter always binds something, thus this should have no effect.

Re: [Mesa-dev] [PATCH 00/11] radeonsi: shader buffer support (atomic counters, ssbo)

Hi Nicolai, Thanks for taking over this work and going the whole nine yards with it! This series is, Reviewed-by: Edward O'Callaghan Thanks again, Edward. On 2016-03-22 10:21, Nicolai Hähnle wrote: Hi, since shader images have laid most of the foundation,

Re: [Mesa-dev] [PATCH] mesa: replace gl_context->Multisample._Enabled with _mesa_is_multisample_enabled.

Too quick, very nice cleanup, thanks. Reviewed-by: Edward O'Callaghan On 2016-03-22 12:58, Bas Nieuwenhuizen wrote: This removes any dependency on driver validation of the number of framebuffer samples. Signed-off-by: Bas Nieuwenhuizen

Re: [Mesa-dev] [PATCH] tgsi: drop unused set_exec/kill_mask interfaces.

Reviewed-by: Edward O'Callaghan On 2016-03-22 11:29, Dave Airlie wrote: From: Dave Airlie These don't get used and haven't been in git history from what I can see, so drop them. Signed-off-by: Dave Airlie ---

Re: [Mesa-dev] [PATCH] radeonsi: fix out-of-bounds indexing of shader images

Reviewed-by: Edward O'Callaghan On 2016-03-22 07:41, Nicolai Hähnle wrote: From: Nicolai Hähnle Results are undefined but may not crash. Without this change, out-of-bounds indexing can lead to VM faults and GPU hangs. Constant

Re: [Mesa-dev] [PATCH 01/17] gallium: Add PIPE_CAP_MSAA_MODES

On 2016-03-21 21:06, Marek Olšák wrote: On Sat, Mar 19, 2016 at 5:09 PM, Ilia Mirkin wrote: On Sat, Mar 19, 2016 at 12:02 PM, Bas Nieuwenhuizen wrote: On Sat, Mar 19, 2016 at 4:25 PM, Ilia Mirkin wrote: On Sat, Mar 19,

Re: [Mesa-dev] [PATCH 17/17] GL3.txt: Mark ARB_framebuffer_no_attachments as done

On 2016-03-19 21:08, Kai Wasserbäch wrote: Edward O'Callaghan wrote on 19.03.2016 07:41: Signed-off-by: Edward O'Callaghan --- docs/GL3.txt | 2 +- docs/relnotes/11.3.0.html | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 0/3] st/mesa, radeonsi: some MemoryBarrier fixes

Hi Nicolai, This series is, Reviewed-by: Edward O'Callaghan Thanks, On 2016-03-19 14:37, Nicolai Hähnle wrote: Hi, these patches apply on top of my ARB_shader_image_load_store series. Together, they fix a few remaining fails with piglit's

Re: [Mesa-dev] [PATCH] configure.ac require libdrm 2.4.65 for amdgpu because of drmGetDevice

Reviewed-by: Edward O'Callaghan On 2016-03-14 03:46, Marek Olšák wrote: From: Marek Olšák --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 49be147..d768db6 100644 ---

Re: [Mesa-dev] [PATCH 1/4] mesa: gl_NumSamples should always be at least one

Reviewed-by: Edward O`Callaghan I had the same issue also. On 2016-02-16 17:31, Ilia Mirkin wrote: From ARB_sample_shading: "gl_NumSamples is the total number of samples in the framebuffer, or one if rendering to a non-multisample framebuffer" So make

Re: [Mesa-dev] [PATCH] mesa/dri/r200: Refrain from using symbol links in repo

Disregard, apparently this breaks out-of-tree builds. There perhaps is maybe no good solution here so i`ll refrain from this can of worms for now. On 2016-02-18 15:46, Edward O'Callaghan wrote: Just use the relative path in the Makefile.source over symbol links that are not necessarily

Re: [Mesa-dev] [PATCH v3] clover: fix build failure since bfd695e

Thanks kindly. Reviewed-by: Edward O'Callaghan On 2016-02-14 09:39, Serge Martin wrote: --- src/gallium/state_trackers/clover/core/kernel.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 1/4] tgsi: break gigantic tgsi_scan_shader() function into pieces

This series is, Reviewed-by: Edward O'Callaghan On 2016-02-06 11:56, Brian Paul wrote: New functions for examining instructions, declarations, etc. --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 739 + 1 file changed, 375

Re: [Mesa-dev] [PATCH 0/4] radeonsi: experimental support for GPUPerfStudio

Can't see any serious issues here and a non-verified `working' instance of GPUPerfStudio is sure better than a crashing one! This series is, Reviewed-by: Edward O'Callaghan On 2016-02-04 00:52, Nicolai Hähnle wrote: Hi, this bunch of patches meets

Re: [Mesa-dev] [PATCH] radeonsi: Dump LLVM IR before optimization passes

Reviewed-by: Edward O'Callaghan On 2016-02-04 13:28, Michel Dänzer wrote: From: Michel Dänzer Otherwise it's not possible to diagnose problems caused by optimization passes. Signed-off-by: Michel Dänzer ---

Re: [Mesa-dev] [PATCH 1/4] st/mesa: unify variants and delete functions for TCS, TES, GS

This series is, Reviewed-by: Edward O'Callaghan On 2016-01-31 02:50, Marek Olšák wrote: From: Marek Olšák no difference between those --- src/mesa/state_tracker/st_atom_shader.c | 6 +- src/mesa/state_tracker/st_cb_program.c | 18 ++-

Re: [Mesa-dev] [PATCH 2/3] mesa: use geometric helper for computing min samples

Reviewed-by: Edward O'Callaghan On 2016-01-31 16:58, Ilia Mirkin wrote: In case we have a draw buffer without attachments, we should be looking at the default number of samples. Signed-off-by: Ilia Mirkin --- Still doesn't work properly on

Re: [Mesa-dev] [PATCH 1/2] winsys/amdgpu: Handle RADEON_FLAG_NO_CPU_ACCESS

This series is, Reviewed-by: Edward O'Callaghan Good job working out where this issue was. On 2016-01-26 18:40, Michel Dänzer wrote: From: Michel Dänzer Failing to do this was resulting in the kernel driver unnecessarily leaving open

Re: [Mesa-dev] [PATCH v4 00/11] st/mesa: add shader buffer support

This whole series is now, Reviewed-by: Edward O'Callaghan On 2016-01-25 05:59, Ilia Mirkin wrote: I believe I've addressed the various feedback people had. There's the outstanding point of how to expose the atomic buffer bindings, but this is a larger issue and

Re: [Mesa-dev] [PATCH] radeonsi: add DCC buffer for sampler views on new CS

Reviewed-by: Edward O'Callaghan On 2016-01-25 03:40, Nicolai Hähnle wrote: From: Nicolai Hähnle This fixes a VM fault and possible lockup in high memory pressure situations. Cc: "11.0 11.1" ---

Re: [Mesa-dev] [PATCH 0/7] radeonsi: geometry shader bug fix and cleanup

This series is, Reviewed-by: Edward O'Callaghan On 2016-01-23 10:59, Nicolai Hähnle wrote: Hi, this series was prompted by a rendering bug reported for Dolphin. The bug is fixed in the first two patches, and the remainder is assorted cleanups that I noticed

Re: [Mesa-dev] [PATCH 1/4] radeonsi: allow using all CUs for tessellation and on-chip GS (v2)

This series is, Reviewed-by: Edward O'Callaghan On 2016-01-23 01:18, Marek Olšák wrote: From: Marek Olšák v2: After more discussion with hw teams, the kernel already contains the optimal settings allowing us to use all CUs. ---

Re: [Mesa-dev] [PATCH] radeonsi: Add option for SI scheduler

Reviewed-by: Edward O'Callaghan On 2016-01-22 04:35, Axel Davy wrote: Add a debug option to select the LLVM SI Machine Scheduler. R600_DEBUG=sisched Signed-off-by: Axel Davy --- The corresponding llvm patch is on llvm master, and should land

Re: [Mesa-dev] [PATCH v2 0/9] st/mesa: accelerate texture uploads from PBOs

To the best of my understanding, this series is now: Reviewed-by: Edward O'Callaghan On 2016-01-22 06:37, Nicolai Hähnle wrote: Hi everybody, here's an updated version of the series. I decided to keep BUFFER_SAMPLER_VIEW_RGBA_ONLY as is, following Fredrik's

Re: [Mesa-dev] [PATCH 1/2] radeonsi: add max waves / CU to shader stats

This series is, Reviewed-by: Edward O'Callaghan On 2016-01-20 12:39, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 33 +--- 1 file changed, 30 insertions(+), 3

Re: [Mesa-dev] [PATCH 06/10] st/mesa: use RESQ to find buffer size

Reviewed-by: Edward O'Callaghan On 2016-01-18 16:51, Ilia Mirkin wrote: --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

Re: [Mesa-dev] [PATCH] tgsi: initialize Atomic field in tgsi_default_declaration

Reviewed-by: Edward O'Callaghan On 2016-01-17 19:46, Ilia Mirkin wrote: Spotted by Coverity. Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/tgsi/tgsi_build.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Mesa-dev] [PATCH 1/2] radeonsi: Print "LLVM emitted unknown config register" warning only once

This series is, Reviewed-by: Edward O'Callaghan On 2016-01-15 14:23, Michel Dänzer wrote: From: Michel Dänzer Say "LLVM" instead of "Compiler" for clarity. Signed-off-by: Michel Dänzer ---

Re: [Mesa-dev] [PATCH 1/7] glsl: enable offset layout qualifier for ARB_enhanced_layouts

This series is, Reviewed-by: Edward O'Callaghan On 2016-01-11 14:13, Timothy Arceri wrote: --- src/glsl/glsl_parser.yy | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy index 6b634f2..b2b94f4

Re: [Mesa-dev] [PATCH 1/2] glsl: combine if blocks

This series is: Reviewed-by: Edward O'Callaghan On 2016-01-08 15:25, Timothy Arceri wrote: --- src/glsl/link_uniforms.cpp | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp index

Re: [Mesa-dev] [PATCH 0/8] gl_FragCoord and gl_FrontFacing as system values

This series is: Reviewed-by: Edward O'Callaghan On 2016-01-08 12:29, Marek Olšák wrote: Hi, This series adds the possibility for drivers to get gl_FragCoord and gl_FrontFacing as system values. When FACE is a system value, it also changes its type to integer

Re: [Mesa-dev] [PATCH 1/2] radeonsi: simplify gl_FragCoord behavior

This series is: Reviewed-by: Edward O'Callaghan On 2016-01-08 12:30, Marek Olšák wrote: From: Marek Olšák It will become a system value, not an input. --- src/gallium/drivers/radeonsi/si_state_shaders.c | 45 - 1

Re: [Mesa-dev] [PATCH 1/3] st/mesa: remove dead code from mesa_to_tgsi

This series is: Reviewed-by: Edward O'Callaghan On 2016-01-08 12:12, Marek Olšák wrote: From: Marek Olšák These aren't part of ARB_fragment_program. --- src/mesa/state_tracker/st_mesa_to_tgsi.c | 51 1

Re: [Mesa-dev] [PATCH 1/3] tgsi/scan: set if a fragment shader writes sample mask

This series is, Reviewed-by: Edward O'Callaghan On 2016-01-06 12:46, Marek Olšák wrote: From: Marek Olšák This will be used by radeonsi. --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 2 ++ src/gallium/auxiliary/tgsi/tgsi_scan.h | 1 + 2

Re: [Mesa-dev] [PATCH 1/6] gallium: Remove unnecessary semicolons

On 2016-01-06 10:30, Brian Paul wrote: Series looks OK to me. Reviewed-by: Brian Paul Do you need someone to commit/push for you? I do yes, thank you kindly. Edward. -Brian On 01/05/2016 03:07 AM, Edward O'Callaghan wrote: Fix silly issue with MSVC case fall-though

Re: [Mesa-dev] [PATCH] nir: few missing struct names

Reviewed-by: Edward O'Callaghan On 2016-01-05 05:27, Rob Clark wrote: From: Rob Clark nir.h is a bit inconsistent about 'typedef struct {} nir_foo' vs 'typedef struct nir_foo {} nir_foo'. But missing struct name tags is inconvenient

Re: [Mesa-dev] [PATCH v3] gallium/tests: fix build with clang compiler

omg I don't know why folks insist on using gnuc nested functions they are insane. Thanks for working though this one! Reviewed-by: Edward O'Callaghan On 2016-01-03 04:20, Samuel Pitoiset wrote: Nested functions are supported as an extension in GNU C, but Clang

Re: [Mesa-dev] [PATCH 0/5] Add ARB_indirect_parameters support

In this series patches 1-4 are: Reviewed-by: Edward O'Callaghan No idea what is happening in patch 5 to say anything either way. On 2016-01-03 07:38, Ilia Mirkin wrote: The nvc0 patch applies on top of some unpublished patches, see

Re: [Mesa-dev] [PATCH 1/8] tgsi: add ureg support for image decls

There is quite a bit of rename churn happening here at the same time as the bring up of ureg support for image declarations. Would it be possible to split the rename churn out from the actual behavioral changes please? On 2016-01-03 15:37, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin

Re: [Mesa-dev] [PATCH 0/8] gallium: add shader buffer support

In this series patches 2-8 are: Reviewed-by: Edward O'Callaghan with some commentary on patch 1. Kind Regards, On 2016-01-03 15:37, Ilia Mirkin wrote: This provides enough support in TGSI to support shader buffers. I do away with the defunct TGSI_FILE_RESOURCE

Re: [Mesa-dev] [PATCH 1/6] gallium: document PK2H/UP2H

This series is: Reviewed-by: Edward O'Callaghan On 2016-01-03 11:37, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- src/gallium/docs/source/tgsi.rst | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 0/9] RadeonSI: Some shaders cleanups

Well can't disagree with anything in this series and it certainly makes `si_shader.c' a tiny bit easier to understand for me. Hopefully not too much fallout with the debug callback patch series as they will need to be rebased on top of this :| Thus this series is, Reviewed-by: Edward

Re: [Mesa-dev] [PATCH 1/6] gallium/radeon: implement set_debug_callback

Fantastic thanks! This series is, Reviewed-by: Edward O'Callaghan On 2015-12-31 13:30, Nicolai Hähnle wrote: From: Nicolai Hähnle --- src/gallium/drivers/radeon/r600_pipe_common.c | 12

Re: [Mesa-dev] [PATCH 1/3] glsl: annotate ast_process_struct_or_iface_block_members() as static

This series is, Reviewed-by: Edward O'Callaghan On 2015-12-29 21:02, Timothy Arceri wrote: From: Emil Velikov Reviewed-by: Timothy Arceri --- src/glsl/ast_to_hir.cpp | 2 +- 1 file changed, 1

Re: [Mesa-dev] [PATCH v5] Add .mailmap

Should I be expecting to see myself on here? On 2015-12-28 20:50, Giuseppe Bilotta wrote: This adds a first tentative .mailmap file, to canonicize contributor name/emails in shortlogs and other statistical endeavours. Signed-off-by: Giuseppe Bilotta --- Hopefully

Re: [Mesa-dev] [PATCH 16/28] glsl: don't pack tessellation stages like we do other stages

On 2015-12-29 16:00, Timothy Arceri wrote: Tessellation shaders treat varyings as shared memory and invocations can access each others varyings therefore we can't use the existing method to lower them. This adds a check for these stages as following patches will allow explicit locations to be

Re: [Mesa-dev] [PATCH 26/28] glsl: lower tessellation varyings packed with component layout qualifier

On 2015-12-29 16:00, Timothy Arceri wrote: For tessellation shaders we cannot just copy everything to the packed varyings like we do in other stages as tessellation uses shared memory for varyings, therefore it is only safe to copy array elements that the shader actually uses. This class

Re: [Mesa-dev] V2 ARB_enhanced_layouts component qualifier support

On 2015-12-29 16:00, Timothy Arceri wrote: This series adds support for the component layout qualifier by enhancing the varying packing pass at the GLSL IR level. The advantage to this approach is that its fairly simple and will work for all drivers, the disadvantage it that it relies on

Re: [Mesa-dev] [PATCH 0/10] Tessellation shaders for Gen7/7.5.

Reviewed-by: Edward O'Callaghan Congrats on getting this working, also thanks! On 2015-12-25 12:34, Kenneth Graunke wrote: This morning, I woke up and somehow "knew" what was causing my HS GPU hangs on Gen7/7.5. It turns out I was (completely) wrong, but

Re: [Mesa-dev] [PATCH 1/8] draw: rework hanndling of non-existing outputs in emit code

Thanks for the most comprehensive cleanup Roland and fixing that minor regression we discussed. Happy holiday's. Reviewed-by: Edward O'Callaghan On 2015-12-22 14:00, srol...@vmware.com wrote: From: Roland Scheidegger Previously the code

Re: [Mesa-dev] [PATCH] nir/builder: fix C90 build errors

On 2015-12-20 09:39, Rob Clark wrote: From: Rob Clark We are going to start using nir_builder.h from some gallium code, which is currently only C90. Which results in: In file included from nir/nir_emulate.c:26:0: ../../../src/glsl/nir/nir_builder.h: In

Re: [Mesa-dev] [PATCH 3/3] radeonsi: fix perfcounter selection for SI_PC_MULTI_BLOCK layouts

On 2015-12-15 04:06, Nicolai Hähnle wrote: From: Nicolai Hähnle The incorrectly computed register count caused lockups. --- src/gallium/drivers/radeonsi/si_perfcounter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 1/3] glsl: simplifiy interface matching

On 2015-12-13 16:25, Timothy Arceri wrote: This makes the code easier to follow, should be more efficient and will makes it easier to add matching via explicit locations in the following patch. This patch also replaces the hash table with the newer resizable hash table this should be more

Re: [Mesa-dev] [PATCH] radeonsi: don't call of u_prims_for_vertices for patches and rectangles

On 2015-12-10 22:15, Marek Olšák wrote: On Thu, Dec 10, 2015 at 4:01 AM, Michel Dänzer wrote: On 10.12.2015 06:58, Marek Olšák wrote: From: Marek Olšák Both caused a crash due to a division by zero in that function. This is an alternative fix. Cc:

Re: [Mesa-dev] [PATCH] gallium/util: handle patches in u_prims_for_vertices to fix a radeonsi crash

On 2015-12-10 01:47, Marek Olšák wrote: From: Marek Olšák I guess the crash was because of divison by zero. Cc: 11.0 11.1 --- src/gallium/auxiliary/util/u_prim.h | 17 +

Re: [Mesa-dev] softpipe: V.2 implement some support for multiple viewports

Roland, I could not due to ml size limit or something, it just bounces hence the pull request. Cheers, Edward. On 2015-12-10 02:38, Roland Scheidegger wrote: Am 09.12.2015 um 05:16 schrieb Edward O'Callaghan: This fixes my initial attempt so that piglit now passes 14/14. Thanks to a couple

Re: [Mesa-dev] softpipe: V.2 implement some support for multiple viewports

The following changes since commit a13b14930d94b024160fe17814e091356d07f7fb: llvmpipe: fix fp64 inputs to geom shader. (2015-12-09 13:56:39 +1000) are available in the git repository at: https://github.com/victoredwardocallaghan/mesa-GLwork.git softpipe-ARB_viewport_array for you to

Re: [Mesa-dev] [PATCH 00/10] Rework of pb_cache_manager for removal of radeon_winsys_cs_handle

On 2015-12-07 11:00, Marek Olšák wrote: Hi, This series addresses the weirdness in radeon drivers that every buffer has 2 handles: - pb_buffer (== pb_cache_buffer) - radeon_winsys_cs_handle (winsys-specific pb_buffer) The inefficiency of converting pb_cache_buffer into the winsys-specific

  1   2   >