Re: [Mesa3d-dev] gallium failing to build on darwin/ppc

2010-04-04 Thread Vinson Lee
> -Original Message- > > I see Vinson committed a better fix to the 7.8 branch. However, > Vinson, I think you made a typo: > > #elif defined(PIPE_CC_GCC) && (PIPE_CC_GCC_VERSION >= 401) > > That version should be "410", not "401", right? > The PIPE_CC_GCC_VERSION macro doesn't use

Re: [Mesa3d-dev] gallium failing to build on darwin/ppc

2010-04-03 Thread Vinson Lee
Leopard uses gcc-4.0, which didn't have built-in support for atomic variables. From: Jeremy Huddleston [jerem...@freedesktop.org] Sent: Saturday, April 03, 2010 11:22 AM To: mesa3d-...@lists.sf.net Subject: [Mesa3d-dev] gallium failing to build on darwin/pp

Re: [Mesa3d-dev] Mesa (master): glsl/pp: Add asserts to check for null pointer deferences.

2010-03-04 Thread Vinson Lee
> -Original Message- > > BTW, I just looked at one of the assert commits, and found it actually > _introduces_ a bug. > Look at the assert(attrib_list) added in > 706fffbff59be0dc884e1938f1bdf731af1efa3e. > > This ends up asserting that the attrib_list in glXCreatePixmap is not > NULL. >

Re: [Mesa3d-dev] Mesa (master): mesa: Remove pointless comparison of unsigned integer with a negative constant.

2010-03-04 Thread Vinson Lee
> -Original Message- > > > > > mesa: Remove pointless comparison of unsigned integer with a negative > constant. > > > > --- > > > > src/mesa/shader/prog_execute.c | 13 - > > 1 files changed, 4 insertions(+), 9 deletions(-) > > > > diff --git a/src/mesa/shader/prog_execute.

Re: [Mesa3d-dev] Mesa (master): glsl/pp: Add asserts to check for null pointer deferences.

2010-03-04 Thread Vinson Lee
> -Original Message- > From: Ian Romanick [mailto:i...@freedesktop.org] > Sent: Thursday, March 04, 2010 3:17 PM > To: mesa3d-dev > Subject: Re: [Mesa3d-dev] Mesa (master): glsl/pp: Add asserts to check for > null pointer deferences. > > > What is the benefit of adding all these NULL poin

Re: [Mesa3d-dev] Mesa (master): mesa: Fix unsigned comparison.

2010-03-04 Thread Vinson Lee
Michel, thanks for spotting this. I've reverted the bad commit. Please go ahead and submit your correct fix. From: Michel Dänzer [mic...@daenzer.net] Sent: Thursday, March 04, 2010 1:41 AM To: Vinson Lee Cc: mesa3d-...@lists.sf.net Subject: Re:

Re: [Mesa3d-dev] Mesa (mesa_7_7_branch): mesa: Fix array out-of-bounds access by _mesa_TexGeni.

2009-12-02 Thread Vinson Lee
I will commit new bug fixes to mesa_7_6_branch. What should be done with fixes that were initially committed to mesa_7_7_branch? From: Keith Whitwell [kei...@vmware.com] Sent: Monday, November 30, 2009 11:32 PM To: Ian Romanick; Vinson Lee Cc: mesa3d-dev

Re: [Mesa3d-dev] [PATCH] adds a test using the optional lod bias in texture sampling.

2009-09-10 Thread Vinson Lee
> -Original Message- > From: Ben Holmes [mailto:shran...@hotmail.com] [...] > + > +static void > +loadTex() > +{ > + int height = 4; > + int width = 4; > + int i, j; > + > + GLfloat texData[width][height][4]; > + for (i=0; i < width; ++i) { > + for (

Re: [Mesa3d-dev] bug in piglit vbo-map-remap.c test?

2009-07-06 Thread Vinson Lee
ientState(GL_VERTEX_ARRAY); 119 120 if (Automatic) 121 piglit_report_result(pass ? PIGLIT_SUCCESS : PIGLIT_FAILURE); 122 } From: Ian Romanick [...@freedesktop.org] Sent: Monday, July 06, 2009 9:12 AM To: Vin

[Mesa3d-dev] bug in piglit vbo-map-remap.c test?

2009-07-02 Thread Vinson Lee
I believe there's a bug in the piglit vbo-map-remap.c test. The test fails for me with a GL_INVALID_ENUM error that comes from glEnable(GL_VERTEX_ARRAY). GL_VERTEX_ARRAY is a client-side capability so the error seems valid. tests/general/vbo-map-remap.c 42 static void 43 init() 44