Re: [Mesa3d-dev] [PATCH] shader_api: Fix bounds checking of glUniform and glUniformMatrix

2009-10-06 Thread Nicolai Hähnle
Am Tuesday 06 October 2009 20:29:00 schrieb Ian Romanick: > Nicolai Hähnle wrote: > > glUniformMatrix() with too large count parameter could previously lead to > > memory corruption. > > Is there a piglit test for this? I imagine calling it with count == > INT_MAX should crash fairly reliably. :)

Re: [Mesa3d-dev] [PATCH] shader_api: Fix bounds checking of glUniform and glUniformMatrix

2009-10-06 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Nicolai Hähnle wrote: > glUniformMatrix() with too large count parameter could previously lead to > memory corruption. Is there a piglit test for this? I imagine calling it with count == INT_MAX should crash fairly reliably. :) > Signed-off-by: Nic

Re: [Mesa3d-dev] [PATCH] shader_api: Fix bounds checking of glUniform and glUniformMatrix

2009-10-05 Thread Brian Paul
Untested, but looks good. This should go on the 7.6 branch. -Brian Nicolai Hähnle wrote: > glUniformMatrix() with too large count parameter could previously lead to > memory corruption. > > Signed-off-by: Nicolai Hähnle > --- > src/mesa/shader/shader_api.c | 29 +

[Mesa3d-dev] [PATCH] shader_api: Fix bounds checking of glUniform and glUniformMatrix

2009-10-03 Thread Nicolai Hähnle
glUniformMatrix() with too large count parameter could previously lead to memory corruption. Signed-off-by: Nicolai Hähnle --- src/mesa/shader/shader_api.c | 29 + 1 files changed, 21 insertions(+), 8 deletions(-) diff --git a/src/mesa/shader/shader_api.c b/src/me