[PATCH 3/7] Makefile.PL: allow N to be overridden

2016-05-27 Thread Eric Wong
Relying on the number of processors isn't a great idea since some of our tests rely on delays to test blocking and slow client behavior. --- Makefile.PL | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.PL b/Makefile.PL index 3cffe13..61cb77b 100644 --- a/Makefile.PL +++

[PATCH 6/7] config: remove try_cat

2016-05-27 Thread Eric Wong
It's moved into the Inbox module and we no longer use it in WWW --- lib/PublicInbox/Config.pm | 12 lib/PublicInbox/WWW.pm| 2 +- 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm index 35b24af..317d290 100644 ---

[PATCH 5/7] www: remove footer_html support

2016-05-27 Thread Eric Wong
I haven't used it in a while and the existing "description" is probably good enough. If we support it again, it should be plain-text + auto-linkified for ease-of-maintenance and consistency. --- lib/PublicInbox/Inbox.pm | 10 -- lib/PublicInbox/WWW.pm | 2 -- 2 files changed, 12 deleti

[PATCH 4/7] examples: config no longer supports atomUrl

2016-05-27 Thread Eric Wong
We build the atomUrl from url, which can change dynamically depending on what PSGI environment it is called under. --- examples/public-inbox-config | 1 - 1 file changed, 1 deletion(-) diff --git a/examples/public-inbox-config b/examples/public-inbox-config index 0c1db11..7fcbe0b 100644 --- a/exa

[PATCH 0/7] miscellaneous cleanups

2016-05-27 Thread Eric Wong
Only the last one (NewsGroup class removal for ::Inbox) is likely to cause problems but I'll be checking logs for errors. Eric Wong (7): t/plack: ensure we can cascade on common endpoints http: clarify comments about layering violation Makefile.PL: allow N to be overridden

[PATCH 1/7] t/plack: ensure we can cascade on common endpoints

2016-05-27 Thread Eric Wong
We don't serve things like robots.txt, favicon.ico, or .well-known/ endpoints ourselves, but ensure we can be used with Plack::App::Cascade for others. --- t/plack.t | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/t/plack.t b/t/plack.t index 04680b2..a4f3245 10064

[PATCH 7/7] remove redundant NewsGroup class

2016-05-27 Thread Eric Wong
Most of its functionality is in the PublicInbox::Inbox class. While we're at it, we no longer auto-create newsgroup names based on the inbox name, since newsgroup names probably deserve some thought when it comes to hierarchy. --- MANIFEST | 1 - lib/PublicInbox/Config.pm

[PATCH 2/7] http: clarify comments about layering violation

2016-05-27 Thread Eric Wong
It's a low priority, but acknowledge it. --- lib/PublicInbox/HTTP.pm | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm index 0454f60..fcbd758 100644 --- a/lib/PublicInbox/HTTP.pm +++ b/lib/PublicInbox/HTTP.pm @@ -4,7 +4,7 @@

[PATCH] config: fix NewsWWW fallback for newsgroups in HTTP URLs

2016-05-27 Thread Eric Wong
Oops, added a test to prevent regressions while we're at it. --- lib/PublicInbox/Config.pm | 4 +++- lib/PublicInbox/NewsWWW.pm | 3 ++- t/plack.t | 15 +++ 3 files changed, 20 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/C

[PATCH 1/2] git-http-backend: move real close to GetlineBody

2016-05-27 Thread Eric Wong
This makes more sense as it keeps management of rpipe nice and neat. --- lib/PublicInbox/GetlineBody.pm| 12 lib/PublicInbox/GitHTTPBackend.pm | 1 - 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/lib/PublicInbox/GetlineBody.pm b/lib/PublicInbox/GetlineBody.pm ind

[PATCH 2/2] git-http-backend: close pipe for generic PSGI on errors

2016-05-27 Thread Eric Wong
The generic PSGI code needs to avoid resource leaks if smart cloning is disabled (due to resource contraints). --- lib/PublicInbox/GitHTTPBackend.pm | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/PublicInbox/GitHTTPBackend.pm b/lib/PublicInbox/GitHTTPBackend.pm inde

[PATCH 0/2] git-http-backend: more cleanups + one fix

2016-05-27 Thread Eric Wong
Eric Wong (2): git-http-backend: move real close to GetlineBody git-http-backend: close pipe for generic PSGI on errors lib/PublicInbox/GetlineBody.pm| 12 lib/PublicInbox/GitHTTPBackend.pm | 8 ++-- 2 files changed, 14 insertions(+), 6 deletions(-) -- unsubscri

[PATCH] unsubscribe.milter: use default postfork dispatcher

2016-05-27 Thread Eric Wong
Let postfix (or sendmail :P) control the concurrency limit instead of doing it ourselves. This is necessary because SMTP connections are completely synchronous at this point and a slow/idle SMTP connection will monopolize the worker process. --- examples/unsubscribe.milter | 2 -- 1 file changed,

[PATCH 4/3] httpd/async: do not needlessly weaken

2016-05-27 Thread Eric Wong
The restart_read callback has no chance of circular reference, and weakening $self before we create it can cause $self to be undefined inside the callback (seen during stress testing). Fixes: 395406118cb2 ("httpd/async: prevent circular reference") --- lib/PublicInbox/HTTPD/Async.pm | 7 ++-