[PATCH 1/3] searchidx: reindex clobbers old thread IDs

2017-02-06 Thread Eric Wong
We cannot always reuse thread IDs since our threading logic may change as bugs are fixed. --- lib/PublicInbox/SearchIdx.pm | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm index 1142ca7..bc003c6 100644 --- a/lib

[PATCH 2/3] Revert "searchidx: reindex clobbers old thread IDs"

2017-02-06 Thread Eric Wong
Oops, that's broken, too. I guess the only way to reindex after fixing the thread detection is to start from scratch. This reverts commit 5d91adedf5f33ef1cb87df2a86306ddf370b4f8d. --- lib/PublicInbox/SearchIdx.pm | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/lib/Pub

[PATCH 3/3] search: schema version bump for empty References/In-Reply-To

2017-02-06 Thread Eric Wong
We cannot distinguish between legitimate ghosts and mis-threaded messages before commit 83425ef12e4b65cdcecd11ddcb38175d4a91d5a0 ("searchidx: deal with empty In-Reply-To and References headers") so we must rebuild the index in parallel to fix it. --- lib/PublicInbox/Search.pm | 4 +++- 1 file chan

[PATCH 0/3] force reindex for threading changes

2017-02-06 Thread Eric Wong
We cannot rely on in-place --reindex to handle thread_id changes when we fix threading bugs in the search indexer like in commit 83425ef12e4b65cdcecd11ddcb38175d4a91d5a0 ("searchidx: deal with empty In-Reply-To and References headers") So, bump the schema version and pay the cost of requiring extr

[PATCH] searchidx: deal with empty In-Reply-To and References headers

2017-02-06 Thread Eric Wong
In some messages, these headers exist, but have empty values. Do not let empty values throw off our search indexer to tie threads together, as it can make non-sensical threads grouped to a Message-Id of "" (empty string). See