Re: [PATCH] doc: lei-rediff: grammar fixes for --drq and --dequote-only

2021-09-27 Thread Eric Wong
Thanks, pushed as commit 3dbd6dc31dd7e34bea87dbb626f811e093b6860b -- unsubscribe: one-click, see List-Unsubscribe header archive: https://public-inbox.org/meta/

[PATCH] doc: lei-rediff: grammar fixes for --drq and --dequote-only

2021-09-27 Thread Kyle Meyer
--- Documentation/lei-rediff.pod | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/lei-rediff.pod b/Documentation/lei-rediff.pod index e711de97..4d5e8168 100644 --- a/Documentation/lei-rediff.pod +++ b/Documentation/lei-rediff.pod @@ -40,7 +40,7 @@ patch email.

Re: [PATCH 0/3] fixes for odd/old/missing dependencies

2021-09-27 Thread Eric Wong
Konstantin Ryabitsev wrote: > Yep, I can confirm that after applying these in addition to the one I applied > earlier, all tests pass. > > Thanks, Eric! No problem, thanks for the bug reports. Btw, I was getting some t/lei-auto-watch.t failures the other week, even after a reliability fix(*)

Re: [PATCH 0/3] fixes for odd/old/missing dependencies

2021-09-27 Thread Konstantin Ryabitsev
On Mon, Sep 27, 2021 at 04:05:42PM -0500, Eric Wong wrote: > On Mon, 27 Sep 2021 15:45:20 -0400, Konstantin Ryabitsev wrote: > > On Mon, Sep 27, 2021 at 07:33:46PM +, Eric Wong wrote: > > > The partial fetching would need some work to support working as > > > root. > > > > Ah. Just catch this

[PATCH 3/3] lei completion: workaround old Perl bug

2021-09-27 Thread Eric Wong
While `$argv[-1]' is `undef' on an empty @argv, using `$argv[-1]' as a subroutine argument would fail incorrectly with: Modification of non-creatable array value attempted, subscript -1 at ... ...even though we'd never attempt to modify @_ itself in the subroutines being called. Work around

[PATCH 2/3] t/lei-index: IMAP and NNTP dependencies are optional

2021-09-27 Thread Eric Wong
"lei index" support for IMAP and NNTP is incomplete, so there's no point in requiring them. Reported-by: Konstantin Ryabitsev Link: https://public-inbox.org/meta/20210927124056.kj5okiefvs4ztk27@meerkat.local/ --- t/lei-index.t | 35 +++ 1 file changed, 23

[PATCH 1/3] fetch: support running as root

2021-09-27 Thread Eric Wong
The "-w" perlop always succeeds as root, so we need to check st_mode for writability bits to detect directories we shouldn't write to. Reported-by: Konstantin Ryabitsev Link: https://public-inbox.org/meta/20210927124056.kj5okiefvs4ztk27@meerkat.local/ --- lib/PublicInbox/Fetch.pm | 15

[PATCH 0/3] fixes for odd/old/missing dependencies

2021-09-27 Thread Eric Wong
On Mon, 27 Sep 2021 15:45:20 -0400, Konstantin Ryabitsev wrote: > On Mon, Sep 27, 2021 at 07:33:46PM +, Eric Wong wrote: > > The partial fetching would need some work to support working as > > root. > > Ah. Just catch this with check if if id=0 and skipping the test as "known not > to work

Re: -fetch failures [was: latest make test failures on CentOS-7]

2021-09-27 Thread Konstantin Ryabitsev
On Mon, Sep 27, 2021 at 07:33:46PM +, Eric Wong wrote: > Konstantin Ryabitsev wrote: > > t/v2mirror.t . 71/? W: > > /tmp/pi-v2mirror-39373-Dl1N/m/git/3.git missing remote.origin.url > > fatal: not a git repository: '/tmp/pi-v2mirror-39373-Dl1N/m/git/3.git' > > git

-fetch failures [was: latest make test failures on CentOS-7]

2021-09-27 Thread Eric Wong
Konstantin Ryabitsev wrote: > t/v2mirror.t . 71/? W: > /tmp/pi-v2mirror-39373-Dl1N/m/git/3.git missing remote.origin.url > fatal: not a git repository: '/tmp/pi-v2mirror-39373-Dl1N/m/git/3.git' > git --git-dir=/tmp/pi-v2mirror-39373-Dl1N/m/git/3.git fetch -q failed >

Re: [PATCH] t/cmd_ipc: allow extra errors and add diagnostics

2021-09-27 Thread Konstantin Ryabitsev
On Mon, Sep 27, 2021 at 01:35:36PM -0500, Eric Wong wrote: > Konstantin Ryabitsev wrote: > > t/cmd_ipc.t .. 29/? > > # Failed test 'got EMSGSIZE' > > # at t/cmd_ipc.t line 108. > > # Looks like you failed 1 test of 42. > > t/cmd_ipc.t ..

[PATCH] t/cmd_ipc: allow extra errors and add diagnostics

2021-09-27 Thread Eric Wong
Konstantin Ryabitsev wrote: > t/cmd_ipc.t .. 29/? > # Failed test 'got EMSGSIZE' > # at t/cmd_ipc.t line 108. > # Looks like you failed 1 test of 42. > t/cmd_ipc.t .. Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/42 subtests >

latest make test failures on CentOS-7

2021-09-27 Thread Konstantin Ryabitsev
Hello: I wanted to try the searchable /all/ from www_index, but it looks like I'm unable to get a clean make test. Below are a few failures that I can see: t/cmd_ipc.t .. 29/? # Failed test 'got EMSGSIZE' # at t/cmd_ipc.t line 108. # Looks like you failed 1

[PATCH] xt/net_writer_imap: env knobs for compress/debug/proxy

2021-09-27 Thread Eric Wong
It can be useful to test with some of these, but we can't enable them universally for all servers (and debug + compress is gross) --- xt/net_writer-imap.t | 6 ++ 1 file changed, 6 insertions(+) diff --git a/xt/net_writer-imap.t b/xt/net_writer-imap.t index f12280908b94..41438cf79b15 100644

[PATCH] config: get_1: use full parameter name

2021-09-27 Thread Eric Wong
Instead of passing the prefix section and key separately, pass them together as is commonly done with git-config(1) usage as well as our ->get_all API. This inconsistency in the get_1 API is a needless footgun and confused me a bit while working on "lei up" the other week. ---

Re: httpd memory usage?

2021-09-27 Thread Eric Wong
Eric Wong wrote: > Is it high for anybody else? I'm not seeing it for small > instances (e.g. the instance that's powering > public-inbox.org/{git,meta} is fine, but with lots of entries my > lore mirror @ https://yhbt.net/lore/ the main sbrk heap seems to > be growing slowly without bounds. I