Re: [RFC] pop3: support `?limit=$NUM' parameter in mailbox name

2023-09-18 Thread Eric Wong
Konstantin Ryabitsev wrote: > On Fri, Sep 15, 2023 at 08:41:10PM +, Eric Wong wrote: > > Thanks, pushed the series as > > a37e3ab3740c24c3 (pop3: limit default mailbox to 1K messages, 2023-09-14) > > 392d251f97d46579 (pop3: support `?limit=$NUM' parameter in mailbox name, > > 2023-09-12) >

Re: [RFC] pop3: support `?limit=$NUM' parameter in mailbox name

2023-09-18 Thread Konstantin Ryabitsev
On Fri, Sep 15, 2023 at 08:41:10PM +, Eric Wong wrote: > Thanks, pushed the series as > a37e3ab3740c24c3 (pop3: limit default mailbox to 1K messages, 2023-09-14) > 392d251f97d46579 (pop3: support `?limit=$NUM' parameter in mailbox name, > 2023-09-12) Oh, I did notice what is probably

[PATCH 7/8] install/deps: more fixes

2023-09-18 Thread Eric Wong
We need to mark *-dev packages as optional, and ignore dependency-only packages in the `optional' field. Furthermore, make the output less confusing when there's neither packages to install nor remove; and avoid invoking `apt-get install' with an empty package list. This also fixes an

[PATCH 0/8] portability odds and ends

2023-09-18 Thread Eric Wong
Nothing major, just a few things I noticed while working on various *BSDs. Eric Wong (8): ci/run: favor `make check' as the default target drop GNU nproc(1) support in favor of getconf(1) ipc: assume SOCK_SEQPACKET exists rename t/run.perl to xt/check-run makefile: avoid needless use of

[PATCH 4/8] rename t/run.perl to xt/check-run

2023-09-18 Thread Eric Wong
This allows us to get rid of some duplication in our Makefile --- MANIFEST | 2 +- Makefile.PL | 15 +-- t/nntpd.t| 2 +- t/run.perl => xt/check-run.t | 4 ++-- 4 files changed, 13 insertions(+), 10 deletions(-) rename

[PATCH 3/8] ipc: assume SOCK_SEQPACKET exists

2023-09-18 Thread Eric Wong
The rest of our code does, and we haven't encountered a platform we'd care about without it. --- lib/PublicInbox/IPC.pm | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/lib/PublicInbox/IPC.pm b/lib/PublicInbox/IPC.pm index fa084795..9388befd 100644 ---

[PATCH 1/8] ci/run: favor `make check' as the default target

2023-09-18 Thread Eric Wong
While parallelism isn't always a good thing, `make check' has more verbose output to help us track down occasionally failing tests. --- ci/run.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ci/run.sh b/ci/run.sh index 54563f1c..93790269 100755 --- a/ci/run.sh +++

[PATCH 6/8] pop3d: split @FLOCK into $FLOCK_TMPL and @FLOCK_ORDER

2023-09-18 Thread Eric Wong
This improves readability since we don't have to subscript the array for use with the `pack' perlop. --- lib/PublicInbox/POP3D.pm | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/PublicInbox/POP3D.pm b/lib/PublicInbox/POP3D.pm index 580a26d3..bee668fc

[PATCH 5/8] makefile: avoid needless use of double-colon rules

2023-09-18 Thread Eric Wong
This non-portable construct isn't needed for our own rules. I'm understanding them correctly, they have different semantics between *BSDs and GNU make. --- Documentation/include.mk | 8 Makefile.PL | 14 +++--- 2 files changed, 11 insertions(+), 11 deletions(-)

[PATCH 8/8] makefile: avoid non-POSIX which(1)

2023-09-18 Thread Eric Wong
which(1) isn't in POSIX so it's perhaps less likely to be available (although I don't think I've noticed a system without it in decades). So replace it with the POSIX `command -v', even though everyone seems to use which... Add a note about `lexgrog', too, since I'm not sure if it's packaged for