2.0 newsgroup name incompatibility (unlikely to affect anyone...)

I don't think this affects anyone, but historically we supported uppercase characters in newsgroup names since (IIRC) the venerable INN server was case-sensitive. However, IMAP, POP3 require lowercase; and our extindex (and WIP -cindex) get confused/broken with uppercase characters. So I think

RE: [Question] review links are disappearing from the qemu-devel mailing-list

> From: Konstantin Ryabitsev > Sent: Monday, November 13, 2023 8:44 PM > To: Salil Mehta > > On Mon, Nov 13, 2023 at 07:39:21PM +, Salil Mehta wrote: > > > When you go to "git.kernel.org" on your company network, what city do you > > > have in the header ("dallas", "amsterdam", etc). > > >

Re: [Question] review links are disappearing from the qemu-devel mailing-list

On Mon, Nov 13, 2023 at 07:39:21PM +, Salil Mehta wrote: > > When you go to "git.kernel.org" on your company network, what city do you > > have in the header ("dallas", "amsterdam", etc). > > I am seeing below in the header: > > Git repositories hosted at kernel.org (amsterdam) This is

RE: [Question] review links are disappearing from the qemu-devel mailing-list

Hi Michael, > From: Salil Mehta > Sent: Monday, November 13, 2023 7:28 PM > To: Michael S. Tsirkin ; Konstantin Ryabitsev > > > Hi Michael, > > On 07/11/2023 14:14, Michael S. Tsirkin wrote: > > On Tue, Nov 07, 2023 at 08:56:01AM -0500, Konstantin Ryabitsev wrote: > >> On Tue, Nov 07, 2023

Re: [Question] review links are disappearing from the qemu-devel mailing-list

On Mon, Nov 13, 2023 at 07:27:34PM +, Salil Mehta wrote: > I am able to open [Patch V6 1/9] from outside the company network (as you > can see the by [2] [3]) but strangely not from inside the company network. > It purges below error from company network. I am totally stumped. When you go to

[PATCH 06/18] xap_helper_cxx: use -pipe by default in CXXFLAGS

-ggdb3 is already used for g++ and clang, and -pipe is supported by clang even if it's a no-op. So just use it to speed up g++ since it saves me 30-40ms. We'll also get rid of the explicit `-O0' since it's the default for both clang and g++. --- lib/PublicInbox/XapHelperCxx.pm | 2 +- 1 file

[PATCH 09/18] spawn: don't append to scalarrefs on stdout/stderr

None of our current code relies on it, and I can't imagine it's something we'd need in the future, actually... This keeps the door open for relying more on Spawn in TestCommon. --- lib/PublicInbox/Spawn.pm | 2 +- t/spawn.t| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

[PATCH 04/18] xap_helper_cxx: use write_file helper

PublicInbox::IO already gets loaded by PublicInbox::Spawn, so there's no avoiding it even if we want fast startup time :< But startup time for this piece will be less relevant in the near future... --- lib/PublicInbox/XapHelperCxx.pm | 16 ++-- 1 file changed, 6 insertions(+), 10

[PATCH 02/18] tmpfile: check `stat' errors, use autodie for unlink

`stat' can fail due to bugs on our end or ENOMEM, but there's no autodie support for it. So just die if `unlink' fails, since the FS wouldn't be usable for tmpfiles in that state, anyways. --- lib/PublicInbox/Tmpfile.pm | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 18/18] cindex: support --associate-aggressive shortcut

This is shorthand to enabling --associate with the most aggressive (and time-consuming) options available, starting from the Unix epoch and having an unlimited window to join on. --- lib/PublicInbox/CodeSearchIdx.pm | 5 + script/public-inbox-cindex | 1 + 2 files changed, 6

[PATCH 14/18] xap_helper: stricter and harsher error handling

We'll require an error stream for dump_ibx and dump_roots commands; they're too important to ignore. Instead of writing code to provide diagnostics for errors, rely on abort(3) and the -ggdb3 compiler flag to generate nice core dumps for gdb since all commands sent to xap_helper are from internal

[PATCH 07/18] xap_client: spawn C++ xap_helper directly

No need to suffer through an extra dose of slow Perl load times when we can drive the build in the big parent Perl process and get the executable path name to pass to spawn directly. --- lib/PublicInbox/XapClient.pm| 28 ++-- lib/PublicInbox/XapHelperCxx.pm | 9

[PATCH 13/18] cidx_xap_helper_aux: complain about truncated inputs

This will help us notice bugs and system resource limitations sooner rather than later. --- lib/PublicInbox/CidxXapHelperAux.pm | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/PublicInbox/CidxXapHelperAux.pm b/lib/PublicInbox/CidxXapHelperAux.pm index

[PATCH 10/18] cindex: imply --all with --associate w/o -I/--only

I just forgot to use --all with --associate and it wasn't easily apparent what was wrong. We'll also show some extra progress while we're at it. --- lib/PublicInbox/CodeSearchIdx.pm | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git

[PATCH 17/18] cindex: rename associate-max => window

"window" is probably a better term since it's an inexact thing to match on. --- lib/PublicInbox/CodeSearchIdx.pm | 10 +- script/public-inbox-cindex | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/PublicInbox/CodeSearchIdx.pm

[PATCH 11/18] cindex: delay associate until prune+indexing finish

Prune can get rid of invalid commits while indexing can add new candidates for association, so we don't dump coderepo roots for association until those are squared away. However, we can dump inbox info since we don't touch inboxes while -cindex is running. --- lib/PublicInbox/CidxComm.pm |

[PATCH 08/18] treewide: update read_all to avoid eof|close checks

read_all can be expanded to support FIFOs/pipes/sockets where read-until-EOF behavior is desired. We can also rely on wantarray to support splitting on EOL markers, but it's hard-coded to support only `$/ eq "\n"' since (AFAIK) it's the only way we use the wantarray form `readline'. ---

[PATCH 16/18] cindex: do not guess integer maximum for Xapian

We can return an array to allow the caller to omit the internal `-m' arg entirely. We'll also allow any non-positive values to mean there's no limit; and we'll defer the "unlimited" case to the XapHelper implementation. This frees us of having to deal with mismatches between Perl and Xapian if

[PATCH 03/18] cindex: use `local' for pipes between processes

We can let these pipes get auto-closed upon leaving the process subroutine scope. --- lib/PublicInbox/CodeSearchIdx.pm | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/lib/PublicInbox/CodeSearchIdx.pm b/lib/PublicInbox/CodeSearchIdx.pm index

[PATCH 12/18] xap_helper: Perl dump_ibx respects `-m MAX'

The C++ version does, so the Perl/XS version should, too; even if we intentionally avoid using it right now. --- lib/PublicInbox/XapHelper.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/XapHelper.pm b/lib/PublicInbox/XapHelper.pm index 1ee918e3..4157600f

[PATCH 15/18] xap_helper: better variable naming for key buffer

We'll use `kbuf' for the search object key, since we already use the `fbuf' term in `struct fbuf'. This also adds an extra check for open_memstream(3) failures in case of ENOMEM. --- lib/PublicInbox/xap_helper.h | 33 - 1 file changed, 16 insertions(+), 17

[PATCH 05/18] xap_helper_cxx: make the build process ccache-friendly

We need to have stable filenames and separate compilation from the linkage stage for ccache to hit. So avoid the use of a temporary directory and instead rely on a lock file to guard against parallel builds. --- lib/PublicInbox/XapHelperCxx.pm | 32 +++- 1 file

[PATCH 00/18] cindex: some --associate work

Still very much in flux, but some treewide cleanups in there... And I've been wondering if "join" is a better word than "associate" to denote the relationship between inboxes and coderepos. But "join" (even if we use join(1) internally) probably implies strict relationships, whereas our current

[PATCH 01/18] cindex: check `say' errors w/ close or ->flush

We actually need to rely on autodie `close' to check for errors, since error-checking with `say' is not useful due to perlio write buffering. We'll also stop relying on `say ... or die' since it's needless noise. Fixes: 19f9089343c9 (cindex: drop redundant close on regular FH) ---