Re: [PATCH] gcf2: die if pkg-config is missing

2021-09-09 Thread Eric Wong
Konstantin Ryabitsev wrote: > On Thu, Sep 09, 2021 at 09:23:48PM +, Eric Wong wrote: > > > Annoyingly, after I blow away the container to start fresh, I get: > > > > > > t/gcf2.t . skipped: PublicInbox::Gcf2 missing for > > > t/gcf2.t > > > > > > That means gcf2

Re: [PATCH] gcf2: die if pkg-config is missing

2021-09-09 Thread Konstantin Ryabitsev
On Thu, Sep 09, 2021 at 09:23:48PM +, Eric Wong wrote: > > Annoyingly, after I blow away the container to start fresh, I get: > > > > t/gcf2.t . skipped: PublicInbox::Gcf2 missing for > > t/gcf2.t > > > > That means gcf2 isn't getting built, right? > > Yeah,

Re: [PATCH] gcf2: die if pkg-config is missing

2021-09-09 Thread Eric Wong
Konstantin Ryabitsev wrote: > On Thu, Sep 09, 2021 at 09:14:36PM +, Eric Wong wrote: > > Konstantin Ryabitsev wrote: > > > Yep, that was the culprit. After installing pkg-config, gcf2 builds and > > > tests > > > pass. I still have this while running "make test": > > > > Good to know.

Re: [PATCH] gcf2: die if pkg-config is missing

2021-09-09 Thread Konstantin Ryabitsev
On Thu, Sep 09, 2021 at 09:14:36PM +, Eric Wong wrote: > Konstantin Ryabitsev wrote: > > Yep, that was the culprit. After installing pkg-config, gcf2 builds and > > tests > > pass. I still have this while running "make test": > > Good to know. We'll have to document that when adding

Re: [PATCH] gcf2: die if pkg-config is missing

2021-09-09 Thread Eric Wong
Konstantin Ryabitsev wrote: > Yep, that was the culprit. After installing pkg-config, gcf2 builds and tests > pass. I still have this while running "make test": Good to know. We'll have to document that when adding libgit2 stuff to the already-huge INSTALL file. > t/git.t

Re: [PATCH] gcf2: die if pkg-config is missing

2021-09-09 Thread Konstantin Ryabitsev
On Thu, Sep 09, 2021 at 08:45:41PM +, Eric Wong wrote: > Konstantin Ryabitsev wrote: > > Hello: > > > > I can't seem to get a clean "make test" in the Debian container. It's > > possible > > that I'm missing some of the packages, as the official Debian container > > image > > is very

[PATCH] gcf2: die if pkg-config is missing

2021-09-09 Thread Eric Wong
libio-compress-perl curl libmail-imapclient-perl > sqlite3 \ >libgit2-dev make eatmydata Oops, pkg-config is needed for libgit2-dev. I thought most *-dev packages would pull it in... ----8< Subject: [PATCH] gcf2: die if pkg-config is missi