[PATCH 02/10] search: drop longer subject: prefix for search

[Eric Wong]

We only document the "s:" anyways.  While the long name is more
descriptive, the ambiguity makes agnostic caching (by Varnish or
similar) slightly harder and longer URLs are more likely to be
accidentally truncated when shared.
---
 lib/PublicInbox/Search.pm |  1 -
 t/search.t                | 14 +++++++-------
 2 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/lib/PublicInbox/Search.pm b/lib/PublicInbox/Search.pm
index aec459b..3b25b66 100644
--- a/lib/PublicInbox/Search.pm
+++ b/lib/PublicInbox/Search.pm
@@ -58,7 +58,6 @@ my %bool_pfx_external = (
 );
 
 my %prob_prefix = (
-       subject => 'S',
        s => 'S', # for mairix compatibility
        m => 'Q', # 'mid' is exact, 'm' can do partial
        f => 'A', # for mairix compatibility
diff --git a/t/search.t b/t/search.t
index bb0861a..7abaf83 100644
--- a/t/search.t
+++ b/t/search.t
@@ -123,19 +123,19 @@ sub filter_mids {
                is($res->{total}, 0, "path variant `$p' does not match");
        }
 
-       $res = $ro->query('subject:(Hello world)');
+       $res = $ro->query('s:(Hello world)');
        @res = filter_mids($res);
-       is_deeply(\@res, \@exp, 'got expected results for subject:() match');
+       is_deeply(\@res, \@exp, 'got expected results for s:() match');
 
-       $res = $ro->query('subject:"Hello world"');
+       $res = $ro->query('s:"Hello world"');
        @res = filter_mids($res);
-       is_deeply(\@res, \@exp, 'got expected results for subject:"" match');
+       is_deeply(\@res, \@exp, 'got expected results for s:"" match');
 
-       $res = $ro->query('subject:"Hello world"', {limit => 1});
+       $res = $ro->query('s:"Hello world"', {limit => 1});
        is(scalar @{$res->{msgs}}, 1, "limit works");
        my $first = $res->{msgs}->[0];
 
-       $res = $ro->query('subject:"Hello world"', {offset => 1});
+       $res = $ro->query('s:"Hello world"', {offset => 1});
        is(scalar @{$res->{msgs}}, 1, "offset works");
        my $second = $res->{msgs}->[0];
 
@@ -181,7 +181,7 @@ sub filter_mids {
        $rw_commit->();
        $ro->reopen;
 
-       # Subject:
+       # subject
        my $res = $ro->query('ghost');
        my @exp = sort qw(ghost-message@s ghost-reply@s);
        my @res = filter_mids($res);
-- 
EW