[PATCH 46/82] t/config.t: always compare against git bool behavior

[Eric Wong]

We'll use the xqx() to avoid losing too much performance
compared to normal `backtick` (qx) when testing using
"make check-run" + Inline::C.
---
 t/config.t | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/t/config.t b/t/config.t
index 1f50bb86a09..3f41c0042a9 100644
--- a/t/config.t
+++ b/t/config.t
@@ -209,20 +209,17 @@ EOF
 }
 
 {
-       my $check_git = !!$ENV{CHECK_GIT_BOOL};
        for my $t (qw(TRUE true yes on 1 +1 -1 13 0x1 0x12 0X5)) {
                is(PublicInbox::Config::_git_config_bool($t), 1, "$t is true");
-               if ($check_git) {
-                       is(`git -c test.val=$t config --bool test.val`,
-                               "true\n", "$t matches git-config behavior");
-               }
+               is(xqx([qw(git -c), "test.val=$t",
+                       qw(config --bool test.val)]),
+                       "true\n", "$t matches git-config behavior");
        }
        for my $f (qw(FALSE false no off 0 +0 +000 00 0x00 0X0)) {
                is(PublicInbox::Config::_git_config_bool($f), 0, "$f is false");
-               if ($check_git) {
-                       is(`git -c test.val=$f config --bool test.val`,
-                               "false\n", "$f matches git-config behavior");
-               }
+               is(xqx([qw(git -c), "test.val=$f",
+                       qw(config --bool test.val)]),
+                       "false\n", "$f matches git-config behavior");
        }
        is(PublicInbox::Config::_git_config_bool('bogus'), undef,
                'bogus is undef');
--
unsubscribe: one-click, see List-Unsubscribe header
archive: https://public-inbox.org/meta/