This non-portable construct isn't needed for our own rules. I'm understanding them correctly, they have different semantics between *BSDs and GNU make. --- Documentation/include.mk | 8 ++++---- Makefile.PL | 14 +++++++------- 2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/Documentation/include.mk b/Documentation/include.mk index 4395e4f4..eb65454a 100644 --- a/Documentation/include.mk +++ b/Documentation/include.mk @@ -47,14 +47,14 @@ install-man: man doc_install :: install-man -check :: check-man +check : check-man check_man = $(AWK) \ '{gsub(/\b./,"")}$$0 !~ /\.onion/&&length>80{print;e=1}END{exit(e)}' \ >&2 -check-man :: $(check_80) +check-man : $(check_80) -check-lexgrog :: $(check_lexgrog) +check-lexgrog : $(check_lexgrog) all :: $(docs) @@ -86,7 +86,7 @@ NEWS NEWS.atom NEWS.html : $(news_deps) $(PERL) -I lib -w Documentation/mknews.perl $@ $(RELEASES) # check for internal API changes: -check :: NEWS .NEWS.atom.check NEWS.html +check : NEWS .NEWS.atom.check NEWS.html .NEWS.atom.check: NEWS.atom $(XMLSTARLET) val NEWS.atom || \ diff --git a/Makefile.PL b/Makefile.PL index 9dc18b5c..81992e46 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -213,7 +213,7 @@ $VARS -include Documentation/include.mk $TGTS -check-man :: $check_lexgrog$warn_no_pod +check-man : $check_lexgrog$warn_no_pod # syntax checks are currently GNU make only: %.syntax :: % @@ -231,24 +231,24 @@ check-manifest : MANIFEST \$(check_manifest) # the traditional way running per-*.t processes: -check-each :: pure_all +check-each : pure_all \$(EATMYDATA) \$(PROVE) --state=save -bvw -j\$(N) -@\$(check_manifest) # check-run relies "--state=save" in check-each for best performance -check-run :: check-man +check-run : check-man # n.b. while `-' isn't specified as an allowed make(1posix) macro name, # GNU and *BSD both allow it. check-run_T_ARGS = -j\$(N) -check-debris check-run :: pure_all +check-debris check-run : pure_all \$(EATMYDATA) \$(PROVE) -bvw xt/\$@.t :: \$(\$\@_T_ARGS) -@\$(check_manifest) -check :: check-each +check : check-each -lib/PublicInbox/UserContent.pm :: contrib/css/216dark.css +lib/PublicInbox/UserContent.pm : contrib/css/216dark.css \$(PERL) -I lib \$@ \$? # Ensure new .pm files will always be installed by updating @@ -269,7 +269,7 @@ symlink-install : lib/PublicInbox.pm ln -sf "\$\$lei" \$\$(basename "\$\$x"); \\ done -pure_all :: lib/PublicInbox.pm +pm_to_blib : lib/PublicInbox.pm lib/PublicInbox.pm : FORCE VERSION=\$(VERSION) \$(PERL) -w ./version-gen.perl