Hi Jean-Francois,
On 01/05/19 21:59, Jean-Francois Dagenais wrote:
>
>
>> On Apr 30, 2019, at 03:14, Luca Ceresoli <l...@lucaceresoli.net> wrote:
>>
>>> EXTRA_OEMAKE_zynqmp_append = "${@' ZYNQMP_CONSOLE=${ATF_CONSOLE}' if
>>> d.getVar('ATF_CONSOLE', True) != '' else ''}"
>>> +EXTRA_OEMAKE_append_versal = "${@' VERSAL_CONSOLE=${ATF_CONSOLE}' if
>>> d.getVar('ATF_CONSOLE', True) != '' else ''}"
>>
>> Not related to your addition, but the zynqmp line before this has
>> swapped "append" and "zynqmp" with respect to the usual syntax. It looks
>> like it works anyway, but perhaps it's worth cleaning it up in a
>> separate patch.
>
> Yes, this current form means that "EXTRA_OEMAKE" has an override for zynqmp,
> onto which we append stuff.
>
> Whereas the other form:
>
> EXTRA_OEMAKE_append_zynqmp = "..."
>
> Means: on the standard EXTRA_OEMAKE append, in the case of of zynqmp, the
> following stuff.
>
> So the first form completely replaces the base EXTRA_OEMAKE whereas the
> second form appends on the base EXTRA_OEMAKE in case of "zynqmp".
>
> One of those many yocto "gotchas" I'v been bitten by in the past. Thought it
> might be good to add my 2 cents here.
Thanks, that's a useful clarification.
It all sounds so obvious... now! :)
--
Luca
--
_______________________________________________
meta-xilinx mailing list
meta-xilinx@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-xilinx
