Re: [meta-xilinx] [PATCH 4/9] Adds gcc bbappend to fix configure options, and enable --sysroot behavior

2018-12-12 Thread Luca Ceresoli
Hi Alejandro, On 11/12/18 23:00, Alejandro Enedino Hernandez Samaniego wrote: > Hey Luca, > > > On 12/11/2018 07:42 AM, Luca Ceresoli wrote: >> Hi Alejandro, >> >> On 06/12/18 22:56, Alejandro Enedino Hernandez Samaniego wrote: >>> Signed-off-by: Alejandro Enedino Hernandez Samaniego >>> >>>

Re: [meta-xilinx] [PATCH 4/9] Adds gcc bbappend to fix configure options, and enable --sysroot behavior

2018-12-12 Thread Alejandro Enedino Hernandez Samaniego
Hey Luca, On 12/11/2018 07:42 AM, Luca Ceresoli wrote: Hi Alejandro, On 06/12/18 22:56, Alejandro Enedino Hernandez Samaniego wrote: Signed-off-by: Alejandro Enedino Hernandez Samaniego Signed-off-by: Manjukumar Matha --- .../recipes-standalone/gcc/gcc-cross_%.bbappend | 17

Re: [meta-xilinx] [PATCH 4/9] Adds gcc bbappend to fix configure options, and enable --sysroot behavior

2018-12-11 Thread Luca Ceresoli
Hi Alejandro, On 06/12/18 22:56, Alejandro Enedino Hernandez Samaniego wrote: > Signed-off-by: Alejandro Enedino Hernandez Samaniego > Signed-off-by: Manjukumar Matha > --- > .../recipes-standalone/gcc/gcc-cross_%.bbappend | 17 > + > 1 file changed, 17 insertions(+) >

Re: [meta-xilinx] [PATCH 4/9] Adds gcc bbappend to fix configure options, and enable --sysroot behavior

2018-12-07 Thread Jean-Francois Dagenais
> On Dec 7, 2018, at 6:23 AM, Jean-François Dagenais > wrote: > > ... or "adds tests for" ;) Sorry for this confusing addition after the quote... So just in case, I meant you should use use "Add tests for..." instead of "Adds tests..." I realize this might seem a bit picky, sorry... it

Re: [meta-xilinx] [PATCH 4/9] Adds gcc bbappend to fix configure options, and enable --sysroot behavior

2018-12-07 Thread Jean-François Dagenais
About the commit headline... Taken from https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project : it’s also a good idea to use the imperative present tense in these messages. In other words, use commands. Instead of “I added tests for” or “Adding tests for,” use “Add tests