Re: [Mingw-w64-public] [PATCH] versionhelpers.h: Fix IsWindowsThresholdOrGreater typo

On Thu, 22 Feb 2018, James Ross-Gowan wrote: Probably a copy/paste error. Without this, IsWindowsThresholdOrGreater and IsWindows10OrGreater would always return FALSE, since they were checking for Windows version 10.3. Signed-off-by: James Ross-Gowan --- mingw-w64-headers/include/versionhelper

Re: [Mingw-w64-public] [PATCH] headers: Temporarily undefine _Bool when typedeffing std::_Bool

On Fri, 23 Feb 2018, Kai Tietz via Mingw-w64-public wrote: Ok, thanks. Thanks, pushed both. // Martin -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.l

Re: [Mingw-w64-public] [PATCH] headers: Temporarily undefine _Bool when typedeffing std::_Bool

Ok, thanks. Cheers, Kai 2018-02-23 11:02 GMT+01:00 Martin Storsjö : > This fixes building the following with libc++: > > #include > #include > > With libc++, yvals.h is implicitly included by anything that includes > locales (via xlocinfo.h). > > Signed-off-by: Martin Storsjö > --- >

[Mingw-w64-public] [PATCH] headers: Temporarily undefine _Bool when typedeffing std::_Bool

This fixes building the following with libc++: #include #include With libc++, yvals.h is implicitly included by anything that includes locales (via xlocinfo.h). Signed-off-by: Martin Storsjö --- mingw-w64-headers/crt/yvals.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ming

Re: [Mingw-w64-public] [PATCH] crt: Allow sleeping for over a second with usleep

2018-02-23 10:56 GMT+01:00 Martin Storsjö : > On Fri, 23 Feb 2018, Kai Tietz via Mingw-w64-public wrote: > >> Patch looks fine beside one nit. The behavior above 4294967 seconds >> seems to be pretty unexpected, isn't it? > > > Well since the useconds_t parameter is a typedef for unsigned int, I >

Re: [Mingw-w64-public] [PATCH] yvals.h: Don't create a _Bool typedef if a macro already exists

On Fri, 23 Feb 2018, Kai Tietz via Mingw-w64-public wrote: hmm, ok. But it might be better to temporary undefine _Bool via 'push_macro/pop_macro' pragma? Thanks - that sounds like an even better fix, will post an updated patch. // Martin --

Re: [Mingw-w64-public] [PATCH] crt: Allow sleeping for over a second with usleep

On Fri, 23 Feb 2018, Kai Tietz via Mingw-w64-public wrote: Patch looks fine beside one nit. The behavior above 4294967 seconds seems to be pretty unexpected, isn't it? Well since the useconds_t parameter is a typedef for unsigned int, I wouldn't think that callers expect to be able to sleep

Re: [Mingw-w64-public] [PATCH] crt: Allow sleeping for over a second with usleep

Patch looks fine beside one nit. The behavior above 4294967 seconds seems to be pretty unexpected, isn't it? Cheers, Kai 2018-02-22 22:17 GMT+01:00 Martin Storsjö : > Even though the POSIX spec of usleep says that the argument shall > be less than one million. Most unixes allow it and sleeps for

Re: [Mingw-w64-public] [PATCH] yvals.h: Don't create a _Bool typedef if a macro already exists

hmm, ok. But it might be better to temporary undefine _Bool via 'push_macro/pop_macro' pragma? Kai 2018-02-23 10:20 GMT+01:00 Martin Storsjö : > From: Hugo Beauzée-Luyssen > > This fixes building the following with libc++: > > #include > #include > > With libc++, yvals.h is implicitly

[Mingw-w64-public] [PATCH] yvals.h: Don't create a _Bool typedef if a macro already exists

From: Hugo Beauzée-Luyssen This fixes building the following with libc++: #include #include With libc++, yvals.h is implicitly included by anything that includes locales (via xlocinfo.h). Signed-off-by: Martin Storsjö --- mingw-w64-headers/crt/yvals.h | 2 ++ 1 file changed, 2 inse