Re: [Mingw-w64-public] Add some more missing declaration of dwrite_1.h

2018-03-13 Thread Ebrahim Byagowi
Spotted one minor issue on the patch, here is another On Wed, Mar 14, 2018 at 12:29 AM, Ebrahim Byagowi wrote: > Hi there. Following https://github.com/Alexpux/mingw-w64/pull/5 I am > sending my work here, this patch allows harfbuzz's hb-directwrite >

[Mingw-w64-public] Add some more missing declaration of dwrite_1.h

2018-03-13 Thread Ebrahim Byagowi
Hi there. Following https://github.com/Alexpux/mingw-w64/pull/5 I am sending my work here, this patch allows harfbuzz's hb-directwrite build on msys2, I hope this change can be applied to both "/msys2/usr/Include/win32api/dwri

Re: [Mingw-w64-public] [PATCH] crt: Add "volatile" to all inline assembly snippets under math

2018-03-13 Thread Martin Storsjö
On Tue, 13 Mar 2018, NightStrike wrote: Well, if it'd be inline functions in a header, I'd be inclined to agree. All of these are in non-inline functions (e.g. like the sqrt function, where you expect it to always produce one "fsqrt" instruction), so I don't expect any losses there. Is that

Re: [Mingw-w64-public] [PATCH] crt: Add "volatile" to all inline assembly snippets under math

2018-03-13 Thread NightStrike
> > Well, if it'd be inline functions in a header, I'd be inclined to agree. > All of these are in non-inline functions (e.g. like the sqrt function, > where you expect it to always produce one "fsqrt" instruction), so I > don't expect any losses there. > Is that always the case? I'm pretty sure t