Re: [Mingw-w64-public] [PATCH] crt: Check whether the linker provides __CTOR_LIST__, don't check for __clang__

2018-08-27 Thread Liu Hao
在 2018/8/28 2:50, Martin Storsjö 写道: > Using the __clang__ ifdef isn't right; one could be using clang for > compiling the mingw-w64 crt for use with binutils ld, which requires > a slightly different setup of __CTOR_LIST__. > > Also, to ease interoperability between binutils ld and lld, lld

Re: [Mingw-w64-public] [PATCH] libmincore.a: Add new importlib.

2018-08-27 Thread Martin Storsjö
On Mon, 27 Aug 2018, Jacek Caban wrote: On 08/27/2018 08:44 PM, Martin Storsjö wrote: On Mon, 27 Aug 2018, Jacek Caban wrote: Please review the attached patch. Note that it adds .mri file in a different way than those that are currently in the tree. I don't like how much copy between

Re: [Mingw-w64-public] [PATCH] libmincore.a: Add new importlib.

2018-08-27 Thread Jacek Caban
On 08/27/2018 08:44 PM, Martin Storsjö wrote: > On Mon, 27 Aug 2018, Jacek Caban wrote: > >> Please review the attached patch. >> >> Note that it adds .mri file in a different way than those that are >> currently in the tree. I don't like how much copy between >> arch-specific rules it would

[Mingw-w64-public] [PATCH] crt: Check whether the linker provides __CTOR_LIST__, don't check for __clang__

2018-08-27 Thread Martin Storsjö
Using the __clang__ ifdef isn't right; one could be using clang for compiling the mingw-w64 crt for use with binutils ld, which requires a slightly different setup of __CTOR_LIST__. Also, to ease interoperability between binutils ld and lld, lld could potentially start providing the __CTOR_LIST__

Re: [Mingw-w64-public] [PATCH] libmincore.a: Add new importlib.

2018-08-27 Thread Martin Storsjö
On Mon, 27 Aug 2018, Jacek Caban wrote: Please review the attached patch. Note that it adds .mri file in a different way than those that are currently in the tree. I don't like how much copy between arch-specific rules it would require otherwise. Being not an expert of autoconf, I'd appreciate

Re: [Mingw-w64-public] [PATCH] crt: Unify and simplify handling of constructor/destructor lists

2018-08-27 Thread Martin Storsjö
On Mon, 27 Aug 2018, Liu Hao wrote: This patch breaks libgcc. At the moment the `__main()` function which performs global initialization for static objects cannot handle `__CTOR_LIST__` with two pointers of `-1` in the front of it [1]. The code is presumed to call every function via

Re: [Mingw-w64-public] [PATCH] crt: Unify and simplify handling of constructor/destructor lists

2018-08-27 Thread Liu Hao
This patch breaks libgcc. At the moment the `__main()` function which performs global initialization for static objects cannot handle `__CTOR_LIST__` with two pointers of `-1` in the front of it [1]. The code is presumed to call every function via pointers between the first `-1` and final null