在 2019/4/8 21:16, Andrew Ng 写道:
> Do you want me to split up the patch?
>
Yes. At least you should have proposed a minimum patch that explains why
the old code was broken and how you fixed it. Style adjustments can
follow provided they have clearly no impact on behavior of existent code.
> I ref
Do you want me to split up the patch?
I reformatted the code to a consistent layout to improve readability whilst
I was trying to figure out how it worked. The original code had a variety
of styles. Is there a "preferred" style? I noticed that other source have
different styles.
Does the removal
在 2019/4/8 下午8:34, Kacvinsky, Tom 写道:
> Is the minge-64-headers component of the CRT repo supposed to install
> pthread.h?
>
>
I don't think so. should only be installed along with
winpthreads which is in the 'mingw-w64-libraries/winpthreads' directory.
--
Best regards,
LH_Mouse
signature.
在 2019/4/8 下午7:18, Jacek Caban 写道:
>
> Sure, but what does it have to do with __forceinline? __forceinline is
> for functions that are really meant to be inlined and thus I think it
> should not try to preserve single pointer value. With removed extern, we
> leave the choice for user, one could st
Is the minge-64-headers component of the CRT repo supposed to install pthread.h?
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
在 2019/4/8 下午12:07, Andrew Ng 写道:
> OK, no problem. Hopefully, the attachment with this message will make it
> through!
>
This patch contains a number of whitespace changes and reordering of
code that are otherwise unnecessary, which obfuscates your idea.
Rearrangement of code should be send as a
On Mon, 8 Apr 2019, Jacek Caban wrote:
Signed-off-by: Jacek Caban
---
mingw-w64-headers/crt/corecrt.h | 8 ++
mingw-w64-headers/crt/time.h| 48 -
2 files changed, 32 insertions(+), 24 deletions(-)
LGTM
// Martin
__
Signed-off-by: Jacek Caban
---
mingw-w64-headers/crt/corecrt.h | 8 ++
mingw-w64-headers/crt/time.h| 48 -
2 files changed, 32 insertions(+), 24 deletions(-)
diff --git a/mingw-w64-headers/crt/corecrt.h b/mingw-w64-headers/crt/corecrt.h
index d171a013..
On 4/5/19 3:43 PM, Martin Storsjö wrote:
How about doing things in msvc ucrt compatible way? Like the patch I
attached as an example (not yet tested)?
This looks good to me (but didn't test it yet).
This approach of modernizing small areas at a time seems good also,
wrt finding out what regre
On 4/8/19 4:33 AM, Liu Hao wrote:
在 2019/4/5 下午8:07, Jacek Caban 写道:
On 4/5/19 9:15 AM, Martin Storsjö wrote:
It would be great to have __forceinline fixed. I've seen a problems in
code using static __forceinline multiple times. I also recall that
attempts to change that had their problems, so
On 04.04.2019 19:18, Kacvinsky, Tom wrote:
I am using
https://sourceforge.net/p/mingw-w64/wiki2/Cross%20Win32%20and%20Win64%20compiler/
In there, it says to use --disable-multilib if I do not want 32 and 64-bit
support, only the native
mingw-w64 architecture. Despite adding that to the config
11 matches
Mail list logo
