Re: [Mingw-w64-public] [PATCH 1/2] crt: Add macro __LIBMSVCRT_OS__ for guarding msvcrt.dll

2022-02-19 Thread Martin Storsjö
On Sat, 19 Feb 2022, Pali Rohár wrote: Currently macro __LIBMSVCRT__ is defined when building any libmsvcr*.a import library. But header file msvcrt.h contains inline function __mingw_get_msvcrt_handle() which should be used only from import library for runtime msvcrt.dll (and not for any other

Re: [Mingw-w64-public] [PATCH 2/2] crt: Fix building lc_locale_func.c for libcrtdll_extra.a

2022-02-19 Thread Martin Storsjö
On Sat, 19 Feb 2022, Pali Rohár wrote: Object files in archive libcrtdll_extra.a (which are linked into import library for crtdll.dll) cannot use msvcrt.h as it uses msvcrt.dll runtime library. Maybe clarify "uses", e.g. like this: "as it tries to load symbols at runtime from msvcrt.dll

Re: [Mingw-w64-public] [PATCH] crt: Add missing __cdecl signature to ucrt functions

2022-02-19 Thread Martin Storsjö
On Sat, 19 Feb 2022, Pali Rohár wrote: When assigning function pointer to variable, both function and variable should have same signature. Fix it. --- The patch looks ok to me, but I presume this is only a pedantic fix with no noticeable effect other than that - because if no calling