Re: [Mingw-w64-public] [PATCH] crt: expose non-dllimport variant of rand_s

2022-09-07 Thread Martin Storsjö
On Wed, 7 Sep 2022, Matthew Lugg wrote: The case I was working with was compiling C sources using Zig (a programming language and compiler toolchain) - I realised the build was failing with this missing symbol in non-debug modes, and eventually narrowed the issue down to LTO. Looking at the othe

Re: [Mingw-w64-public] [PATCH] crt: expose non-dllimport variant of rand_s

2022-09-07 Thread Matthew Lugg
On Wed, Sep 07, 2022 at 10:29:41AM +0300, Martin Storsjö wrote: > On Tue, 6 Sep 2022, Matthew Lugg wrote: > > > The lack of this function meant that LTO on software building against > > mingw caused undefined references to rand_s. > > > > Signed-off-by: mlugg > > --- > > mingw-w64-crt/secapi/ran

Re: [Mingw-w64-public] [PATCH] [RFC] crt: Add support for Control Flow Guard

2022-09-07 Thread Alvin Wong via Mingw-w64-public
Hi, On 7/9/2022 15:09, Martin Storsjö wrote: > On Sat, 3 Sep 2022, Alvin Wong via Mingw-w64-public wrote: > >> >> (Note: the patches to add the Clang option hasn't landed yet, therefore >> this is still subject to change.) > > Thanks a lot for your work on this matter! > >> >> This adds support to

Re: [Mingw-w64-public] [PATCH] [RFC] crt: Add support for Control Flow Guard

2022-09-07 Thread Martin Storsjö
On Sat, 3 Sep 2022, Alvin Wong via Mingw-w64-public wrote: (Note: the patches to add the Clang option hasn't landed yet, therefore this is still subject to change.) Thanks a lot for your work on this matter! This adds support to enable building mingw-w64-crt and user code with Control Flow

Re: [Mingw-w64-public] [PATCH] crt: expose non-dllimport variant of rand_s

2022-09-07 Thread Martin Storsjö
On Tue, 6 Sep 2022, Matthew Lugg wrote: The lack of this function meant that LTO on software building against mingw caused undefined references to rand_s. Signed-off-by: mlugg --- mingw-w64-crt/secapi/rand_s.c | 6 ++ 1 file changed, 6 insertions(+) I think the patch might be safe - but I