Re: [Mingw-w64-public] [PATCH 2/7] crt: msvcr90d.def.in: Fix I386 symbol alias _wfindnext

2024-04-27 Thread Pali Rohár
On Saturday 27 April 2024 22:47:33 LIU Hao wrote: > 在 2024-04-27 19:46, Pali Rohár 写道: > > Symbol alias is defined by "==". > > This message is incorrect. `=` really defines an alias [1]. `==` specifies > the export name (the name before `==` is used by the linker). Ok, I see. Alias is somehow ov

Re: [Mingw-w64-public] [PATCH 2/7] crt: msvcr90d.def.in: Fix I386 symbol alias _wfindnext

2024-04-27 Thread LIU Hao
在 2024-04-27 19:46, Pali Rohár 写道: Symbol alias is defined by "==". This message is incorrect. `=` really defines an alias [1]. `==` specifies the export name (the name before `==` is used by the linker). For an import library, there is likely no difference. The difference arises when buildi

Re: [Mingw-w64-public] [PATCH 10/10] crt: Move find, stat and time aliases to def-include/msvcrt-common.def.in

2024-04-27 Thread Pali Rohár
On Saturday 27 April 2024 10:38:58 Martin Storsjö wrote: > On Sat, 27 Apr 2024, Jacek Caban wrote: > > > On 26.04.2024 21:43, Pali Rohár wrote: > > > I played a bit with different msvc 19.x versions and 32-bit x86 variant > > > recognize time symbol and maps it to _time32 at link time. First > > >

[Mingw-w64-public] [PATCH 7/7] crt: Move find, stat and time aliases to def-include/msvcrt-common.def.in

2024-04-27 Thread Pali Rohár
Add 4 new macros FIXED_SIZE_SYMBOLS, NO_I64_FIXED_SIZE, NO_FIXED_SIZE_64_ALIAS and NO_TIME_ALIAS to distinguish between different crt versions. This change adds new symbol aliases which were missing. There is no symbol change or removal. For reference here is list of changes between individual ou

[Mingw-w64-public] [PATCH 2/7] crt: msvcr90d.def.in: Fix I386 symbol alias _wfindnext

2024-04-27 Thread Pali Rohár
Symbol alias is defined by "==". --- mingw-w64-crt/lib32/msvcr90d.def.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mingw-w64-crt/lib32/msvcr90d.def.in b/mingw-w64-crt/lib32/msvcr90d.def.in index 4c31b632351e..db2eb6e01991 100644 --- a/mingw-w64-crt/lib32/msvcr90d.def.in

[Mingw-w64-public] [PATCH 6/7] crt: UCRT: Change I386 time functions without suffix to use 32-bit time_t

2024-04-27 Thread Pali Rohár
CRT header files ensures that time symbols without 32/64 suffixes are not emitted. And linker always sees time symbols with explicit 32 or 64 suffix name. When CRT header files are not included then 32-bit MSVC compiler + linker treats symbols without "64" suffix name as functions which use 32-bit

[Mingw-w64-public] [PATCH 4/7] crt: msvcr120_app.def.in: Fix X64 symbol aliases _stat and _stati64

2024-04-27 Thread Pali Rohár
Symbol alias is defined by "==". --- mingw-w64-crt/lib-common/msvcr120_app.def.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mingw-w64-crt/lib-common/msvcr120_app.def.in b/mingw-w64-crt/lib-common/msvcr120_app.def.in index e2474e77c372..8319ed012060 100644 --- a/mingw

[Mingw-w64-public] [PATCH 3/7] crt: msvcr120 and UCRT: Fix X64 _(w)findfirst and _(w)findnext symbol aliases

2024-04-27 Thread Pali Rohár
These symbols on X64 should resolve to _findfirst64i32/_findnext64i32 functions, like in other CRT libraries and header files. --- mingw-w64-crt/Makefile.am | 4 ...l1-1-0.def => api-ms-win-crt-filesystem-l1-1-0.def.in} | 8 ++-- mingw-w64-crt/lib-common/ms

[Mingw-w64-public] [PATCH 1/7] crt: msvcr90d.def.in: Fix X64 ctime symbol alias to use 64-bit time_t

2024-04-27 Thread Pali Rohár
--- mingw-w64-crt/lib64/msvcr90d.def.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mingw-w64-crt/lib64/msvcr90d.def.in b/mingw-w64-crt/lib64/msvcr90d.def.in index 3c7d7525a01d..f8f6ecae13ea 100644 --- a/mingw-w64-crt/lib64/msvcr90d.def.in +++ b/mingw-w64-crt/lib64/msvcr90

[Mingw-w64-public] [PATCH 5/7] crt: msvcr120_app.def.in: Remove duplicate symbol alias swab

2024-04-27 Thread Pali Rohár
This alias is already provided by the msvcrt-common.def.in file. --- mingw-w64-crt/lib-common/msvcr120_app.def.in | 1 - 1 file changed, 1 deletion(-) diff --git a/mingw-w64-crt/lib-common/msvcr120_app.def.in b/mingw-w64-crt/lib-common/msvcr120_app.def.in index 8319ed012060..7fa9d0a32c30 100644

Re: [Mingw-w64-public] [PATCH 10/10] crt: Move find, stat and time aliases to def-include/msvcrt-common.def.in

2024-04-27 Thread Martin Storsjö
On Sat, 27 Apr 2024, Jacek Caban wrote: On 26.04.2024 21:43, Pali Rohár wrote: I played a bit with different msvc 19.x versions and 32-bit x86 variant recognize time symbol and maps it to _time32 at link time. First compiler maps time symbol to _time and then linker maps _time to __time32. It m