Re: [Mingw-w64-public] [PATCH] Remove the Macros of the time_r functions and replace them with actual functions

2014-11-12 Thread Dongsheng Song
Pushed with delete mysterious U+200B characters. Unicode Character 'ZERO WIDTH SPACE' (U+200B) +tmp = localtime(_Time); +if (tmp != NULL) +memcpy(_Tm, tmp, sizeof(struct tm); +return tmp;<200b><200b> +<200b>}<200b> + On Wed, Nov 12, 2014 at 11:59 PM, Kai Tietz wrote: > Well

Re: [Mingw-w64-public] [PATCH] Remove the Macros of the time_r functions and replace them with actual functions

2014-11-12 Thread Kai Tietz
Well, ascitime is in msvcrt thread-save too ... anyway, from my POOV patch is ok. If there are no objections by others, please apply. Thanks, Kai 2014-11-12 15:50 GMT+01:00 Martell Malone : > Added a guard to every function and handle errno values > Used memcpy in gmtime_r as discussed > > This

Re: [Mingw-w64-public] [PATCH] Remove the Macros of the time_r functions and replace them with actual functions

2014-11-12 Thread Martell Malone
Added a guard to every function and handle errno values Used memcpy in gmtime_r as discussed This version should address all concerns. Please commit On Wed, Nov 12, 2014 at 2:41 PM, Martell Malone wrote: > Arg I changed the old patch with including errno.h > Can someone delete the previous emai

Re: [Mingw-w64-public] [PATCH] Remove the Macros of the time_r functions and replace them with actual functions

2014-11-12 Thread Martell Malone
Arg I changed the old patch with including errno.h Can someone delete the previous email from the thread Sorry On Wed, Nov 12, 2014 at 2:38 PM, Martell Malone wrote: > Caching stopped me from including > > On Wed, Nov 12, 2014 at 2:34 PM, Martell Malone > wrote: > >> Dongsheng Song >> Thank yo

Re: [Mingw-w64-public] [PATCH] Remove the Macros of the time_r functions and replace them with actual functions

2014-11-12 Thread Martell Malone
Caching stopped me from including On Wed, Nov 12, 2014 at 2:34 PM, Martell Malone wrote: > Dongsheng Song > Thank you for your suggested changes. > > I would like to note that my implementation was the exact same as the > Macros apart from the _r in acrtime which I did change but somehow didn't

Re: [Mingw-w64-public] [PATCH] Remove the Macros of the time_r functions and replace them with actual functions

2014-11-12 Thread Martell Malone
Dongsheng Song Thank you for your suggested changes. I would like to note that my implementation was the exact same as the Macros apart from the _r in acrtime which I did change but somehow didn't end up in the attached patch due to caching or something heh The fact that "these functions destroys

Re: [Mingw-w64-public] [PATCH] Remove the Macros of the time_r functions and replace them with actual functions

2014-11-11 Thread Dongsheng Song
On Wed, Nov 12, 2014 at 12:24 AM, Ray Donnelly wrote: > On Tue, Nov 11, 2014 at 2:02 PM, Dongsheng Song > wrote: >> I think you need add 1 line like this: >> >> TODO: real thread safe implementation. >> > > Why? msvcrt is thread safe already. > MSDN not said asctime[1] is thread safe, it only sa

Re: [Mingw-w64-public] [PATCH] Remove the Macros of the time_r functions and replace them with actual functions

2014-11-11 Thread Ray Donnelly
On Tue, Nov 11, 2014 at 2:02 PM, Dongsheng Song wrote: > I think you need add 1 line like this: > > TODO: real thread safe implementation. > Why? msvcrt is thread safe already. > On Tue, Nov 11, 2014 at 8:15 PM, Martell Malone > wrote: >> Comments Suggestions and changes Welcome. >> >> Kind Re

Re: [Mingw-w64-public] [PATCH] Remove the Macros of the time_r functions and replace them with actual functions

2014-11-11 Thread Dongsheng Song
I think you need add 1 line like this: TODO: real thread safe implementation. On Tue, Nov 11, 2014 at 8:15 PM, Martell Malone wrote: > Comments Suggestions and changes Welcome. > > Kind Regards > Martell > > -- > Compreh

[Mingw-w64-public] [PATCH] Remove the Macros of the time_r functions and replace them with actual functions

2014-11-11 Thread Martell Malone
Comments Suggestions and changes Welcome. Kind Regards Martell 0001-Remove-the-Macros-of-the-time_r-functions-and-replac.patch Description: Binary data -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers