Re: [Mingw-w64-public] [PATCH] crt: Implement __gets_chk

2023-02-13 Thread Martin Storsjö
On Mon, 13 Feb 2023, LIU Hao wrote: 在 2023-02-13 06:13, Martin Storsjö 写道: When a subset of ssp functions were implemented in 7478c20848f60e6238547db63d1a5bc450d468cc, only functions that were referenced with _FORTIFY_SOURCE were added. This set of functions accidentally missed __gets_chk,

Re: [Mingw-w64-public] [PATCH] crt: Implement __gets_chk

2023-02-13 Thread Christian Franke
LIU Hao wrote: Side note: I am a bit curious how this function is supposed to be useful. Generally speaking `get()` should never be used. __gets_chk() may (only) be useful to fortify very old code. From the C/C++ standards point of view, the gets() prototype should be disabled if C11 or

Re: [Mingw-w64-public] [PATCH] crt: Implement __gets_chk

2023-02-13 Thread LIU Hao
在 2023-02-13 06:13, Martin Storsjö 写道: When a subset of ssp functions were implemented in 7478c20848f60e6238547db63d1a5bc450d468cc, only functions that were referenced with _FORTIFY_SOURCE were added. This set of functions accidentally missed __gets_chk, which we do reference if fortification is

[Mingw-w64-public] [PATCH] crt: Implement __gets_chk

2023-02-12 Thread Martin Storsjö
When a subset of ssp functions were implemented in 7478c20848f60e6238547db63d1a5bc450d468cc, only functions that were referenced with _FORTIFY_SOURCE were added. This set of functions accidentally missed __gets_chk, which we do reference if fortification is enabled. Thus, this fixes an accidental