Re: [Mingw-w64-public] [PATCH] headers: Move some macros about deprecated functions from 'strsafe.h' into 'dontuse.h'

2024-03-02 Thread LIU Hao
在 2024-03-03 04:55, Martin Storsjö 写道: LGTM, thanks! Thanks. Pushed now. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net

Re: [Mingw-w64-public] [PATCH] headers: Move some macros about deprecated functions from 'strsafe.h' into 'dontuse.h'

2024-03-02 Thread Martin Storsjö
On Fri, 1 Mar 2024, LIU Hao wrote: 在 2024-02-29 16:25, Martin Storsjö 写道: The functions within the DEPRECATE_SUPPORTED block in strsafe.h are not defined elsewhere, they are all inline functions within strsafe.h. So there is no way of having code that otherwise works, then you include

Re: [Mingw-w64-public] [PATCH] headers: Move some macros about deprecated functions from 'strsafe.h' into 'dontuse.h'

2024-03-01 Thread LIU Hao
在 2024-02-29 16:25, Martin Storsjö 写道: The functions within the DEPRECATE_SUPPORTED block in strsafe.h are not defined elsewhere, they are all inline functions within strsafe.h. So there is no way of having code that otherwise works, then you include strsafe.h and suddenly it no longer works.

Re: [Mingw-w64-public] [PATCH] headers: Move some macros about deprecated functions from 'strsafe.h' into 'dontuse.h'

2024-02-29 Thread Martin Storsjö
On Thu, 29 Feb 2024, LIU Hao wrote: 在 2024-02-29 01:14, Martin Storsjö 写道: It would be much more understandable, if the message would start with some context like this: ---8<--- WinSDK's strsafe.h also tries to discourage users from calling a bunch of its internal functions. This is done

Re: [Mingw-w64-public] [PATCH] headers: Move some macros about deprecated functions from 'strsafe.h' into 'dontuse.h'

2024-02-28 Thread LIU Hao
在 2024-02-29 01:14, Martin Storsjö 写道: It would be much more understandable, if the message would start with some context like this: ---8<--- WinSDK's strsafe.h also tries to discourage users from calling a bunch of its internal functions. This is done in two different ways; if

Re: [Mingw-w64-public] [PATCH] headers: Move some macros about deprecated functions from 'strsafe.h' into 'dontuse.h'

2024-02-28 Thread Martin Storsjö
On Wed, 28 Feb 2024, LIU Hao wrote: Attached is the updated patch. Ok, so let's see... because the semicolon in the macro `lstrcpyA` affects not only invocations, but also declarations. Those semicolons have been removed since Windows SDK 8.0, so we remove them as well. This allows

Re: [Mingw-w64-public] [PATCH] headers: Move some macros about deprecated functions from 'strsafe.h' into 'dontuse.h'

2024-02-28 Thread LIU Hao
在 2024-02-28 06:01, Martin Storsjö 写道: Can you mention in the commit message, what used to break if strsafe.h was included befoe windows.h? The commit message explains that we're moveing a bunch of macros from strsafe.h into dontuse.h, but in the diff, I'm also seeing a bunch of other minor

Re: [Mingw-w64-public] [PATCH] headers: Move some macros about deprecated functions from 'strsafe.h' into 'dontuse.h'

2024-02-27 Thread Martin Storsjö
On Wed, 21 Feb 2024, LIU Hao wrote: Since Windows SDK 8.0, `STRSAFE_NO_DEPRECATE` no longer has an effect. It's still defined by some headers, but the check in 'strsafe.h' has been removed. Those macros that match POSIX names have been moved to 'dontuse.h', so we do the same. This allows

[Mingw-w64-public] [PATCH] headers: Move some macros about deprecated functions from 'strsafe.h' into 'dontuse.h'

2024-02-21 Thread LIU Hao
-- Best regards, LIU Hao From f6bbea6b0530ff47da5c1abefef3182933fd8641 Mon Sep 17 00:00:00 2001 From: LIU Hao Date: Wed, 21 Feb 2024 22:51:59 +0800 Subject: [PATCH] headers: Move some macros about deprecated functions from 'strsafe.h' into 'dontuse.h' Since Windows SDK 8.0,