Re: [Mingw-w64-public] [PATCH v3] Make isatty Cygwin-compatible

2016-11-14 Thread Corinna Vinschen
On Nov 14 05:00, Mihail Konev wrote: > On Sun, Nov 13, 2016 at 09:44:49PM +0100, Corinna Vinschen wrote: > > On Nov 14 00:31, Mihail Konev wrote: > > > > I'm opposed to checking the pipes for *-msys-* additionally to > > *-cygwin-* for no good reason. You're adding just another test to the > >

Re: [Mingw-w64-public] [PATCH v3] Make isatty Cygwin-compatible

2016-11-13 Thread Mihail Konev
On Sun, Nov 13, 2016 at 09:44:49PM +0100, Corinna Vinschen wrote: > On Nov 14 00:31, Mihail Konev wrote: > > I'm opposed to checking the pipes for *-msys-* additionally to > *-cygwin-* for no good reason. You're adding just another test to the > checking code and potentially introduce hard to

Re: [Mingw-w64-public] [PATCH v3] Make isatty Cygwin-compatible

2016-11-13 Thread Corinna Vinschen
On Nov 14 00:31, Mihail Konev wrote: > +/* Cygwin-compatible isatty. > + * > + * Cygwin pty is a specially-named named pipe. > + * Fetch absolute device namespace path to fd (if any), > + * and check it for the following pattern: > + * > + * >

[Mingw-w64-public] [PATCH v3] Make isatty Cygwin-compatible

2016-11-13 Thread Mihail Konev
Before, isatty() was an alias for WinAPI _isatty(). This resulted in wrong result for mintty. Implement a pipe name check in a static isatty(). This makes io.h include NT and Windows APIs. The change isn't strictly standard, as it adds 'static' to the isatty() signature. Signed-off-by: Mihail